Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 02/22/2018 08:37 AM, Vincent Guittot wrote: > On 21 February 2018 at 14:13, Valentin Schneider > wrote: >> On 02/16/2018 01:44 PM, Vincent Guittot wrote: >>> On 16 February 2018 at 13:13, Valentin Schneider >>> wrote: On 02/14/2018

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 02/22/2018 08:37 AM, Vincent Guittot wrote: > On 21 February 2018 at 14:13, Valentin Schneider > wrote: >> On 02/16/2018 01:44 PM, Vincent Guittot wrote: >>> On 16 February 2018 at 13:13, Valentin Schneider >>> wrote: On 02/14/2018 03:26 PM, Vincent Guittot wrote: > Stopped the

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 21 February 2018 at 14:13, Valentin Schneider wrote: > On 02/16/2018 01:44 PM, Vincent Guittot wrote: >> On 16 February 2018 at 13:13, Valentin Schneider >> wrote: >>> On 02/14/2018 03:26 PM, Vincent Guittot wrote: Stopped the

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 21 February 2018 at 14:13, Valentin Schneider wrote: > On 02/16/2018 01:44 PM, Vincent Guittot wrote: >> On 16 February 2018 at 13:13, Valentin Schneider >> wrote: >>> On 02/14/2018 03:26 PM, Vincent Guittot wrote: Stopped the periodic update of blocked load when all idle CPUs have fully

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 02/21/2018 01:13 PM, Valentin Schneider wrote: > On 02/16/2018 01:44 PM, Vincent Guittot wrote: >> On 16 February 2018 at 13:13, Valentin Schneider >> wrote: >>> On 02/14/2018 03:26 PM, Vincent Guittot wrote: > BTW, with the current set on Peter's sched/testing,

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 02/21/2018 01:13 PM, Valentin Schneider wrote: > On 02/16/2018 01:44 PM, Vincent Guittot wrote: >> On 16 February 2018 at 13:13, Valentin Schneider >> wrote: >>> On 02/14/2018 03:26 PM, Vincent Guittot wrote: > BTW, with the current set on Peter's sched/testing, update_nohz_stats() > is called

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 02/16/2018 01:44 PM, Vincent Guittot wrote: > On 16 February 2018 at 13:13, Valentin Schneider > wrote: >> On 02/14/2018 03:26 PM, Vincent Guittot wrote: >>> Stopped the periodic update of blocked load when all idle CPUs have fully >>> decayed. We introduce a new

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 02/16/2018 01:44 PM, Vincent Guittot wrote: > On 16 February 2018 at 13:13, Valentin Schneider > wrote: >> On 02/14/2018 03:26 PM, Vincent Guittot wrote: >>> Stopped the periodic update of blocked load when all idle CPUs have fully >>> decayed. We introduce a new nohz.has_blocked that reflect

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 02/16/2018 05:02 PM, Vincent Guittot wrote: > On 16 February 2018 at 13:53, Valentin Schneider > wrote: >> On 02/14/2018 03:26 PM, Vincent Guittot wrote: >>> Stopped the periodic update of blocked load when all idle CPUs have fully >>> decayed. We introduce a new

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 02/16/2018 05:02 PM, Vincent Guittot wrote: > On 16 February 2018 at 13:53, Valentin Schneider > wrote: >> On 02/14/2018 03:26 PM, Vincent Guittot wrote: >>> Stopped the periodic update of blocked load when all idle CPUs have fully >>> decayed. We introduce a new nohz.has_blocked that reflect

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 16 February 2018 at 13:53, Valentin Schneider wrote: > On 02/14/2018 03:26 PM, Vincent Guittot wrote: >> Stopped the periodic update of blocked load when all idle CPUs have fully >> decayed. We introduce a new nohz.has_blocked that reflect if some idle >> CPUs has

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 16 February 2018 at 13:53, Valentin Schneider wrote: > On 02/14/2018 03:26 PM, Vincent Guittot wrote: >> Stopped the periodic update of blocked load when all idle CPUs have fully >> decayed. We introduce a new nohz.has_blocked that reflect if some idle >> CPUs has blocked load that have to be

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 16 February 2018 at 13:13, Valentin Schneider wrote: > On 02/14/2018 03:26 PM, Vincent Guittot wrote: >> Stopped the periodic update of blocked load when all idle CPUs have fully >> decayed. We introduce a new nohz.has_blocked that reflect if some idle >> CPUs has

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 16 February 2018 at 13:13, Valentin Schneider wrote: > On 02/14/2018 03:26 PM, Vincent Guittot wrote: >> Stopped the periodic update of blocked load when all idle CPUs have fully >> decayed. We introduce a new nohz.has_blocked that reflect if some idle >> CPUs has blocked load that have to be

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 02/14/2018 03:26 PM, Vincent Guittot wrote: > Stopped the periodic update of blocked load when all idle CPUs have fully > decayed. We introduce a new nohz.has_blocked that reflect if some idle > CPUs has blocked load that have to be periodiccally updated. nohz.has_blocked > is set everytime

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 02/14/2018 03:26 PM, Vincent Guittot wrote: > Stopped the periodic update of blocked load when all idle CPUs have fully > decayed. We introduce a new nohz.has_blocked that reflect if some idle > CPUs has blocked load that have to be periodiccally updated. nohz.has_blocked > is set everytime

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 02/14/2018 03:26 PM, Vincent Guittot wrote: > Stopped the periodic update of blocked load when all idle CPUs have fully > decayed. We introduce a new nohz.has_blocked that reflect if some idle > CPUs has blocked load that have to be periodiccally updated. nohz.has_blocked > is set everytime

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 02/14/2018 03:26 PM, Vincent Guittot wrote: > Stopped the periodic update of blocked load when all idle CPUs have fully > decayed. We introduce a new nohz.has_blocked that reflect if some idle > CPUs has blocked load that have to be periodiccally updated. nohz.has_blocked > is set everytime

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

Hi Vincent, here are some possible small code improvement suggestions from my side. Cheers Patrick On 14-Feb 16:26, Vincent Guittot wrote: > > Stopped the periodic update of blocked load when all idle CPUs have fully > > decayed. We introduce a new nohz.has_blocked that reflect if some idle > >

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

Hi Vincent, here are some possible small code improvement suggestions from my side. Cheers Patrick On 14-Feb 16:26, Vincent Guittot wrote: > > Stopped the periodic update of blocked load when all idle CPUs have fully > > decayed. We introduce a new nohz.has_blocked that reflect if some idle > >

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

Hi Patrick, On 15 February 2018 at 16:22, Patrick Bellasi wrote: > Hi Vincent, > here are some possible small code improvement suggestions from my side. > > Cheers Patrick > > On 14-Feb 16:26, Vincent Guittot wrote: >> > Stopped the periodic update of blocked load when

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

Hi Patrick, On 15 February 2018 at 16:22, Patrick Bellasi wrote: > Hi Vincent, > here are some possible small code improvement suggestions from my side. > > Cheers Patrick > > On 14-Feb 16:26, Vincent Guittot wrote: >> > Stopped the periodic update of blocked load when all idle CPUs have fully

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 15-Feb 17:50, Peter Zijlstra wrote: > On Thu, Feb 15, 2018 at 03:22:47PM +, Patrick Bellasi wrote: > > > > static struct { > > > > cpumask_var_t idle_cpus_mask; > > > > atomic_t nr_cpus; > > > > + int has_blocked;/* Idle CPUS has blocked load */ > > >

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On 15-Feb 17:50, Peter Zijlstra wrote: > On Thu, Feb 15, 2018 at 03:22:47PM +, Patrick Bellasi wrote: > > > > static struct { > > > > cpumask_var_t idle_cpus_mask; > > > > atomic_t nr_cpus; > > > > + int has_blocked;/* Idle CPUS has blocked load */ > > >

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On Thu, Feb 15, 2018 at 03:22:47PM +, Patrick Bellasi wrote: > > > static struct { > > > cpumask_var_t idle_cpus_mask; > > > atomic_t nr_cpus; > > > + int has_blocked;/* Idle CPUS has blocked load */ > > Why not "bool"? > Because then he gets me yelling that

Re: [PATCH v5 1/3] sched: Stop nohz stats when decayed

On Thu, Feb 15, 2018 at 03:22:47PM +, Patrick Bellasi wrote: > > > static struct { > > > cpumask_var_t idle_cpus_mask; > > > atomic_t nr_cpus; > > > + int has_blocked;/* Idle CPUS has blocked load */ > > Why not "bool"? > Because then he gets me yelling that

[PATCH v5 1/3] sched: Stop nohz stats when decayed

Stopped the periodic update of blocked load when all idle CPUs have fully decayed. We introduce a new nohz.has_blocked that reflect if some idle CPUs has blocked load that have to be periodiccally updated. nohz.has_blocked is set everytime that a Idle CPU can have blocked load and it is then clear

[PATCH v5 1/3] sched: Stop nohz stats when decayed

Stopped the periodic update of blocked load when all idle CPUs have fully decayed. We introduce a new nohz.has_blocked that reflect if some idle CPUs has blocked load that have to be periodiccally updated. nohz.has_blocked is set everytime that a Idle CPU can have blocked load and it is then clear