Re: [PATCH v5 4/4] sched/fair: update util_est only on util_avg updates

2018-03-08 Thread Patrick Bellasi
On 08-Mar 10:48, Peter Zijlstra wrote: > On Thu, Feb 22, 2018 at 05:01:53PM +, Patrick Bellasi wrote: > > +#define UTIL_EST_NEED_UPDATE_FLAG 0x1 > > > @@ -5321,12 +5345,19 @@ static inline void util_est_dequeue(struct cfs_rq > > *cfs_rq, > > if (!task_sleep) > > return; > >

Re: [PATCH v5 4/4] sched/fair: update util_est only on util_avg updates

2018-03-08 Thread Patrick Bellasi
On 08-Mar 10:48, Peter Zijlstra wrote: > On Thu, Feb 22, 2018 at 05:01:53PM +, Patrick Bellasi wrote: > > +#define UTIL_EST_NEED_UPDATE_FLAG 0x1 > > > @@ -5321,12 +5345,19 @@ static inline void util_est_dequeue(struct cfs_rq > > *cfs_rq, > > if (!task_sleep) > > return; > >

Re: [PATCH v5 4/4] sched/fair: update util_est only on util_avg updates

2018-03-08 Thread Peter Zijlstra
On Thu, Feb 22, 2018 at 05:01:53PM +, Patrick Bellasi wrote: > +#define UTIL_EST_NEED_UPDATE_FLAG 0x1 > @@ -5321,12 +5345,19 @@ static inline void util_est_dequeue(struct cfs_rq > *cfs_rq, > if (!task_sleep) > return; > > + /* > + * Skip update of task's

Re: [PATCH v5 4/4] sched/fair: update util_est only on util_avg updates

2018-03-08 Thread Peter Zijlstra
On Thu, Feb 22, 2018 at 05:01:53PM +, Patrick Bellasi wrote: > +#define UTIL_EST_NEED_UPDATE_FLAG 0x1 > @@ -5321,12 +5345,19 @@ static inline void util_est_dequeue(struct cfs_rq > *cfs_rq, > if (!task_sleep) > return; > > + /* > + * Skip update of task's

Re: [PATCH v5 4/4] sched/fair: update util_est only on util_avg updates

2018-03-08 Thread Peter Zijlstra
On Wed, Mar 07, 2018 at 11:38:52AM +0100, Peter Zijlstra wrote: > On Thu, Feb 22, 2018 at 05:01:53PM +, Patrick Bellasi wrote: > > @@ -5218,7 +5242,7 @@ static inline void util_est_enqueue(struct cfs_rq > > *cfs_rq, > > > > /* Update root cfs_rq's estimated utilization */ > >

Re: [PATCH v5 4/4] sched/fair: update util_est only on util_avg updates

2018-03-08 Thread Peter Zijlstra
On Wed, Mar 07, 2018 at 11:38:52AM +0100, Peter Zijlstra wrote: > On Thu, Feb 22, 2018 at 05:01:53PM +, Patrick Bellasi wrote: > > @@ -5218,7 +5242,7 @@ static inline void util_est_enqueue(struct cfs_rq > > *cfs_rq, > > > > /* Update root cfs_rq's estimated utilization */ > >

Re: [PATCH v5 4/4] sched/fair: update util_est only on util_avg updates

2018-03-07 Thread Peter Zijlstra
On Thu, Feb 22, 2018 at 05:01:53PM +, Patrick Bellasi wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 8364771f7301..1bf9a86ebc39 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -3047,6 +3047,29 @@ static inline void cfs_rq_util_change(struct cfs_rq

Re: [PATCH v5 4/4] sched/fair: update util_est only on util_avg updates

2018-03-07 Thread Peter Zijlstra
On Thu, Feb 22, 2018 at 05:01:53PM +, Patrick Bellasi wrote: > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index 8364771f7301..1bf9a86ebc39 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -3047,6 +3047,29 @@ static inline void cfs_rq_util_change(struct cfs_rq

Re: [PATCH v5 4/4] sched/fair: update util_est only on util_avg updates

2018-03-01 Thread Patrick Bellasi
The changelog is missing the below CCs. :( Since that's a new patch in this series, I expect some feedbacks and thus I'll add them on the next respin. On 22-Feb 17:01, Patrick Bellasi wrote: > The estimated utilization of a task is currently updated every time the > task is dequeued. However, to

Re: [PATCH v5 4/4] sched/fair: update util_est only on util_avg updates

2018-03-01 Thread Patrick Bellasi
The changelog is missing the below CCs. :( Since that's a new patch in this series, I expect some feedbacks and thus I'll add them on the next respin. On 22-Feb 17:01, Patrick Bellasi wrote: > The estimated utilization of a task is currently updated every time the > task is dequeued. However, to

[PATCH v5 4/4] sched/fair: update util_est only on util_avg updates

2018-02-22 Thread Patrick Bellasi
The estimated utilization of a task is currently updated every time the task is dequeued. However, to keep overheads under control, PELT signals are effectively updated at maximum once every 1ms. Thus, for really short running tasks, it can happen that their util_avg value has not been updates

[PATCH v5 4/4] sched/fair: update util_est only on util_avg updates

2018-02-22 Thread Patrick Bellasi
The estimated utilization of a task is currently updated every time the task is dequeued. However, to keep overheads under control, PELT signals are effectively updated at maximum once every 1ms. Thus, for really short running tasks, it can happen that their util_avg value has not been updates