Re: [PATCH v6] fs: dax: Adding new return type vm_fault_t

2018-04-27 Thread Matthew Wilcox
On Fri, Apr 27, 2018 at 10:54:53AM +0530, Souptick Joarder wrote: > > I noticed that we have the following status translation now in 4 places in 2 > > files: > > > > if (err == -ENOMEM) > > return VM_FAULT_OOM; > > if (err < 0 && err != -EBUSY) > >

Re: [PATCH v6] fs: dax: Adding new return type vm_fault_t

2018-04-27 Thread Matthew Wilcox
On Fri, Apr 27, 2018 at 10:54:53AM +0530, Souptick Joarder wrote: > > I noticed that we have the following status translation now in 4 places in 2 > > files: > > > > if (err == -ENOMEM) > > return VM_FAULT_OOM; > > if (err < 0 && err != -EBUSY) > >

Re: [PATCH v6] fs: dax: Adding new return type vm_fault_t

2018-04-26 Thread Souptick Joarder
> I noticed that we have the following status translation now in 4 places in 2 > files: > > if (err == -ENOMEM) > return VM_FAULT_OOM; > if (err < 0 && err != -EBUSY) > return VM_FAULT_SIGBUS; > return VM_FAULT_NOPAGE; > > > This happens in

Re: [PATCH v6] fs: dax: Adding new return type vm_fault_t

2018-04-26 Thread Souptick Joarder
> I noticed that we have the following status translation now in 4 places in 2 > files: > > if (err == -ENOMEM) > return VM_FAULT_OOM; > if (err < 0 && err != -EBUSY) > return VM_FAULT_SIGBUS; > return VM_FAULT_NOPAGE; > > > This happens in

Re: [PATCH v6] fs: dax: Adding new return type vm_fault_t

2018-04-26 Thread Ross Zwisler
On Tue, Apr 24, 2018 at 10:17:51PM +0530, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. For > now, this is just documenting that the function returns > a VM_FAULT value rather than an errno. Once all instances > are converted, vm_fault_t will become a distinct type. >

Re: [PATCH v6] fs: dax: Adding new return type vm_fault_t

2018-04-26 Thread Ross Zwisler
On Tue, Apr 24, 2018 at 10:17:51PM +0530, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler. For > now, this is just documenting that the function returns > a VM_FAULT value rather than an errno. Once all instances > are converted, vm_fault_t will become a distinct type. >

[PATCH v6] fs: dax: Adding new return type vm_fault_t

2018-04-24 Thread Souptick Joarder
Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. commit 1c8f422059ae ("mm: change return type to vm_fault_t") There was an

[PATCH v6] fs: dax: Adding new return type vm_fault_t

2018-04-24 Thread Souptick Joarder
Use new return type vm_fault_t for fault handler. For now, this is just documenting that the function returns a VM_FAULT value rather than an errno. Once all instances are converted, vm_fault_t will become a distinct type. commit 1c8f422059ae ("mm: change return type to vm_fault_t") There was an