On Tue, 2014-08-26 at 09:10 +, David Laight wrote:
> From: Arnd Bergmann
> > While this seems correct, I wonder why you don't do the normal approach of
> > dequeuing the skb from the chain and adding a newly allocated skb to it to
> > save the memcpy.
>
> Because the receive buffer area
From: Arnd Bergmann
> On Monday 25 August 2014 16:22:22 Jonas Jensen wrote:
> > @@ -226,13 +226,15 @@ static int moxart_rx_poll(struct napi_struct *napi,
> > int budget)
> > if (len > RX_BUF_SIZE)
> > len = RX_BUF_SIZE;
> >
> > - skb =
On Monday 25 August 2014 16:22:22 Jonas Jensen wrote:
> @@ -226,13 +226,15 @@ static int moxart_rx_poll(struct napi_struct *napi, int
> budget)
> if (len > RX_BUF_SIZE)
> len = RX_BUF_SIZE;
>
> - skb = build_skb(priv->rx_buf[rx_head],
On Monday 25 August 2014 16:22:22 Jonas Jensen wrote:
@@ -226,13 +226,15 @@ static int moxart_rx_poll(struct napi_struct *napi, int
budget)
if (len RX_BUF_SIZE)
len = RX_BUF_SIZE;
- skb = build_skb(priv-rx_buf[rx_head],
From: Arnd Bergmann
On Monday 25 August 2014 16:22:22 Jonas Jensen wrote:
@@ -226,13 +226,15 @@ static int moxart_rx_poll(struct napi_struct *napi,
int budget)
if (len RX_BUF_SIZE)
len = RX_BUF_SIZE;
- skb =
On Tue, 2014-08-26 at 09:10 +, David Laight wrote:
From: Arnd Bergmann
While this seems correct, I wonder why you don't do the normal approach of
dequeuing the skb from the chain and adding a newly allocated skb to it to
save the memcpy.
Because the receive buffer area isn't made of
From: Jonas Jensen
Date: Mon, 25 Aug 2014 16:22:22 +0200
> build_skb() is used to make skbs out of existing RX ring memory
> which is bad because the RX ring is allocated only once, on probe.
> Memory corruption occur because said memory is reclaimed, i.e.
> __kfree_skb() (and eventually
build_skb() is used to make skbs out of existing RX ring memory
which is bad because the RX ring is allocated only once, on probe.
Memory corruption occur because said memory is reclaimed, i.e.
__kfree_skb() (and eventually put_page()).
Replace build_skb() with netdev_alloc_skb_ip_align() and use
build_skb() is used to make skbs out of existing RX ring memory
which is bad because the RX ring is allocated only once, on probe.
Memory corruption occur because said memory is reclaimed, i.e.
__kfree_skb() (and eventually put_page()).
Replace build_skb() with netdev_alloc_skb_ip_align() and use
From: Jonas Jensen jonas.jen...@gmail.com
Date: Mon, 25 Aug 2014 16:22:22 +0200
build_skb() is used to make skbs out of existing RX ring memory
which is bad because the RX ring is allocated only once, on probe.
Memory corruption occur because said memory is reclaimed, i.e.
__kfree_skb() (and
10 matches
Mail list logo
