Re: [PATCH v6 2/8] lib: prepare xxhash for preboot environment

2020-07-07 Thread Arvind Sankar
On Tue, Jul 07, 2020 at 07:49:25PM -0700, Kees Cook wrote: > On Tue, Jul 07, 2020 at 05:59:25PM -0400, Arvind Sankar wrote: > > On Mon, Jul 06, 2020 at 08:45:58PM -0700, Nick Terrell wrote: > > > From: Nick Terrell > > > > > > Don't export symbols if XXH_PREBOOT is defined. > > > > > > This

Re: [PATCH v6 2/8] lib: prepare xxhash for preboot environment

2020-07-07 Thread Kees Cook
On Tue, Jul 07, 2020 at 05:59:25PM -0400, Arvind Sankar wrote: > On Mon, Jul 06, 2020 at 08:45:58PM -0700, Nick Terrell wrote: > > From: Nick Terrell > > > > Don't export symbols if XXH_PREBOOT is defined. > > > > This change is necessary to get xxhash to work in a preboot environment, > >

Re: [PATCH v6 2/8] lib: prepare xxhash for preboot environment

2020-07-07 Thread Nick Terrell
> On Jul 7, 2020, at 5:59 PM, Arvind Sankar wrote: > > On Mon, Jul 06, 2020 at 08:45:58PM -0700, Nick Terrell wrote: >> From: Nick Terrell >> >> Don't export symbols if XXH_PREBOOT is defined. >> >> This change is necessary to get xxhash to work in a preboot environment, >> which is needed

Re: [PATCH v6 2/8] lib: prepare xxhash for preboot environment

2020-07-07 Thread Arvind Sankar
On Mon, Jul 06, 2020 at 08:45:58PM -0700, Nick Terrell wrote: > From: Nick Terrell > > Don't export symbols if XXH_PREBOOT is defined. > > This change is necessary to get xxhash to work in a preboot environment, > which is needed to support zstd-compressed kernels. The usual way to do it is by

[PATCH v6 2/8] lib: prepare xxhash for preboot environment

2020-07-06 Thread Nick Terrell
From: Nick Terrell Don't export symbols if XXH_PREBOOT is defined. This change is necessary to get xxhash to work in a preboot environment, which is needed to support zstd-compressed kernels. Reviewed-by: Kees Cook Tested-by: Sedat Dilek Signed-off-by: Nick Terrell --- lib/xxhash.c | 21