Re: [PATCH v6 3/8] staging: lustre: lclient: lcommon_misc.c fixing coding style issues
> If you are using min_t(__u32, ...) then there is no need for the (__u32) cast of LOV_MAX_STRIPE_COUNT, since that is the whole point of min_t() that the cast is done internally. Agreed, it makes sense not to cast twice when using min_t(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v6 3/8] staging: lustre: lclient: lcommon_misc.c fixing coding style issues
On 2014/06/16, 11:43 PM, "Anil Belur" wrote: >From: Anil Belur > >fixed warning: >* WARNING: min() should probably be min_t(__u32, desc.ld_tgt_count, >LOV_MAX_STRIPE_COUNT) > >Signed-off-by: Anil Belur >--- > drivers/staging/lustre/lustre/lclient/lcommon_misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c >b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c >index 21de1cd..0900bef 100644 >--- a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c >+++ b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c >@@ -63,7 +63,7 @@ int cl_init_ea_size(struct obd_export *md_exp, struct >obd_export *dt_exp) > if (rc) > return rc; > >- stripes = min(desc.ld_tgt_count, (__u32)LOV_MAX_STRIPE_COUNT); >+ stripes = min_t(__u32, desc.ld_tgt_count, (__u32)LOV_MAX_STRIPE_COUNT); If you are using min_t(__u32, ...) then there is no need for the (__u32) cast of LOV_MAX_STRIPE_COUNT, since that is the whole point of min_t() that the cast is done internally. > lsm.lsm_stripe_count = stripes; > easize = obd_size_diskmd(dt_exp, ); > >-- >1.9.0 > > Cheers, Andreas -- Andreas Dilger Lustre Software Architect Intel High Performance Data Division -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v6 3/8] staging: lustre: lclient: lcommon_misc.c fixing coding style issues
On 2014/06/16, 11:43 PM, Anil Belur ask...@gmail.com wrote: From: Anil Belur ask...@gmail.com fixed warning: * WARNING: min() should probably be min_t(__u32, desc.ld_tgt_count, LOV_MAX_STRIPE_COUNT) Signed-off-by: Anil Belur ask...@gmail.com --- drivers/staging/lustre/lustre/lclient/lcommon_misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c index 21de1cd..0900bef 100644 --- a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c +++ b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c @@ -63,7 +63,7 @@ int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp) if (rc) return rc; - stripes = min(desc.ld_tgt_count, (__u32)LOV_MAX_STRIPE_COUNT); + stripes = min_t(__u32, desc.ld_tgt_count, (__u32)LOV_MAX_STRIPE_COUNT); If you are using min_t(__u32, ...) then there is no need for the (__u32) cast of LOV_MAX_STRIPE_COUNT, since that is the whole point of min_t() that the cast is done internally. lsm.lsm_stripe_count = stripes; easize = obd_size_diskmd(dt_exp, lsm); -- 1.9.0 Cheers, Andreas -- Andreas Dilger Lustre Software Architect Intel High Performance Data Division -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v6 3/8] staging: lustre: lclient: lcommon_misc.c fixing coding style issues
If you are using min_t(__u32, ...) then there is no need for the (__u32) cast of LOV_MAX_STRIPE_COUNT, since that is the whole point of min_t() that the cast is done internally. Agreed, it makes sense not to cast twice when using min_t(). -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v6 3/8] staging: lustre: lclient: lcommon_misc.c fixing coding style issues
From: Anil Belur fixed warning: * WARNING: min() should probably be min_t(__u32, desc.ld_tgt_count, LOV_MAX_STRIPE_COUNT) Signed-off-by: Anil Belur --- drivers/staging/lustre/lustre/lclient/lcommon_misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c index 21de1cd..0900bef 100644 --- a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c +++ b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c @@ -63,7 +63,7 @@ int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp) if (rc) return rc; - stripes = min(desc.ld_tgt_count, (__u32)LOV_MAX_STRIPE_COUNT); + stripes = min_t(__u32, desc.ld_tgt_count, (__u32)LOV_MAX_STRIPE_COUNT); lsm.lsm_stripe_count = stripes; easize = obd_size_diskmd(dt_exp, ); -- 1.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v6 3/8] staging: lustre: lclient: lcommon_misc.c fixing coding style issues
From: Anil Belur ask...@gmail.com fixed warning: * WARNING: min() should probably be min_t(__u32, desc.ld_tgt_count, LOV_MAX_STRIPE_COUNT) Signed-off-by: Anil Belur ask...@gmail.com --- drivers/staging/lustre/lustre/lclient/lcommon_misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c index 21de1cd..0900bef 100644 --- a/drivers/staging/lustre/lustre/lclient/lcommon_misc.c +++ b/drivers/staging/lustre/lustre/lclient/lcommon_misc.c @@ -63,7 +63,7 @@ int cl_init_ea_size(struct obd_export *md_exp, struct obd_export *dt_exp) if (rc) return rc; - stripes = min(desc.ld_tgt_count, (__u32)LOV_MAX_STRIPE_COUNT); + stripes = min_t(__u32, desc.ld_tgt_count, (__u32)LOV_MAX_STRIPE_COUNT); lsm.lsm_stripe_count = stripes; easize = obd_size_diskmd(dt_exp, lsm); -- 1.9.0 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
