Re: [PATCH v6 5/8] clk: mediatek: Add MT6765 clock support

2019-08-15 Thread Greg KH
On Wed, Aug 14, 2019 at 05:27:20PM -0700, Stephen Boyd wrote:
> Quoting Macpaul Lin (2019-07-12 02:43:41)
> > diff --git a/drivers/clk/mediatek/clk-mt6765-audio.c 
> > b/drivers/clk/mediatek/clk-mt6765-audio.c
> > new file mode 100644
> > index ..41f19343dfb9
> > --- /dev/null
> > +++ b/drivers/clk/mediatek/clk-mt6765-audio.c
> > @@ -0,0 +1,109 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2018 MediaTek Inc.
> > + * Author: Owen Chen 
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> 
> Please use SPDX tags.

To be specific, _only_ the SPDX tag.  There is an SPDX tag on this file,
and the others, it's just that the license text is no longer needed with
that.

thanks,

greg k-h


Re: [PATCH v6 5/8] clk: mediatek: Add MT6765 clock support

2019-08-14 Thread Stephen Boyd
Quoting Macpaul Lin (2019-07-12 02:43:41)
> diff --git a/drivers/clk/mediatek/clk-mt6765-audio.c 
> b/drivers/clk/mediatek/clk-mt6765-audio.c
> new file mode 100644
> index ..41f19343dfb9
> --- /dev/null
> +++ b/drivers/clk/mediatek/clk-mt6765-audio.c
> @@ -0,0 +1,109 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2018 MediaTek Inc.
> + * Author: Owen Chen 
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.

Please use SPDX tags.

> + */
> +
> +#include 
> +#include 
> +
> +#include "clk-mtk.h"
> +#include "clk-gate.h"
> +
> diff --git a/drivers/clk/mediatek/clk-mt6765-vcodec.c 
> b/drivers/clk/mediatek/clk-mt6765-vcodec.c
> new file mode 100644
> index ..eb9ae1c2c99c
> --- /dev/null
> +++ b/drivers/clk/mediatek/clk-mt6765-vcodec.c
> @@ -0,0 +1,79 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2018 MediaTek Inc.
> + * Author: Owen Chen 
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */

SPDX tags.

> diff --git a/drivers/clk/mediatek/clk-mt6765.c 
> b/drivers/clk/mediatek/clk-mt6765.c
> new file mode 100644
> index ..f716a48a926d
> --- /dev/null
> +++ b/drivers/clk/mediatek/clk-mt6765.c
> @@ -0,0 +1,961 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2018 MediaTek Inc.
> + * Author: Owen Chen 
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.

SPDX tags.

> + */
> +
> +#include 
> +#include 
> +#include 
> +#include 
> +#include 

Is this used? Maybe I deleted it.

> +#include 
> +#include 
[...]
> +
> +static const char * const axi_parents[] = {
> +   "clk26m",
> +   "syspll_d7",
> +   "syspll1_d4",
> +   "syspll3_d2"
> +};
> +
> +static const char * const mem_parents[] = {
> +   "clk26m",
> +   "dmpll_ck",
> +   "apll1_ck"
> +};
> +
> +static const char * const mm_parents[] = {
> +   "clk26m",
> +   "mmpll_ck",
> +   "syspll1_d2",
> +   "syspll_d5",
> +   "syspll1_d4",
> +   "univpll_d5",
> +   "univpll1_d2",
> +   "mmpll_d2"
> +};
> +
> +static const char * const scp_parents[] = {
> +   "clk26m",
> +   "syspll4_d2",
> +   "univpll2_d2",
> +   "syspll1_d2",
> +   "univpll1_d2",
> +   "syspll_d3",
> +   "univpll_d3"
> +};
> +
> +static const char * const mfg_parents[] = {
> +   "clk26m",
> +   "mfgpll_ck",
> +   "syspll_d3",
> +   "univpll_d3"
> +};
> +
> +static const char * const atb_parents[] = {
> +   "clk26m",
> +   "syspll1_d4",
> +   "syspll1_d2"
> +};
> +
> +static const char * const camtg_parents[] = {
> +   "clk26m",
> +   "usb20_192m_d8",
> +   "univpll2_d8",
> +   "usb20_192m_d4",
> +   "univpll2_d32",
> +   "usb20_192m_d16",
> +   "usb20_192m_d32"
> +};
> +
> +static const char * const uart_parents[] = {
> +   "clk26m",
> +   "univpll2_d8"
> +};
> +
> +static const char * const spi_parents[] = {
> +   "clk26m",
> +   "syspll3_d2",
> +   "syspll4_d2",
> +   "syspll2_d4"
> +};
> +
> +static const char * const msdc5hclk_parents[] = {
> +   "clk26m",
> +   "syspll1_d2",
> +   "univpll1_d4",
> +   "syspll2_d2"
> +};
> +
> +static const char * const msdc50_0_parents[] = {
> +   "clk26m",
> +   "msdcpll_ck",
> +   "syspll2_d2",
> +   "syspll4_d2",
> +   "univpll1_d2",
> +   "syspll1_d2",
> +   "univpll_d5",
> +   "univpll1_d4"
> +};
> +
> +static const char * const msdc30_1_parents[] = {
> +   "clk26m",
> +   "msdcpll_d2",
> +   "univpll2_d2",
> +   "syspll2_d2",
> +   "syspll1_d4",
> +   "univpll1_d4",
> +   "usb20_192m_d4",
> +   "syspll2_d4"
> +};
> +
> +static const char * const audio_parents[] = {
> +   "clk26m",
> + 

[PATCH v6 5/8] clk: mediatek: Add MT6765 clock support

2019-07-12 Thread Macpaul Lin
From: Owen Chen 

Add MT6765 clock support, include topckgen, apmixedsys,
infracfg, mcucfg and subsystem clocks.

Signed-off-by: Owen Chen 
Signed-off-by: Mars Cheng 
Signed-off-by: Macpaul Lin 
---
 drivers/clk/mediatek/Kconfig |  86 ++
 drivers/clk/mediatek/Makefile|   7 +
 drivers/clk/mediatek/clk-mt6765-audio.c  | 109 +++
 drivers/clk/mediatek/clk-mt6765-cam.c|  83 ++
 drivers/clk/mediatek/clk-mt6765-img.c|  79 ++
 drivers/clk/mediatek/clk-mt6765-mipi0a.c |  77 ++
 drivers/clk/mediatek/clk-mt6765-mm.c | 105 +++
 drivers/clk/mediatek/clk-mt6765-vcodec.c |  79 ++
 drivers/clk/mediatek/clk-mt6765.c| 961 +++
 9 files changed, 1586 insertions(+)
 create mode 100644 drivers/clk/mediatek/clk-mt6765-audio.c
 create mode 100644 drivers/clk/mediatek/clk-mt6765-cam.c
 create mode 100644 drivers/clk/mediatek/clk-mt6765-img.c
 create mode 100644 drivers/clk/mediatek/clk-mt6765-mipi0a.c
 create mode 100644 drivers/clk/mediatek/clk-mt6765-mm.c
 create mode 100644 drivers/clk/mediatek/clk-mt6765-vcodec.c
 create mode 100644 drivers/clk/mediatek/clk-mt6765.c

diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig
index 4d8a9aef95f6..1a8db28f9d10 100644
--- a/drivers/clk/mediatek/Kconfig
+++ b/drivers/clk/mediatek/Kconfig
@@ -116,6 +116,92 @@ config COMMON_CLK_MT2712_VENCSYS
---help---
  This driver supports MediaTek MT2712 vencsys clocks.
 
+config COMMON_CLK_MT6765
+   bool "Clock driver for MediaTek MT6765"
+   depends on (ARCH_MEDIATEK && ARM64) || COMPILE_TEST
+   select COMMON_CLK_MEDIATEK
+   default ARCH_MEDIATEK && ARM64
+   help
+ This driver supports MediaTek MT6765 basic clocks.
+
+config COMMON_CLK_MT6765_AUDIOSYS
+   bool "Clock driver for MediaTek MT6765 audiosys"
+   depends on COMMON_CLK_MT6765
+   help
+ This driver supports MediaTek MT6765 audiosys clocks.
+
+config COMMON_CLK_MT6765_CAMSYS
+   bool "Clock driver for MediaTek MT6765 camsys"
+   depends on COMMON_CLK_MT6765
+   help
+ This driver supports MediaTek MT6765 camsys clocks.
+
+config COMMON_CLK_MT6765_GCESYS
+   bool "Clock driver for MediaTek MT6765 gcesys"
+   depends on COMMON_CLK_MT6765
+   help
+ This driver supports MediaTek MT6765 gcesys clocks.
+
+config COMMON_CLK_MT6765_MMSYS
+   bool "Clock driver for MediaTek MT6765 mmsys"
+   depends on COMMON_CLK_MT6765
+   help
+ This driver supports MediaTek MT6765 mmsys clocks.
+
+config COMMON_CLK_MT6765_IMGSYS
+   bool "Clock driver for MediaTek MT6765 imgsys"
+   depends on COMMON_CLK_MT6765
+   help
+ This driver supports MediaTek MT6765 imgsys clocks.
+
+config COMMON_CLK_MT6765_VCODECSYS
+   bool "Clock driver for MediaTek MT6765 vcodecsys"
+   depends on COMMON_CLK_MT6765
+   help
+ This driver supports MediaTek MT6765 vcodecsys clocks.
+
+config COMMON_CLK_MT6765_MFGSYS
+   bool "Clock driver for MediaTek MT6765 mfgsys"
+   depends on COMMON_CLK_MT6765
+   help
+ This driver supports MediaTek MT6765 mfgsys clocks.
+
+config COMMON_CLK_MT6765_MIPI0ASYS
+   bool "Clock driver for MediaTek MT6765 mipi0asys"
+   depends on COMMON_CLK_MT6765
+   help
+ This driver supports MediaTek MT6765 mipi0asys clocks.
+
+config COMMON_CLK_MT6765_MIPI0BSYS
+   bool "Clock driver for MediaTek MT6765 mipi0bsys"
+   depends on COMMON_CLK_MT6765
+   help
+ This driver supports MediaTek MT6765 mipi0bsys clocks.
+
+config COMMON_CLK_MT6765_MIPI1ASYS
+   bool "Clock driver for MediaTek MT6765 mipi1asys"
+   depends on COMMON_CLK_MT6765
+   help
+ This driver supports MediaTek MT6765 mipi1asys clocks.
+
+config COMMON_CLK_MT6765_MIPI1BSYS
+   bool "Clock driver for MediaTek MT6765 mipi1bsys"
+   depends on COMMON_CLK_MT6765
+   help
+ This driver supports MediaTek MT6765 mipi1bsys clocks.
+
+config COMMON_CLK_MT6765_MIPI2ASYS
+   bool "Clock driver for MediaTek MT6765 mipi2asys"
+   depends on COMMON_CLK_MT6765
+  help
+ This driver supports MediaTek MT6765 mipi2asys clocks.
+
+config COMMON_CLK_MT6765_MIPI2BSYS
+   bool "Clock driver for MediaTek MT6765 mipi2bsys"
+   depends on COMMON_CLK_MT6765
+   help
+ This driver supports MediaTek MT6765 mipi2bsys clocks.
+
 config COMMON_CLK_MT6797
bool "Clock driver for MediaTek MT6797"
depends on (ARCH_MEDIATEK && ARM64) || COMPILE_TEST
diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile
index f74937b35f68..c368442914a8 100644
--- a/drivers/clk/mediatek/Makefile
+++ b/drivers/clk/mediatek/Makefile
@@ -1,6 +1,13 @@
 # SPDX-License-Identifier: GPL-2.0
 obj-$(CONFIG_COMMON_CLK_MEDIATEK) += clk-mtk.o clk-pll.o clk-gate.o 
clk-apmixed.o clk-cpumux.o reset.o clk-mux.o
 
+obj-$(CONFIG_COMMON_CLK_MT6765) += clk-mt6765.o
+obj-$(CONFIG_COMMON_CLK_MT6765_AUDI