Re: [PATCH v6 7/8] staging: lustre: lclient: lcommon_cl.c fixing coding style issues
> Should be an empty line between variable declarations and code. Hi Andreas, not sure if you are referring to the same patch as there is already an empty line present. 823 loff_t size = cl_isize_read(inode); 824 loff_t cur_index = start >> PAGE_CACHE_SHIFT; 825 loff_t size_index = ((size - 1) >> PAGE_CACHE_SHIFT); 826 827 if ((size == 0 && cur_index != 0) || Cheers, Anil -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v6 7/8] staging: lustre: lclient: lcommon_cl.c fixing coding style issues
On 2014/06/16, 11:43 PM, "Anil Belur" wrote: >From: Anil Belur > >fixed: WARNING: line over 80 characters, used a new variable 'size_index' >to >store the offset. Replaceed "unsigned long" with "loff_t" type for >'cur_index' > >Signed-off-by: Anil Belur >--- > drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c >b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c >index 2f51b76..e2da397 100644 >--- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c >+++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c >@@ -821,10 +821,11 @@ int ccc_prep_size(const struct lu_env *env, struct >cl_object *obj, >* linux-2.6.18-128.1.1 miss to do that. >* --bug 17336 */ > loff_t size = cl_isize_read(inode); >- unsigned long cur_index = start >> >PAGE_CACHE_SHIFT; >+ loff_t cur_index = start >> PAGE_CACHE_SHIFT; >+ loff_t size_index = ((size - 1) >> >PAGE_CACHE_SHIFT); Should be an empty line between variable declarations and code. > > if ((size == 0 && cur_index != 0) || >- (((size - 1) >> PAGE_CACHE_SHIFT) < >cur_index)) >+ (size_index < cur_index)) > *exceed = 1; > } > return result; >-- >1.9.0 > > Cheers, Andreas -- Andreas Dilger Lustre Software Architect Intel High Performance Data Division -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v6 7/8] staging: lustre: lclient: lcommon_cl.c fixing coding style issues
On 2014/06/16, 11:43 PM, Anil Belur ask...@gmail.com wrote: From: Anil Belur ask...@gmail.com fixed: WARNING: line over 80 characters, used a new variable 'size_index' to store the offset. Replaceed unsigned long with loff_t type for 'cur_index' Signed-off-by: Anil Belur ask...@gmail.com --- drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c index 2f51b76..e2da397 100644 --- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c +++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c @@ -821,10 +821,11 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj, * linux-2.6.18-128.1.1 miss to do that. * --bug 17336 */ loff_t size = cl_isize_read(inode); - unsigned long cur_index = start PAGE_CACHE_SHIFT; + loff_t cur_index = start PAGE_CACHE_SHIFT; + loff_t size_index = ((size - 1) PAGE_CACHE_SHIFT); Should be an empty line between variable declarations and code. if ((size == 0 cur_index != 0) || - (((size - 1) PAGE_CACHE_SHIFT) cur_index)) + (size_index cur_index)) *exceed = 1; } return result; -- 1.9.0 Cheers, Andreas -- Andreas Dilger Lustre Software Architect Intel High Performance Data Division -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v6 7/8] staging: lustre: lclient: lcommon_cl.c fixing coding style issues
Should be an empty line between variable declarations and code. Hi Andreas, not sure if you are referring to the same patch as there is already an empty line present. 823 loff_t size = cl_isize_read(inode); 824 loff_t cur_index = start PAGE_CACHE_SHIFT; 825 loff_t size_index = ((size - 1) PAGE_CACHE_SHIFT); 826 827 if ((size == 0 cur_index != 0) || Cheers, Anil -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v6 7/8] staging: lustre: lclient: lcommon_cl.c fixing coding style issues
From: Anil Belur fixed: WARNING: line over 80 characters, used a new variable 'size_index' to store the offset. Replaceed "unsigned long" with "loff_t" type for 'cur_index' Signed-off-by: Anil Belur --- drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c index 2f51b76..e2da397 100644 --- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c +++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c @@ -821,10 +821,11 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj, * linux-2.6.18-128.1.1 miss to do that. * --bug 17336 */ loff_t size = cl_isize_read(inode); - unsigned long cur_index = start >> PAGE_CACHE_SHIFT; + loff_t cur_index = start >> PAGE_CACHE_SHIFT; + loff_t size_index = ((size - 1) >> PAGE_CACHE_SHIFT); if ((size == 0 && cur_index != 0) || - (((size - 1) >> PAGE_CACHE_SHIFT) < cur_index)) + (size_index < cur_index)) *exceed = 1; } return result; -- 1.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v6 7/8] staging: lustre: lclient: lcommon_cl.c fixing coding style issues
From: Anil Belur ask...@gmail.com fixed: WARNING: line over 80 characters, used a new variable 'size_index' to store the offset. Replaceed unsigned long with loff_t type for 'cur_index' Signed-off-by: Anil Belur ask...@gmail.com --- drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c index 2f51b76..e2da397 100644 --- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c +++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c @@ -821,10 +821,11 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj, * linux-2.6.18-128.1.1 miss to do that. * --bug 17336 */ loff_t size = cl_isize_read(inode); - unsigned long cur_index = start PAGE_CACHE_SHIFT; + loff_t cur_index = start PAGE_CACHE_SHIFT; + loff_t size_index = ((size - 1) PAGE_CACHE_SHIFT); if ((size == 0 cur_index != 0) || - (((size - 1) PAGE_CACHE_SHIFT) cur_index)) + (size_index cur_index)) *exceed = 1; } return result; -- 1.9.0 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
