Re: [PATCH v7, 0/8] Add MediaTek USB3 DRD Driver
On Fri, 2016-10-28 at 12:37 +0200, Matthias Brugger wrote: > Hi Chunfeng, > > On 10/19/2016 04:28 AM, Chunfeng Yun wrote: > > These patches introduce the MediaTek USB3 dual-role controller > > driver. > > > > The driver can be configured as Dual-Role Device (DRD), > > Peripheral Only and Host Only (xHCI) modes. It works well > > with Mass Storage, RNDIS and g_zero on FS/HS and SS. And it is > > tested on MT8173 platform which only contains USB2.0 device IP, > > and on MT6290 platform which contains USB3.0 device IP. [...] > > > > Change in v2: > > 1. modify binding docs according to suggestions > > 2. modify some comments and remove some dummy blank lines > > 3. fix memory leakage > > > > > > Chunfeng Yun (8): > > dt-bindings: mt8173-xhci: support host side of dual-role mode > > dt-bindings: mt8173-mtu3: add devicetree bindings > > usb: xhci-mtk: make IPPC register optional > > usb: Add MediaTek USB3 DRD driver > > usb: mtu3: Super-Speed Peripheral mode support > > usb: mtu3: host only mode support > > usb: mtu3: dual-role mode support > > arm64: dts: mediatek: add USB3 DRD driver > > > > I tried the driver with my mt8173-evb, but wasn't able to get USB > working (no usb stick detected when adding to the usb port). > Can you test it again by USB3.0 type-A port? If it works, then regulators of vusb33 and vbus are got after PROBE_DEFER of mt6397-regulator driver; For OTG port, need cherry pick a patch: https://patchwork.kernel.org/patch/9055261/ which is abandoned because GPIO driver owner wants to fix all pins with the same problem. Then device will be recognized well when connected to PC with OTG cable. But it is a trouble for OTG host mode, due to vbus 5.5V of OTG port is originally provided by charger driver which is not upstreamed on EVB board, we need rework the board to control vbus by gpio. There is a simple way, you can plug in a self-powered hub to test OTG host mode. > # dmesg |grep mtu > [0.428420] mtu3 11271000.usb: failed to get vusb33 > [0.510570] mtu3 11271000.usb: failed to get vbus > [0.592103] mtu3 11271000.usb: failed to get vbus > > > Relevant config options: > CONFIG_USB_MTU3=y > CONFIG_USB_MTU3_HOST=y > CONFIG_USB_MTU3_DEBUG=y > CONFIG_PHY_MT65XX_USB3=y > > > Looks like an error in the device tree. I can see that the mt6397 > regulater get's initialized *after* the mtu3 driver: > [0.505166] mt6397-regulator mt6397-regulator: Chip ID = 0x4097 > > Not sure if this is related. > Any idea whats going wrong here? > as above. Sorry for inconvenience > Cheers, > Matthias
Re: [PATCH v7, 0/8] Add MediaTek USB3 DRD Driver
Hi Chunfeng, On 10/19/2016 04:28 AM, Chunfeng Yun wrote: These patches introduce the MediaTek USB3 dual-role controller driver. The driver can be configured as Dual-Role Device (DRD), Peripheral Only and Host Only (xHCI) modes. It works well with Mass Storage, RNDIS and g_zero on FS/HS and SS. And it is tested on MT8173 platform which only contains USB2.0 device IP, and on MT6290 platform which contains USB3.0 device IP. Change in v7: 1. split dual-role driver into four patchs 2. remove QMU done tasklet 3. add a bool in xhci_hcd_mtk to signal absence of IPPC Change in v6: 1. handle endianness of GPD and SETUP data 2. remove dummy error log and return suitable error number 3. cancel delay work when deregiseter driver Change in v5: 1. modify some comments 2. rename some unsuitable variables 3. add reg-names property for host node 4. add USB_MTU3_DEBUG to control debug messages Change in v4: 1. fix build errors on non-mediatek platforms 2. provide manual dual-role switch via debugfs instead of sysfs Change in v3: 1. fix some typo error 2. rename mtu3.txt to mt8173-mtu3.txt Change in v2: 1. modify binding docs according to suggestions 2. modify some comments and remove some dummy blank lines 3. fix memory leakage Chunfeng Yun (8): dt-bindings: mt8173-xhci: support host side of dual-role mode dt-bindings: mt8173-mtu3: add devicetree bindings usb: xhci-mtk: make IPPC register optional usb: Add MediaTek USB3 DRD driver usb: mtu3: Super-Speed Peripheral mode support usb: mtu3: host only mode support usb: mtu3: dual-role mode support arm64: dts: mediatek: add USB3 DRD driver I tried the driver with my mt8173-evb, but wasn't able to get USB working (no usb stick detected when adding to the usb port). # dmesg |grep mtu [0.428420] mtu3 11271000.usb: failed to get vusb33 [0.510570] mtu3 11271000.usb: failed to get vbus [0.592103] mtu3 11271000.usb: failed to get vbus Relevant config options: CONFIG_USB_MTU3=y CONFIG_USB_MTU3_HOST=y CONFIG_USB_MTU3_DEBUG=y CONFIG_PHY_MT65XX_USB3=y Looks like an error in the device tree. I can see that the mt6397 regulater get's initialized *after* the mtu3 driver: [0.505166] mt6397-regulator mt6397-regulator: Chip ID = 0x4097 Not sure if this is related. Any idea whats going wrong here? Cheers, Matthias
Re: [PATCH v7, 0/8] Add MediaTek USB3 DRD Driver
On Wed, Oct 19, 2016 at 10:28:19AM +0800, Chunfeng Yun wrote: > These patches introduce the MediaTek USB3 dual-role controller > driver. > > The driver can be configured as Dual-Role Device (DRD), > Peripheral Only and Host Only (xHCI) modes. It works well > with Mass Storage, RNDIS and g_zero on FS/HS and SS. And it is > tested on MT8173 platform which only contains USB2.0 device IP, > and on MT6290 platform which contains USB3.0 device IP. > > Change in v7: > 1. split dual-role driver into four patchs > 2. remove QMU done tasklet > 3. add a bool in xhci_hcd_mtk to signal absence of IPPC Given a lack of objection from anyone, I've now merged these to my tree to get them a spin in the 0-day build-bot. thanks, greg k-h
[PATCH v7, 0/8] Add MediaTek USB3 DRD Driver
These patches introduce the MediaTek USB3 dual-role controller driver. The driver can be configured as Dual-Role Device (DRD), Peripheral Only and Host Only (xHCI) modes. It works well with Mass Storage, RNDIS and g_zero on FS/HS and SS. And it is tested on MT8173 platform which only contains USB2.0 device IP, and on MT6290 platform which contains USB3.0 device IP. Change in v7: 1. split dual-role driver into four patchs 2. remove QMU done tasklet 3. add a bool in xhci_hcd_mtk to signal absence of IPPC Change in v6: 1. handle endianness of GPD and SETUP data 2. remove dummy error log and return suitable error number 3. cancel delay work when deregiseter driver Change in v5: 1. modify some comments 2. rename some unsuitable variables 3. add reg-names property for host node 4. add USB_MTU3_DEBUG to control debug messages Change in v4: 1. fix build errors on non-mediatek platforms 2. provide manual dual-role switch via debugfs instead of sysfs Change in v3: 1. fix some typo error 2. rename mtu3.txt to mt8173-mtu3.txt Change in v2: 1. modify binding docs according to suggestions 2. modify some comments and remove some dummy blank lines 3. fix memory leakage Chunfeng Yun (8): dt-bindings: mt8173-xhci: support host side of dual-role mode dt-bindings: mt8173-mtu3: add devicetree bindings usb: xhci-mtk: make IPPC register optional usb: Add MediaTek USB3 DRD driver usb: mtu3: Super-Speed Peripheral mode support usb: mtu3: host only mode support usb: mtu3: dual-role mode support arm64: dts: mediatek: add USB3 DRD driver .../devicetree/bindings/usb/mt8173-mtu3.txt| 87 ++ .../devicetree/bindings/usb/mt8173-xhci.txt| 54 +- arch/arm64/boot/dts/mediatek/mt8173-evb.dts| 63 +- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 29 +- drivers/usb/Kconfig|2 + drivers/usb/Makefile |1 + drivers/usb/host/xhci-mtk.c| 38 +- drivers/usb/host/xhci-mtk.h|1 + drivers/usb/mtu3/Kconfig | 54 ++ drivers/usb/mtu3/Makefile | 18 + drivers/usb/mtu3/mtu3.h| 417 + drivers/usb/mtu3/mtu3_core.c | 859 +++ drivers/usb/mtu3/mtu3_dr.c | 379 + drivers/usb/mtu3/mtu3_dr.h | 108 +++ drivers/usb/mtu3/mtu3_gadget.c | 730 drivers/usb/mtu3/mtu3_gadget_ep0.c | 881 drivers/usb/mtu3/mtu3_host.c | 294 +++ drivers/usb/mtu3/mtu3_hw_regs.h| 473 +++ drivers/usb/mtu3/mtu3_plat.c | 484 +++ drivers/usb/mtu3/mtu3_qmu.c| 573 + drivers/usb/mtu3/mtu3_qmu.h| 43 + 21 files changed, 5561 insertions(+), 27 deletions(-) create mode 100644 Documentation/devicetree/bindings/usb/mt8173-mtu3.txt create mode 100644 drivers/usb/mtu3/Kconfig create mode 100644 drivers/usb/mtu3/Makefile create mode 100644 drivers/usb/mtu3/mtu3.h create mode 100644 drivers/usb/mtu3/mtu3_core.c create mode 100644 drivers/usb/mtu3/mtu3_dr.c create mode 100644 drivers/usb/mtu3/mtu3_dr.h create mode 100644 drivers/usb/mtu3/mtu3_gadget.c create mode 100644 drivers/usb/mtu3/mtu3_gadget_ep0.c create mode 100644 drivers/usb/mtu3/mtu3_host.c create mode 100644 drivers/usb/mtu3/mtu3_hw_regs.h create mode 100644 drivers/usb/mtu3/mtu3_plat.c create mode 100644 drivers/usb/mtu3/mtu3_qmu.c create mode 100644 drivers/usb/mtu3/mtu3_qmu.h -- 1.7.9.5
