Re: [PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge
Hi Laurent, On Fri, Apr 06, 2018 at 04:53:43PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > On Friday, 6 April 2018 16:08:05 EEST Jacopo Mondi wrote: > > Hello, > >this series enables HDMI display on V3M Eagle board. > > > > The series is based on Geert's "renesas-drivers-2018-04-03-v4.16" with > > THC63LVD1024 driver on top (cfr. my in review series: > > "[PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge") > > This isn't a good base for development, as you would pull way too many > dependencies in. Could you please base v8 on top of v4.17-rc1 (or if you get > to post it before v4.17-rc1 gets merged, you can use Linus' master, as the > ARM64 DT pull requests for v4.17-rc1 have been merged) ? It will then be ready > for Simon to pull in his v4.18 branch. I used renesas-drivers as it already contains partial r8a77970 support which is not there in v4.16 (PFC, GPIO, SCIF...) I should wait for v4.17-rc1 to come out and re-propose on top of that probably. > > > This series includes some preliminary work from Sergei and Niklas. I have > > reworked the two final patches from Niklas to enable DU first, add the LVDS > > decoder node, and finally add the ADV7511W chip and enable HDMI output. > > > > A branch for testing is available at: > > git://jmondi.org/linux v3m/renesas-drivers-2018-04-03-v4.16/v7-eagle-dts > > > > Thanks > >j > > > > Jacopo Mondi (2): > > arm64: dts: renesas: eagle: Enable DU > > arm64: dts: renesas: eagle: Add LVDS decoder > > > > Niklas Söderlund (2): > > arm64: dts: renesas: r8a77970: add the LVDS instance > > arm64: dts: renesas: eagle: Add ADV7511W and HDMI output > > > > Sergei Shtylyov (3): > > arm64: dts: renesas: r8a77970: add FCPVD support > > arm64: dts: renesas: r8a77970: add VSPD support > > arm64: dts: renesas: r8a77970: add DU support > > > > arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 89 +++ > > arch/arm64/boot/dts/renesas/r8a77970.dtsi | 73 + > > 2 files changed, 162 insertions(+) > > > > -- > Regards, > > Laurent Pinchart > > > signature.asc Description: PGP signature
Re: [PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge
Hi Laurent, On Fri, Apr 06, 2018 at 04:53:43PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > On Friday, 6 April 2018 16:08:05 EEST Jacopo Mondi wrote: > > Hello, > >this series enables HDMI display on V3M Eagle board. > > > > The series is based on Geert's "renesas-drivers-2018-04-03-v4.16" with > > THC63LVD1024 driver on top (cfr. my in review series: > > "[PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge") > > This isn't a good base for development, as you would pull way too many > dependencies in. Could you please base v8 on top of v4.17-rc1 (or if you get > to post it before v4.17-rc1 gets merged, you can use Linus' master, as the > ARM64 DT pull requests for v4.17-rc1 have been merged) ? It will then be ready > for Simon to pull in his v4.18 branch. I used renesas-drivers as it already contains partial r8a77970 support which is not there in v4.16 (PFC, GPIO, SCIF...) I should wait for v4.17-rc1 to come out and re-propose on top of that probably. > > > This series includes some preliminary work from Sergei and Niklas. I have > > reworked the two final patches from Niklas to enable DU first, add the LVDS > > decoder node, and finally add the ADV7511W chip and enable HDMI output. > > > > A branch for testing is available at: > > git://jmondi.org/linux v3m/renesas-drivers-2018-04-03-v4.16/v7-eagle-dts > > > > Thanks > >j > > > > Jacopo Mondi (2): > > arm64: dts: renesas: eagle: Enable DU > > arm64: dts: renesas: eagle: Add LVDS decoder > > > > Niklas Söderlund (2): > > arm64: dts: renesas: r8a77970: add the LVDS instance > > arm64: dts: renesas: eagle: Add ADV7511W and HDMI output > > > > Sergei Shtylyov (3): > > arm64: dts: renesas: r8a77970: add FCPVD support > > arm64: dts: renesas: r8a77970: add VSPD support > > arm64: dts: renesas: r8a77970: add DU support > > > > arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 89 +++ > > arch/arm64/boot/dts/renesas/r8a77970.dtsi | 73 + > > 2 files changed, 162 insertions(+) > > > > -- > Regards, > > Laurent Pinchart > > > signature.asc Description: PGP signature
Re: [PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge
Hi Jacopo, On Friday, 6 April 2018 16:08:05 EEST Jacopo Mondi wrote: > Hello, >this series enables HDMI display on V3M Eagle board. > > The series is based on Geert's "renesas-drivers-2018-04-03-v4.16" with > THC63LVD1024 driver on top (cfr. my in review series: > "[PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge") This isn't a good base for development, as you would pull way too many dependencies in. Could you please base v8 on top of v4.17-rc1 (or if you get to post it before v4.17-rc1 gets merged, you can use Linus' master, as the ARM64 DT pull requests for v4.17-rc1 have been merged) ? It will then be ready for Simon to pull in his v4.18 branch. > This series includes some preliminary work from Sergei and Niklas. I have > reworked the two final patches from Niklas to enable DU first, add the LVDS > decoder node, and finally add the ADV7511W chip and enable HDMI output. > > A branch for testing is available at: > git://jmondi.org/linux v3m/renesas-drivers-2018-04-03-v4.16/v7-eagle-dts > > Thanks >j > > Jacopo Mondi (2): > arm64: dts: renesas: eagle: Enable DU > arm64: dts: renesas: eagle: Add LVDS decoder > > Niklas Söderlund (2): > arm64: dts: renesas: r8a77970: add the LVDS instance > arm64: dts: renesas: eagle: Add ADV7511W and HDMI output > > Sergei Shtylyov (3): > arm64: dts: renesas: r8a77970: add FCPVD support > arm64: dts: renesas: r8a77970: add VSPD support > arm64: dts: renesas: r8a77970: add DU support > > arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 89 +++ > arch/arm64/boot/dts/renesas/r8a77970.dtsi | 73 + > 2 files changed, 162 insertions(+) > -- Regards, Laurent Pinchart
Re: [PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge
Hi Jacopo, On Friday, 6 April 2018 16:08:05 EEST Jacopo Mondi wrote: > Hello, >this series enables HDMI display on V3M Eagle board. > > The series is based on Geert's "renesas-drivers-2018-04-03-v4.16" with > THC63LVD1024 driver on top (cfr. my in review series: > "[PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge") This isn't a good base for development, as you would pull way too many dependencies in. Could you please base v8 on top of v4.17-rc1 (or if you get to post it before v4.17-rc1 gets merged, you can use Linus' master, as the ARM64 DT pull requests for v4.17-rc1 have been merged) ? It will then be ready for Simon to pull in his v4.18 branch. > This series includes some preliminary work from Sergei and Niklas. I have > reworked the two final patches from Niklas to enable DU first, add the LVDS > decoder node, and finally add the ADV7511W chip and enable HDMI output. > > A branch for testing is available at: > git://jmondi.org/linux v3m/renesas-drivers-2018-04-03-v4.16/v7-eagle-dts > > Thanks >j > > Jacopo Mondi (2): > arm64: dts: renesas: eagle: Enable DU > arm64: dts: renesas: eagle: Add LVDS decoder > > Niklas Söderlund (2): > arm64: dts: renesas: r8a77970: add the LVDS instance > arm64: dts: renesas: eagle: Add ADV7511W and HDMI output > > Sergei Shtylyov (3): > arm64: dts: renesas: r8a77970: add FCPVD support > arm64: dts: renesas: r8a77970: add VSPD support > arm64: dts: renesas: r8a77970: add DU support > > arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 89 +++ > arch/arm64/boot/dts/renesas/r8a77970.dtsi | 73 + > 2 files changed, 162 insertions(+) > -- Regards, Laurent Pinchart
Re: [PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge
Sorry for the mess subject should have been Subject: [PATCH 0/7] V3M-Eagle display enablement I copied the wrong one from another cover letter... On Fri, Apr 06, 2018 at 03:08:05PM +0200, Jacopo Mondi wrote: > Hello, >this series enables HDMI display on V3M Eagle board. > > The series is based on Geert's "renesas-drivers-2018-04-03-v4.16" with > THC63LVD1024 driver on top (cfr. my in review series: > "[PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge") > > This series includes some preliminary work from Sergei and Niklas. I have > reworked the two final patches from Niklas to enable DU first, add the LVDS > decoder node, and finally add the ADV7511W chip and enable HDMI output. > > A branch for testing is available at: > git://jmondi.org/linux v3m/renesas-drivers-2018-04-03-v4.16/v7-eagle-dts > > Thanks >j > > Jacopo Mondi (2): > arm64: dts: renesas: eagle: Enable DU > arm64: dts: renesas: eagle: Add LVDS decoder > > Niklas Söderlund (2): > arm64: dts: renesas: r8a77970: add the LVDS instance > arm64: dts: renesas: eagle: Add ADV7511W and HDMI output > > Sergei Shtylyov (3): > arm64: dts: renesas: r8a77970: add FCPVD support > arm64: dts: renesas: r8a77970: add VSPD support > arm64: dts: renesas: r8a77970: add DU support > > arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 89 > ++ > arch/arm64/boot/dts/renesas/r8a77970.dtsi | 73 + > 2 files changed, 162 insertions(+) > > -- > 2.7.4 > signature.asc Description: PGP signature
Re: [PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge
Sorry for the mess subject should have been Subject: [PATCH 0/7] V3M-Eagle display enablement I copied the wrong one from another cover letter... On Fri, Apr 06, 2018 at 03:08:05PM +0200, Jacopo Mondi wrote: > Hello, >this series enables HDMI display on V3M Eagle board. > > The series is based on Geert's "renesas-drivers-2018-04-03-v4.16" with > THC63LVD1024 driver on top (cfr. my in review series: > "[PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge") > > This series includes some preliminary work from Sergei and Niklas. I have > reworked the two final patches from Niklas to enable DU first, add the LVDS > decoder node, and finally add the ADV7511W chip and enable HDMI output. > > A branch for testing is available at: > git://jmondi.org/linux v3m/renesas-drivers-2018-04-03-v4.16/v7-eagle-dts > > Thanks >j > > Jacopo Mondi (2): > arm64: dts: renesas: eagle: Enable DU > arm64: dts: renesas: eagle: Add LVDS decoder > > Niklas Söderlund (2): > arm64: dts: renesas: r8a77970: add the LVDS instance > arm64: dts: renesas: eagle: Add ADV7511W and HDMI output > > Sergei Shtylyov (3): > arm64: dts: renesas: r8a77970: add FCPVD support > arm64: dts: renesas: r8a77970: add VSPD support > arm64: dts: renesas: r8a77970: add DU support > > arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 89 > ++ > arch/arm64/boot/dts/renesas/r8a77970.dtsi | 73 + > 2 files changed, 162 insertions(+) > > -- > 2.7.4 > signature.asc Description: PGP signature
[PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge
Hello, this series enables HDMI display on V3M Eagle board. The series is based on Geert's "renesas-drivers-2018-04-03-v4.16" with THC63LVD1024 driver on top (cfr. my in review series: "[PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge") This series includes some preliminary work from Sergei and Niklas. I have reworked the two final patches from Niklas to enable DU first, add the LVDS decoder node, and finally add the ADV7511W chip and enable HDMI output. A branch for testing is available at: git://jmondi.org/linux v3m/renesas-drivers-2018-04-03-v4.16/v7-eagle-dts Thanks j Jacopo Mondi (2): arm64: dts: renesas: eagle: Enable DU arm64: dts: renesas: eagle: Add LVDS decoder Niklas Söderlund (2): arm64: dts: renesas: r8a77970: add the LVDS instance arm64: dts: renesas: eagle: Add ADV7511W and HDMI output Sergei Shtylyov (3): arm64: dts: renesas: r8a77970: add FCPVD support arm64: dts: renesas: r8a77970: add VSPD support arm64: dts: renesas: r8a77970: add DU support arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 89 ++ arch/arm64/boot/dts/renesas/r8a77970.dtsi | 73 + 2 files changed, 162 insertions(+) -- 2.7.4
[PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge
Hello, this series enables HDMI display on V3M Eagle board. The series is based on Geert's "renesas-drivers-2018-04-03-v4.16" with THC63LVD1024 driver on top (cfr. my in review series: "[PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge") This series includes some preliminary work from Sergei and Niklas. I have reworked the two final patches from Niklas to enable DU first, add the LVDS decoder node, and finally add the ADV7511W chip and enable HDMI output. A branch for testing is available at: git://jmondi.org/linux v3m/renesas-drivers-2018-04-03-v4.16/v7-eagle-dts Thanks j Jacopo Mondi (2): arm64: dts: renesas: eagle: Enable DU arm64: dts: renesas: eagle: Add LVDS decoder Niklas Söderlund (2): arm64: dts: renesas: r8a77970: add the LVDS instance arm64: dts: renesas: eagle: Add ADV7511W and HDMI output Sergei Shtylyov (3): arm64: dts: renesas: r8a77970: add FCPVD support arm64: dts: renesas: r8a77970: add VSPD support arm64: dts: renesas: r8a77970: add DU support arch/arm64/boot/dts/renesas/r8a77970-eagle.dts | 89 ++ arch/arm64/boot/dts/renesas/r8a77970.dtsi | 73 + 2 files changed, 162 insertions(+) -- 2.7.4
[PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge
Hello, this new version moves the driver and its bindings to use semi-standard names for powerdown and output enable GPIOs, as result of the discussion with Laurent, Vladimir and Rob. I kept the actual pin names in the bindings description for reference, even if there are no huge ambiguities on which chip pin is actually an enable and which one a power down. I have reworked the regulator management, making the 'vcc' supply the only requested one, and all other optional supplies have been removed as suggested by Laurent. It is unlikely a dedicated regulator is to be installed for each power supply, and in case some HW design requires this, it's an easy add to be implemented in future. Contrary to what discussed on v6, the 'vcc' supply is still described as optional in dt bindings, and the driver is now using 'regulator_get(NORMAL_GET)' in place of the _optional() version that was used before. With the 'NORMAL_GET' version the regulator core provides a dummy regulator in case an actual one is not available. This simplifies integration in designs where the chip power supplies are directly connected to some power rail. At the same time it makes easier to forget to add a regulator if there's actually one there, and someone could find herself wondering why the chip does not work even if probe completes properly. I removed the Eagle display enablement patch from the series, I'll send it separately squashed on top of Niklas' series that addresses the issue. Thanks j v6 -> v7: - Use semi-standard names for powerdown and output enable GPIOs as suggested by Rob and Vladimir - Use 'regulator_get()' not the optional version, and list only 'vcc' as requested supply - Addressed Laurent's review comments and removed Eagle display enablement patch to be sent separately v5 -> v6: - Drop check for CONFIG_OF as it is a Kconfig dependency - Add Niklas Reviewed-by tags - List [3/3] depenencies below commit message to ease integration v4 -> v5: - Fix punctuation in bindings documentation - Add small statement to bindings document to clarify the chip has no control bus - Print regulator name in enable/disable routines error path - Add Andrzej Reviewed-by tag v3 -> v4: - Rename permutations of "pdwn" to just "pdwn" everywhere in the series - Improve power enable/disable routines as suggested by Andrzej and Sergei - Change "pdwn" gpio initialization to use the logical output level - Change Kconfig description v2 -> v3: - Drop support for "lvds-decoder" and make the driver THC63LVD1024 specific -- Rework bindings to describe multiple input/output ports -- Rename driver and remove "lvds-decoder" references -- Rework Eagle DTS to use new bindings v1 -> v2: - Drop support for THC63LVD1024 Jacopo Mondi (2): dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder drm: bridge: Add thc63lvd1024 LVDS decoder driver .../bindings/display/bridge/thine,thc63lvd1024.txt | 60 ++ drivers/gpu/drm/bridge/Kconfig | 6 + drivers/gpu/drm/bridge/Makefile| 1 + drivers/gpu/drm/bridge/thc63lvd1024.c | 212 + 4 files changed, 279 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt create mode 100644 drivers/gpu/drm/bridge/thc63lvd1024.c -- 2.7.4
[PATCH v7 0/2] drm: Add Thine THC63LVD1024 LVDS decoder bridge
Hello, this new version moves the driver and its bindings to use semi-standard names for powerdown and output enable GPIOs, as result of the discussion with Laurent, Vladimir and Rob. I kept the actual pin names in the bindings description for reference, even if there are no huge ambiguities on which chip pin is actually an enable and which one a power down. I have reworked the regulator management, making the 'vcc' supply the only requested one, and all other optional supplies have been removed as suggested by Laurent. It is unlikely a dedicated regulator is to be installed for each power supply, and in case some HW design requires this, it's an easy add to be implemented in future. Contrary to what discussed on v6, the 'vcc' supply is still described as optional in dt bindings, and the driver is now using 'regulator_get(NORMAL_GET)' in place of the _optional() version that was used before. With the 'NORMAL_GET' version the regulator core provides a dummy regulator in case an actual one is not available. This simplifies integration in designs where the chip power supplies are directly connected to some power rail. At the same time it makes easier to forget to add a regulator if there's actually one there, and someone could find herself wondering why the chip does not work even if probe completes properly. I removed the Eagle display enablement patch from the series, I'll send it separately squashed on top of Niklas' series that addresses the issue. Thanks j v6 -> v7: - Use semi-standard names for powerdown and output enable GPIOs as suggested by Rob and Vladimir - Use 'regulator_get()' not the optional version, and list only 'vcc' as requested supply - Addressed Laurent's review comments and removed Eagle display enablement patch to be sent separately v5 -> v6: - Drop check for CONFIG_OF as it is a Kconfig dependency - Add Niklas Reviewed-by tags - List [3/3] depenencies below commit message to ease integration v4 -> v5: - Fix punctuation in bindings documentation - Add small statement to bindings document to clarify the chip has no control bus - Print regulator name in enable/disable routines error path - Add Andrzej Reviewed-by tag v3 -> v4: - Rename permutations of "pdwn" to just "pdwn" everywhere in the series - Improve power enable/disable routines as suggested by Andrzej and Sergei - Change "pdwn" gpio initialization to use the logical output level - Change Kconfig description v2 -> v3: - Drop support for "lvds-decoder" and make the driver THC63LVD1024 specific -- Rework bindings to describe multiple input/output ports -- Rename driver and remove "lvds-decoder" references -- Rework Eagle DTS to use new bindings v1 -> v2: - Drop support for THC63LVD1024 Jacopo Mondi (2): dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder drm: bridge: Add thc63lvd1024 LVDS decoder driver .../bindings/display/bridge/thine,thc63lvd1024.txt | 60 ++ drivers/gpu/drm/bridge/Kconfig | 6 + drivers/gpu/drm/bridge/Makefile| 1 + drivers/gpu/drm/bridge/thc63lvd1024.c | 212 + 4 files changed, 279 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt create mode 100644 drivers/gpu/drm/bridge/thc63lvd1024.c -- 2.7.4
