Re: [PATCH v7 02/61] radix tree: Use bottom four bits of gfp_t for flags

2018-03-03 Thread Matthew Wilcox
On Sat, Mar 03, 2018 at 07:44:36AM -0500, Jeff Layton wrote: > > - return root->gfp_mask & __GFP_BITS_MASK; > > + return root->gfp_mask & ((__GFP_BITS_MASK >> 4) << 4); > > Maybe phrase this in terms of a constant like GFP_ZONEMASK here? Would > this be more appropriate? Yeah, that's a

Re: [PATCH v7 02/61] radix tree: Use bottom four bits of gfp_t for flags

2018-03-03 Thread Matthew Wilcox
On Sat, Mar 03, 2018 at 07:44:36AM -0500, Jeff Layton wrote: > > - return root->gfp_mask & __GFP_BITS_MASK; > > + return root->gfp_mask & ((__GFP_BITS_MASK >> 4) << 4); > > Maybe phrase this in terms of a constant like GFP_ZONEMASK here? Would > this be more appropriate? Yeah, that's a

Re: [PATCH v7 02/61] radix tree: Use bottom four bits of gfp_t for flags

2018-03-03 Thread Jeff Layton
On Mon, 2018-02-19 at 11:44 -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > None of these four bits may be used for slab allocations, so we can > use them for flags as long as we mask them off before passing them > to the slab allocator. Move the IDR flag from

Re: [PATCH v7 02/61] radix tree: Use bottom four bits of gfp_t for flags

2018-03-03 Thread Jeff Layton
On Mon, 2018-02-19 at 11:44 -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > None of these four bits may be used for slab allocations, so we can > use them for flags as long as we mask them off before passing them > to the slab allocator. Move the IDR flag from the top bits to the >

[PATCH v7 02/61] radix tree: Use bottom four bits of gfp_t for flags

2018-02-19 Thread Matthew Wilcox
From: Matthew Wilcox None of these four bits may be used for slab allocations, so we can use them for flags as long as we mask them off before passing them to the slab allocator. Move the IDR flag from the top bits to the bottom bits. Signed-off-by: Matthew Wilcox

[PATCH v7 02/61] radix tree: Use bottom four bits of gfp_t for flags

2018-02-19 Thread Matthew Wilcox
From: Matthew Wilcox None of these four bits may be used for slab allocations, so we can use them for flags as long as we mask them off before passing them to the slab allocator. Move the IDR flag from the top bits to the bottom bits. Signed-off-by: Matthew Wilcox --- include/linux/idr.h