Re: [PATCH v7 2/3] ARM: dts: add TOPEET itop elite based board

[Krzysztof Kozlowski]

On Sun, Sep 18, 2016 at 10:01:18PM +0800, Randy Li wrote:
> The TOPEET itop exynos 4412 have three versions base board. The
> Elite version is the cheap one without too much peripheral devices
> on it.
> 
> Currently supported are serial console, wired networking(USB),
> USB OTG in peripheral mode, USB host, SD storage, GPIO buttons,
> PWM beeper, ADC and LEDs. The WM8960 analog audio codec is also
> enabled.
> 
> The FIMC is not used for camera currently, I enabled it just for a
> colorspace convertor.
> 
> Signed-off-by: Randy Li 
> ---
>  .../bindings/arm/samsung/samsung-boards.txt|   3 +
>  arch/arm/boot/dts/Makefile |   1 +
>  arch/arm/boot/dts/exynos4412-itop-elite.dts| 240 
> +
>  3 files changed, 244 insertions(+)
>  create mode 100644 arch/arm/boot/dts/exynos4412-itop-elite.dts

Looks good to me, for the record:

Reviewed-by: Krzysztof Kozlowski 

You don't need to resend the third patch. Rob took it.

Best regards,
Krzysztof

Re: [PATCH v7 2/3] ARM: dts: add TOPEET itop elite based board

[Krzysztof Kozlowski]

On Sun, Sep 18, 2016 at 10:01:18PM +0800, Randy Li wrote:
> The TOPEET itop exynos 4412 have three versions base board. The
> Elite version is the cheap one without too much peripheral devices
> on it.
> 
> Currently supported are serial console, wired networking(USB),
> USB OTG in peripheral mode, USB host, SD storage, GPIO buttons,
> PWM beeper, ADC and LEDs. The WM8960 analog audio codec is also
> enabled.
> 
> The FIMC is not used for camera currently, I enabled it just for a
> colorspace convertor.
> 
> Signed-off-by: Randy Li 
> ---
>  .../bindings/arm/samsung/samsung-boards.txt|   3 +
>  arch/arm/boot/dts/Makefile |   1 +
>  arch/arm/boot/dts/exynos4412-itop-elite.dts| 240 
> +
>  3 files changed, 244 insertions(+)
>  create mode 100644 arch/arm/boot/dts/exynos4412-itop-elite.dts

Looks good to me, for the record:

Reviewed-by: Krzysztof Kozlowski 

You don't need to resend the third patch. Rob took it.

Best regards,
Krzysztof

[PATCH v7 2/3] ARM: dts: add TOPEET itop elite based board

[Randy Li]

The TOPEET itop exynos 4412 have three versions base board. The
Elite version is the cheap one without too much peripheral devices
on it.

Currently supported are serial console, wired networking(USB),
USB OTG in peripheral mode, USB host, SD storage, GPIO buttons,
PWM beeper, ADC and LEDs. The WM8960 analog audio codec is also
enabled.

The FIMC is not used for camera currently, I enabled it just for a
colorspace convertor.

Signed-off-by: Randy Li 
---
 .../bindings/arm/samsung/samsung-boards.txt|   3 +
 arch/arm/boot/dts/Makefile |   1 +
 arch/arm/boot/dts/exynos4412-itop-elite.dts| 240 +
 3 files changed, 244 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos4412-itop-elite.dts

diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt 
b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
index 0ea7f14..5160fa5 100644
--- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
+++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
@@ -22,6 +22,9 @@ Required root node properties:
   * FriendlyARM
- "friendlyarm,tiny4412"  - for Exynos4412-based FriendlyARM
TINY4412 board.
+  * TOPEET
+   - "topeet,itop4412-elite" - for Exynos4412-based TOPEET
+Elite base board.
 
   * Google
- "google,pi"   - for Exynos5800-based Google Peach Pi
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index befcd26..d709f74 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -136,6 +136,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
exynos4210-smdkv310.dtb \
exynos4210-trats.dtb \
exynos4210-universal_c210.dtb \
+   exynos4412-itop-elite.dtb \
exynos4412-odroidu3.dtb \
exynos4412-odroidx.dtb \
exynos4412-odroidx2.dtb \
diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts 
b/arch/arm/boot/dts/exynos4412-itop-elite.dts
new file mode 100644
index 000..b08705e
--- /dev/null
+++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
@@ -0,0 +1,240 @@
+/*
+ * TOPEET's Exynos4412 based itop board device tree source
+ *
+ * Copyright (c) 2016 SUMOMO Computer Association
+ * https://www.sumomo.mobi
+ * Randy Li 
+ *
+ * Device tree source file for TOPEET iTop Exynos 4412 core board
+ * which is based on Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+#include 
+#include 
+#include "exynos4412-itop-scp-core.dtsi"
+
+/ {
+   model = "TOPEET iTop 4412 Elite board based on Exynos4412";
+   compatible = "topeet,itop4412-elite", "samsung,exynos4412", 
"samsung,exynos4";
+
+   chosen {
+   bootargs = "root=/dev/mmcblk0p2 rw rootfstype=ext4 rootdelay=1 
rootwait";
+   stdout-path = "serial2:115200n8";
+   };
+
+   leds {
+   compatible = "gpio-leds";
+
+   led2 {
+   label = "red:system";
+   gpios = < 0 GPIO_ACTIVE_HIGH>;
+   default-state = "off";
+   linux,default-trigger = "heartbeat";
+   };
+
+   led3 {
+   label = "red:user";
+   gpios = < 1 GPIO_ACTIVE_HIGH>;
+   default-state = "off";
+   };
+   };
+
+   gpio-keys {
+   compatible = "gpio-keys";
+
+   home {
+   label = "GPIO Key Home";
+   linux,code = ;
+   gpios = < 1 GPIO_ACTIVE_LOW>;
+   };
+
+   back {
+   label = "GPIO Key Back";
+   linux,code = ;
+   gpios = < 2 GPIO_ACTIVE_LOW>;
+   };
+
+   sleep {
+   label = "GPIO Key Sleep";
+   linux,code = ;
+   gpios = < 3 GPIO_ACTIVE_LOW>;
+   };
+
+   vol-up {
+   label = "GPIO Key Vol+";
+   linux,code = ;
+   gpios = < 1 GPIO_ACTIVE_LOW>;
+   };
+
+   vol-down {
+   label = "GPIO Key Vol-";
+   linux,code = ;
+   gpios = < 0 GPIO_ACTIVE_LOW>;
+   };
+   };
+
+   sound {
+   compatible = "simple-audio-card";
+   simple-audio-card,name = "wm-sound";
+
+   assigned-clocks = <_audss EXYNOS_MOUT_AUDSS>,
+   <_audss EXYNOS_MOUT_I2S>,
+   <_audss EXYNOS_DOUT_SRP>,
+   

[PATCH v7 2/3] ARM: dts: add TOPEET itop elite based board

[Randy Li]

The TOPEET itop exynos 4412 have three versions base board. The
Elite version is the cheap one without too much peripheral devices
on it.

Currently supported are serial console, wired networking(USB),
USB OTG in peripheral mode, USB host, SD storage, GPIO buttons,
PWM beeper, ADC and LEDs. The WM8960 analog audio codec is also
enabled.

The FIMC is not used for camera currently, I enabled it just for a
colorspace convertor.

Signed-off-by: Randy Li 
---
 .../bindings/arm/samsung/samsung-boards.txt|   3 +
 arch/arm/boot/dts/Makefile |   1 +
 arch/arm/boot/dts/exynos4412-itop-elite.dts| 240 +
 3 files changed, 244 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos4412-itop-elite.dts

diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt 
b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
index 0ea7f14..5160fa5 100644
--- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
+++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
@@ -22,6 +22,9 @@ Required root node properties:
   * FriendlyARM
- "friendlyarm,tiny4412"  - for Exynos4412-based FriendlyARM
TINY4412 board.
+  * TOPEET
+   - "topeet,itop4412-elite" - for Exynos4412-based TOPEET
+Elite base board.
 
   * Google
- "google,pi"   - for Exynos5800-based Google Peach Pi
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index befcd26..d709f74 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -136,6 +136,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
exynos4210-smdkv310.dtb \
exynos4210-trats.dtb \
exynos4210-universal_c210.dtb \
+   exynos4412-itop-elite.dtb \
exynos4412-odroidu3.dtb \
exynos4412-odroidx.dtb \
exynos4412-odroidx2.dtb \
diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts 
b/arch/arm/boot/dts/exynos4412-itop-elite.dts
new file mode 100644
index 000..b08705e
--- /dev/null
+++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
@@ -0,0 +1,240 @@
+/*
+ * TOPEET's Exynos4412 based itop board device tree source
+ *
+ * Copyright (c) 2016 SUMOMO Computer Association
+ * https://www.sumomo.mobi
+ * Randy Li 
+ *
+ * Device tree source file for TOPEET iTop Exynos 4412 core board
+ * which is based on Samsung's Exynos4412 SoC.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+#include 
+#include 
+#include "exynos4412-itop-scp-core.dtsi"
+
+/ {
+   model = "TOPEET iTop 4412 Elite board based on Exynos4412";
+   compatible = "topeet,itop4412-elite", "samsung,exynos4412", 
"samsung,exynos4";
+
+   chosen {
+   bootargs = "root=/dev/mmcblk0p2 rw rootfstype=ext4 rootdelay=1 
rootwait";
+   stdout-path = "serial2:115200n8";
+   };
+
+   leds {
+   compatible = "gpio-leds";
+
+   led2 {
+   label = "red:system";
+   gpios = < 0 GPIO_ACTIVE_HIGH>;
+   default-state = "off";
+   linux,default-trigger = "heartbeat";
+   };
+
+   led3 {
+   label = "red:user";
+   gpios = < 1 GPIO_ACTIVE_HIGH>;
+   default-state = "off";
+   };
+   };
+
+   gpio-keys {
+   compatible = "gpio-keys";
+
+   home {
+   label = "GPIO Key Home";
+   linux,code = ;
+   gpios = < 1 GPIO_ACTIVE_LOW>;
+   };
+
+   back {
+   label = "GPIO Key Back";
+   linux,code = ;
+   gpios = < 2 GPIO_ACTIVE_LOW>;
+   };
+
+   sleep {
+   label = "GPIO Key Sleep";
+   linux,code = ;
+   gpios = < 3 GPIO_ACTIVE_LOW>;
+   };
+
+   vol-up {
+   label = "GPIO Key Vol+";
+   linux,code = ;
+   gpios = < 1 GPIO_ACTIVE_LOW>;
+   };
+
+   vol-down {
+   label = "GPIO Key Vol-";
+   linux,code = ;
+   gpios = < 0 GPIO_ACTIVE_LOW>;
+   };
+   };
+
+   sound {
+   compatible = "simple-audio-card";
+   simple-audio-card,name = "wm-sound";
+
+   assigned-clocks = <_audss EXYNOS_MOUT_AUDSS>,
+   <_audss EXYNOS_MOUT_I2S>,
+   <_audss EXYNOS_DOUT_SRP>,
+   <_audss EXYNOS_DOUT_AUD_BUS>;
+