Re: [PATCH v7 2/5] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

Thanks for your comments, Russell On 4/6/2018 5:09 PM, Russell King - ARM Linux Wrote: On Thu, Apr 05, 2018 at 05:50:54AM -0700, Matthew Wilcox wrote: On Thu, Apr 05, 2018 at 08:44:12PM +0800, Jia He wrote: On 4/5/2018 7:34 PM, Matthew Wilcox Wrote: On Thu, Apr 05, 2018 at 01:04:35AM

Re: [PATCH v7 2/5] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

Thanks for your comments, Russell On 4/6/2018 5:09 PM, Russell King - ARM Linux Wrote: On Thu, Apr 05, 2018 at 05:50:54AM -0700, Matthew Wilcox wrote: On Thu, Apr 05, 2018 at 08:44:12PM +0800, Jia He wrote: On 4/5/2018 7:34 PM, Matthew Wilcox Wrote: On Thu, Apr 05, 2018 at 01:04:35AM

Re: [PATCH v7 2/5] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

On Fri, Apr 6, 2018 at 11:09 AM, Russell King - ARM Linux wrote: > On Thu, Apr 05, 2018 at 05:50:54AM -0700, Matthew Wilcox wrote: >> On Thu, Apr 05, 2018 at 08:44:12PM +0800, Jia He wrote: >> > >> > >> > On 4/5/2018 7:34 PM, Matthew Wilcox Wrote: >> > > On Thu, Apr 05,

Re: [PATCH v7 2/5] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

On Fri, Apr 6, 2018 at 11:09 AM, Russell King - ARM Linux wrote: > On Thu, Apr 05, 2018 at 05:50:54AM -0700, Matthew Wilcox wrote: >> On Thu, Apr 05, 2018 at 08:44:12PM +0800, Jia He wrote: >> > >> > >> > On 4/5/2018 7:34 PM, Matthew Wilcox Wrote: >> > > On Thu, Apr 05, 2018 at 01:04:35AM -0700,

Re: [PATCH v7 2/5] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

On Thu, Apr 05, 2018 at 05:50:54AM -0700, Matthew Wilcox wrote: > On Thu, Apr 05, 2018 at 08:44:12PM +0800, Jia He wrote: > > > > > > On 4/5/2018 7:34 PM, Matthew Wilcox Wrote: > > > On Thu, Apr 05, 2018 at 01:04:35AM -0700, Jia He wrote: > > > > Commit b92df1de5d28 ("mm: page_alloc: skip over

Re: [PATCH v7 2/5] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

On Thu, Apr 05, 2018 at 05:50:54AM -0700, Matthew Wilcox wrote: > On Thu, Apr 05, 2018 at 08:44:12PM +0800, Jia He wrote: > > > > > > On 4/5/2018 7:34 PM, Matthew Wilcox Wrote: > > > On Thu, Apr 05, 2018 at 01:04:35AM -0700, Jia He wrote: > > > > Commit b92df1de5d28 ("mm: page_alloc: skip over

Re: [PATCH v7 2/5] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

On Thu, Apr 05, 2018 at 08:44:12PM +0800, Jia He wrote: > > > On 4/5/2018 7:34 PM, Matthew Wilcox Wrote: > > On Thu, Apr 05, 2018 at 01:04:35AM -0700, Jia He wrote: > > > Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns > > > where possible") optimized the loop in

Re: [PATCH v7 2/5] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

On Thu, Apr 05, 2018 at 08:44:12PM +0800, Jia He wrote: > > > On 4/5/2018 7:34 PM, Matthew Wilcox Wrote: > > On Thu, Apr 05, 2018 at 01:04:35AM -0700, Jia He wrote: > > > Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns > > > where possible") optimized the loop in

Re: [PATCH v7 2/5] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

On 4/5/2018 7:34 PM, Matthew Wilcox Wrote: On Thu, Apr 05, 2018 at 01:04:35AM -0700, Jia He wrote: Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns where possible") optimized the loop in memmap_init_zone(). But there is still some room for improvement. E.g. if pfn and

Re: [PATCH v7 2/5] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

On 4/5/2018 7:34 PM, Matthew Wilcox Wrote: On Thu, Apr 05, 2018 at 01:04:35AM -0700, Jia He wrote: Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns where possible") optimized the loop in memmap_init_zone(). But there is still some room for improvement. E.g. if pfn and

Re: [PATCH v7 2/5] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

On Thu, Apr 05, 2018 at 01:04:35AM -0700, Jia He wrote: > Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns > where possible") optimized the loop in memmap_init_zone(). But there is > still some room for improvement. E.g. if pfn and pfn+1 are in the same > memblock region, we

Re: [PATCH v7 2/5] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

On Thu, Apr 05, 2018 at 01:04:35AM -0700, Jia He wrote: > Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns > where possible") optimized the loop in memmap_init_zone(). But there is > still some room for improvement. E.g. if pfn and pfn+1 are in the same > memblock region, we

[PATCH v7 2/5] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns where possible") optimized the loop in memmap_init_zone(). But there is still some room for improvement. E.g. if pfn and pfn+1 are in the same memblock region, we can simply pfn++ instead of doing the binary search in

[PATCH v7 2/5] arm: arm64: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn()

Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns where possible") optimized the loop in memmap_init_zone(). But there is still some room for improvement. E.g. if pfn and pfn+1 are in the same memblock region, we can simply pfn++ instead of doing the binary search in