Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr
On Tue, 13 Mar 2018 10:58:16 +0100 Greg Kroah-Hartmanwrote: > On Tue, Mar 13, 2018 at 01:00:51PM +0530, Ajay Singh wrote: > > > > Reviewed-by: Ajay Singh > > > > On Mon, 12 Mar 2018 15:09:03 +0530 > > wrote: > > > > > From: HariPrasath Elango > > > > > > > Please avoid use of 'From' tag specially when there is only one > > 'Signed-off-by' tag and its same. > > But the email client isn't putting the correct info in the email header, > so this line is needed. > > And if it's redundant, not a problem, git handles it just fine, better > to be safe. Thanks Greg, for giving the information. In that case, we can keep the 'From:' tag to be on safe side. Regards, Ajay
Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr
On Tue, 13 Mar 2018 10:58:16 +0100 Greg Kroah-Hartman wrote: > On Tue, Mar 13, 2018 at 01:00:51PM +0530, Ajay Singh wrote: > > > > Reviewed-by: Ajay Singh > > > > On Mon, 12 Mar 2018 15:09:03 +0530 > > wrote: > > > > > From: HariPrasath Elango > > > > > > > Please avoid use of 'From' tag specially when there is only one > > 'Signed-off-by' tag and its same. > > But the email client isn't putting the correct info in the email header, > so this line is needed. > > And if it's redundant, not a problem, git handles it just fine, better > to be safe. Thanks Greg, for giving the information. In that case, we can keep the 'From:' tag to be on safe side. Regards, Ajay
Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr
On Tue, Mar 13, 2018 at 01:00:51PM +0530, Ajay Singh wrote: > > Reviewed-by: Ajay Singh> > On Mon, 12 Mar 2018 15:09:03 +0530 > wrote: > > > From: HariPrasath Elango > > > > Please avoid use of 'From' tag specially when there is only one > 'Signed-off-by' tag and its same. But the email client isn't putting the correct info in the email header, so this line is needed. And if it's redundant, not a problem, git handles it just fine, better to be safe. thanks, greg k-h
Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr
On Tue, Mar 13, 2018 at 01:00:51PM +0530, Ajay Singh wrote: > > Reviewed-by: Ajay Singh > > On Mon, 12 Mar 2018 15:09:03 +0530 > wrote: > > > From: HariPrasath Elango > > > > Please avoid use of 'From' tag specially when there is only one > 'Signed-off-by' tag and its same. But the email client isn't putting the correct info in the email header, so this line is needed. And if it's redundant, not a problem, git handles it just fine, better to be safe. thanks, greg k-h
Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr
Reviewed-by: Ajay SinghOn Mon, 12 Mar 2018 15:09:03 +0530 wrote: > From: HariPrasath Elango > Please avoid use of 'From' tag specially when there is only one 'Signed-off-by' tag and its same. > Use the kernel pre-defined macro is_broadcast_ether_addr() instead of > doing a memcmp here. > > Signed-off-by: HariPrasath Elango > --- Regards, Ajay
Re: [PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr
Reviewed-by: Ajay Singh On Mon, 12 Mar 2018 15:09:03 +0530 wrote: > From: HariPrasath Elango > Please avoid use of 'From' tag specially when there is only one 'Signed-off-by' tag and its same. > Use the kernel pre-defined macro is_broadcast_ether_addr() instead of > doing a memcmp here. > > Signed-off-by: HariPrasath Elango > --- Regards, Ajay
[PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr
From: HariPrasath ElangoUse the kernel pre-defined macro is_broadcast_ether_addr() instead of doing a memcmp here. Signed-off-by: HariPrasath Elango --- drivers/staging/wilc1000/linux_mon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c index bbdfc7a..f93f411 100644 --- a/drivers/staging/wilc1000/linux_mon.c +++ b/drivers/staging/wilc1000/linux_mon.c @@ -27,7 +27,6 @@ static struct net_device *wilc_wfi_mon; /* global monitor netdev */ static u8 srcadd[6]; static u8 bssid[6]; -static u8 broadcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; /** * @brief WILC_WFI_monitor_rx * @details @@ -193,7 +192,7 @@ static netdev_tx_t WILC_WFI_mon_xmit(struct sk_buff *skb, skb_pull(skb, rtap_len); - if (skb->data[0] == 0xc0 && (!(memcmp(broadcast, >data[4], 6 { + if (skb->data[0] == 0xc0 && is_broadcast_ether_addr(>data[4])) { skb2 = dev_alloc_skb(skb->len + sizeof(struct wilc_wfi_radiotap_cb_hdr)); if (!skb2) return -ENOMEM; -- 2.10.0.GIT
[PATCHv2] staging: wilc1000: use pre-defined macro is_broadcast_ether_addr
From: HariPrasath Elango Use the kernel pre-defined macro is_broadcast_ether_addr() instead of doing a memcmp here. Signed-off-by: HariPrasath Elango --- drivers/staging/wilc1000/linux_mon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c index bbdfc7a..f93f411 100644 --- a/drivers/staging/wilc1000/linux_mon.c +++ b/drivers/staging/wilc1000/linux_mon.c @@ -27,7 +27,6 @@ static struct net_device *wilc_wfi_mon; /* global monitor netdev */ static u8 srcadd[6]; static u8 bssid[6]; -static u8 broadcast[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; /** * @brief WILC_WFI_monitor_rx * @details @@ -193,7 +192,7 @@ static netdev_tx_t WILC_WFI_mon_xmit(struct sk_buff *skb, skb_pull(skb, rtap_len); - if (skb->data[0] == 0xc0 && (!(memcmp(broadcast, >data[4], 6 { + if (skb->data[0] == 0xc0 && is_broadcast_ether_addr(>data[4])) { skb2 = dev_alloc_skb(skb->len + sizeof(struct wilc_wfi_radiotap_cb_hdr)); if (!skb2) return -ENOMEM; -- 2.10.0.GIT