Re: [PATCHv2 1/4] arm64: dump: Make ptdump debugfs a separate option

2016-10-17 Thread Laura Abbott
On 10/17/2016 03:52 AM, Mark Rutland wrote: Hi Laura, In looking at this, I realised I was confused about ptdump_initialize() previously, and now see why we can't decouple the debugfs registration of the kernel page tables from the rest of the ptdump init. Sorry for the noise on that. Aside

Re: [PATCHv2 1/4] arm64: dump: Make ptdump debugfs a separate option

2016-10-17 Thread Laura Abbott
On 10/17/2016 03:52 AM, Mark Rutland wrote: Hi Laura, In looking at this, I realised I was confused about ptdump_initialize() previously, and now see why we can't decouple the debugfs registration of the kernel page tables from the rest of the ptdump init. Sorry for the noise on that. Aside

Re: [PATCHv2 1/4] arm64: dump: Make ptdump debugfs a separate option

2016-10-17 Thread Mark Rutland
Hi Laura, In looking at this, I realised I was confused about ptdump_initialize() previously, and now see why we can't decouple the debugfs registration of the kernel page tables from the rest of the ptdump init. Sorry for the noise on that. Aside from one issue below, this looks good to me. On

Re: [PATCHv2 1/4] arm64: dump: Make ptdump debugfs a separate option

2016-10-17 Thread Mark Rutland
Hi Laura, In looking at this, I realised I was confused about ptdump_initialize() previously, and now see why we can't decouple the debugfs registration of the kernel page tables from the rest of the ptdump init. Sorry for the noise on that. Aside from one issue below, this looks good to me. On

Re: [PATCHv2 1/4] arm64: dump: Make ptdump debugfs a separate option

2016-10-12 Thread Laura Abbott
On 10/12/2016 03:45 PM, Kees Cook wrote: On Wed, Oct 12, 2016 at 3:31 PM, Laura Abbott wrote: ptdump_register currently initializes a set of page table information and registers debugfs. There are uses for the ptdump option without wanting the debugfs options. Split this

Re: [PATCHv2 1/4] arm64: dump: Make ptdump debugfs a separate option

2016-10-12 Thread Laura Abbott
On 10/12/2016 03:45 PM, Kees Cook wrote: On Wed, Oct 12, 2016 at 3:31 PM, Laura Abbott wrote: ptdump_register currently initializes a set of page table information and registers debugfs. There are uses for the ptdump option without wanting the debugfs options. Split this out to make it a

Re: [PATCHv2 1/4] arm64: dump: Make ptdump debugfs a separate option

2016-10-12 Thread Kees Cook
On Wed, Oct 12, 2016 at 3:57 PM, Laura Abbott wrote: > On 10/12/2016 03:45 PM, Kees Cook wrote: >> >> On Wed, Oct 12, 2016 at 3:31 PM, Laura Abbott wrote: >>> >>> >>> ptdump_register currently initializes a set of page table information and >>> registers

Re: [PATCHv2 1/4] arm64: dump: Make ptdump debugfs a separate option

2016-10-12 Thread Kees Cook
On Wed, Oct 12, 2016 at 3:57 PM, Laura Abbott wrote: > On 10/12/2016 03:45 PM, Kees Cook wrote: >> >> On Wed, Oct 12, 2016 at 3:31 PM, Laura Abbott wrote: >>> >>> >>> ptdump_register currently initializes a set of page table information and >>> registers debugfs. There are uses for the ptdump

Re: [PATCHv2 1/4] arm64: dump: Make ptdump debugfs a separate option

2016-10-12 Thread Kees Cook
On Wed, Oct 12, 2016 at 3:31 PM, Laura Abbott wrote: > > ptdump_register currently initializes a set of page table information and > registers debugfs. There are uses for the ptdump option without wanting the > debugfs options. Split this out to make it a separate option. > >

Re: [PATCHv2 1/4] arm64: dump: Make ptdump debugfs a separate option

2016-10-12 Thread Kees Cook
On Wed, Oct 12, 2016 at 3:31 PM, Laura Abbott wrote: > > ptdump_register currently initializes a set of page table information and > registers debugfs. There are uses for the ptdump option without wanting the > debugfs options. Split this out to make it a separate option. > > Signed-off-by: Laura

[PATCHv2 1/4] arm64: dump: Make ptdump debugfs a separate option

2016-10-12 Thread Laura Abbott
ptdump_register currently initializes a set of page table information and registers debugfs. There are uses for the ptdump option without wanting the debugfs options. Split this out to make it a separate option. Signed-off-by: Laura Abbott --- v2: Minor style fixups per Mark

[PATCHv2 1/4] arm64: dump: Make ptdump debugfs a separate option

2016-10-12 Thread Laura Abbott
ptdump_register currently initializes a set of page table information and registers debugfs. There are uses for the ptdump option without wanting the debugfs options. Split this out to make it a separate option. Signed-off-by: Laura Abbott --- v2: Minor style fixups per Mark Rutland,