Re: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API

2017-08-08 Thread Byungchul Park
On Wed, Aug 09, 2017 at 09:39:09AM +0300, Nikolay Borisov wrote: > > > On 8.08.2017 09:00, Byungchul Park wrote: > > On Tue, Aug 08, 2017 at 01:28:39PM +0800, Coly Li wrote: > > + llist_for_each_entry_safe(cl, t, reverse, list) { > > Just wondering why not using llist_for_eac

Re: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API

2017-08-08 Thread Nikolay Borisov
On 8.08.2017 09:00, Byungchul Park wrote: > On Tue, Aug 08, 2017 at 01:28:39PM +0800, Coly Li wrote: > + llist_for_each_entry_safe(cl, t, reverse, list) { Just wondering why not using llist_for_each_entry(), or you use the _safe version on purpose ? >>> >>> If I use llist_for_

Re: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API

2017-08-07 Thread Coly Li
On 2017/8/8 下午2:00, Byungchul Park wrote: > On Tue, Aug 08, 2017 at 01:28:39PM +0800, Coly Li wrote: > + llist_for_each_entry_safe(cl, t, reverse, list) { Just wondering why not using llist_for_each_entry(), or you use the _safe version on purpose ? >>> >>> If I use llist_for_eac

Re: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API

2017-08-07 Thread Byungchul Park
On Tue, Aug 08, 2017 at 01:28:39PM +0800, Coly Li wrote: > >>> + llist_for_each_entry_safe(cl, t, reverse, list) { > >> > >> Just wondering why not using llist_for_each_entry(), or you use the > >> _safe version on purpose ? > > > > If I use llist_for_each_entry(), then it would change the origina

Re: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API

2017-08-07 Thread Coly Li
On 2017/8/8 下午12:12, Byungchul Park wrote: > On Mon, Aug 07, 2017 at 06:18:35PM +0800, Coly Li wrote: >> On 2017/8/7 下午4:38, Byungchul Park wrote: >>> Although llist provides proper APIs, they are not used. Make them used. >>> >>> Signed-off-by: Byungchul Park > Only have a question about why not u

Re: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API

2017-08-07 Thread Byungchul Park
On Mon, Aug 07, 2017 at 06:18:35PM +0800, Coly Li wrote: > On 2017/8/7 下午4:38, Byungchul Park wrote: > > Although llist provides proper APIs, they are not used. Make them used. > > > > Signed-off-by: Byungchul Park Only have a question about why not using llist_for_each_entry(), it's Hello, The

Re: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API

2017-08-07 Thread Coly Li
On 2017/8/7 下午4:38, Byungchul Park wrote: > Although llist provides proper APIs, they are not used. Make them used. > > Signed-off-by: Byungchul Park > --- > drivers/md/bcache/closure.c | 17 +++-- > 1 file changed, 3 insertions(+), 14 deletions(-) > > diff --git a/drivers/md/bcach

[RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API

2017-08-07 Thread Byungchul Park
Although llist provides proper APIs, they are not used. Make them used. Signed-off-by: Byungchul Park --- drivers/md/bcache/closure.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c index 864e673..18

[RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API

2017-07-09 Thread Byungchul Park
Although llist provides proper APIs, they are not used. Make them used. Signed-off-by: Byungchul Park --- drivers/md/bcache/closure.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c index 864e673..18

Re: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API

2017-06-12 Thread Byungchul Park
On Fri, Jun 02, 2017 at 11:08:48AM +0900, Byungchul Park wrote: > On Fri, May 12, 2017 at 09:35:02AM +0900, Byungchul Park wrote: > > Although llist provides proper APIs, they are not used. Make them used. > > +to ax...@kernel.dk > > I didn't know your e-mail address has been changed. > Could you

Re: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API

2017-06-01 Thread Byungchul Park
On Fri, May 12, 2017 at 09:35:02AM +0900, Byungchul Park wrote: > Although llist provides proper APIs, they are not used. Make them used. +to ax...@kernel.dk I didn't know your e-mail address has been changed. Could you give your opinion about this patch? > Signed-off-by: Byungchul Park > --- >

[RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API

2017-05-11 Thread Byungchul Park
Although llist provides proper APIs, they are not used. Make them used. Signed-off-by: Byungchul Park --- drivers/md/bcache/closure.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c index 864e673..18