Re: [RFC PATCH 3/3] sched/fair: Change @running of __update_load_avg() to @update_util

2016-06-03 Thread Juri Lelli
On 02/06/16 18:27, Dietmar Eggemann wrote: > On 02/06/16 10:25, Juri Lelli wrote: > > [...] > > >> @@ -2757,7 +2754,7 @@ __update_load_avg(u64 now, int cpu, struct sched_avg > >> *sa, > >>weight * scaled_delta_w; > >>} > >>

Re: [RFC PATCH 3/3] sched/fair: Change @running of __update_load_avg() to @update_util

2016-06-03 Thread Juri Lelli
On 02/06/16 18:27, Dietmar Eggemann wrote: > On 02/06/16 10:25, Juri Lelli wrote: > > [...] > > >> @@ -2757,7 +2754,7 @@ __update_load_avg(u64 now, int cpu, struct sched_avg > >> *sa, > >>weight * scaled_delta_w; > >>} > >>

Re: [RFC PATCH 3/3] sched/fair: Change @running of __update_load_avg() to @update_util

2016-06-02 Thread Dietmar Eggemann
On 02/06/16 10:25, Juri Lelli wrote: [...] >> @@ -2757,7 +2754,7 @@ __update_load_avg(u64 now, int cpu, struct sched_avg >> *sa, >> weight * scaled_delta_w; >> } >> } >> -if (update_util && running) >> +

Re: [RFC PATCH 3/3] sched/fair: Change @running of __update_load_avg() to @update_util

2016-06-02 Thread Dietmar Eggemann
On 02/06/16 10:25, Juri Lelli wrote: [...] >> @@ -2757,7 +2754,7 @@ __update_load_avg(u64 now, int cpu, struct sched_avg >> *sa, >> weight * scaled_delta_w; >> } >> } >> -if (update_util && running) >> +

Re: [RFC PATCH 3/3] sched/fair: Change @running of __update_load_avg() to @update_util

2016-06-02 Thread Dietmar Eggemann
On 01/06/16 21:11, Peter Zijlstra wrote: > On Wed, Jun 01, 2016 at 08:39:22PM +0100, Dietmar Eggemann wrote: >> The information whether a se/cfs_rq should get its load and >> utilization (se representing a task and root cfs_rq) or only its load >> (se representing a task group and cfs_rq owned by

Re: [RFC PATCH 3/3] sched/fair: Change @running of __update_load_avg() to @update_util

2016-06-02 Thread Dietmar Eggemann
On 01/06/16 21:11, Peter Zijlstra wrote: > On Wed, Jun 01, 2016 at 08:39:22PM +0100, Dietmar Eggemann wrote: >> The information whether a se/cfs_rq should get its load and >> utilization (se representing a task and root cfs_rq) or only its load >> (se representing a task group and cfs_rq owned by

Re: [RFC PATCH 3/3] sched/fair: Change @running of __update_load_avg() to @update_util

2016-06-02 Thread Juri Lelli
Hi, another minor comment below. :-) On 01/06/16 20:39, Dietmar Eggemann wrote: > The information whether a se/cfs_rq should get its load and > utilization (se representing a task and root cfs_rq) or only its load > (se representing a task group and cfs_rq owned by this se) updated can > be

Re: [RFC PATCH 3/3] sched/fair: Change @running of __update_load_avg() to @update_util

2016-06-02 Thread Juri Lelli
Hi, another minor comment below. :-) On 01/06/16 20:39, Dietmar Eggemann wrote: > The information whether a se/cfs_rq should get its load and > utilization (se representing a task and root cfs_rq) or only its load > (se representing a task group and cfs_rq owned by this se) updated can > be

Re: [RFC PATCH 3/3] sched/fair: Change @running of __update_load_avg() to @update_util

2016-06-01 Thread Peter Zijlstra
On Wed, Jun 01, 2016 at 08:39:22PM +0100, Dietmar Eggemann wrote: > The information whether a se/cfs_rq should get its load and > utilization (se representing a task and root cfs_rq) or only its load > (se representing a task group and cfs_rq owned by this se) updated can > be passed into

Re: [RFC PATCH 3/3] sched/fair: Change @running of __update_load_avg() to @update_util

2016-06-01 Thread Peter Zijlstra
On Wed, Jun 01, 2016 at 08:39:22PM +0100, Dietmar Eggemann wrote: > The information whether a se/cfs_rq should get its load and > utilization (se representing a task and root cfs_rq) or only its load > (se representing a task group and cfs_rq owned by this se) updated can > be passed into

[RFC PATCH 3/3] sched/fair: Change @running of __update_load_avg() to @update_util

2016-06-01 Thread Dietmar Eggemann
The information whether a se/cfs_rq should get its load and utilization (se representing a task and root cfs_rq) or only its load (se representing a task group and cfs_rq owned by this se) updated can be passed into __update_load_avg() to avoid the additional if/else condition to set update_util.

[RFC PATCH 3/3] sched/fair: Change @running of __update_load_avg() to @update_util

2016-06-01 Thread Dietmar Eggemann
The information whether a se/cfs_rq should get its load and utilization (se representing a task and root cfs_rq) or only its load (se representing a task group and cfs_rq owned by this se) updated can be passed into __update_load_avg() to avoid the additional if/else condition to set update_util.