Re: [RFC PATCH 3/6] of: iommu: Increment DT node refcount in of_iommu_set_ops()

[Robin Murphy]

On 27/01/16 05:21, Anup Patel wrote:

We are saving pointer to iommu DT node in of_iommu_set_ops()
hence we should increment DT node ref count.


Oh man, shame on whoever wrote that code! :P

Reviewed-by: Robin Murphy 


Signed-off-by: Anup Patel 
Reviewed-by: Ray Jui 
Reviewed-by: Scott Branden 
---
  drivers/iommu/of_iommu.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
index 60ba238..5fea665 100644
--- a/drivers/iommu/of_iommu.c
+++ b/drivers/iommu/of_iommu.c
@@ -110,6 +110,7 @@ void of_iommu_set_ops(struct device_node *np, struct 
iommu_ops *ops)
if (WARN_ON(!iommu))
return;

+   of_node_get(np);
INIT_LIST_HEAD(>list);
iommu->np = np;
iommu->ops = ops;

Re: [RFC PATCH 3/6] of: iommu: Increment DT node refcount in of_iommu_set_ops()

[Robin Murphy]

On 27/01/16 05:21, Anup Patel wrote:

We are saving pointer to iommu DT node in of_iommu_set_ops()
hence we should increment DT node ref count.


Oh man, shame on whoever wrote that code! :P

Reviewed-by: Robin Murphy 


Signed-off-by: Anup Patel 
Reviewed-by: Ray Jui 
Reviewed-by: Scott Branden 
---
  drivers/iommu/of_iommu.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
index 60ba238..5fea665 100644
--- a/drivers/iommu/of_iommu.c
+++ b/drivers/iommu/of_iommu.c
@@ -110,6 +110,7 @@ void of_iommu_set_ops(struct device_node *np, struct 
iommu_ops *ops)
if (WARN_ON(!iommu))
return;

+   of_node_get(np);
INIT_LIST_HEAD(>list);
iommu->np = np;
iommu->ops = ops;

[RFC PATCH 3/6] of: iommu: Increment DT node refcount in of_iommu_set_ops()

[Anup Patel]

We are saving pointer to iommu DT node in of_iommu_set_ops()
hence we should increment DT node ref count.

Signed-off-by: Anup Patel 
Reviewed-by: Ray Jui 
Reviewed-by: Scott Branden 
---
 drivers/iommu/of_iommu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
index 60ba238..5fea665 100644
--- a/drivers/iommu/of_iommu.c
+++ b/drivers/iommu/of_iommu.c
@@ -110,6 +110,7 @@ void of_iommu_set_ops(struct device_node *np, struct 
iommu_ops *ops)
if (WARN_ON(!iommu))
return;
 
+   of_node_get(np);
INIT_LIST_HEAD(>list);
iommu->np = np;
iommu->ops = ops;
-- 
1.9.1

[RFC PATCH 3/6] of: iommu: Increment DT node refcount in of_iommu_set_ops()

[Anup Patel]

We are saving pointer to iommu DT node in of_iommu_set_ops()
hence we should increment DT node ref count.

Signed-off-by: Anup Patel 
Reviewed-by: Ray Jui 
Reviewed-by: Scott Branden 
---
 drivers/iommu/of_iommu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/of_iommu.c b/drivers/iommu/of_iommu.c
index 60ba238..5fea665 100644
--- a/drivers/iommu/of_iommu.c
+++ b/drivers/iommu/of_iommu.c
@@ -110,6 +110,7 @@ void of_iommu_set_ops(struct device_node *np, struct 
iommu_ops *ops)
if (WARN_ON(!iommu))
return;
 
+   of_node_get(np);
INIT_LIST_HEAD(>list);
iommu->np = np;
iommu->ops = ops;
-- 
1.9.1