Re: [RFC PATCH 4/7] kconfig: support new special property shell

On Sun, 11 Feb 2018 12:06:35 PST (-0800), Linus Torvalds wrote: On Sun, Feb 11, 2018 at 11:53 AM, Linus Torvalds wrote: Well, it's still not a very *big* bump. With modern distros being at 7.3, and people testing pre-releases of gcc-8, something like gcc-4.5 is

Re: [RFC PATCH 4/7] kconfig: support new special property shell

On Sun, 11 Feb 2018 12:06:35 PST (-0800), Linus Torvalds wrote: On Sun, Feb 11, 2018 at 11:53 AM, Linus Torvalds wrote: Well, it's still not a very *big* bump. With modern distros being at 7.3, and people testing pre-releases of gcc-8, something like gcc-4.5 is still pretty darn ancient.

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-13 17:35 GMT+09:00 Arnd Bergmann : > On Tue, Feb 13, 2018 at 2:53 AM, Randy Dunlap wrote: >> On 02/12/2018 05:41 PM, Masahiro Yamada wrote: >>> 2018-02-13 8:48 GMT+09:00 Randy Dunlap : On 02/12/2018 07:24 AM, Kees Cook

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-13 17:35 GMT+09:00 Arnd Bergmann : > On Tue, Feb 13, 2018 at 2:53 AM, Randy Dunlap wrote: >> On 02/12/2018 05:41 PM, Masahiro Yamada wrote: >>> 2018-02-13 8:48 GMT+09:00 Randy Dunlap : On 02/12/2018 07:24 AM, Kees Cook wrote: > On Mon, Feb 12, 2018 at 6:39 AM, Masahiro Yamada

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Tue, Feb 13, 2018 at 01:10:34AM +0900, Masahiro Yamada wrote: > 2018-02-13 0:46 GMT+09:00 Kees Cook : > > On Mon, Feb 12, 2018 at 2:44 AM, Masahiro Yamada > > wrote: > >> Linus said: > >> > >>> But yes, I also reacted to your earlier " It

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Tue, Feb 13, 2018 at 01:10:34AM +0900, Masahiro Yamada wrote: > 2018-02-13 0:46 GMT+09:00 Kees Cook : > > On Mon, Feb 12, 2018 at 2:44 AM, Masahiro Yamada > > wrote: > >> Linus said: > >> > >>> But yes, I also reacted to your earlier " It can't silently rewrite it > >>> to _REGULAR because the

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Tue, Feb 13, 2018 at 2:53 AM, Randy Dunlap wrote: > On 02/12/2018 05:41 PM, Masahiro Yamada wrote: >> 2018-02-13 8:48 GMT+09:00 Randy Dunlap : >>> On 02/12/2018 07:24 AM, Kees Cook wrote: On Mon, Feb 12, 2018 at 6:39 AM, Masahiro Yamada

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Tue, Feb 13, 2018 at 2:53 AM, Randy Dunlap wrote: > On 02/12/2018 05:41 PM, Masahiro Yamada wrote: >> 2018-02-13 8:48 GMT+09:00 Randy Dunlap : >>> On 02/12/2018 07:24 AM, Kees Cook wrote: On Mon, Feb 12, 2018 at 6:39 AM, Masahiro Yamada wrote: >>> >> (And in thinking about this,

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On 02/12/2018 05:41 PM, Masahiro Yamada wrote: > 2018-02-13 8:48 GMT+09:00 Randy Dunlap : >> On 02/12/2018 07:24 AM, Kees Cook wrote: >>> On Mon, Feb 12, 2018 at 6:39 AM, Masahiro Yamada >>> wrote: >> > (And in thinking about this, does

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On 02/12/2018 05:41 PM, Masahiro Yamada wrote: > 2018-02-13 8:48 GMT+09:00 Randy Dunlap : >> On 02/12/2018 07:24 AM, Kees Cook wrote: >>> On Mon, Feb 12, 2018 at 6:39 AM, Masahiro Yamada >>> wrote: >> > (And in thinking about this, does Kconfig know the true $CC in use? > i.e. the

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-13 8:48 GMT+09:00 Randy Dunlap : > On 02/12/2018 07:24 AM, Kees Cook wrote: >> On Mon, Feb 12, 2018 at 6:39 AM, Masahiro Yamada >> wrote: > (And in thinking about this, does Kconfig know the true $CC in use? i.e. the

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-13 8:48 GMT+09:00 Randy Dunlap : > On 02/12/2018 07:24 AM, Kees Cook wrote: >> On Mon, Feb 12, 2018 at 6:39 AM, Masahiro Yamada >> wrote: > (And in thinking about this, does Kconfig know the true $CC in use? i.e. the configured cross compiler, etc?) >>> >>> I was thinking of

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On 02/12/2018 07:24 AM, Kees Cook wrote: > On Mon, Feb 12, 2018 at 6:39 AM, Masahiro Yamada > wrote: >>> (And in thinking about this, does Kconfig know the true $CC in use? >>> i.e. the configured cross compiler, etc?) >> >> I was thinking of removing

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On 02/12/2018 07:24 AM, Kees Cook wrote: > On Mon, Feb 12, 2018 at 6:39 AM, Masahiro Yamada > wrote: >>> (And in thinking about this, does Kconfig know the true $CC in use? >>> i.e. the configured cross compiler, etc?) >> >> I was thinking of removing CONFIG_CROSS_COMPILE. >> >> A user can

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 9:36 AM, David Woodhouse wrote: > On Mon, 2018-02-12 at 09:33 -0800, Kees Cook wrote: >> On Mon, Feb 12, 2018 at 9:05 AM, Peter Zijlstra wrote: >> > On Mon, Feb 12, 2018 at 08:56:31AM -0800, Kees Cook wrote: >> >> That would be

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 9:36 AM, David Woodhouse wrote: > On Mon, 2018-02-12 at 09:33 -0800, Kees Cook wrote: >> On Mon, Feb 12, 2018 at 9:05 AM, Peter Zijlstra wrote: >> > On Mon, Feb 12, 2018 at 08:56:31AM -0800, Kees Cook wrote: >> >> That would be bad: Android exclusively builds with clang.

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, 2018-02-12 at 09:33 -0800, Kees Cook wrote: > On Mon, Feb 12, 2018 at 9:05 AM, Peter Zijlstra wrote: > > On Mon, Feb 12, 2018 at 08:56:31AM -0800, Kees Cook wrote: > >> That would be bad: Android exclusively builds with clang. > > > > So implement asm-goto already,

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, 2018-02-12 at 09:33 -0800, Kees Cook wrote: > On Mon, Feb 12, 2018 at 9:05 AM, Peter Zijlstra wrote: > > On Mon, Feb 12, 2018 at 08:56:31AM -0800, Kees Cook wrote: > >> That would be bad: Android exclusively builds with clang. > > > > So implement asm-goto already, and do asm-cc-output

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 9:05 AM, Peter Zijlstra wrote: > On Mon, Feb 12, 2018 at 08:56:31AM -0800, Kees Cook wrote: >> That would be bad: Android exclusively builds with clang. > > So implement asm-goto already, and do asm-cc-output while you're at it. Yup, I've already

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 9:05 AM, Peter Zijlstra wrote: > On Mon, Feb 12, 2018 at 08:56:31AM -0800, Kees Cook wrote: >> That would be bad: Android exclusively builds with clang. > > So implement asm-goto already, and do asm-cc-output while you're at it. Yup, I've already been asking for it. I'm

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 08:56:31AM -0800, Kees Cook wrote: > That would be bad: Android exclusively builds with clang. So implement asm-goto already, and do asm-cc-output while you're at it. The whole asm-goto/jump_label stuff really does make a measureable difference in performance, and its

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 08:56:31AM -0800, Kees Cook wrote: > That would be bad: Android exclusively builds with clang. So implement asm-goto already, and do asm-cc-output while you're at it. The whole asm-goto/jump_label stuff really does make a measureable difference in performance, and its

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 04:19:22PM +, David Woodhouse wrote: > On Mon, 2018-02-12 at 09:26 +0100, Peter Zijlstra wrote: > > On Sun, Feb 11, 2018 at 10:13:44AM -0800, Linus Torvalds wrote: > > > > > That actually sounds like we could just > > >  > > >  (a) make gcc 4.5 be the minimum required

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 04:19:22PM +, David Woodhouse wrote: > On Mon, 2018-02-12 at 09:26 +0100, Peter Zijlstra wrote: > > On Sun, Feb 11, 2018 at 10:13:44AM -0800, Linus Torvalds wrote: > > > > > That actually sounds like we could just > > >  > > >  (a) make gcc 4.5 be the minimum required

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 8:19 AM, David Woodhouse wrote: > On Mon, 2018-02-12 at 09:26 +0100, Peter Zijlstra wrote: >> On Sun, Feb 11, 2018 at 10:13:44AM -0800, Linus Torvalds wrote: >> >> > That actually sounds like we could just >> > >> > (a) make gcc 4.5 be the minimum

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 8:19 AM, David Woodhouse wrote: > On Mon, 2018-02-12 at 09:26 +0100, Peter Zijlstra wrote: >> On Sun, Feb 11, 2018 at 10:13:44AM -0800, Linus Torvalds wrote: >> >> > That actually sounds like we could just >> > >> > (a) make gcc 4.5 be the minimum required version >> > >>

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, 2018-02-12 at 09:26 +0100, Peter Zijlstra wrote: > On Sun, Feb 11, 2018 at 10:13:44AM -0800, Linus Torvalds wrote: > > > That actually sounds like we could just > >  > >  (a) make gcc 4.5 be the minimum required version > >  > >  (b) actually error out if we find a bad compiler > > So

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, 2018-02-12 at 09:26 +0100, Peter Zijlstra wrote: > On Sun, Feb 11, 2018 at 10:13:44AM -0800, Linus Torvalds wrote: > > > That actually sounds like we could just > >  > >  (a) make gcc 4.5 be the minimum required version > >  > >  (b) actually error out if we find a bad compiler > > So

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-13 0:46 GMT+09:00 Kees Cook : > On Mon, Feb 12, 2018 at 2:44 AM, Masahiro Yamada > wrote: >> Linus said: >> >>> But yes, I also reacted to your earlier " It can't silently rewrite it >>> to _REGULAR because the compiler support for

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-13 0:46 GMT+09:00 Kees Cook : > On Mon, Feb 12, 2018 at 2:44 AM, Masahiro Yamada > wrote: >> Linus said: >> >>> But yes, I also reacted to your earlier " It can't silently rewrite it >>> to _REGULAR because the compiler support for _STRONG regressed." >>> Because it damn well can. If the

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 2:44 AM, Masahiro Yamada wrote: > Linus said: > >> But yes, I also reacted to your earlier " It can't silently rewrite it >> to _REGULAR because the compiler support for _STRONG regressed." >> Because it damn well can. If the compiler doesn't

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 2:44 AM, Masahiro Yamada wrote: > Linus said: > >> But yes, I also reacted to your earlier " It can't silently rewrite it >> to _REGULAR because the compiler support for _STRONG regressed." >> Because it damn well can. If the compiler doesn't support >>

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 4:22 PM, Masahiro Yamada wrote: > 2018-02-12 23:53 GMT+09:00 Ulf Magnusson : >> On Mon, Feb 12, 2018 at 3:21 PM, Masahiro Yamada >> wrote: >>> 'syncconfig' in a more proper name >> >>

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 4:22 PM, Masahiro Yamada wrote: > 2018-02-12 23:53 GMT+09:00 Ulf Magnusson : >> On Mon, Feb 12, 2018 at 3:21 PM, Masahiro Yamada >> wrote: >>> 'syncconfig' in a more proper name >> >> Wonder if --update-config-files-for-build or something would be an >> even better name.

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 6:39 AM, Masahiro Yamada wrote: > 2018-02-12 2:56 GMT+09:00 Kees Cook : >> I think it would work to skip KBUILD_CPPFLAGS right up until it >> didn't. Since we have the arch split, we can already add -m32 to the >>

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 6:39 AM, Masahiro Yamada wrote: > 2018-02-12 2:56 GMT+09:00 Kees Cook : >> I think it would work to skip KBUILD_CPPFLAGS right up until it >> didn't. Since we have the arch split, we can already add -m32 to the >> 32-bit case, etc. However, I worry about interaction with

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-12 23:53 GMT+09:00 Ulf Magnusson : > On Mon, Feb 12, 2018 at 3:21 PM, Masahiro Yamada > wrote: >> 'syncconfig' in a more proper name > > Wonder if --update-config-files-for-build or something would be an > even better name. I want to

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-12 23:53 GMT+09:00 Ulf Magnusson : > On Mon, Feb 12, 2018 at 3:21 PM, Masahiro Yamada > wrote: >> 'syncconfig' in a more proper name > > Wonder if --update-config-files-for-build or something would be an > even better name. I want to use a name that ends with 'config' like any other

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 3:21 PM, Masahiro Yamada wrote: > 'syncconfig' in a more proper name Wonder if --update-config-files-for-build or something would be an even better name. Kinda tough to compress it into something that adheres to *nix terseness while making

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 3:21 PM, Masahiro Yamada wrote: > 'syncconfig' in a more proper name Wonder if --update-config-files-for-build or something would be an even better name. Kinda tough to compress it into something that adheres to *nix terseness while making it somewhat clear what kind of

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-12 2:56 GMT+09:00 Kees Cook : > I think it would work to skip KBUILD_CPPFLAGS right up until it > didn't. Since we have the arch split, we can already add -m32 to the > 32-bit case, etc. However, I worry about interaction with other > selected build options. For

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-12 2:56 GMT+09:00 Kees Cook : > I think it would work to skip KBUILD_CPPFLAGS right up until it > didn't. Since we have the arch split, we can already add -m32 to the > 32-bit case, etc. However, I worry about interaction with other > selected build options. For example, while retpoline

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 3:23 PM, Masahiro Yamada wrote: > 2018-02-12 23:21 GMT+09:00 Masahiro Yamada : >> 2018-02-12 21:54 GMT+09:00 Ulf Magnusson : >>> On Sun, Feb 11, 2018 at 09:42:09PM +0100, Ulf Magnusson

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 3:23 PM, Masahiro Yamada wrote: > 2018-02-12 23:21 GMT+09:00 Masahiro Yamada : >> 2018-02-12 21:54 GMT+09:00 Ulf Magnusson : >>> On Sun, Feb 11, 2018 at 09:42:09PM +0100, Ulf Magnusson wrote: On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson wrote: > On Sun, Feb

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 3:21 PM, Masahiro Yamada wrote: > 2018-02-12 21:54 GMT+09:00 Ulf Magnusson : >> On Sun, Feb 11, 2018 at 09:42:09PM +0100, Ulf Magnusson wrote: >>> On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 3:21 PM, Masahiro Yamada wrote: > 2018-02-12 21:54 GMT+09:00 Ulf Magnusson : >> On Sun, Feb 11, 2018 at 09:42:09PM +0100, Ulf Magnusson wrote: >>> On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson wrote: >>> > On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: >>> >> Another

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-12 23:21 GMT+09:00 Masahiro Yamada : > 2018-02-12 21:54 GMT+09:00 Ulf Magnusson : >> On Sun, Feb 11, 2018 at 09:42:09PM +0100, Ulf Magnusson wrote: >>> On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson wrote: >>> > On

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-12 23:21 GMT+09:00 Masahiro Yamada : > 2018-02-12 21:54 GMT+09:00 Ulf Magnusson : >> On Sun, Feb 11, 2018 at 09:42:09PM +0100, Ulf Magnusson wrote: >>> On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson wrote: >>> > On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: >>> >> Another case I

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-12 21:54 GMT+09:00 Ulf Magnusson : > On Sun, Feb 11, 2018 at 09:42:09PM +0100, Ulf Magnusson wrote: >> On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson wrote: >> > On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: >> >>

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-12 21:54 GMT+09:00 Ulf Magnusson : > On Sun, Feb 11, 2018 at 09:42:09PM +0100, Ulf Magnusson wrote: >> On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson wrote: >> > On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: >> >> Another case I mentioned before that I just want to make sure we don't

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 2:53 PM, Masahiro Yamada wrote: > 2018-02-12 20:44 GMT+09:00 Ulf Magnusson : > >>> >>> I think Linus's comment was dismissed here. >>> >>> >>> Linus said: >>> But yes, I also reacted to your earlier " It can't

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 2:53 PM, Masahiro Yamada wrote: > 2018-02-12 20:44 GMT+09:00 Ulf Magnusson : > >>> >>> I think Linus's comment was dismissed here. >>> >>> >>> Linus said: >>> But yes, I also reacted to your earlier " It can't silently rewrite it to _REGULAR because the compiler

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-12 20:44 GMT+09:00 Ulf Magnusson : >> >> I think Linus's comment was dismissed here. >> >> >> Linus said: >> >>> But yes, I also reacted to your earlier " It can't silently rewrite it >>> to _REGULAR because the compiler support for _STRONG regressed." >>> Because it

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-12 20:44 GMT+09:00 Ulf Magnusson : >> >> I think Linus's comment was dismissed here. >> >> >> Linus said: >> >>> But yes, I also reacted to your earlier " It can't silently rewrite it >>> to _REGULAR because the compiler support for _STRONG regressed." >>> Because it damn well can. If the

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 09:42:09PM +0100, Ulf Magnusson wrote: > On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson wrote: > > On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: > >> Another case I mentioned before that I just want to make sure we don't >

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 09:42:09PM +0100, Ulf Magnusson wrote: > On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson wrote: > > On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: > >> Another case I mentioned before that I just want to make sure we don't > >> reintroduce the problem of getting "stuck"

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 11:27:25AM +0100, Thomas Gleixner wrote: > On Mon, 12 Feb 2018, Peter Zijlstra wrote: > > > On Sun, Feb 11, 2018 at 10:13:44AM -0800, Linus Torvalds wrote: > > > > > That actually sounds like we could just > > > > > > (a) make gcc 4.5 be the minimum required version > >

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 11:27:25AM +0100, Thomas Gleixner wrote: > On Mon, 12 Feb 2018, Peter Zijlstra wrote: > > > On Sun, Feb 11, 2018 at 10:13:44AM -0800, Linus Torvalds wrote: > > > > > That actually sounds like we could just > > > > > > (a) make gcc 4.5 be the minimum required version > >

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 12:44 PM, Ulf Magnusson wrote: > On Mon, Feb 12, 2018 at 11:44 AM, Masahiro Yamada > wrote: >> 2018-02-11 19:34 GMT+09:00 Ulf Magnusson : >>> Looks to me like there's a few unrelated issues here: >>>

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 12:44 PM, Ulf Magnusson wrote: > On Mon, Feb 12, 2018 at 11:44 AM, Masahiro Yamada > wrote: >> 2018-02-11 19:34 GMT+09:00 Ulf Magnusson : >>> Looks to me like there's a few unrelated issues here: >>> >>> >>> 1. The stack protector support test scripts >>> >>> Worthwhile

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 11:44 AM, Masahiro Yamada wrote: > 2018-02-11 19:34 GMT+09:00 Ulf Magnusson : >> Looks to me like there's a few unrelated issues here: >> >> >> 1. The stack protector support test scripts >> >> Worthwhile IMO if they (*in

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, Feb 12, 2018 at 11:44 AM, Masahiro Yamada wrote: > 2018-02-11 19:34 GMT+09:00 Ulf Magnusson : >> Looks to me like there's a few unrelated issues here: >> >> >> 1. The stack protector support test scripts >> >> Worthwhile IMO if they (*in practice*) prevent hard-to-debug build errors or

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-11 19:34 GMT+09:00 Ulf Magnusson : > Looks to me like there's a few unrelated issues here: > > > 1. The stack protector support test scripts > > Worthwhile IMO if they (*in practice*) prevent hard-to-debug build errors or a > subtly broken kernel from being built. > >

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

2018-02-11 19:34 GMT+09:00 Ulf Magnusson : > Looks to me like there's a few unrelated issues here: > > > 1. The stack protector support test scripts > > Worthwhile IMO if they (*in practice*) prevent hard-to-debug build errors or a > subtly broken kernel from being built. > > A few questions: > >

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 10:50 PM, Linus Torvalds wrote: > On Sun, Feb 11, 2018 at 1:19 PM, Kees Cook wrote: >> On Sun, Feb 11, 2018 at 1:10 PM, Arnd Bergmann wrote: >>> >>> In my tests last year, I identified gcc-4.6 as a nice

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 10:50 PM, Linus Torvalds wrote: > On Sun, Feb 11, 2018 at 1:19 PM, Kees Cook wrote: >> On Sun, Feb 11, 2018 at 1:10 PM, Arnd Bergmann wrote: >>> >>> In my tests last year, I identified gcc-4.6 as a nice minimum level, IIRC >>> gcc-4.5 was unable to build some of the

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, 12 Feb 2018, Peter Zijlstra wrote: > On Sun, Feb 11, 2018 at 10:13:44AM -0800, Linus Torvalds wrote: > > > That actually sounds like we could just > > > > (a) make gcc 4.5 be the minimum required version > > > > (b) actually error out if we find a bad compiler > > So the unofficial

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Mon, 12 Feb 2018, Peter Zijlstra wrote: > On Sun, Feb 11, 2018 at 10:13:44AM -0800, Linus Torvalds wrote: > > > That actually sounds like we could just > > > > (a) make gcc 4.5 be the minimum required version > > > > (b) actually error out if we find a bad compiler > > So the unofficial

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 10:13:44AM -0800, Linus Torvalds wrote: > That actually sounds like we could just > > (a) make gcc 4.5 be the minimum required version > > (b) actually error out if we find a bad compiler So the unofficial plan was to enforce asm-goto and -fentry support by hard

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 10:13:44AM -0800, Linus Torvalds wrote: > That actually sounds like we could just > > (a) make gcc 4.5 be the minimum required version > > (b) actually error out if we find a bad compiler So the unofficial plan was to enforce asm-goto and -fentry support by hard

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 10:10 PM, Arnd Bergmann wrote: > On Sun, Feb 11, 2018 at 9:06 PM, Linus Torvalds > wrote: >> On Sun, Feb 11, 2018 at 11:53 AM, Linus Torvalds >> wrote: >>> >>> Well, it's still not a very *big*

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 10:10 PM, Arnd Bergmann wrote: > On Sun, Feb 11, 2018 at 9:06 PM, Linus Torvalds > wrote: >> On Sun, Feb 11, 2018 at 11:53 AM, Linus Torvalds >> wrote: >>> >>> Well, it's still not a very *big* bump. With modern distros being at >>> 7.3, and people testing pre-releases

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 1:19 PM, Kees Cook wrote: > On Sun, Feb 11, 2018 at 1:10 PM, Arnd Bergmann wrote: >> >> In my tests last year, I identified gcc-4.6 as a nice minimum level, IIRC >> gcc-4.5 was unable to build some of the newer ARM targets. > > But

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 1:19 PM, Kees Cook wrote: > On Sun, Feb 11, 2018 at 1:10 PM, Arnd Bergmann wrote: >> >> In my tests last year, I identified gcc-4.6 as a nice minimum level, IIRC >> gcc-4.5 was unable to build some of the newer ARM targets. > > But yes, if Linus wants 4.5 over 4.3, I

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 10:05 PM, Kees Cook wrote: > On Sun, Feb 11, 2018 at 10:34 AM, Ulf Magnusson wrote: >> On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: >>> Old? That's not the case. The check for -fno-stack-protector

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 10:05 PM, Kees Cook wrote: > On Sun, Feb 11, 2018 at 10:34 AM, Ulf Magnusson wrote: >> On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: >>> Old? That's not the case. The check for -fno-stack-protector will >>> likely be needed forever, as some distro compilers enable

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: >> 3. Whether to implement CC_STACKPROTECTOR_AUTO in Kconfig or the Makefiles >> >> I'd just go with whatever is simplest here. I don't find the Kconfig version >> too bad, but I'm already very familiar with Kconfig, so it's

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: >> 3. Whether to implement CC_STACKPROTECTOR_AUTO in Kconfig or the Makefiles >> >> I'd just go with whatever is simplest here. I don't find the Kconfig version >> too bad, but I'm already very familiar with Kconfig, so it's harder for me to >>

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 1:10 PM, Arnd Bergmann wrote: > On Sun, Feb 11, 2018 at 9:06 PM, Linus Torvalds > wrote: >> On Sun, Feb 11, 2018 at 11:53 AM, Linus Torvalds >> wrote: >>> >>> Well, it's still not a very *big*

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 1:10 PM, Arnd Bergmann wrote: > On Sun, Feb 11, 2018 at 9:06 PM, Linus Torvalds > wrote: >> On Sun, Feb 11, 2018 at 11:53 AM, Linus Torvalds >> wrote: >>> >>> Well, it's still not a very *big* bump. With modern distros being at >>> 7.3, and people testing pre-releases of

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 11:53 AM, Linus Torvalds wrote: > On Sun, Feb 11, 2018 at 11:39 AM, Kees Cook wrote: >> This made akpm and Arnd very very grumpy as it regressed their builds. >> That's why I had to deal with the condition very

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 11:53 AM, Linus Torvalds wrote: > On Sun, Feb 11, 2018 at 11:39 AM, Kees Cook wrote: >> This made akpm and Arnd very very grumpy as it regressed their builds. >> That's why I had to deal with the condition very carefully for _AUTO. > > Well, Arnd build new cross-tools

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 9:06 PM, Linus Torvalds wrote: > On Sun, Feb 11, 2018 at 11:53 AM, Linus Torvalds > wrote: >> >> Well, it's still not a very *big* bump. With modern distros being at >> 7.3, and people testing pre-releases of

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 9:06 PM, Linus Torvalds wrote: > On Sun, Feb 11, 2018 at 11:53 AM, Linus Torvalds > wrote: >> >> Well, it's still not a very *big* bump. With modern distros being at >> 7.3, and people testing pre-releases of gcc-8, something like gcc-4.5 >> is still pretty darn ancient.

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 10:34 AM, Ulf Magnusson wrote: > On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: >> Old? That's not the case. The check for -fno-stack-protector will >> likely be needed forever, as some distro compilers enable >>

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 10:34 AM, Ulf Magnusson wrote: > On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: >> Old? That's not the case. The check for -fno-stack-protector will >> likely be needed forever, as some distro compilers enable >> stack-protector by default. So when someone wants to

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson wrote: > On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: >> Another case I mentioned before that I just want to make sure we don't >> reintroduce the problem of getting "stuck" with a bad .config file.

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 9:29 PM, Ulf Magnusson wrote: > On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: >> Another case I mentioned before that I just want to make sure we don't >> reintroduce the problem of getting "stuck" with a bad .config file. >> While adding _STRONG support, I discovered

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: > Another case I mentioned before that I just want to make sure we don't > reintroduce the problem of getting "stuck" with a bad .config file. > While adding _STRONG support, I discovered the two-phase Kconfig > resolution

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: > Another case I mentioned before that I just want to make sure we don't > reintroduce the problem of getting "stuck" with a bad .config file. > While adding _STRONG support, I discovered the two-phase Kconfig > resolution that happens during the

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 11:53 AM, Linus Torvalds wrote: > > Well, it's still not a very *big* bump. With modern distros being at > 7.3, and people testing pre-releases of gcc-8, something like gcc-4.5 > is still pretty darn ancient. ... it's worth noting that our

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 11:53 AM, Linus Torvalds wrote: > > Well, it's still not a very *big* bump. With modern distros being at > 7.3, and people testing pre-releases of gcc-8, something like gcc-4.5 > is still pretty darn ancient. ... it's worth noting that our _documentation_ may claim that

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 11:39 AM, Kees Cook wrote: >> >> (a) make gcc 4.5 be the minimum required version > > I love bumping minimum for so many reason more than just stack protector. :) Well, it's still not a very *big* bump. With modern distros being at 7.3, and people

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 11:39 AM, Kees Cook wrote: >> >> (a) make gcc 4.5 be the minimum required version > > I love bumping minimum for so many reason more than just stack protector. :) Well, it's still not a very *big* bump. With modern distros being at 7.3, and people testing pre-releases of

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 10:13 AM, Linus Torvalds wrote: > > That actually sounds like we could just > > (a) make gcc 4.5 be the minimum required version > > (b) actually error out if we find a bad compiler Just to explain why that's different from what we do not

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 10:13 AM, Linus Torvalds wrote: > > That actually sounds like we could just > > (a) make gcc 4.5 be the minimum required version > > (b) actually error out if we find a bad compiler Just to explain why that's different from what we do not (apart from the "error out"

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 10:13 AM, Linus Torvalds wrote: > On Sun, Feb 11, 2018 at 9:56 AM, Kees Cook wrote: >> >>> - How common are those broken compilers? >> >> I *thought* it was rare (i.e. gcc 4.2) but while working on ..._AUTO I >>

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 10:13 AM, Linus Torvalds wrote: > On Sun, Feb 11, 2018 at 9:56 AM, Kees Cook wrote: >> >>> - How common are those broken compilers? >> >> I *thought* it was rare (i.e. gcc 4.2) but while working on ..._AUTO I >> found breakage in akpm's 4.4 gcc, and all of Arnd's gccs

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: > Old? That's not the case. The check for -fno-stack-protector will > likely be needed forever, as some distro compilers enable > stack-protector by default. So when someone wants to explicitly build > without

Re: [RFC PATCH 4/7] kconfig: support new special property shell=

On Sun, Feb 11, 2018 at 6:56 PM, Kees Cook wrote: > Old? That's not the case. The check for -fno-stack-protector will > likely be needed forever, as some distro compilers enable > stack-protector by default. So when someone wants to explicitly build > without stack-protector (or if the compiler's

  1   2   >