Re: [RFC PATCH v2 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite

2016-09-18 Thread Krzysztof Kozlowski
On Sun, Sep 18, 2016 at 09:03:48PM +0200, Krzysztof Kozlowski wrote:
> On Sun, Sep 18, 2016 at 10:27:38PM +0800, Randy Li wrote:
> > It is actually a lvds panel connected through a rga-lvds bridge.
> > The touchscreen is communicated with i2c bus but the driver is not
> > support now.
> > 
> > Signed-off-by: Randy Li 
> 
> Subject: ARM: dts: exynos
> 
> > ---
> >  arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 
> > +++--
> >  1 file changed, 52 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts 
> > b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > index b08705e..9ef0505 100644
> > --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > @@ -138,6 +138,36 @@
> > assigned-clocks = < CLK_MOUT_CAM0>;
> > assigned-clock-parents = < CLK_XUSBXTI>;
> > };
> > +
> > +   vcc_sys_lcd: sys-lcd {
> 
> No underscores, use hyphens.

Ah wait, it's a label, so underscore seems ok. My mistake.

> 
> > +   compatible = "regulator-fixed";
> > +   regulator-name = "vcc_5v";
> > +   regulator-min-microvolt = <500>;
> > +   regulator-max-microvolt = <500>;
> > +   gpio = < 4 GPIO_ACTIVE_HIGH>;
> 
> Isn't this one of S5M8767 PMIC regulators? If so, then it should be
> defined there... On the other hand, the PMIC supports GPIO enable
> control only for buck9...
> 
> > +   };
> > +
> > +   panel: panel@0 {
> > +   compatible = "chunghwa,claa070wp03xg";
> > +
> > +   power-supply = <_sys_lcd>;
> > +   enable-gpios = < 2 GPIO_ACTIVE_HIGH>;
> > +   backlight = <>;
> > +
> > +   port {
> > +   lcd_ep: endpoint {
> 
> lcd-ep

No need, the same.

Best regards,
Krzysztof

> 
> > +   remote-endpoint = <_lvds>;
> > +   };
> > +   };
> > +   };
> > +
> > +   bl: backlight {
> > +   compatible = "pwm-backlight";
> > +   pwms = < 1 500 PWM_POLARITY_INVERTED>;
> > +   brightness-levels = <0 5 12 16 32 64 128 255>;
> > +   default-brightness-level = <5>;
> > +   power-supply = <_sys_lcd>;
> > +   };
> >  };
> >  
> >   {
> > @@ -215,9 +245,9 @@
> >  
> >   {
> > status = "okay";
> > -   pinctrl-0 = <_out>;
> > +   pinctrl-0 = <_out _out>;
> > pinctrl-names = "default";
> > -   samsung,pwm-outputs = <0>;
> > +   samsung,pwm-outputs = <0>, <1>;
> >  };
> >  
> >  _2 {
> > @@ -238,3 +268,23 @@
> >  _2 {
> > status = "okay";
> >  };
> > +
> > +_3 {
> > +   status = "okay";
> > +};
> > +
> > + {
> 
> Please put these nodes in alphabetical order. I asked about it for
> initial DTS and it applies still.
> 
> > +   pinctrl-0 = <_clk _data24>;
> > +   pinctrl-names = "default";
> > +   status = "okay";
> > +   ports {
> > +   #address-cells = <1>;
> > +   #size-cells = <0>;
> > +   port@3 {
> > +   reg = <3>;
> > +   rga_lvds: endpoint {
> 
> rga-lvds
> 
> Best regards,
> Krzysztof
> 
> > +   remote-endpoint = <_ep>;
> > +   };
> > +   };
> > +   };
> > +};
> > -- 
> > 2.7.4
> > 


Re: [RFC PATCH v2 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite

2016-09-18 Thread Krzysztof Kozlowski
On Sun, Sep 18, 2016 at 09:03:48PM +0200, Krzysztof Kozlowski wrote:
> On Sun, Sep 18, 2016 at 10:27:38PM +0800, Randy Li wrote:
> > It is actually a lvds panel connected through a rga-lvds bridge.
> > The touchscreen is communicated with i2c bus but the driver is not
> > support now.
> > 
> > Signed-off-by: Randy Li 
> 
> Subject: ARM: dts: exynos
> 
> > ---
> >  arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 
> > +++--
> >  1 file changed, 52 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts 
> > b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > index b08705e..9ef0505 100644
> > --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> > @@ -138,6 +138,36 @@
> > assigned-clocks = < CLK_MOUT_CAM0>;
> > assigned-clock-parents = < CLK_XUSBXTI>;
> > };
> > +
> > +   vcc_sys_lcd: sys-lcd {
> 
> No underscores, use hyphens.

Ah wait, it's a label, so underscore seems ok. My mistake.

> 
> > +   compatible = "regulator-fixed";
> > +   regulator-name = "vcc_5v";
> > +   regulator-min-microvolt = <500>;
> > +   regulator-max-microvolt = <500>;
> > +   gpio = < 4 GPIO_ACTIVE_HIGH>;
> 
> Isn't this one of S5M8767 PMIC regulators? If so, then it should be
> defined there... On the other hand, the PMIC supports GPIO enable
> control only for buck9...
> 
> > +   };
> > +
> > +   panel: panel@0 {
> > +   compatible = "chunghwa,claa070wp03xg";
> > +
> > +   power-supply = <_sys_lcd>;
> > +   enable-gpios = < 2 GPIO_ACTIVE_HIGH>;
> > +   backlight = <>;
> > +
> > +   port {
> > +   lcd_ep: endpoint {
> 
> lcd-ep

No need, the same.

Best regards,
Krzysztof

> 
> > +   remote-endpoint = <_lvds>;
> > +   };
> > +   };
> > +   };
> > +
> > +   bl: backlight {
> > +   compatible = "pwm-backlight";
> > +   pwms = < 1 500 PWM_POLARITY_INVERTED>;
> > +   brightness-levels = <0 5 12 16 32 64 128 255>;
> > +   default-brightness-level = <5>;
> > +   power-supply = <_sys_lcd>;
> > +   };
> >  };
> >  
> >   {
> > @@ -215,9 +245,9 @@
> >  
> >   {
> > status = "okay";
> > -   pinctrl-0 = <_out>;
> > +   pinctrl-0 = <_out _out>;
> > pinctrl-names = "default";
> > -   samsung,pwm-outputs = <0>;
> > +   samsung,pwm-outputs = <0>, <1>;
> >  };
> >  
> >  _2 {
> > @@ -238,3 +268,23 @@
> >  _2 {
> > status = "okay";
> >  };
> > +
> > +_3 {
> > +   status = "okay";
> > +};
> > +
> > + {
> 
> Please put these nodes in alphabetical order. I asked about it for
> initial DTS and it applies still.
> 
> > +   pinctrl-0 = <_clk _data24>;
> > +   pinctrl-names = "default";
> > +   status = "okay";
> > +   ports {
> > +   #address-cells = <1>;
> > +   #size-cells = <0>;
> > +   port@3 {
> > +   reg = <3>;
> > +   rga_lvds: endpoint {
> 
> rga-lvds
> 
> Best regards,
> Krzysztof
> 
> > +   remote-endpoint = <_ep>;
> > +   };
> > +   };
> > +   };
> > +};
> > -- 
> > 2.7.4
> > 


Re: [RFC PATCH v2 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite

2016-09-18 Thread Krzysztof Kozlowski
On Sun, Sep 18, 2016 at 10:27:38PM +0800, Randy Li wrote:
> It is actually a lvds panel connected through a rga-lvds bridge.
> The touchscreen is communicated with i2c bus but the driver is not
> support now.
> 
> Signed-off-by: Randy Li 

Subject: ARM: dts: exynos

> ---
>  arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 
> +++--
>  1 file changed, 52 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts 
> b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> index b08705e..9ef0505 100644
> --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
> +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> @@ -138,6 +138,36 @@
>   assigned-clocks = < CLK_MOUT_CAM0>;
>   assigned-clock-parents = < CLK_XUSBXTI>;
>   };
> +
> + vcc_sys_lcd: sys-lcd {

No underscores, use hyphens.

> + compatible = "regulator-fixed";
> + regulator-name = "vcc_5v";
> + regulator-min-microvolt = <500>;
> + regulator-max-microvolt = <500>;
> + gpio = < 4 GPIO_ACTIVE_HIGH>;

Isn't this one of S5M8767 PMIC regulators? If so, then it should be
defined there... On the other hand, the PMIC supports GPIO enable
control only for buck9...

> + };
> +
> + panel: panel@0 {
> + compatible = "chunghwa,claa070wp03xg";
> +
> + power-supply = <_sys_lcd>;
> + enable-gpios = < 2 GPIO_ACTIVE_HIGH>;
> + backlight = <>;
> +
> + port {
> + lcd_ep: endpoint {

lcd-ep

> + remote-endpoint = <_lvds>;
> + };
> + };
> + };
> +
> + bl: backlight {
> + compatible = "pwm-backlight";
> + pwms = < 1 500 PWM_POLARITY_INVERTED>;
> + brightness-levels = <0 5 12 16 32 64 128 255>;
> + default-brightness-level = <5>;
> + power-supply = <_sys_lcd>;
> + };
>  };
>  
>   {
> @@ -215,9 +245,9 @@
>  
>   {
>   status = "okay";
> - pinctrl-0 = <_out>;
> + pinctrl-0 = <_out _out>;
>   pinctrl-names = "default";
> - samsung,pwm-outputs = <0>;
> + samsung,pwm-outputs = <0>, <1>;
>  };
>  
>  _2 {
> @@ -238,3 +268,23 @@
>  _2 {
>   status = "okay";
>  };
> +
> +_3 {
> + status = "okay";
> +};
> +
> + {

Please put these nodes in alphabetical order. I asked about it for
initial DTS and it applies still.

> + pinctrl-0 = <_clk _data24>;
> + pinctrl-names = "default";
> + status = "okay";
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@3 {
> + reg = <3>;
> + rga_lvds: endpoint {

rga-lvds

Best regards,
Krzysztof

> + remote-endpoint = <_ep>;
> + };
> + };
> + };
> +};
> -- 
> 2.7.4
> 


Re: [RFC PATCH v2 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite

2016-09-18 Thread Krzysztof Kozlowski
On Sun, Sep 18, 2016 at 10:27:38PM +0800, Randy Li wrote:
> It is actually a lvds panel connected through a rga-lvds bridge.
> The touchscreen is communicated with i2c bus but the driver is not
> support now.
> 
> Signed-off-by: Randy Li 

Subject: ARM: dts: exynos

> ---
>  arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 
> +++--
>  1 file changed, 52 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts 
> b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> index b08705e..9ef0505 100644
> --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
> +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
> @@ -138,6 +138,36 @@
>   assigned-clocks = < CLK_MOUT_CAM0>;
>   assigned-clock-parents = < CLK_XUSBXTI>;
>   };
> +
> + vcc_sys_lcd: sys-lcd {

No underscores, use hyphens.

> + compatible = "regulator-fixed";
> + regulator-name = "vcc_5v";
> + regulator-min-microvolt = <500>;
> + regulator-max-microvolt = <500>;
> + gpio = < 4 GPIO_ACTIVE_HIGH>;

Isn't this one of S5M8767 PMIC regulators? If so, then it should be
defined there... On the other hand, the PMIC supports GPIO enable
control only for buck9...

> + };
> +
> + panel: panel@0 {
> + compatible = "chunghwa,claa070wp03xg";
> +
> + power-supply = <_sys_lcd>;
> + enable-gpios = < 2 GPIO_ACTIVE_HIGH>;
> + backlight = <>;
> +
> + port {
> + lcd_ep: endpoint {

lcd-ep

> + remote-endpoint = <_lvds>;
> + };
> + };
> + };
> +
> + bl: backlight {
> + compatible = "pwm-backlight";
> + pwms = < 1 500 PWM_POLARITY_INVERTED>;
> + brightness-levels = <0 5 12 16 32 64 128 255>;
> + default-brightness-level = <5>;
> + power-supply = <_sys_lcd>;
> + };
>  };
>  
>   {
> @@ -215,9 +245,9 @@
>  
>   {
>   status = "okay";
> - pinctrl-0 = <_out>;
> + pinctrl-0 = <_out _out>;
>   pinctrl-names = "default";
> - samsung,pwm-outputs = <0>;
> + samsung,pwm-outputs = <0>, <1>;
>  };
>  
>  _2 {
> @@ -238,3 +268,23 @@
>  _2 {
>   status = "okay";
>  };
> +
> +_3 {
> + status = "okay";
> +};
> +
> + {

Please put these nodes in alphabetical order. I asked about it for
initial DTS and it applies still.

> + pinctrl-0 = <_clk _data24>;
> + pinctrl-names = "default";
> + status = "okay";
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@3 {
> + reg = <3>;
> + rga_lvds: endpoint {

rga-lvds

Best regards,
Krzysztof

> + remote-endpoint = <_ep>;
> + };
> + };
> + };
> +};
> -- 
> 2.7.4
> 


[RFC PATCH v2 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite

2016-09-18 Thread Randy Li
It is actually a lvds panel connected through a rga-lvds bridge.
The touchscreen is communicated with i2c bus but the driver is not
support now.

Signed-off-by: Randy Li 
---
 arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 +++--
 1 file changed, 52 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts 
b/arch/arm/boot/dts/exynos4412-itop-elite.dts
index b08705e..9ef0505 100644
--- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
+++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
@@ -138,6 +138,36 @@
assigned-clocks = < CLK_MOUT_CAM0>;
assigned-clock-parents = < CLK_XUSBXTI>;
};
+
+   vcc_sys_lcd: sys-lcd {
+   compatible = "regulator-fixed";
+   regulator-name = "vcc_5v";
+   regulator-min-microvolt = <500>;
+   regulator-max-microvolt = <500>;
+   gpio = < 4 GPIO_ACTIVE_HIGH>;
+   };
+
+   panel: panel@0 {
+   compatible = "chunghwa,claa070wp03xg";
+
+   power-supply = <_sys_lcd>;
+   enable-gpios = < 2 GPIO_ACTIVE_HIGH>;
+   backlight = <>;
+
+   port {
+   lcd_ep: endpoint {
+   remote-endpoint = <_lvds>;
+   };
+   };
+   };
+
+   bl: backlight {
+   compatible = "pwm-backlight";
+   pwms = < 1 500 PWM_POLARITY_INVERTED>;
+   brightness-levels = <0 5 12 16 32 64 128 255>;
+   default-brightness-level = <5>;
+   power-supply = <_sys_lcd>;
+   };
 };
 
  {
@@ -215,9 +245,9 @@
 
  {
status = "okay";
-   pinctrl-0 = <_out>;
+   pinctrl-0 = <_out _out>;
pinctrl-names = "default";
-   samsung,pwm-outputs = <0>;
+   samsung,pwm-outputs = <0>, <1>;
 };
 
 _2 {
@@ -238,3 +268,23 @@
 _2 {
status = "okay";
 };
+
+_3 {
+   status = "okay";
+};
+
+ {
+   pinctrl-0 = <_clk _data24>;
+   pinctrl-names = "default";
+   status = "okay";
+   ports {
+   #address-cells = <1>;
+   #size-cells = <0>;
+   port@3 {
+   reg = <3>;
+   rga_lvds: endpoint {
+   remote-endpoint = <_ep>;
+   };
+   };
+   };
+};
-- 
2.7.4



[RFC PATCH v2 1/2] ARM: dts: samsung: add rga-lvds panel in itop elite

2016-09-18 Thread Randy Li
It is actually a lvds panel connected through a rga-lvds bridge.
The touchscreen is communicated with i2c bus but the driver is not
support now.

Signed-off-by: Randy Li 
---
 arch/arm/boot/dts/exynos4412-itop-elite.dts | 54 +++--
 1 file changed, 52 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts 
b/arch/arm/boot/dts/exynos4412-itop-elite.dts
index b08705e..9ef0505 100644
--- a/arch/arm/boot/dts/exynos4412-itop-elite.dts
+++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts
@@ -138,6 +138,36 @@
assigned-clocks = < CLK_MOUT_CAM0>;
assigned-clock-parents = < CLK_XUSBXTI>;
};
+
+   vcc_sys_lcd: sys-lcd {
+   compatible = "regulator-fixed";
+   regulator-name = "vcc_5v";
+   regulator-min-microvolt = <500>;
+   regulator-max-microvolt = <500>;
+   gpio = < 4 GPIO_ACTIVE_HIGH>;
+   };
+
+   panel: panel@0 {
+   compatible = "chunghwa,claa070wp03xg";
+
+   power-supply = <_sys_lcd>;
+   enable-gpios = < 2 GPIO_ACTIVE_HIGH>;
+   backlight = <>;
+
+   port {
+   lcd_ep: endpoint {
+   remote-endpoint = <_lvds>;
+   };
+   };
+   };
+
+   bl: backlight {
+   compatible = "pwm-backlight";
+   pwms = < 1 500 PWM_POLARITY_INVERTED>;
+   brightness-levels = <0 5 12 16 32 64 128 255>;
+   default-brightness-level = <5>;
+   power-supply = <_sys_lcd>;
+   };
 };
 
  {
@@ -215,9 +245,9 @@
 
  {
status = "okay";
-   pinctrl-0 = <_out>;
+   pinctrl-0 = <_out _out>;
pinctrl-names = "default";
-   samsung,pwm-outputs = <0>;
+   samsung,pwm-outputs = <0>, <1>;
 };
 
 _2 {
@@ -238,3 +268,23 @@
 _2 {
status = "okay";
 };
+
+_3 {
+   status = "okay";
+};
+
+ {
+   pinctrl-0 = <_clk _data24>;
+   pinctrl-names = "default";
+   status = "okay";
+   ports {
+   #address-cells = <1>;
+   #size-cells = <0>;
+   port@3 {
+   reg = <3>;
+   rga_lvds: endpoint {
+   remote-endpoint = <_ep>;
+   };
+   };
+   };
+};
-- 
2.7.4