Re: [RFC V3 0/3] perf stat: improvements for handling of multiple PMUs
> Sure, I have this applied to my local branch, and will add his acks or > drop the patches if he still has any objection, Andi? Patches looks good to me. Acked-by: Andi Kleen -Andi
Re: [RFC V3 0/3] perf stat: improvements for handling of multiple PMUs
Em Wed, Mar 07, 2018 at 02:51:05PM +0100, Jiri Olsa escreveu: > On Wed, Mar 07, 2018 at 10:36:30AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Mar 07, 2018 at 11:04:08AM +0100, Jiri Olsa escreveu: > > > On Tue, Mar 06, 2018 at 09:04:41AM -0500, Agustin Vega-Frias wrote: > > > > This series of patches adds some simple improvements to the way perf > > > > stat > > > > handles PMUs that have multiple instances by: > > > > > > > > 1. Adding glob-like matching in addition to the prefix-based matching > > > >introduced previously (patch 1). > > > > 2. Adding the ability to recover the PMU names when printing the events > > > >separately with the --no-merge option (patch 2). > > > > 3. Restoring auto-merge for events created by prefix or glob-like match > > > >(patch 3). Note that this still keeps the behavior that disables > > > >auto-merging of legacy symbolic events (e.g. cycles). > > > > > > > > V3: > > > > > > > > - Consolidated prefix and glob matching into a single glob match with a > > > > trailing * to maintain prefix matching and have more consistent > > > > behavior. > > > > E.g., all of these match all the uncore_imc PMUs: imc, imc*, *imc, > > > > *imc* > > > > > > Acked-by: Jiri Olsa > > > > Thanks, applied. > > > > I guess Andi had Acked or Reviewed this, no? > > not the latest version.. please wait for his ack Sure, I have this applied to my local branch, and will add his acks or drop the patches if he still has any objection, Andi? - Arnaldo
Re: [RFC V3 0/3] perf stat: improvements for handling of multiple PMUs
On Wed, Mar 07, 2018 at 10:36:30AM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 07, 2018 at 11:04:08AM +0100, Jiri Olsa escreveu: > > On Tue, Mar 06, 2018 at 09:04:41AM -0500, Agustin Vega-Frias wrote: > > > This series of patches adds some simple improvements to the way perf stat > > > handles PMUs that have multiple instances by: > > > > > > 1. Adding glob-like matching in addition to the prefix-based matching > > >introduced previously (patch 1). > > > 2. Adding the ability to recover the PMU names when printing the events > > >separately with the --no-merge option (patch 2). > > > 3. Restoring auto-merge for events created by prefix or glob-like match > > >(patch 3). Note that this still keeps the behavior that disables > > >auto-merging of legacy symbolic events (e.g. cycles). > > > > > > V3: > > > > > > - Consolidated prefix and glob matching into a single glob match with a > > > trailing * to maintain prefix matching and have more consistent > > > behavior. > > > E.g., all of these match all the uncore_imc PMUs: imc, imc*, *imc, *imc* > > > > Acked-by: Jiri Olsa > > Thanks, applied. > > I guess Andi had Acked or Reviewed this, no? not the latest version.. please wait for his ack jirka
Re: [RFC V3 0/3] perf stat: improvements for handling of multiple PMUs
Em Wed, Mar 07, 2018 at 11:04:08AM +0100, Jiri Olsa escreveu: > On Tue, Mar 06, 2018 at 09:04:41AM -0500, Agustin Vega-Frias wrote: > > This series of patches adds some simple improvements to the way perf stat > > handles PMUs that have multiple instances by: > > > > 1. Adding glob-like matching in addition to the prefix-based matching > >introduced previously (patch 1). > > 2. Adding the ability to recover the PMU names when printing the events > >separately with the --no-merge option (patch 2). > > 3. Restoring auto-merge for events created by prefix or glob-like match > >(patch 3). Note that this still keeps the behavior that disables > >auto-merging of legacy symbolic events (e.g. cycles). > > > > V3: > > > > - Consolidated prefix and glob matching into a single glob match with a > > trailing * to maintain prefix matching and have more consistent behavior. > > E.g., all of these match all the uncore_imc PMUs: imc, imc*, *imc, *imc* > > Acked-by: Jiri Olsa Thanks, applied. I guess Andi had Acked or Reviewed this, no? - Arnaldo
Re: [RFC V3 0/3] perf stat: improvements for handling of multiple PMUs
On Tue, Mar 06, 2018 at 09:04:41AM -0500, Agustin Vega-Frias wrote: > This series of patches adds some simple improvements to the way perf stat > handles PMUs that have multiple instances by: > > 1. Adding glob-like matching in addition to the prefix-based matching >introduced previously (patch 1). > 2. Adding the ability to recover the PMU names when printing the events >separately with the --no-merge option (patch 2). > 3. Restoring auto-merge for events created by prefix or glob-like match >(patch 3). Note that this still keeps the behavior that disables >auto-merging of legacy symbolic events (e.g. cycles). > > V3: > > - Consolidated prefix and glob matching into a single glob match with a > trailing * to maintain prefix matching and have more consistent behavior. > E.g., all of these match all the uncore_imc PMUs: imc, imc*, *imc, *imc* Acked-by: Jiri Olsa thanks, jirka
[RFC V3 0/3] perf stat: improvements for handling of multiple PMUs
This series of patches adds some simple improvements to the way perf stat handles PMUs that have multiple instances by: 1. Adding glob-like matching in addition to the prefix-based matching introduced previously (patch 1). 2. Adding the ability to recover the PMU names when printing the events separately with the --no-merge option (patch 2). 3. Restoring auto-merge for events created by prefix or glob-like match (patch 3). Note that this still keeps the behavior that disables auto-merging of legacy symbolic events (e.g. cycles). V3: - Consolidated prefix and glob matching into a single glob match with a trailing * to maintain prefix matching and have more consistent behavior. E.g., all of these match all the uncore_imc PMUs: imc, imc*, *imc, *imc* V2: - Updated the documentation to explain prefix and glob matching of PMU names, and event auto-merging. - Added sample output to the third patch. Agustin Vega-Frias (3): perf, tools: Support wildcards on pmu name in dynamic pmu events perf, tools: Display pmu name when printing unmerged events in stat perf pmu: Auto-merge PMU events created by prefix or glob match tools/perf/Documentation/perf-list.txt | 8 +++- tools/perf/Documentation/perf-stat.txt | 17 + tools/perf/builtin-stat.c | 29 - tools/perf/util/evsel.c| 1 + tools/perf/util/evsel.h| 1 + tools/perf/util/parse-events.c | 21 ++--- tools/perf/util/parse-events.h | 2 +- tools/perf/util/parse-events.l | 2 +- tools/perf/util/parse-events.y | 23 ++- 9 files changed, 80 insertions(+), 24 deletions(-) -- Qualcomm Datacenter Technologies, Inc. on behalf of the Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.