Re: [resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function

2013-01-09 Thread Andy Shevchenko
On Wed, Jan 9, 2013 at 5:10 PM, Vinod Koul wrote: > On Wed, Jan 09, 2013 at 04:58:02PM +0200, Andy Shevchenko wrote: >> On Wed, Jan 9, 2013 at 4:19 PM, Viresh Kumar wrote: >> > n 9 January 2013 19:20, Vinod Koul wrote: >> >>> +static inline bool is_slave_xfer(enum dma_transfer_direction

Re: [resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function

2013-01-09 Thread Vinod Koul
On Wed, Jan 09, 2013 at 04:58:02PM +0200, Andy Shevchenko wrote: > On Wed, Jan 9, 2013 at 4:19 PM, Viresh Kumar wrote: > > n 9 January 2013 19:20, Vinod Koul wrote: > >>> +static inline bool is_slave_xfer(enum dma_transfer_direction direction) > >>> +{ > >>> + return (direction ==

Re: [resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function

2013-01-09 Thread Andy Shevchenko
On Wed, Jan 9, 2013 at 4:19 PM, Viresh Kumar wrote: > n 9 January 2013 19:20, Vinod Koul wrote: >>> +static inline bool is_slave_xfer(enum dma_transfer_direction direction) >>> +{ >>> + return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM); >>> +} >> After reading the

Re: [resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function

2013-01-09 Thread Viresh Kumar
n 9 January 2013 19:20, Vinod Koul wrote: >> +static inline bool is_slave_xfer(enum dma_transfer_direction direction) >> +{ >> + return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM); >> +} > After reading the subsequent patch I understand what is intent here. Perhaps >

Re: [resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function

2013-01-09 Thread Vinod Koul
On Wed, Jan 09, 2013 at 10:17:02AM +0200, Andy Shevchenko wrote: > This function helps to distinguish the slave type of transfer by checking the > direction parameter. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Viresh Kumar > Reviewed-by: Mika Westerberg > Reviewed-by: Linus Walleij >

[resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function

2013-01-09 Thread Andy Shevchenko
This function helps to distinguish the slave type of transfer by checking the direction parameter. Signed-off-by: Andy Shevchenko Reviewed-by: Viresh Kumar Reviewed-by: Mika Westerberg Reviewed-by: Linus Walleij Cc: Nicolas Ferre Cc: Guennadi Liakhovetski --- include/linux/dmaengine.h |

[resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function

2013-01-09 Thread Andy Shevchenko
This function helps to distinguish the slave type of transfer by checking the direction parameter. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Reviewed-by: Viresh Kumar viresh.ku...@linaro.org Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com Reviewed-by: Linus

Re: [resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function

2013-01-09 Thread Vinod Koul
On Wed, Jan 09, 2013 at 10:17:02AM +0200, Andy Shevchenko wrote: This function helps to distinguish the slave type of transfer by checking the direction parameter. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Reviewed-by: Viresh Kumar viresh.ku...@linaro.org Reviewed-by:

Re: [resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function

2013-01-09 Thread Viresh Kumar
n 9 January 2013 19:20, Vinod Koul vinod.k...@intel.com wrote: +static inline bool is_slave_xfer(enum dma_transfer_direction direction) +{ + return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM); +} After reading the subsequent patch I understand what is intent here.

Re: [resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function

2013-01-09 Thread Andy Shevchenko
On Wed, Jan 9, 2013 at 4:19 PM, Viresh Kumar viresh.ku...@linaro.org wrote: n 9 January 2013 19:20, Vinod Koul vinod.k...@intel.com wrote: +static inline bool is_slave_xfer(enum dma_transfer_direction direction) +{ + return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM);

Re: [resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function

2013-01-09 Thread Vinod Koul
On Wed, Jan 09, 2013 at 04:58:02PM +0200, Andy Shevchenko wrote: On Wed, Jan 9, 2013 at 4:19 PM, Viresh Kumar viresh.ku...@linaro.org wrote: n 9 January 2013 19:20, Vinod Koul vinod.k...@intel.com wrote: +static inline bool is_slave_xfer(enum dma_transfer_direction direction) +{ +

Re: [resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function

2013-01-09 Thread Andy Shevchenko
On Wed, Jan 9, 2013 at 5:10 PM, Vinod Koul vinod.k...@intel.com wrote: On Wed, Jan 09, 2013 at 04:58:02PM +0200, Andy Shevchenko wrote: On Wed, Jan 9, 2013 at 4:19 PM, Viresh Kumar viresh.ku...@linaro.org wrote: n 9 January 2013 19:20, Vinod Koul vinod.k...@intel.com wrote: +static inline