Commit-ID: 0e54705b0e01dcaf3eb2a496bb66d5f05012056b
Gitweb: https://git.kernel.org/tip/0e54705b0e01dcaf3eb2a496bb66d5f05012056b
Author: Wei Yongjun <weiyongj...@huawei.com>
AuthorDate: Tue, 14 Nov 2017 06:57:28 +0000
Committer: Thomas Gleixner <t...@linutronix.de>
CommitDate: Tue, 14 Nov 2017 11:27:22 +0100
irqchip/exiu: Fix return value check in exiu_init()
In case of error, the function of_iomap() returns NULL pointer not
ERR_PTR().
Replace the IS_ERR() test of the return value with NULL test and return
a proper error code.
Fixes: 706cffc1b912 ("irqchip/exiu: Add support for Socionext Synquacer EXIU
controller")
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
Signed-off-by: Thomas Gleixner <t...@linutronix.de>
Acked-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
Cc: Marc Zyngier <marc.zyng...@arm.com>
Cc: Jason Cooper <ja...@lakedaemon.net>
Link:
https://lkml.kernel.org/r/1510642648-123574-1-git-send-email-weiyongj...@huawei.com
---
drivers/irqchip/irq-sni-exiu.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-sni-exiu.c b/drivers/irqchip/irq-sni-exiu.c
index 1b6e2f7..1927b2f 100644
--- a/drivers/irqchip/irq-sni-exiu.c
+++ b/drivers/irqchip/irq-sni-exiu.c
@@ -196,8 +196,8 @@ static int __init exiu_init(struct device_node *node,
}
data->base = of_iomap(node, 0);
- if (IS_ERR(data->base)) {
- err = PTR_ERR(data->base);
+ if (!data->base) {
+ err = -ENODEV;
goto out_free;
}
