Commit-ID: 2cbc0d66de0480449c75636f55697c7ff3af61fc Gitweb: https://git.kernel.org/tip/2cbc0d66de0480449c75636f55697c7ff3af61fc Author: Dominik Brodowski <li...@dominikbrodowski.net> AuthorDate: Sun, 11 Feb 2018 12:10:11 +0100 Committer: Ingo Molnar <mi...@kernel.org> CommitDate: Tue, 13 Feb 2018 09:05:37 +0100
selftests/x86: Do not rely on "int $0x80" in test_mremap_vdso.c On 64-bit builds, we should not rely on "int $0x80" working (it only does if CONFIG_IA32_EMULATION=y is enabled). Without this patch, the move test may succeed, but the "int $0x80" causes a segfault, resulting in a false negative output of this self-test. Signed-off-by: Dominik Brodowski <li...@dominikbrodowski.net> Cc: Andy Lutomirski <l...@kernel.org> Cc: Dmitry Safonov <dsafo...@virtuozzo.com> Cc: Linus Torvalds <torva...@linux-foundation.org> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: linux-kselft...@vger.kernel.org Cc: sh...@kernel.org Link: http://lkml.kernel.org/r/20180211111013.16888-4-li...@dominikbrodowski.net Signed-off-by: Ingo Molnar <mi...@kernel.org> --- tools/testing/selftests/x86/test_mremap_vdso.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/x86/test_mremap_vdso.c b/tools/testing/selftests/x86/test_mremap_vdso.c index bf0d687..64f11c8 100644 --- a/tools/testing/selftests/x86/test_mremap_vdso.c +++ b/tools/testing/selftests/x86/test_mremap_vdso.c @@ -90,8 +90,12 @@ int main(int argc, char **argv, char **envp) vdso_size += PAGE_SIZE; } +#ifdef __i386__ /* Glibc is likely to explode now - exit with raw syscall */ asm volatile ("int $0x80" : : "a" (__NR_exit), "b" (!!ret)); +#else /* __x86_64__ */ + syscall(SYS_exit, ret); +#endif } else { int status;
