Re: GPF in keyring_destroy

Dmitry Vyukov wrote: > Do you mean in addition or instead of the previous one? From your > description, it sounds like it alone should prevent the crash. I'm going to submit them both, so if you could test them together. You're right, though, I think this should also prevent the crash. David

Re: GPF in keyring_destroy

On Mon, Oct 19, 2015 at 12:33 PM, David Howells wrote: > Dmitry Vyukov wrote: > >> > Does the attached patch fix it for you? >> >> Yes, it fixes the crash for me. > > I have an additional patch to prevent keyrings from being constructed by > request_key() at all (though it can still search for

Re: GPF in keyring_destroy

Dmitry Vyukov wrote: > > Does the attached patch fix it for you? > > Yes, it fixes the crash for me. I have an additional patch to prevent keyrings from being constructed by request_key() at all (though it can still search for them). Could you give this a spin in addition to the previous one

Re: GPF in keyring_destroy

Dmitry Vyukov wrote: > Yes, sure. Do I need to say something like: > > Tested-by: Dmitry Vyukov > > in future? That helps:-) David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: GPF in keyring_destroy

On Mon, Oct 19, 2015 at 11:30 AM, David Howells wrote: > Dmitry Vyukov wrote: > >> > Does the attached patch fix it for you? >> >> Yes, it fixes the crash for me. > > Can I put you down as a Tested-by? > > David Yes, sure. Do I need to say something like: Tested-by: Dmitry Vyukov in future?

Re: GPF in keyring_destroy

Dmitry Vyukov wrote: > > Does the attached patch fix it for you? > > Yes, it fixes the crash for me. Can I put you down as a Tested-by? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: GPF in keyring_destroy

On Thu, Oct 15, 2015 at 9:21 PM, David Howells wrote: > Does the attached patch fix it for you? Yes, it fixes the crash for me. > David > --- > commit a7609e0bb3973d6ee3c9f1ecd0b6a382d99d6248 > Author: David Howells > Date: Thu Oct 15 17:21:37 2015 +0100 > > KEYS: Fix crash when attempt

Re: GPF in keyring_destroy

Dmitry Vyukov wrote: > Do you mean in addition or instead of the previous one? From your > description, it sounds like it alone should prevent the crash. I'm going to submit them both, so if you could test them together. You're right, though, I think this should also

Re: GPF in keyring_destroy

Dmitry Vyukov wrote: > > Does the attached patch fix it for you? > > Yes, it fixes the crash for me. Can I put you down as a Tested-by? David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: GPF in keyring_destroy

Dmitry Vyukov wrote: > > Does the attached patch fix it for you? > > Yes, it fixes the crash for me. I have an additional patch to prevent keyrings from being constructed by request_key() at all (though it can still search for them). Could you give this a spin in addition

Re: GPF in keyring_destroy

Dmitry Vyukov wrote: > Yes, sure. Do I need to say something like: > > Tested-by: Dmitry Vyukov > > in future? That helps:-) David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: GPF in keyring_destroy

On Mon, Oct 19, 2015 at 12:33 PM, David Howells wrote: > Dmitry Vyukov wrote: > >> > Does the attached patch fix it for you? >> >> Yes, it fixes the crash for me. > > I have an additional patch to prevent keyrings from being constructed by > request_key()

Re: GPF in keyring_destroy

On Thu, Oct 15, 2015 at 9:21 PM, David Howells wrote: > Does the attached patch fix it for you? Yes, it fixes the crash for me. > David > --- > commit a7609e0bb3973d6ee3c9f1ecd0b6a382d99d6248 > Author: David Howells > Date: Thu Oct 15 17:21:37 2015

Re: GPF in keyring_destroy

On Mon, Oct 19, 2015 at 11:30 AM, David Howells wrote: > Dmitry Vyukov wrote: > >> > Does the attached patch fix it for you? >> >> Yes, it fixes the crash for me. > > Can I put you down as a Tested-by? > > David Yes, sure. Do I need to say something

Re: GPF in keyring_destroy

Does the attached patch fix it for you? David --- commit a7609e0bb3973d6ee3c9f1ecd0b6a382d99d6248 Author: David Howells Date: Thu Oct 15 17:21:37 2015 +0100 KEYS: Fix crash when attempt to garbage collect an uninstantiated keyring The following sequence of commands:

Re: GPF in keyring_destroy

Dmitry Vyukov wrote: > RAX: ff82 This is the value that matters. It would appear to be -ENOKEY and would be in key->type_data.reject_error, I think. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: GPF in keyring_destroy

Dmitry Vyukov wrote: > RAX: ff82 This is the value that matters. It would appear to be -ENOKEY and would be in key->type_data.reject_error, I think. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: GPF in keyring_destroy

Does the attached patch fix it for you? David --- commit a7609e0bb3973d6ee3c9f1ecd0b6a382d99d6248 Author: David Howells Date: Thu Oct 15 17:21:37 2015 +0100 KEYS: Fix crash when attempt to garbage collect an uninstantiated keyring The following sequence of

GPF in keyring_destroy

Hello, The following program crashes kernel: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include int main() { long r0 = syscall(SYS_mmap, 0x20001000ul, 0x1000ul, 0x3ul, 0x32ul, 0xul, 0x0ul); long r1 = syscall(SYS_mmap,

GPF in keyring_destroy

Hello, The following program crashes kernel: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include int main() { long r0 = syscall(SYS_mmap, 0x20001000ul, 0x1000ul, 0x3ul, 0x32ul, 0xul, 0x0ul); long r1 = syscall(SYS_mmap,