Re: Linux 4.10-rc4 compile error
On Mon, Nov 16 2020 at 15:32, Harald Arnesen wrote: > I get the following compile error, which reverting commit > ff828729be446b86957f7c294068758231cd2183 fixes (and the resulting kernel > boots fine). > CC drivers/iommu/intel/dmar.o > drivers/iommu/intel/dmar.c: In function 'vf_inherit_msi_domain': > drivers/iommu/intel/dmar.c:338:59: error: 'struct pci_dev' has no member > named 'physfn'; did you mean 'is_physfn'? > 338 | dev_set_msi_domain(&pdev->dev, > dev_get_msi_domain(&pdev->physfn->dev)); I queued a fix already: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=x86/urgent&id=8986f223bd777a73119f5d593c15b4d630ff49bb Sorry for the wreckage. Thanks, tglx
Linux 4.10-rc4 compile error
I get the following compile error, which reverting commit ff828729be446b86957f7c294068758231cd2183 fixes (and the resulting kernel boots fine). $ make ... CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h CHK kernel/kheaders_data.tar.xz CC drivers/iommu/intel/dmar.o drivers/iommu/intel/dmar.c: In function 'vf_inherit_msi_domain': drivers/iommu/intel/dmar.c:338:59: error: 'struct pci_dev' has no member named 'physfn'; did you mean 'is_physfn'? 338 | dev_set_msi_domain(&pdev->dev, dev_get_msi_domain(&pdev->physfn->dev)); | ^~ | is_physfn make[3]: *** [scripts/Makefile.build:283: drivers/iommu/intel/dmar.o] Error 1 make[2]: *** [scripts/Makefile.build:500: drivers/iommu/intel] Error 2 make[1]: *** [scripts/Makefile.build:500: drivers/iommu] Error 2 make: *** [Makefile:1799: drivers] Error 2 -- Hilsen Harald
[ANNOUNCE] linux-4.10-ck1 / MuQSS CPU scheduler 0.152
These are patches designed to improve system responsiveness and interactivity with specific emphasis on the desktop, but configurable for any workload. The patchset is mainly centred around the Multiple Queue Skiplist Scheduler, MuQSS. -ck1 patches: http://ck.kolivas.org/patches/4.0/4.10/4.10-ck1/ Git tree: https://github.com/ckolivas/linux/tree/4.10-ck Ubuntu 16.10 packages: http://ck.kolivas.org/patches/4.0/4.10/4.10-ck1/Ubuntu16.10/ Patch for those struggling with the nvidia driver and 4.10: http://ck.kolivas.org/patches/4.0/4.10/nvidia-375.39-linux-4.10.patch Full patch list: 0001-MuQSS-150-pre-merge.patch 0002-Remove-quick-ramp-up-which-may-have-been-keeping-CPU.patch 0003-Fix-iso-tick-calculation.patch 0004-Prevent-negative-value-causing-further-overflow-in-t.patch 0005-Demote-no-cpumask-message-to-info.patch 0006-Bump-muqss-version-to-0.152.patch 0007-Make-preemptible-kernel-default.patch 0008-Expose-vmsplit-option-for-our-poor-32bit-users.patch 0009-Implement-min-and-msec-hrtimeout-un-interruptible-sc.patch 0010-Special-case-calls-of-schedule_timeout-1-to-use-the-.patch 0011-Convert-msleep-to-use-hrtimers-when-active.patch 0012-Replace-all-schedule-timeout-1-with-schedule_min_hrt.patch 0013-Change-all-schedule_timeout-with-msecs_to_jiffies-po.patch 0014-Replace-all-calls-to-schedule_timeout_interruptible-.patch 0015-Replace-all-calls-to-schedule_timeout_uninterruptibl.patch 0016-Fix-build-for-disabled-highres-timers-with-hrtimeout.patch 0017-Make-hrtimer-granularity-and-minimum-hrtimeout-confi.patch 0018-Make-threaded-IRQs-optionally-the-default-which-can-.patch 0019-Reinstate-default-Hz-of-100-in-combination-with-MuQS.patch 0020-Don-t-use-hrtimer-overlay-when-pm_freezing-since-som.patch 0021-Make-writeback-throttling-default-enabled.patch 0022-Swap-sucks.patch 0023-BFQ-version-8.patch 0024-Make-BFQ-default-IO-scheduler.patch 0025-Add-ck1-version.patch For a brief description of each patch without trawling the git tree, each patch can be found as a quilt series here: http://ck.kolivas.org/patches/4.0/4.10/4.10-ck1/patches/ Hacking blog: http://ck-hack.blogspot.com/ Simple homepage: http://kernel.kolivas.org Enjoy! お楽しみ下さい -- -ck
Linux 4.10
So there it is, the final 4.10 release. It's been quiet since rc8, but we did end up fixing several small issues, so the extra week was all good. On the whole, 4.10 didn't end up as small as it initially looked. After the huge release that was 4.9, I expected things to be pretty quiet, but it ended up very much a fairly average release by modern kernel standards. So we have about 13,000 commits (not counting merges - that would be another 1200+ commits if you count those). The work is all over, obviously - the shortlog below is just the changes in the last week, since rc8. Go out and verify that it's all good, and I'll obviously start pulling stuff for 4.11 on Monday. Linus --- Al Viro (1): Fix missing sanity check in /dev/sg Alexei Starovoitov (1): bpf: introduce BPF_F_ALLOW_OVERRIDE flag Allen Hubbe (1): NTB: ntb_transport: fix debugfs_remove_recursive Andrey Konovalov (1): dccp: fix freeing skb too early for IPV6_RECVPKTINFO Andy Gross (1): ARM: multi_v7_defconfig: enable Qualcomm RPMCC Anoob Soman (1): packet: Do not call fanout_release from atomic contexts Anssi Hannula (3): mmc: core: fix multi-bit bus width without high-speed mode net: xilinx_emaclite: fix receive buffer overflow net: xilinx_emaclite: fix freezes due to unordered I/O Arnaldo Carvalho de Melo (1): MAINTAINERS: Remove old e-mail address Dan Carpenter (1): dpaa_eth: small leak on error Dave Jiang (2): ntb: ntb_perf missing dmaengine_unmap_put ntb: ntb_hw_intel: link_poll isn't clearing the pending status properly David S. Miller (2): rhashtable: Revert nested table changes. irda: Fix lockdep annotations in hashbin_delete(). Dmitry V. Levin (1): uapi: fix linux/if_pppol2tp.h userspace compilation errors Eric Dumazet (3): net/llc: avoid BUG_ON() in skb_orphan() packet: fix races in fanout_add() tcp: tcp_probe: use spin_lock_bh() Hans Verkuil (2): [media] videodev2.h: go back to limited range Y'CbCr for SRGB and, ADOBERGB [media] cec: initiator should be the same as the destination for, poll Herbert Xu (3): gfs2: Use rhashtable walk interface in glock_hash_walk tipc: Fix tipc_sk_reinit race conditions rhashtable: Add nested tables IHARA Hiroka (1): Input: elan_i2c - add ELAN0605 to the ACPI table Ivan Khoronzhuk (1): net: ethernet: ti: cpsw: fix cpsw assignment in resume Jarkko Nikula (1): Revert "i2c: designware: detect when dynamic tar update is possible" Jens Axboe (1): cfq-iosched: don't call wbt_disable_default() with IRQs disabled Jerome Brunet (1): reset: fix shared reset triggered_count decrement on error Johannes Thumshirn (1): scsi: don't BUG_ON() empty DMA transfers Jonathan T. Leighton (2): ipv6: Inhibit IPv4-mapped src address on the wire. ipv6: Handle IPv4-mapped src to in6addr_any dst. Kees Cook (2): ARM: 8657/1: uaccess: consistently check object sizes ARM: 8658/1: uaccess: fix zeroing of 64-bit get_user() Kirill A. Shutemov (1): x86/vm86: Fix unused variable warning if THP is disabled Linus Torvalds (2): Revert "nohz: Fix collision between tick and other hrtimers" Linux 4.10 Marcus Huewe (1): net: neigh: Fix netevent NETEVENT_DELAY_PROBE_TIME_UPDATE notification Mart van Santen (1): xen-netback: vif counters from int/long to u64 Mauro Carvalho Chehab (1): [media] siano: make it work again with CONFIG_VMAP_STACK Michel Dänzer (1): drm/radeon: Use mode h/vdisplay fields to hide out of bounds HW cursor Mike Galbraith (1): tick/broadcast: Prevent deadlock on tick_broadcast_lock Miklos Szeredi (2): fuse: fix uninitialized flags in pipe_buffer vfs: fix uninitialized flags in splice_to_pipe() Nathan Fontenot (2): ibmvnic: Initialize completion variables before starting work ibmvnic: Call napi_disable instead of napi_enable in failure path Or Gerlitz (1): net/mlx5e: Disable preemption when doing TC statistics upcall Paolo Abeni (1): vxlan: fix oops in dev_fill_metadata_dst Paul Mackerras (1): powerpc/64: Disable use of radix under a hypervisor Pierre-Louis Bossart (1): drm/dp/mst: fix kernel oops when turning off secondary monitor Ralf Baechle (1): NET: Fix /proc/net/arp for AX.25 Rui Sousa (1): net: fec: fix multicast filtering hardware setup Sahitya Tummala (1): fuse: fix use after free issue in fuse_dev_do_read() Sergey Senozhatsky (2): timekeeping: Use deferred printk() in debug code printk: use rcuidle console tracepoint Stephen Rothwell (1): bpf: kernel header files need to be copied into the tools directory Thomas Falcon (3): ibmvnic: Fix initial MTU settings ibmvnic: Fix endian error when requesting device capabilities ibmvnic: Fix
Re: Linux 4.10-rc8
> Not yet. This is my main machine, so it is slightly problematic. I > should be able to try tommorow. Ok. So fun thing number one: I press suspend button on keyboard, machine suspends but power light and fans are on. I hit power button, machine suspends. I hit it again, machine resumes. Second suspend works normally. Third suspend, have to press power button to make it suspend. Then the pattern breaks. I guess something is wrong in ACPI/EC land... I guess that may be well unrelated, but... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature
Re: Linux 4.10-rc8
On Sun 2017-02-12 14:40:04, Linus Torvalds wrote: > On Sun, Feb 12, 2017 at 2:32 PM, Pavel Machek wrote: > > > > I see some crazy stuff with v4.10-rc7 (and older). > > > > Like machine not booting from cold boot, needing ctrl-alt-del at boot, > > otherwise it changs during PCI quirks. > > I assume from your description that it's not repeatable enough to > bisect? But if you can bisect it even partially to narrow things down > a bit, that would be great. If it hangs, it seems to hang at one place (probably running pci quirks). So I guess next step is "enough printks to determine where it hangs...) > That said, one of the reverts in rc8 was a ioapic change that caused a > reported boot hang (just one person). Did you check rc8 already? I did now, and it is still broken. Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature
Re: Linux 4.10-rc8
On Sun 2017-02-12 14:40:04, Linus Torvalds wrote: > On Sun, Feb 12, 2017 at 2:32 PM, Pavel Machek wrote: > > > > I see some crazy stuff with v4.10-rc7 (and older). > > > > Like machine not booting from cold boot, needing ctrl-alt-del at boot, > > otherwise it changs during PCI quirks. > > I assume from your description that it's not repeatable enough to > bisect? But if you can bisect it even partially to narrow things down > a bit, that would be great. I tried "bisecting" but then it said "everything good" because I apparently powered machine down wrong way. > That said, one of the reverts in rc8 was a ioapic change that caused a > reported boot hang (just one person). Did you check rc8 already? Not yet. This is my main machine, so it is slightly problematic. I should be able to try tommorow. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature
Re: Linux 4.10-rc8
On Sun, Feb 12, 2017 at 2:32 PM, Pavel Machek wrote: > > I see some crazy stuff with v4.10-rc7 (and older). > > Like machine not booting from cold boot, needing ctrl-alt-del at boot, > otherwise it changs during PCI quirks. I assume from your description that it's not repeatable enough to bisect? But if you can bisect it even partially to narrow things down a bit, that would be great. That said, one of the reverts in rc8 was a ioapic change that caused a reported boot hang (just one person). Did you check rc8 already? Linus
Re: Linux 4.10-rc8
On Sun 2017-02-12 13:39:21, Linus Torvalds wrote: > Hey, it's another week, and I could have released the final 4.10. > > It's not been all that busy, although we did have a number of small > last-minute regression fixes (some just reverting stuff that caused > problems and needed more thought, others fixing things). But nothing > out of the ordinary, and I wouldn't have felt bad about just doing the > final release today. I see some crazy stuff with v4.10-rc7 (and older). Like machine not booting from cold boot, needing ctrl-alt-del at boot, otherwise it changs during PCI quirks. ...and then it went away. ...and now it came back, seems it depends on the way it was shut down, or length of power off. Plus suspend/resume does not seem to work all that well now. (It works well in v4.9 and before). Generic Intel desktop. If someone sees strange stuff, too, it would be good to know Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature
Linux 4.10-rc8
lice_read() udp: properly cope with csum errors l2tp: do not use udp_ioctl() Eyal Itkin (2): IB/rxe: Fix resid update IB/rxe: Fix mem_check_range integer overflow Fabio Estevam (1): ARM: dts: imx: Pass 'chosen' and 'memory' nodes Florian Fainelli (2): net: dsa: Do not destroy invalid network devices net: phy: Fix PHY module checks and NULL deref in phy_attach_direct() Frederic Weisbecker (1): tick/nohz: Fix possible missing clock reprog after tick soft restart Gary R Hook (2): crypto: ccp - Fix DMA operations when IOMMU is enabled crypto: ccp - Fix double add when creating new DMA command Giovanni Cabiddu (2): crypto: qat - fix bar discovery for c62x crypto: qat - zero esram only for DH85x devices Hangbin Liu (1): igmp, mld: Fix memory leak in igmpv3/mld_del_delrec() Hans Verkuil (3): [media] cec rst: remove "This API is not yet finalized" notice [media] cec-intro.rst: mention the v4l-utils package and CEC utilities [media] cec: fix wrong last_la determination Harsh Jain (4): crypto: chcr - Fix panic on dma_unmap_sg crypto: chcr - Check device is allocated before use crypto: algif_aead - Fix kernel panic on list_del crypto: chcr - Fix key length for RFC4106 Herbert Xu (1): crypto: aesni - Fix failure when pcbc module is absent Hugh Dickins (1): mm: fix KPF_SWAPCACHE in /proc/kpageflags Hui Wang (1): ALSA: hda - adding a new NV HDMI/DP codec ID in the driver J. Bruce Fields (1): nfsd: Revert "nfsd: special case truncates some more" Jan Kara (1): mm: avoid returning VM_FAULT_RETRY from ->page_mkwrite handlers Jani Nikula (1): drm/i915: don't warn about Skylake CPU - KabyPoint PCH combo Jean-Nicolas Graux (1): mmc: mmci: avoid clearing ST Micro busy end interrupt mistakenly Jeff Mahoney (1): btrfs: fix btrfs_compat_ioctl failures on non-compat ioctls Jerome Brunet (1): ARM64: dts: meson-gxbb-odroidc2: fix GbE tx link breakage Jouni Malinen (2): mac80211: Fix FILS AEAD protection in Association Request frame mac80211: Allocate a sync skcipher explicitly for FILS AEAD Juergen Gross (1): drm/i915: fix i915 running as dom0 under Xen Jurij Smakov (1): rtlwifi: rtl8192ce: Fix loading of incorrect firmware Kejian Yan (1): net: hns: Fix the device being used for dma mapping during TX Krister Johansen (1): perf callchain: Reference count maps Lee, Shawn C (1): drm/i915/bxt: Add MST support when do DPLL calculation Leon Romanovsky (1): RDMA: Don't reference kernel private header from UAPI header Linus Lüssing (1): ipv6: Fix IPv6 packet loss in scenarios involving roaming + snooping switches Linus Torvalds (2): Revert "x86/ioapic: Restore IO-APIC irq_chip retrigger callback" Linux 4.10-rc8 Ludovic Desroches (1): MAINTAINERS: change email address from atmel to microchip Luis R. Rodriguez (1): kernel/ucount.c: mark user_header with kmemleak_ignore() Mao Wenan (1): net: phy: Fix lack of reference count on PHY driver Marcelo Ricardo Leitner (1): sctp: avoid BUG_ON on sctp_wait_for_sndbuf Marcus Huewe (1): ipv6: addrconf: fix generation of new temporary addresses Markus Mayer (2): cpufreq: brcmstb-avs-cpufreq: extend sysfs entry brcm_avs_pmap cpufreq: brcmstb-avs-cpufreq: properly retrieve P-state upon suspend Martin KaFai Lau (2): mlx4: Fix memory leak after mlx4_en_update_priv() mlx4: xdp_prog becomes inactive after ethtool '-L' or '-G' Masashi Honma (1): nl80211: Fix mesh HT operation check Mauricio Faria de Oliveira (1): scsi: qla2xxx: Avoid that issuing a LIP triggers a kernel crash Michał Winiarski (1): drm/i915: Always convert incoming exec offsets to non-canonical Mike Snitzer (2): dm mpath: cleanup -Wbool-operation warning in choose_pgpath() dm rq: cope with DM device destruction while in dm_old_request_fn() Namhyung Kim (2): perf diff: Fix segfault on 'perf diff -o N' option perf diff: Fix -o/--order option behavior (again) Neil Armstrong (1): ARM64: dts: meson-gx: Add firmware reserved memory zones Nicholas Bellinger (5): target: Don't BUG_ON during NodeACL dynamic -> explicit conversion target: Use correct SCSI status during EXTENDED_COPY exception target: Fix early transport_generic_handle_tmr abort scenario target: Fix multi-session dynamic se_node_acl double free OOPs target: Fix COMPARE_AND_WRITE ref leak for non GOOD status Nicolas Ferre (1): MAINTAINERS: at91: change email address Omar Sandoval (2): stacktrace, lockdep: Fix address, newline ugliness Btrfs: fix btrfs_decompress_buf2page() Ondrej Kozina (1): dm crypt: replace RCU read-side section with rwsem Patrice Chotard (1):
Re: [Intel-gfx] [REGRESSION] Black screen after switching desktop session (was: Re: Linux 4.10-rc5)
Am Mittwoch, 1. Februar 2017, 14:11:22 CET schrieb David Weinehall: > On Wed, Jan 25, 2017 at 01:10:26PM +0100, Martin Steigerwald wrote: > > Am Sonntag, 22. Januar 2017, 13:32:08 CET schrieb Linus Torvalds: > > > Things seem to be calming down a bit, and everything looks nominal. > > > > > > There's only been about 250 changes (not counting merges) in the last > > > week, and the diffstat touches less than 300 files (with drivers and > > > architecture updates being the bulk, but there's tooling, networking > > > and filesystems in there too). > > > > > > So keep testing, and I think we'll have a regular release schedule. > > > > Testing this is no fun: > > > > Bug 99533 - black screen after switching session > > https://bugs.freedesktop.org/99533 > > > > > > This after GPU hang/lockups with Kernel 4.9 reported as for example: > > > > Bug 98922 - [snb] GPU hang on PlaneShift > > https://bugs.freedesktop.org/98922 > > > > Which may be a duplicate of #98747, #98794, #98860, #98891, #98288. > > > > > > I am back at kernel 4.8.15 as I need this machine for production work. > > > > Sometimes I wish for a microkernel that might be able to reincarnate > > drivers that hang or do wierd things like that. That may at least give a > > way to actually do some debugging or even get the desktop session back > > without loosing its state. Especially for graphics drivers and > > hibernating/resuming from hibernations which also occasionally fails – > > again without leaving a way to interact with the machine to do further > > debugging. Linux kernel usually just crashes completely, not even a ping > > or ssh possible, or it at least stuck with a black display without any > > way to restart the graphics driver cause it seems to be in some undefined > > state. Combined with occasionally happening bugs this makes triaging bugs > > time consuming and risky. I do like to help testing, but maybe its time > > to just switch to distro kernels and be done about it, as I regularily > > come across bugs that are too expensive for me to triage. > > > > Please understand that I am not willing to bisect these occasionally > > happening bugs with have the potential to cause data loss due to having > > to switch off the machine forcefully. Fortunately at least KMail saves a > > mail I write from time to time and also Kate does swap files. > > > > I am also a bit unwilling to do further debugging of this one as I usually > > use two sessions when I am at work and I risk loosing data I work on. > > But… at least with this issue it seems I would have a way to SSH into the > > machine before kicking it. > > > > > > I am dissatisfied with the state of the Intel graphics driver on this > > ThinkPad T520 with Sandybridge since kernel 4.9 and wonder whether you > > guys at Intel really test things with older hardware versions. > > Yes, we do. But for practical reasons we can only do testing for things > that we actually have testcases for, and obviously we don't have the > manpower to actually do *manual* testing on every platform, so issues > for older platforms that are only triggered by manual interaction tend > to slip under the radar. > > We have a testfarm that tests every nightly build on all platforms we > have test machines for. The testcases are publicly available here: > > https://cgit.freedesktop.org/xorg/app/intel-gpu-tools/ > > Obviously most of our manpower is spent on development and testing for > current and future platforms, so for issues that involve older platforms, > especially something as old as Sandybridge (which is, by now, 6 years old) > we are happy for help with testing and bisection. > > If the issues are specific to certain subsets of a platform it obviously > gets even more complex; it'd be a combinatorial nightmare to build a > testfarm that could test every variation of every platform. > > If I got the count right the i915 driver supports around a hundred > different varieties of Intel graphics; combine that with the number of > different displays people connect, the number of eDP display that the > vendors connect, the different BIOSes that vendors use, etc., and I > think you'll begin to see what we're combating) -- to make things even > more complex you can connect several displays to each graphics card > (possibly via adapters), displays that don't always meet the standards > that they claim to meet. Due to limited room we are also a bit limited > when it comes to testing with multi-monitor setups. > > This is why any help is welcome and sometimes even necessary. If you're > afraid of dataloss, be aware that it's possible to boot your system with > file systems mounted read-only; you could also boot from a USB-stick or > similar. > > If you can find a testcase in i-g-t that easily reproduces the issue > that'd also be very helpful. Do note that not all testcases in i-g-t > are run as part of our nightly tests, since some of them are *extremely* > time consuming; the full combinatorial
Re: Linux 4.10-rc7
On Mon, Feb 06, 2017 at 04:56:55PM -0800, Linus Torvalds wrote: > Christop, missing h :) > mind re-sending that patch with commit message and sign-off, > and I'll apply it. I'll resend it through the nfsd maintainer (Bruce).
Re: Linux 4.10-rc7
On Mon, Feb 6, 2017 at 4:22 PM, Dave Jones wrote: > On Mon, Feb 06, 2017 at 09:19:24AM +0100, Christoph Hellwig wrote: > > > > Double mnt_want_write, no idea why lockdep isn't reporting that for me. > > Fix below: > > Yep, seems to do the trick. > > Tested-by: Dave Jones Christop, mind re-sending that patch with commit message and sign-off, and I'll apply it. Or just send a git pull request, of course. Linus
Re: Linux 4.10-rc7
On Mon, Feb 06, 2017 at 09:19:24AM +0100, Christoph Hellwig wrote: > On Mon, Feb 06, 2017 at 01:00:32AM -0500, Dave Jones wrote: > > This one smells funny to me. > > Double mnt_want_write, no idea why lockdep isn't reporting that for me. > Fix below: Yep, seems to do the trick. Tested-by: Dave Jones
Re: Linux 4.10-rc7
On Mon, Feb 06, 2017 at 01:00:32AM -0500, Dave Jones wrote:
> This one smells funny to me.
Double mnt_want_write, no idea why lockdep isn't reporting that for me.
Fix below:
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index ca13236dbb1f..a974368026a1 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -359,11 +359,6 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp,
struct iattr *iap,
err = fh_verify(rqstp, fhp, ftype, accmode);
if (err)
return err;
- if (get_write_count) {
- host_err = fh_want_write(fhp);
- if (host_err)
- goto out_host_err;
- }
dentry = fhp->fh_dentry;
inode = d_inode(dentry);
@@ -416,6 +411,12 @@ nfsd_setattr(struct svc_rqst *rqstp, struct svc_fh *fhp,
struct iattr *iap,
iap->ia_valid |= ATTR_CTIME;
+ if (get_write_count) {
+ host_err = fh_want_write(fhp);
+ if (host_err)
+ goto out_host_err;
+ }
+
fh_lock(fhp);
host_err = notify_change(dentry, iap, NULL);
fh_unlock(fhp);
Re: Linux 4.10-rc7
Hi Linus, here in my environment I hit a pm/runtime problem. For people seeing this too, [1] has the fix "PM / runtime: Avoid false-positive warnings from might_sleep_if()". Just for the records. Regards, - Sedat - [1] http://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit/?h=linux-next&id=a9306a63631493afc75893a4ac405d4e1cbae6aa
Re: Linux 4.10-rc7
On Sun, Feb 05, 2017 at 03:41:54PM -0800, Linus Torvalds wrote:
> Hey, look at that - it's all been very quiet, and unless anything bad
> happens, we're all back to the regular schedule with this being the
> last rc.
..
> Christoph Hellwig (1):
> nfsd: special case truncates some more
This one smells funny to me.
[ 145.983182] =
[ 145.983201] [ INFO: possible recursive locking detected ]
[ 145.983220] 4.10.0-rc7+ #1 Not tainted
[ 145.983236] -
[ 145.984868] nfsd/865 is trying to acquire lock:
[ 145.986497] (sb_writers#7){.+.+.+}, at: []
mnt_want_write+0x25/0x50
[ 145.988153]
but task is already holding lock:
[ 145.991350] (sb_writers#7){.+.+.+}, at: []
mnt_want_write+0x25/0x50
[ 145.992931]
other info that might help us debug this:
[ 145.995991] Possible unsafe locking scenario:
[ 145.998936]CPU0
[ 146.000358]
[ 146.001749] lock(sb_writers#7);
[ 146.003109] lock(sb_writers#7);
[ 146.004431]
*** DEADLOCK ***
[ 146.008179] May be due to missing lock nesting notation
[ 146.010541] 1 lock held by nfsd/865:
[ 146.011681] #0: (sb_writers#7){.+.+.+}, at: []
mnt_want_write+0x25/0x50
[ 146.012820]
stack backtrace:
[ 146.015033] CPU: 0 PID: 865 Comm: nfsd Not tainted 4.10.0-rc7+ #1
[ 146.016147] Call Trace:
[ 146.017225] dump_stack+0x68/0xa0
[ 146.018273] __lock_acquire+0x6ea/0x11d0
[ 146.019251] ? trace_hardirqs_on_caller+0xef/0x1b0
[ 146.020119] lock_acquire+0x109/0x270
[ 146.020957] ? mnt_want_write+0x25/0x50
[ 146.021770] __sb_start_write+0xd8/0x230
[ 146.022555] ? mnt_want_write+0x25/0x50
[ 146.023313] ? nfsd_permission+0x7f/0x110
[ 146.024042] mnt_want_write+0x25/0x50
[ 146.024745] vfs_truncate+0x4e/0x200
[ 146.025421] nfsd_setattr+0x13a/0x300
[ 146.026070] nfsd4_setattr+0x109/0x130
[ 146.026690] nfsd4_proc_compound+0x443/0x6e0
[ 146.027286] nfsd_dispatch+0x91/0x170
[ 146.027853] svc_process+0x6e6/0xa00
[ 146.028393] nfsd+0x193/0x2a0
[ 146.028903] ? nfsd+0x5/0x2a0
[ 146.029448] kthread+0x111/0x150
[ 146.029964] ? nfsd_destroy+0x190/0x190
[ 146.030474] ? __kthread_create_on_node+0x250/0x250
[ 146.030988] ret_from_fork+0x2e/0x40
I'll double check that it's that commit in the morning, but nfs+truncate seems
to point
in this direction..
Dave
Linux 4.10-rc7
o_signal_on_read() Dimitris Michailidis (2): ipv6: fix flow labels when the traffic class is non-0 net: fix ndo_features_check/ndo_fix_features comment ordering Douglas Miller (1): percpu-refcount: fix reference leak during percpu-atomic transition Eric Dumazet (2): can: Fix kernel panic at security_sock_rcv_skb tcp: fix 0 divide in __tcp_select_window() Eric Farman (1): scsi: virtio_scsi: Reject commands when virtqueue is broken Gabriel Krisman Bertazi (1): mmc: sdhci: Ignore unexpected CARD_INT interrupts Gal Pressman (2): net/mlx5e: Modify TIRs hash only when it's needed net/mlx5e: Fix update of hash function/key via ethtool Gavin Shan (1): powerpc/eeh: Fix wrong flag passed to eeh_unfreeze_pe() Hadar Hen Zion (1): net/mlx5e: Support TC encapsulation offloads with upper devices Halil Pasic (1): vhost: fix initialization for vq->is_le Iago Abal (1): dmaengine: pl330: fix double lock Ilia Mirkin (1): drm/nouveau/nv1a,nv1f/disp: fix memory clock rate retrieval Ivan Vecera (1): be2net: fix initial MAC setting J. Bruce Fields (1): svcrpc: fix oops in absence of krb5 module Jack Morgenstein (1): net/mlx4_core: Avoid command timeouts during VF driver device shutdown Jason Gerecke (1): HID: wacom: Fix poor prox handling in 'wacom_pl_irq' Jens Axboe (1): iwlwifi: fix kernel crash when unregistering thermal zone Jiri Kosina (1): x86/efi: Always map the first physical page into the EFI pagetables Jiri Slaby (1): objtool: Fix IRET's opcode Jisheng Zhang (1): pinctrl: berlin-bg4ct: fix the value for "sd1a" of pin SCRD0_CRD_PRES Johan Hovold (2): HID: cp2112: fix sleep-while-atomic HID: cp2112: fix gpio-callback error handling Johannes Berg (1): iwlwifi: mvm: avoid crash on restart w/o reserved queues John Brooks (1): iio: dht11: Use usleep_range instead of msleep for start signal Jürg Billeter (1): iwlwifi: fix double hyphen in MODULE_FIRMWARE for 8000 Kalle Valo (1): MAINTAINERS: ath9k-devel is closed Kevin Hao (1): x86/fpu: Set the xcomp_bv when we fake up a XSAVES area Kinglong Mee (1): NFSD: Fix a null reference case in find_or_create_lock_stateid() Kirill A. Shutemov (1): shmem: fix sleeping from atomic context Liam R. Howlett (2): sparc64: Zero pages on allocation for mondo and error queues. sparc64: Handle PIO & MEM non-resumable errors. Linus Torvalds (1): Linux 4.10-rc7 Luis R. Rodriguez (1): firmware: fix NULL pointer dereference in __fw_load_abort() Lukáš Lalinský (1): USB: Add quirk for WORLDE easykey.25 MIDI keyboard Maarten Lankhorst (2): drm/atomic: Fix double free in drm_atomic_state_default_clear drm/atomic: Unconditionally call prepare_fb. Manuel Lauss (1): Input: wm97xx - make missing platform data non-fatal Marc Zyngier (1): irqdomain: Avoid activating interrupts more than once Marcel J.E. Mol (1): USB: serial: pl2303: add ATEN device ID Mark Rutland (1): regulator: fixed: Revert support for ACPI interface Martin Peres (1): drm/nouveau/nouveau/led: prevent compiling the led-code if nouveau=y and leds=m Matt Ranostay (1): iio: health: max30100: fixed parenthesis around FIFO count check Max Filippov (1): xtensa: fix noMMU build on cores with MMU Maxime Ripard (1): pinctrl: sunxi: Don't enforce bias disable (for now) Michael Ellerman (2): powerpc: Revert the initial stack protector support powerpc: Fix build failure with clang due to BUILD_BUG_ON() Michael S. Tsirkin (1): Revert "vring: Force use of DMA API for ARM-based systems with legacy devices" Michal Hocko (2): fs: break out of iomap_file_buffered_write on fatal signals mm, fs: check for fatal signals in do_generic_file_read() Michel Dänzer (1): drm/radeon: Fix vram_size/visible values in DRM_RADEON_GEM_INFO ioctl Mike Kravetz (1): sparc: use symbolic names for tsb indexing Moshe Shemesh (1): net/mlx5e: Check ets capability before ets query FW command Oliver Hartkopp (1): can: bcm: fix hrtimer/tasklet termination in bcm op removal Or Gerlitz (4): net/mlx5: Change ENOTSUPP to EOPNOTSUPP net/mlx5: Return EOPNOTSUPP when failing to get steering name-space net/mlx5: E-Switch, Err when retrieving steering name-space fails net/mlx5: E-Switch, Re-enable RoCE on mode change only after FDB destroy Pavel Belous (1): net: ethtool: add support for 2500BaseT and 5000BaseT link modes Peter Zijlstra (3): perf/core: Fix use-after-free bug perf/core: Fix PERF_RECORD_MMAP2 prot/flags for anonymous memory kasan: respect /proc/sys/kernel/traceoff_on_warning Rabin Vincent (1): cifs: initialize file_info_lock Radim Krčmář (1): KVM: x86: do not save guest-unsupported XSAVE state
Re: [Intel-gfx] [REGRESSION] Black screen after switching desktop session (was: Re: Linux 4.10-rc5)
On Wed, Jan 25, 2017 at 01:10:26PM +0100, Martin Steigerwald wrote: > Am Sonntag, 22. Januar 2017, 13:32:08 CET schrieb Linus Torvalds: > > Things seem to be calming down a bit, and everything looks nominal. > > > > There's only been about 250 changes (not counting merges) in the last > > week, and the diffstat touches less than 300 files (with drivers and > > architecture updates being the bulk, but there's tooling, networking > > and filesystems in there too). > > > > So keep testing, and I think we'll have a regular release schedule. > > Testing this is no fun: > > Bug 99533 - black screen after switching session > https://bugs.freedesktop.org/99533 > > > This after GPU hang/lockups with Kernel 4.9 reported as for example: > > Bug 98922 - [snb] GPU hang on PlaneShift > https://bugs.freedesktop.org/98922 > > Which may be a duplicate of #98747, #98794, #98860, #98891, #98288. > > > I am back at kernel 4.8.15 as I need this machine for production work. > > Sometimes I wish for a microkernel that might be able to reincarnate drivers > that hang or do wierd things like that. That may at least give a way to > actually do some debugging or even get the desktop session back without > loosing its state. Especially for graphics drivers and hibernating/resuming > from hibernations which also occasionally fails – again without leaving a way > to interact with the machine to do further debugging. Linux kernel usually > just crashes completely, not even a ping or ssh possible, or it at least > stuck > with a black display without any way to restart the graphics driver cause it > seems to be in some undefined state. Combined with occasionally happening > bugs > this makes triaging bugs time consuming and risky. I do like to help testing, > but maybe its time to just switch to distro kernels and be done about it, as > I > regularily come across bugs that are too expensive for me to triage. > > Please understand that I am not willing to bisect these occasionally > happening > bugs with have the potential to cause data loss due to having to switch off > the machine forcefully. Fortunately at least KMail saves a mail I write from > time to time and also Kate does swap files. > > I am also a bit unwilling to do further debugging of this one as I usually > use > two sessions when I am at work and I risk loosing data I work on. But… at > least with this issue it seems I would have a way to SSH into the machine > before kicking it. > > > I am dissatisfied with the state of the Intel graphics driver on this > ThinkPad > T520 with Sandybridge since kernel 4.9 and wonder whether you guys at Intel > really test things with older hardware versions. Yes, we do. But for practical reasons we can only do testing for things that we actually have testcases for, and obviously we don't have the manpower to actually do *manual* testing on every platform, so issues for older platforms that are only triggered by manual interaction tend to slip under the radar. We have a testfarm that tests every nightly build on all platforms we have test machines for. The testcases are publicly available here: https://cgit.freedesktop.org/xorg/app/intel-gpu-tools/ Obviously most of our manpower is spent on development and testing for current and future platforms, so for issues that involve older platforms, especially something as old as Sandybridge (which is, by now, 6 years old) we are happy for help with testing and bisection. If the issues are specific to certain subsets of a platform it obviously gets even more complex; it'd be a combinatorial nightmare to build a testfarm that could test every variation of every platform. If I got the count right the i915 driver supports around a hundred different varieties of Intel graphics; combine that with the number of different displays people connect, the number of eDP display that the vendors connect, the different BIOSes that vendors use, etc., and I think you'll begin to see what we're combating) -- to make things even more complex you can connect several displays to each graphics card (possibly via adapters), displays that don't always meet the standards that they claim to meet. Due to limited room we are also a bit limited when it comes to testing with multi-monitor setups. This is why any help is welcome and sometimes even necessary. If you're afraid of dataloss, be aware that it's possible to boot your system with file systems mounted read-only; you could also boot from a USB-stick or similar. If you can find a testcase in i-g-t that easily reproduces the issue that'd also be very helpful. Do note that not all testcases in i-g-t are run as part of our nightly tests, since some of them are *extremely* time consuming; the full combinatorial testcase, for instance, can take weeks or months--I haven't done a full run recently--to complete. I hope this helps you understand why bugs can slip under the radar, and why a bisect is so important. Kind regards, Davi
Linux 4.10-rc6
ax()
Fabian Frederick (1):
Documentation/filesystems/proc.txt: add VmPin
Fabio Estevam (1):
Revert "thermal: thermal_hwmon: Convert to
hwmon_device_register_with_info()"
Flora Cui (1):
drm/amdgpu: fix vm_fault_stop on gfx6
Florian Fainelli (3):
net: phy: Avoid deadlock during phy_error()
net: dsa: Check return value of phy_connect_direct()
net: dsa: Bring back device detaching in dsa_slave_suspend()
Florian Westphal (2):
netfilter: conntrack: remove GC_MAX_EVICTS break
netfilter: conntrack: refine gc worker heuristics, redux
Francisco Jerez (1):
drm/i915: Remove WaDisableLSQCROPERFforOCL KBL workaround.
Gao Pan (1):
i2c: imx-lpi2c: add VLLS mode support
Geert Uytterhoeven (3):
net: phy: leds: Clear phy_num_led_triggers on failure to avoid crash
net: phy: leds: Break dependency of phy.h on phy_led_triggers.h
net: phy: leds: Fix truncated LED trigger names
Gerd Hoffmann (3):
drm/virtio: fix framebuffer sparse warning
drm: update MAINTAINERS for qemu drivers (bochs, cirrus, qxl, virtio-gpu)
drm: flip cirrus driver status to "obsolete".
Greg Kurz (1):
vfio/spapr: fail tce_iommu_attach_group() when iommu_data is null
Gustavo Padovan (1):
drm/fence: fix memory overwrite when setting out_fence fd
Hans Verkuil (7):
[media] cec: fix report_current_latency
[media] cec: when canceling a message, don't overwrite old status info
[media] cec: CEC_MSG_GIVE_FEATURES should abort for CEC version < 2
[media] cec: update log_addr[] before finishing configuration
[media] cec: replace cec_report_features by cec_fill_msg_report_features
[media] cec: move cec_report_phys_addr into cec_config_thread_func
[media] cec: fix race between configuring and unconfiguring
Hans de Goede (1):
Revert "ACPI / video: Add force_native quirk for HP Pavilion dv6"
Hariprasad Shenai (1):
MAINTAINERS: update cxgb4 maintainer
Helge Deller (2):
parisc, parport_gsc: Fixes for printk continuation lines
parisc: Don't use BITS_PER_LONG in userspace-exported swab.h header
Ido Schimmel (1):
mlxsw: spectrum_router: Correctly reallocate adjacency entries
Igor Druzhinin (2):
xen-netback: fix memory leaks on XenBus disconnect
xen-netback: protect resource cleaning on XenBus disconnect
Israel Rukshin (2):
IB/srp: fix mr allocation when the device supports sg gaps
IB/srp: fix invalid indirect_sg_entries parameter value
Ivan Vecera (1):
bridge: netlink: call br_changelink() during br_dev_newlink()
Jack Morgenstein (1):
RDMA/cma: Fix unknown symbol when CONFIG_IPV6 is not enabled
Jakub Kicinski (1):
virtio_net: reject XDP programs using header adjustment
James Smart (1):
nvmet_fc: correct logic in disconnect queue LS handling
Jan Beulich (2):
xen-blkfront: feature flags handling adjustments
xen-blkfront: correct maximum segment accounting
Jason Baron (1):
tcp: correct memory barrier usage in tcp_check_space()
Jason Wang (1):
virtio-net: restore VIRTIO_HDR_F_DATA_VALID on receiving
Jesper Dangaard Brouer (1):
bpf: fix samples xdp_tx_iptunnel and tc_l2_redirect with fake
KBUILD_MODNAME
Jike Song (5):
drm/i915/gvt: init/destroy vgpu_idr properly
drm/i915/gvt: destroy the allocated idr on vgpu creating failures
drm/i915/gvt: cleanup opregion memory allocation code
drm/i915/gvt/kvmgt: return meaningful error for vgpu creating failure
drm/i915/gvt: cleanup GFP flags
Jingju Hou (1):
net: phy: marvell: Add Wake from LAN support for 88E1510 PHY
Jiri Slaby (1):
kernel/panic.c: add missing \n
Johannes Berg (1):
mac80211: don't try to sleep in rate_control_rate_init()
John Crispin (2):
Documentation: devicetree: change the mediatek ethernet compatible string
net-next: ethernet: mediatek: change the compatible string
John Fastabend (1):
virtio_net: use dev_kfree_skb for small buffer XDP receive
Julia Lawall (1):
stmmac: add missing of_node_put
Kazuya Mizuguchi (1):
ravb: unmap descriptors when freeing rings
Kees Cook (1):
fbdev: color map copying bounds checking
Kefeng Wang (1):
ipv6: addrconf: Avoid addrconf_disable_change() using RCU read-side lock
Kenneth Lee (1):
IB/umem: Release pid in error and ODP flow
Keno Fischer (1):
mm/huge_memory.c: respect FOLL_FORCE/FOLL_COW for thp
Kinglong Mee (1):
SUNRPC: cleanup ida information when removing sunrpc module
Lance Richardson (1):
vxlan: fix byte order of vxlan-gpe port number
Laurent Pinchart (3):
[media] v4l: tvp5150: Reset device at probe time, not in get/set
format handlers
[media] v4l: tvp5150: Fix comment regarding output pin muxing
[media] v4l: tvp5150: Don't override output pinmuxing at stream
on/off time
Lendacky, Thomas (2):
amd-xgbe: Add a hardware quirk for re
[REGRESSION] Black screen after switching desktop session (was: Re: Linux 4.10-rc5)
Am Sonntag, 22. Januar 2017, 13:32:08 CET schrieb Linus Torvalds: > Things seem to be calming down a bit, and everything looks nominal. > > There's only been about 250 changes (not counting merges) in the last > week, and the diffstat touches less than 300 files (with drivers and > architecture updates being the bulk, but there's tooling, networking > and filesystems in there too). > > So keep testing, and I think we'll have a regular release schedule. Testing this is no fun: Bug 99533 - black screen after switching session https://bugs.freedesktop.org/99533 This after GPU hang/lockups with Kernel 4.9 reported as for example: Bug 98922 - [snb] GPU hang on PlaneShift https://bugs.freedesktop.org/98922 Which may be a duplicate of #98747, #98794, #98860, #98891, #98288. I am back at kernel 4.8.15 as I need this machine for production work. Sometimes I wish for a microkernel that might be able to reincarnate drivers that hang or do wierd things like that. That may at least give a way to actually do some debugging or even get the desktop session back without loosing its state. Especially for graphics drivers and hibernating/resuming from hibernations which also occasionally fails – again without leaving a way to interact with the machine to do further debugging. Linux kernel usually just crashes completely, not even a ping or ssh possible, or it at least stuck with a black display without any way to restart the graphics driver cause it seems to be in some undefined state. Combined with occasionally happening bugs this makes triaging bugs time consuming and risky. I do like to help testing, but maybe its time to just switch to distro kernels and be done about it, as I regularily come across bugs that are too expensive for me to triage. Please understand that I am not willing to bisect these occasionally happening bugs with have the potential to cause data loss due to having to switch off the machine forcefully. Fortunately at least KMail saves a mail I write from time to time and also Kate does swap files. I am also a bit unwilling to do further debugging of this one as I usually use two sessions when I am at work and I risk loosing data I work on. But… at least with this issue it seems I would have a way to SSH into the machine before kicking it. I am dissatisfied with the state of the Intel graphics driver on this ThinkPad T520 with Sandybridge since kernel 4.9 and wonder whether you guys at Intel really test things with older hardware versions. Thanks, -- Martin
Re: linux-4.10-rc5/drivers/char/xilinx_hwicap/buffer_icap.c: 2 * pointless local variables ?
On 23.1.2017 12:39, David Binderman wrote: > > Hello there, > > [linux-4.10-rc5/drivers/char/xilinx_hwicap/buffer_icap.c:301]: (style) > Variable 'num_writes' is modified but its new value is never used. > [linux-4.10-rc5/drivers/char/xilinx_hwicap/buffer_icap.c:356]: (style) > Variable 'read_count' is modified but its new value is never used. > > Suggest either use these local variables in some way or delete them. > I have sent patch which removes them. Thanks, Michal
Linux 4.10-rc5
suspending if we're in gadget mode
Jon Mason (1):
ARM: dts: NSP: Fix DT ranges error
Joonyoung Shim (1):
clocksource/exynos_mct: Clear interrupt when cpu is shut down
Josef Bacik (1):
nbd: only set MSG_MORE when we have more to send
Karicheri, Muralidharan (1):
net: phy: dp83867: allow RGMII_TXID/RGMII_RXID interface types
Kazuya Mizuguchi (1):
ravb: Remove Rx overflow log messages
Keith Busch (1):
blk-mq: Remove unused variable
Kevin Hilman (1):
spi: davinci: use dma_mapping_error()
Krzysztof Kozlowski (2):
MAINTAINERS: Add Patchwork URL to Samsung Exynos entry
ARM: s3c2410_defconfig: Fix invalid values for NF_CT_PROTO_*
Lance Richardson (1):
openvswitch: maintain correct checksum state in conntrack actions
Larry Finger (1):
taint/module: Fix problems when out-of-kernel driver defines true or false
Leo Yan (1):
usb: dwc2: use u32 for DT binding parameters
Linus Torvalds (1):
Linux 4.10-rc5
Linus Walleij (1):
ARM: 8613/1: Fix the uaccess crash on PB11MPCore
Lokesh Vutla (1):
ARM: dts: am335x-icev2: Remove the duplicated pinmux setting
Madhavan Srinivasan (3):
powerpc/perf: Fix PM_BRU_CMPL event code for power9
selftest/powerpc: Wrong PMC initialized in pmc56_overflow test
powerpc/perf: Use MSR to report privilege level on P9 DD1
Marc Gonzalez (2):
mtd: nand: tango: Update DT binding description
mtd: nand: tango: Reset pbus to raw mode in probe
Marc Zyngier (2):
KVM: arm/arm64: vgic: Fix deadlock on error handling
PCI/MSI: pci-xgene-msi: Fix CPU hotplug registration handling
Marek Szyprowski (1):
clk/samsung: exynos542x: mark some clocks as critical
Mark Rutland (2):
ARM: 8634/1: hw_breakpoint: blacklist Scorpion CPUs
arm64: avoid returning from bad_mode
Martynas Pumputis (1):
vxlan: Set ports in flow key when doing route lookups
Masahiro Yamada (1):
ARM, ARM64: dts: drop "arm,amba-bus" in favor of "simple-bus" part 3
Masami Hiramatsu (3):
perf probe: Fix to show correct locations for events on modules
perf probe: Add error checks to offline probe post-processing
perf probe: Fix to probe on gcc generated functions in modules
Masaru Nagai (1):
ravb: do not use zero-length alignment DMA descriptor
Mathias Nyman (1):
xhci: remove WARN_ON if dma mask is not set for platform devices
Michal Kazior (1):
mac80211: prevent skb/txq mismatch
Michal Simek (1):
ARM64: zynqmp: Fix W=1 dtc 1.4 warnings
Milan P. Gandhi (1):
scsi: qla2xxx: Get mutex lock before checking optrom_state
Milo Kim (1):
ARM: dts: sun8i: Support DTB build for NanoPi M1
Moritz Fischer (1):
ARM64: zynqmp: Fix i2c node's compatible string
Murali Karicheri (1):
PCI: designware: Check for iATU unroll only on platforms that use ATU
Neil Armstrong (1):
ARM64: dts: meson-gxbb-odroidc2: Disable SCPI DVFS
Nicholas Mc Guire (1):
usb: dwc2: host: fix Wmaybe-uninitialized warning
Nicholas Piggin (1):
powerpc: Fix pgtable pmd cache init
Nicolas Dichtel (1):
ARM: put types.h in uapi
Nikita Yushchenko (1):
swiotlb: ensure that page-sized mappings are page-aligned
Oleksandr Andrushchenko (1):
arm64: mm: avoid name clash in __page_to_voff()
Parthasarathy Bhuvaragan (1):
tipc: allocate user memory with GFP_KERNEL flag
Paul E. McKenney (2):
rcu: Remove cond_resched() from Tiny synchronize_sched()
rcu: Narrow early boot window of illegal synchronous grace periods
Peter Rosin (1):
ubifs: fix unencrypted journal write
Peter Ujfalusi (1):
ARM: OMAP1: DMA: Correct the number of logical channels
Phil Reid (1):
spi: dw: Make debugfs name unique between instances
Pierre Morel (1):
virtio/s390: support READ_STATUS command for virtio-ccw
Quinn Tran (7):
qla2xxx: Fix wrong IOCB type assumption
qla2xxx: Collect additional information to debug fw dump
qla2xxx: Fix crash due to null pointer access
qla2xxx: Terminate exchange if corrupted
qla2xxx: Reduce exess wait during chip reset
qla2xxx: Fix erroneous invalid handle message
qla2xxx: Disable out-of-order processing by default in firmware
Rabin Vincent (1):
ARM: 8632/1: ftrace: fix syscall name matching
Randy Dunlap (1):
mtd: nand: oxnas_nand: fix build errors on arch/um, require HAS_IOMEM
Reza Arbab (1):
powerpc/mm: Fix memory hotplug BUG() on radix
Richard Weinberger (1):
ubifs: Fix journal replay wrt. xattr nodes
Roberto Sassu (1):
scsi: lpfc: avoid double free of resource identifiers
Ruslan Ruslichenko (1):
x86/ioapic: Restore IO-APIC irq_chip retrigger callback
Russell King (1):
MAINTAINERS: update rmk's entries
Scott Mayhew (1):
sunrpc: don't call sleeping functions from the notifier block callbacks
Sedat Dilek (1):
perf/x86/amd/ibs: Fix t
Re: Linux 4.10-rc2 arm: dmesg flooded with alloc_contig_range: [X, Y) PFNs busy
On 01/18/2017 01:23 AM, Shuah Khan wrote: > Hi, > > dmesg floods with PFNs busy messages. > > [10119.071455] alloc_contig_range: [bb900, bbc00) PFNs busy > [10119.071631] alloc_contig_range: [bba00, bbd00) PFNs busy > [10119.071762] alloc_contig_range: [bbb00, bbe00) PFNs busy > [10119.071940] alloc_contig_range: [bbc00, bbf00) PFNs busy > [10119.072039] alloc_contig_range: [bbd00, bc000) PFNs busy > [10119.072188] alloc_contig_range: [bbe00, bc100) PFNs busy > [10119.072301] alloc_contig_range: [bbf00, bc200) PFNs busy > [10119.072403] alloc_contig_range: [bc000, bc300) PFNs busy > [10119.072549] alloc_contig_range: [bc100, bc400) PFNs busy > [10119.072584] [drm:exynos_drm_gem_create] *ERROR* failed to allocate buffer. > > I think this is triggered when drm tries to allocate CMA buffers. > I might have seen one or two messages in 4.9, but since 4.10, it > just floods dmesg. > > Is this a known problem? I am seeing this on odroid-xu4 Hi, yes most likely it's the problem fixed by this patch in mmotm/linux-next: http://ozlabs.org/~akpm/mmots/broken-out/mm-alloc_contig-re-allow-cma-to-compact-fs-pages.patch > Linux odroid 4.10.0-rc2-00251-ge03c755-dirty #12 SMP PREEMPT > Wed Jan 11 23:12:52 UTC 2017 armv7l armv7l armv7l GNU/Linux > > thanks, > -- Shuah >
Linux 4.10-rc2 arm: dmesg flooded with alloc_contig_range: [X, Y) PFNs busy
Hi, dmesg floods with PFNs busy messages. [10119.071455] alloc_contig_range: [bb900, bbc00) PFNs busy [10119.071631] alloc_contig_range: [bba00, bbd00) PFNs busy [10119.071762] alloc_contig_range: [bbb00, bbe00) PFNs busy [10119.071940] alloc_contig_range: [bbc00, bbf00) PFNs busy [10119.072039] alloc_contig_range: [bbd00, bc000) PFNs busy [10119.072188] alloc_contig_range: [bbe00, bc100) PFNs busy [10119.072301] alloc_contig_range: [bbf00, bc200) PFNs busy [10119.072403] alloc_contig_range: [bc000, bc300) PFNs busy [10119.072549] alloc_contig_range: [bc100, bc400) PFNs busy [10119.072584] [drm:exynos_drm_gem_create] *ERROR* failed to allocate buffer. I think this is triggered when drm tries to allocate CMA buffers. I might have seen one or two messages in 4.9, but since 4.10, it just floods dmesg. Is this a known problem? I am seeing this on odroid-xu4 Linux odroid 4.10.0-rc2-00251-ge03c755-dirty #12 SMP PREEMPT Wed Jan 11 23:12:52 UTC 2017 armv7l armv7l armv7l GNU/Linux thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shua...@osg.samsung.com
Linux 4.10-rc4
irk at probe time too Hadar Hen Zion (1): net/mlx5e: Fix kbuild warnings for uninitialized parameters Herbert Xu (4): crypto: aesni - Fix failure when built-in with modular pcbc gro: Enter slow-path if there is no tailroom gro: Disable frag0 optimization on IPv6 ext headers Revert "tty: serial: 8250: add CON_CONSDEV to flags" Huang Shijie (1): arm64: hugetlb: fix the wrong return value for huge_ptep_set_access_flags Ivan Vecera (2): be2net: fix accesses to unicast list be2net: fix unicast list filling JackieLiu (1): md/raid5-cache: removes unnecessary write-through mode judgments Jamie Iles (1): signal: protect SIGNAL_UNKILLABLE from unintentional clearing. Jan Kara (1): xfs: Timely free truncated dirty pages Jean Delvare (2): dmaengine: dw: fix typo in Kconfig net: phy: Add Meson GXL PHY hardware dependency Jeeja KP (1): ASoC: Intel: Skylake: Release FW ctx in cleanup Jeff Mahoney (2): btrfs: fix error handling when run_delayed_extent_op fails btrfs: fix locking when we put back a delayed ref that's too new Jeff Moyer (1): nbd: blk_mq_init_queue returns an error code on failure, not NULL Jes Sorensen (1): md/raid5: Use correct IS_ERR() variation on pointer check Jike Song (2): capability: export has_capability vfio iommu type1: fix the testing of capability for remote task Jiri Kosina (1): HID: ignore Petzl USB headlamp Jiri Olsa (5): tools lib subcmd: Add OPT_STRING_OPTARG_SET option perf record: Make __record_options static perf record: Fix --switch-output documentation and comment perf/x86/intel: Account interrupts for PEBS errors perf/x86: Reject non sampling events with precise_ip Johan Hovold (9): USB: serial: ch341: fix initial modem-control state USB: serial: ch341: fix open and resume after B0 USB: serial: ch341: fix modem-control and B0 handling USB: serial: ch341: fix open error handling USB: serial: ch341: fix resume after reset USB: serial: ch341: fix line settings after reset-resume USB: serial: ch341: fix baud rate and line-control handling USB: serial: kl5kusb105: fix line-state error handling USB: serial: ch341: fix control-message error handling Johannes Berg (1): nl80211: fix sched scan netlink socket owner destruction John Garry (1): i2c: print correct device invalid address John Hsu (2): ASoC: nau8825: correct the function name of register ASoC: nau8825: fix invalid configuration in Pre-Scalar of FLL John Sperbeck (1): mm/slab.c: fix SLAB freelist randomization duplicate entries Jordan Crouse (3): drm/msm: Ensure that the hardware write pointer is valid drm/msm: Put back the vaddr in submit_reloc() drm/msm: Verify that MSM_SUBMIT_BO_FLAGS are set Jose Abreu (1): ASoC: dwc: Fix PIO mode initialization Josh Poimboeuf (4): x86/unwind: Silence warnings for non-current tasks x86/unwind: Disable KASAN checks for non-current tasks x86/unwind: Include __schedule() in stack traces x86/entry: Fix the end of the stack for newly forked tasks Julian Wiedmann (1): net/af_iucv: don't use paged skbs for TX on HiperSockets Junichi Nomura (2): x86/microcode/intel: Fix allocation size of struct ucode_patch x86/microcode/intel: Use correct buffer size for saving microcode data Junwei Zhang (3): drm/amd/amdgpu: add Polaris12 support (v3) drm/amdgpu/powerplay: add Polaris12 support drm/amd/amdgpu: add Polaris12 PCI ID Krister Johansen (1): dmaengine: iota: ioat_alloc_chan_resources should not perform sleeping allocations. Kweh, Hock Leong (1): net: stmmac: fix maxmtu assignment to be within valid range Larry Finger (1): rtlwifi: rtl_usb: Fix missing entry in USB driver's private data Laurent Pinchart (1): drm: Clean up planes in atomic commit helper failure path Len Brown (1): x86/tsc: Add the Intel Denverton Processor to native_calibrate_tsc() Lendacky, Thomas (1): amd-xgbe: Fix IRQ processing when running in single IRQ mode Linus Torvalds (1): Linux 4.10-rc4 Liu Bo (5): Btrfs: use down_read_nested to make lockdep silent Btrfs: fix lockdep warning about log_mutex Btrfs: adjust outstanding_extents counter properly when dio write is split Btrfs: add 'inode' for extent map tracepoint Btrfs: add truncated_len for ordered extent tracepoints Loic Pallardy (2): rpmsg: virtio_rpmsg_bus: fix channel creation remoteproc: fix vdev reference management Lukasz Odzioba (1): x86/cpu: Fix bootup crashes by sanitizing the argument of the 'clearcpuid=' command-line option M'boumba Cedric Madianga (2): dmaengine: stm32-dma: Set correct args number for DMA request from DT dmaengine: stm32-dma: Fix null pointer derefere
RE: Dell XPS13 does not suspend with Linux 4.10-rc3
>
> On 01/11/17 10:49, Winkler, Tomas wrote:
>
> >> Subject: Re: Dell XPS13 does not suspend with Linux 4.10-rc3
> >>
> >> On 01/11/17 10:36, Greg Kroah-Hartman wrote:
> >>> On Wed, Jan 11, 2017 at 09:53:38AM +0100, Paul Menzel wrote:
> >>
> >>>> On 01/10/17 23:24, Jan Niehusmann wrote:
> >>>>> On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
> >>>>>> And I bisected the issue to commit 7279b238ba, "mei: send OS type
> >>>>>> to the FW"
> >>>>>
> >>>>> Indeed, just disabling the FIXUP implemented by that commit fixes
> >>>>> suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
> >>>>>
> >>>>> (For the addressees newly added to cc, it seems like the mentioned
> >>>>> commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
> >>>>>
> >>>>> --- a/drivers/misc/mei/bus-fixup.c
> >>>>> +++ b/drivers/misc/mei/bus-fixup.c
> >>>>> @@ -406,3 +406,3 @@ static struct mei_fixup {
> >>>>> MEI_FIXUP(MEI_UUID_WD, mei_wd),
> >>>>> - MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> >>>>> +// MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> >>>>> };
> >>>>>
> >>>>>
> >>>>> I don't know what this may break, as the description of 7279b23
> >>>>> just
> >>>>> says:
> >>>>> "This workaround was added to support other broken OS and we need
> >>>>> to follow here."
> >>>>>
> >>>>> Unless there is a better justification, I think the commit should
> >>>>> be reverted, for now.
> >>>>
> >>>> Somebody else already created the bug 192051 in the Linux Kernel
> >>>> Bug Tracker [1].
> >>>
> >>> There's a fix for this in my tree to go to Linus for 4.10-rc4.
> >>
> >> Yes, Tomas referenced it in the bug report. I test it on the Dell
> >> XPS13
> >> (9360) now.
>
> As written elsewhere, the issue on the Dell XPS13 seems to be a different
> issue.
> (No idea, which message I should have replied to.) I have to run, and won't
> have access to the machine until Monday, so here is as far as I got.
>
> ```
> $ git bisect log
> git bisect start
> # good: [69973b830859bc6529a7a0468ba0d80ee5117826] Linux 4.9 git bisect
> good 69973b830859bc6529a7a0468ba0d80ee5117826
> # good: [69973b830859bc6529a7a0468ba0d80ee5117826] Linux 4.9 git bisect
> good 69973b830859bc6529a7a0468ba0d80ee5117826
> # bad: [a121103c922847ba5010819a3f250f1f7fc84ab8] Linux 4.10-rc3 git bisect
> bad a121103c922847ba5010819a3f250f1f7fc84ab8
> # bad: [72cca7baf4fba777b8ab770b902cf2e08941773f] Merge tag 'staging-
> 4.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging
> git bisect bad 72cca7baf4fba777b8ab770b902cf2e08941773f
> # good: [b8d2798f32785398fcd1c48ea80c0c6c5ab88537] Merge tag 'clk-for-
> linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux
> git bisect good b8d2798f32785398fcd1c48ea80c0c6c5ab88537
> # good: [9439b3710df688d853eb6cb4851256f2c92b1797] Merge tag 'drm-for-
> v4.10' of git://people.freedesktop.org/~airlied/linux
> git bisect good 9439b3710df688d853eb6cb4851256f2c92b1797
> ```
Can you please hattach your .config as well
Thanks
Tomas
Re: Dell XPS13 does not suspend with Linux 4.10-rc3
On 01/11/17 10:49, Winkler, Tomas wrote:
Subject: Re: Dell XPS13 does not suspend with Linux 4.10-rc3
On 01/11/17 10:36, Greg Kroah-Hartman wrote:
On Wed, Jan 11, 2017 at 09:53:38AM +0100, Paul Menzel wrote:
On 01/10/17 23:24, Jan Niehusmann wrote:
On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
And I bisected the issue to commit 7279b238ba, "mei: send OS type
to the FW"
Indeed, just disabling the FIXUP implemented by that commit fixes
suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
(For the addressees newly added to cc, it seems like the mentioned
commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
--- a/drivers/misc/mei/bus-fixup.c
+++ b/drivers/misc/mei/bus-fixup.c
@@ -406,3 +406,3 @@ static struct mei_fixup {
MEI_FIXUP(MEI_UUID_WD, mei_wd),
- MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
+// MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
};
I don't know what this may break, as the description of 7279b23 just
says:
"This workaround was added to support other broken OS and we need to
follow here."
Unless there is a better justification, I think the commit should be
reverted, for now.
Somebody else already created the bug 192051 in the Linux Kernel Bug
Tracker [1].
There's a fix for this in my tree to go to Linus for 4.10-rc4.
Yes, Tomas referenced it in the bug report. I test it on the Dell XPS13
(9360) now.
As written elsewhere, the issue on the Dell XPS13 seems to be a
different issue. (No idea, which message I should have replied to.) I
have to run, and won’t have access to the machine until Monday, so here
is as far as I got.
```
$ git bisect log
git bisect start
# good: [69973b830859bc6529a7a0468ba0d80ee5117826] Linux 4.9
git bisect good 69973b830859bc6529a7a0468ba0d80ee5117826
# good: [69973b830859bc6529a7a0468ba0d80ee5117826] Linux 4.9
git bisect good 69973b830859bc6529a7a0468ba0d80ee5117826
# bad: [a121103c922847ba5010819a3f250f1f7fc84ab8] Linux 4.10-rc3
git bisect bad a121103c922847ba5010819a3f250f1f7fc84ab8
# bad: [72cca7baf4fba777b8ab770b902cf2e08941773f] Merge tag
'staging-4.10-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging
git bisect bad 72cca7baf4fba777b8ab770b902cf2e08941773f
# good: [b8d2798f32785398fcd1c48ea80c0c6c5ab88537] Merge tag
'clk-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux
git bisect good b8d2798f32785398fcd1c48ea80c0c6c5ab88537
# good: [9439b3710df688d853eb6cb4851256f2c92b1797] Merge tag
'drm-for-v4.10' of git://people.freedesktop.org/~airlied/linux
git bisect good 9439b3710df688d853eb6cb4851256f2c92b1797
```
[…]
Kind regards,
Paul
RE: Dell XPS13 does not suspend with Linux 4.10-rc3
> Subject: Re: Dell XPS13 does not suspend with Linux 4.10-rc3
>
> On 01/11/17 10:36, Greg Kroah-Hartman wrote:
> > On Wed, Jan 11, 2017 at 09:53:38AM +0100, Paul Menzel wrote:
>
> >> On 01/10/17 23:24, Jan Niehusmann wrote:
> >>> On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
> >>>> And I bisected the issue to commit 7279b238ba, "mei: send OS type
> >>>> to the FW"
> >>>
> >>> Indeed, just disabling the FIXUP implemented by that commit fixes
> >>> suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
> >>>
> >>> (For the addressees newly added to cc, it seems like the mentioned
> >>> commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
> >>>
> >>> --- a/drivers/misc/mei/bus-fixup.c
> >>> +++ b/drivers/misc/mei/bus-fixup.c
> >>> @@ -406,3 +406,3 @@ static struct mei_fixup {
> >>> MEI_FIXUP(MEI_UUID_WD, mei_wd),
> >>> - MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> >>> +// MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> >>> };
> >>>
> >>>
> >>> I don't know what this may break, as the description of 7279b23 just
> >>> says:
> >>> "This workaround was added to support other broken OS and we need to
> >>> follow here."
> >>>
> >>> Unless there is a better justification, I think the commit should be
> >>> reverted, for now.
> >>
> >> Somebody else already created the bug 192051 in the Linux Kernel Bug
> >> Tracker [1].
> >
> > There's a fix for this in my tree to go to Linus for 4.10-rc4.
>
> Yes, Tomas referenced it in the bug report. I test it on the Dell XPS13
> (9360) now.
>
> I would have liked if it mentioned suspend issues, and the known broken
> devices in the commit message. That way, I would have found the commit
> more easily.
Yep, I should probably add that info about the suspend issue, but looks like
we broke the whole gen of older devices so we cannot list all of them :(
Tomas
Re: Dell XPS13 does not suspend with Linux 4.10-rc3
On 01/11/17 10:36, Greg Kroah-Hartman wrote:
On Wed, Jan 11, 2017 at 09:53:38AM +0100, Paul Menzel wrote:
On 01/10/17 23:24, Jan Niehusmann wrote:
On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
FW"
Indeed, just disabling the FIXUP implemented by that commit fixes
suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
(For the addressees newly added to cc, it seems like the mentioned
commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
--- a/drivers/misc/mei/bus-fixup.c
+++ b/drivers/misc/mei/bus-fixup.c
@@ -406,3 +406,3 @@ static struct mei_fixup {
MEI_FIXUP(MEI_UUID_WD, mei_wd),
- MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
+// MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
};
I don't know what this may break, as the description of 7279b23 just
says:
"This workaround was added to support other broken OS and we need to
follow here."
Unless there is a better justification, I think the commit should be
reverted, for now.
Somebody else already created the bug 192051 in the Linux Kernel Bug Tracker
[1].
There's a fix for this in my tree to go to Linus for 4.10-rc4.
Yes, Tomas referenced it in the bug report. I test it on the Dell XPS13
(9360) now.
I would have liked if it mentioned suspend issues, and the known broken
devices in the commit message. That way, I would have found the commit
more easily.
Kind regards,
Paul
Re: Dell XPS13 does not suspend with Linux 4.10-rc3
On Wed, Jan 11, 2017 at 09:53:38AM +0100, Paul Menzel wrote:
> Dear Linux folks,
>
>
> On 01/10/17 23:24, Jan Niehusmann wrote:
> > On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
> > > And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
> > > FW"
> >
> > Indeed, just disabling the FIXUP implemented by that commit fixes
> > suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
> >
> > (For the addressees newly added to cc, it seems like the mentioned
> > commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
> >
> > --- a/drivers/misc/mei/bus-fixup.c
> > +++ b/drivers/misc/mei/bus-fixup.c
> > @@ -406,3 +406,3 @@ static struct mei_fixup {
> > MEI_FIXUP(MEI_UUID_WD, mei_wd),
> > - MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> > +// MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> > };
> >
> >
> > I don't know what this may break, as the description of 7279b23 just
> > says:
> > "This workaround was added to support other broken OS and we need to
> > follow here."
> >
> > Unless there is a better justification, I think the commit should be
> > reverted, for now.
>
> Somebody else already created the bug 192051 in the Linux Kernel Bug Tracker
> [1].
There's a fix for this in my tree to go to Linus for 4.10-rc4.
thanks,
greg k-h
Re: Dell XPS13 does not suspend with Linux 4.10-rc3
Dear Linux folks,
On 01/10/17 23:24, Jan Niehusmann wrote:
On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
FW"
Indeed, just disabling the FIXUP implemented by that commit fixes
suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
(For the addressees newly added to cc, it seems like the mentioned
commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
--- a/drivers/misc/mei/bus-fixup.c
+++ b/drivers/misc/mei/bus-fixup.c
@@ -406,3 +406,3 @@ static struct mei_fixup {
MEI_FIXUP(MEI_UUID_WD, mei_wd),
- MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
+// MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
};
I don't know what this may break, as the description of 7279b23 just
says:
"This workaround was added to support other broken OS and we need to
follow here."
Unless there is a better justification, I think the commit should be
reverted, for now.
Somebody else already created the bug 192051 in the Linux Kernel Bug
Tracker [1].
Kind regards,
Paul
[1] https://bugzilla.kernel.org/show_bug.cgi?id=192051
"[Bug 192051] [bisected] No hibernation/suspend/shutdown after
commit 7279b238badec09efd0545293e64c21feee97f73"
Re: Dell XPS13 does not suspend with Linux 4.10-rc3
On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
> And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
> FW"
Indeed, just disabling the FIXUP implemented by that commit fixes
suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
(For the addressees newly added to cc, it seems like the mentioned
commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
--- a/drivers/misc/mei/bus-fixup.c
+++ b/drivers/misc/mei/bus-fixup.c
@@ -406,3 +406,3 @@ static struct mei_fixup {
MEI_FIXUP(MEI_UUID_WD, mei_wd),
- MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
+// MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
};
I don't know what this may break, as the description of 7279b23 just
says:
"This workaround was added to support other broken OS and we need to
follow here."
Unless there is a better justification, I think the commit should be
reverted, for now.
Jan
Re: Dell XPS13 does not suspend with Linux 4.10-rc3
Hi,
On Tue, Jan 10, 2017 at 03:08:32PM +0100, Paul Menzel wrote:
> Testing Linux 4.10-rc{1,2,3} the Dell XPS13 does not suspend with the
> attached configuration. The screen turns black, but the power button never
> goes dark. The white light stays always on.
Same here.
And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
FW"
Suspending from the console with no_console_suspend shows that the last
message is "e1000e: EEE TX LPI TIMER: " (which is probably
unrelated).
More interesting is the first message missing, ie. the one after the one
mentioned when using a working kernel: "ACPI : EC: event blocked".
This seems to be related to the bisected commit. Maybe it's not even the
kernel's fault, but the EC just happens to change it's behavior when it
got told about the OS type, before?
Jan
Re: Dell XPS13 does not suspend with Linux 4.10-rc3
Lo! Paul Menzel wrote on 10.01.2017 15:08:
>
> Testing Linux 4.10-rc{1,2,3} the Dell XPS13 does not suspend with the
> attached configuration.
During quick tests I saw similar problems with the Fedora rawhide
configuration in 4.10-rc{1,2} (haven't tried rc3/mainline yet). My free
time was extremely limited in the past few weeks as I was traveling
(often without the machine), hence I couldn't look closer into it yet
(sorry, I nevertheless should have reported it).
> The screen turns black, but the power button
> never goes dark. The white light stays always on.
>
> Pressing the power button also does not turn the system back on. Holding
> it for a long time, like ten seconds, sometimes the screen is shown for
> a quick moment, but then it seems to „suspend“ again, at least the
> screen goes dark. I am unable to log in, and debug.
Same here.
Did you try to check if the machine is still reachable via ssh (it looks
like it might) and if there is anything helpful in dmesg? That's on my
todo list.
> [...]
Ciao, knurd
Linux 4.10-rc3
TSI ARM: dts: omap3: Add an empty chosen node to top level DTSI ARM: dts: omap4: Add an empty chosen node to top level DTSI ARM: dts: omap5: Add an empty chosen node to top level DTSI ARM: dts: am33xx: Add an empty chosen node to top level DTSI ARM: dts: am4372: Add an empty chosen node to top level DTSI ARM: dts: dm814x: Add an empty chosen node to top level DTSI ARM: dts: dm816x: Add an empty chosen node to top level DTSI ARM: dts: dra7: Add an empty chosen node to top level DTSI Jeff Moyer (1): block: fix up io_poll documentation Jiandi An (1): Xen: ARM: Zero reserved fields of xatp before making hypervisor call Jike Song (4): drm/i915/gvt/kvmgt: dereference the pointer within lock drm/i915/gvt/kvmgt: check returned slot for gfn drm/i915/gvt/kvmgt: prevent double-release of vgpu drm/i915/gvt/kvmgt: trival: code cleanup Johan Hovold (27): net: stmmac: dwmac-oxnas: fix of-node leak net: stmmac: dwmac-oxnas: fix fixed-link-phydev leaks net: stmmac: dwmac-oxnas: use generic pm implementation USB: serial: cyberjack: fix NULL-deref at open USB: serial: garmin_gps: fix memory leak on failed URB submit USB: serial: io_edgeport: fix NULL-deref at open USB: serial: io_ti: fix NULL-deref at open USB: serial: io_ti: fix another NULL-deref at open USB: serial: io_ti: fix I/O after disconnect USB: serial: io_ti: bind to interface after fw download USB: serial: iuu_phoenix: fix NULL-deref at open USB: serial: keyspan_pda: verify endpoints at probe USB: serial: kobil_sct: fix NULL-deref in write USB: serial: mos7720: fix NULL-deref at open USB: serial: mos7720: fix use-after-free on probe errors USB: serial: mos7720: fix parport use-after-free on probe errors USB: serial: mos7720: fix parallel probe USB: serial: mos7720: remove obsolete port initialisation USB: serial: mos7840: fix NULL-deref at open USB: serial: mos7840: remove unused write URB USB: serial: mos7840: fix misleading interrupt-URB comment USB: serial: omninet: fix NULL-derefs at open and disconnect USB: serial: oti6858: fix NULL-deref at open USB: serial: pl2303: fix NULL-deref at open USB: serial: quatech2: fix sleep-while-atomic in close USB: serial: spcp8x5: fix NULL-deref at open USB: serial: ti_usb_3410_5052: fix NULL-deref at open Johannes Berg (1): mac80211: initialize fast-xmit 'info' later Johannes Thumshirn (1): nvme/fc: simplify error handling of nvme_fc_create_hw_io_queues Johannes Weiner (1): mm: workingset: fix use-after-free in shadow node shrinker John Youn (1): usb: dwc3: pci: Add "linux,sysdev_is_parent" property Jon Derrick (1): genhd: remove dead and duplicated scsi code Juergen Gross (3): xen: xenbus driver must not accept invalid transaction ids xen: return xenstore command failures via response instead of rc xen: remove stale xs_input_avail() from header Jérémy Lefaure (2): usb: musb: fix compilation warning on unused function usb: musb: blackfin: add bfin_fifo_offset in bfin_ops Kees Cook (2): latent_entropy: fix ARM build error on earlier gcc gcc-plugins: update gcc-common.h for gcc-7 Keith Busch (2): nvme: simplify stripe quirk nvme/pci: Delete misleading queue-wrap comment Kevin Hilman (2): ARM64: dts: meson-gxl: fix GPIO include ARM64: defconfig: enable DRM_MESON as module Kishon Vijay Abraham I (1): ARM: dts: am572x-idk: Add gpios property to control PCIE_RESETn Konrad Rzeszutek Wilk (1): swiotlb: Export swiotlb_max_segment to users Krzysztof Kozlowski (1): ARM: Drop fixed 200 Hz timer requirement from Samsung platforms Krzysztof Opasiak (1): usb: gadget: composite: Test get_alt() presence instead of set_alt() Leon Romanovsky (1): net/mlx4: Remove BUG_ON from ICM allocation routine Linus Torvalds (1): Linux 4.10-rc3 Linus Walleij (1): iio: accel: st_accel: fix LIS3LV02 reading and scaling Lokesh Vutla (1): ARM: dts: dra72-evm-tps65917: Add voltage supplies to usb_phy, mmc, dss Lorenzo Bianconi (1): iio: common: st_sensors: fix channel data parsing Lorenzo Pieralisi (1): ACPI: Drop misplaced acpi_dma_deconfigure() call from acpi_bind_one() Lu Baolu (3): usb: xhci: fix return value of xhci_setup_device() usb: xhci: fix possible wild pointer usb: xhci: hold lock over xhci_abort_cmd_ring() Lv Zheng (1): ACPI / sysfs: Provide quirk mechanism to prevent GPE flooding Madalin Bucur (1): dpaa_eth: cleanup after init_phy() failure Maninder Singh (1): ARM: omap2+: fixing wrong strcat for Non-NULL terminated string Maor Gottlieb (2): net/mlx5: Mask destination mac value in ethtool steering rules net/mlx5: Release FTE lock in error flow Marcel H
Linux 4.10-rc2
Hey, it's been a really slow week between Christmas Day and New Years Day, and I am not complaining at all. It does mean that rc2 is ridiculously and unrealistically small. I almost decided to skip rc2 entirely, but a small little meaningless release every once in a while never hurt anybody. So here it is. The only even remotely noticeable work here is the DAX fixups that really arguably should have been merge window material but depended on stuff during this merge window and were delayed until rc2 due to that. Even that wasn't big, and the rest is trivial small fixes. I'm expecting things to start picking up next week as people recover from the holidays. Linus --- Al Viro (1): arm64: don't pull uaccess.h into *.S Chun-Hao Lin (1): r8169: add support for RTL8168 series add-on card. Cihangir Akturk (1): Documentation/unaligned-memory-access.txt: fix incorrect comparison operator Daniel Borkmann (1): net, sched: fix soft lockup in tc_classify Eric Dumazet (1): ipvlan: fix various issues in ipvlan_process_multicast() Florian Fainelli (1): net: korina: Fix NAPI versus resources freeing Haishuang Yan (1): ipv4: Namespaceify tcp_tw_reuse knob Jan Kara (6): ext2: Return BH_New buffers for zeroed blocks mm: Invalidate DAX radix tree entries only if appropriate dax: Avoid page invalidation races and unnecessary radix tree traversals dax: Finish fault completely when loading holes dax: Call ->iomap_begin without entry lock during dax fault ext4: Simplify DAX fault path Jason Wang (1): net: xdp: remove unused bfp_warn_invalid_xdp_buffer() John Brooks (1): docs: Fix build failure Jon Paul Maloy (1): tipc: don't send FIN message from connectionless socket Kweh, Hock Leong (1): net: stmmac: fix incorrect bit set in gmac4 mdio addr register Laura Abbott (1): crypto: testmgr - Use heap buffer for acomp test input Linus Torvalds (2): mm: optimize PageWaiters bit use for unlock_page() Linux 4.10-rc2 Mahesh Bandewar (1): ipvlan: fix multicast processing Olof Johansson (1): mm/filemap: fix parameters to test_bit() Romain Perier (1): crypto: marvell - Copy IVDIG before launching partial DMA ahash requests Tariq Toukan (1): net/mlx4_en: Fix user prio field in XDP forward Thomas Gleixner (2): smp/hotplug: Undo tglxs brainfart x86/mce/AMD: Make the init code more robust pravin shelar (1): openvswitch: upcall: Fix vlan handling.
Re: Linux 4.10-rc1
On Mon, Dec 26, 2016 at 02:23:43PM +, Al Viro wrote:
> On Mon, Dec 26, 2016 at 05:45:10PM +0800, Hanjun Guo wrote:
> > On 2016/12/26 17:18, Al Viro wrote:
> > > On Mon, Dec 26, 2016 at 05:05:37PM +0800, Kefeng Wang wrote:
> > >> It looks like we need revert the changes from assembly files.
> >
> > I tested Kefeng's patch and works. more comments below.
> >
> > > Better yet, split the damn thing in two and include the asm-only part.
> >
> > split will cause other places for building errors, because there is no
> >
> > -#ifndef __ASSEMBLY__
>
> Huh? It's included only from assembler files, so what would use the other
> parts?
FWIW, my arguments for splitting it are
* asm and non-asm parts have almost no overlap - only
uaccess_{en,dis}able_not_uao (as asm macro and static inline
resp.), but that's it. It's not as if there had been arseloads of
constants shared between C and assembler, etc.
* having no asm/uaccess.h includes left allows to consolidate stuff
into linux/uaccess.h; sure, in this case the stuff getting moved there would be
under ifndef anyway, but "no includes outside of linux/uaccess.h" is easier
to verify than "no includes outside of linux/uaccess.h and arch/arm64/.../*.S"
I can live with reverting those several includes to asm/uaccess.h (all
interesting stuff is under that ifndef), but I think splitting the asm
part away would be cleaner.
PS: if that variant does cause any build errors, I would very much like to
see .config. Hanjun, could you post one that is triggering those?
Re: Linux 4.10-rc1
On Mon, Dec 26, 2016 at 05:45:10PM +0800, Hanjun Guo wrote: > On 2016/12/26 17:18, Al Viro wrote: > > On Mon, Dec 26, 2016 at 05:05:37PM +0800, Kefeng Wang wrote: > >> It looks like we need revert the changes from assembly files. > > I tested Kefeng's patch and works. more comments below. > > > Better yet, split the damn thing in two and include the asm-only part. > > split will cause other places for building errors, because there is no > > -#ifndef __ASSEMBLY__ Huh? It's included only from assembler files, so what would use the other parts?
linux-next: stats (Was: Linux 4.10-rc1)
Hi All, On Sun, 25 Dec 2016 16:41:46 -0800 Linus Torvalds wrote: > > It's Christmas Day, and it's two weeks since the merge window opened. > Thus, the merge window is now closed. As usual, the executive friendly graph is at http://neuling.org/linux-next-size.html :-) (No merge commits counted, next-20161212 was the first linux-next after the merge window opened.) Commits in v4.10-rc1 (relative to v4.9): 11455 Commits in next-20161212: 10625 Commits with the same SHA1: 9927 Commits with the same patch_id: 437 (1) Commits with the same subject line: 25 (1) (1) not counting those in the lines above. So commits in -rc1 that were in next-20161212: 10389 90% Some breakdown of the list of extra commits (relative to next-20161212) in -rc1: Top ten first word of commit summary: 153 ib 64 drm 46 x86 38 i40iw 34 net 33 s390 33 input 30 ubifs 27 perf 26 btrfs Top ten authors: 32 t...@linutronix.de 27 rich...@nod.at 26 bart.vanass...@sandisk.com 22 henry.oro...@intel.com 20 l...@kernel.org 19 je...@suse.com 18 m...@redhat.com 18 idryo...@gmail.com 15 trond.mykleb...@primarydata.com 13 vinod.k...@intel.com Top ten commiters: 225 dledf...@redhat.com 115 da...@davemloft.net 63 t...@linutronix.de 34 torva...@linux-foundation.org 34 m...@redhat.com 33 schwidef...@de.ibm.com 33 a...@redhat.com 32 idryo...@gmail.com 32 dmitry.torok...@gmail.com 31 rich...@nod.at There are also 236 commits in next-20161212 that didn't make it into v4.10-rc1. Top ten first word of commit summary: 24 arm 21 rcu 9 keys 9 coresight 9 btrfs 8 vfs 8 torture 8 thermal 6 mm 6 bf609 Top ten authors: 24 paul...@linux.vnet.ibm.com 15 mszer...@redhat.com 14 a...@linux-foundation.org 11 o...@lixom.net 11 dhowe...@redhat.com 10 v...@zeniv.linux.org.uk 8 wangxg.f...@cn.fujitsu.com 6 vitalyw...@gmail.com 6 colin.k...@canonical.com 5 sonic.zh...@analog.com Some of Andrew's patches are fixes for other patches in his tree (and have been merged into those). Top ten commiters: 39 s...@canb.auug.org.au 36 paul...@linux.vnet.ibm.com 16 steven@ubuntu-virtualbox.(none) 15 mszer...@redhat.com 13 o...@lixom.net 11 dhowe...@redhat.com 10 v...@zeniv.linux.org.uk 10 edubez...@gmail.com 9 mathieu.poir...@linaro.org 9 dste...@suse.com Those commits by me are from the quilt series (mainly Andrew's mmotm tree). Turns out that steven@ubuntu-virtualbox.(none) is Steven Miao and all those commits are old stuff left over in the blackfin tree since March, 2016 - it would be nice if they were cleaned up. -- Cheers, Stephen Rothwell
Re: Linux 4.10-rc1
On 2016/12/26 17:18, Al Viro wrote: > On Mon, Dec 26, 2016 at 05:05:37PM +0800, Kefeng Wang wrote: >> It looks like we need revert the changes from assembly files. I tested Kefeng's patch and works. more comments below. > Better yet, split the damn thing in two and include the asm-only part. split will cause other places for building errors, because there is no -#ifndef __ASSEMBLY__ in the file. > >> diff --git a/arch/arm64/mm/cache.S b/arch/arm64/mm/cache.S >> diff --git a/arch/arm64/xen/hypercall.S b/arch/arm64/xen/hypercall.S > Missed those two... OK, how about this? > > arm64: don't pull uaccess.h into *.S > > Split asm-only parts of arm64 uaccess.h into a new header and use that > from *.S. > > Signed-off-by: Al Viro > > diff --git a/arch/arm64/include/asm/asm-uaccess.h > b/arch/arm64/include/asm/asm-uaccess.h > new file mode 100644 > index ..df411f3e083c > --- /dev/null > +++ b/arch/arm64/include/asm/asm-uaccess.h > @@ -0,0 +1,65 @@ > +#ifndef __ASM_ASM_UACCESS_H > +#define __ASM_ASM_UACCESS_H > + > +#include > +#include > +#include > +#include > + > +/* > + * User access enabling/disabling macros. > + */ > +#ifdef CONFIG_ARM64_SW_TTBR0_PAN > + .macro __uaccess_ttbr0_disable, tmp1 > + mrs \tmp1, ttbr1_el1// swapper_pg_dir > + add \tmp1, \tmp1, #SWAPPER_DIR_SIZE // reserved_ttbr0 at the end of > swapper_pg_dir > + msr ttbr0_el1, \tmp1// set reserved TTBR0_EL1 > + isb > + .endm > + > + .macro __uaccess_ttbr0_enable, tmp1 > + get_thread_info \tmp1 > + ldr \tmp1, [\tmp1, #TSK_TI_TTBR0] // load saved TTBR0_EL1 > + msr ttbr0_el1, \tmp1// set the non-PAN TTBR0_EL1 > + isb > + .endm > + > + .macro uaccess_ttbr0_disable, tmp1 > +alternative_if_not ARM64_HAS_PAN > + __uaccess_ttbr0_disable \tmp1 > +alternative_else_nop_endif > + .endm > + > + .macro uaccess_ttbr0_enable, tmp1, tmp2 > +alternative_if_not ARM64_HAS_PAN > + save_and_disable_irq \tmp2 // avoid preemption > + __uaccess_ttbr0_enable \tmp1 > + restore_irq \tmp2 > +alternative_else_nop_endif > + .endm > +#else > + .macro uaccess_ttbr0_disable, tmp1 > + .endm > + > + .macro uaccess_ttbr0_enable, tmp1, tmp2 > + .endm > +#endif > + > +/* > + * These macros are no-ops when UAO is present. > + */ > + .macro uaccess_disable_not_uao, tmp1 > + uaccess_ttbr0_disable \tmp1 > +alternative_if ARM64_ALT_PAN_NOT_UAO > + SET_PSTATE_PAN(1) > +alternative_else_nop_endif > + .endm > + > + .macro uaccess_enable_not_uao, tmp1, tmp2 > + uaccess_ttbr0_enable \tmp1, \tmp2 > +alternative_if ARM64_ALT_PAN_NOT_UAO > + SET_PSTATE_PAN(0) > +alternative_else_nop_endif > + .endm > + > +#endif > diff --git a/arch/arm64/include/asm/uaccess.h > b/arch/arm64/include/asm/uaccess.h > index d26750ca6e06..46da3ea638bb 100644 > --- a/arch/arm64/include/asm/uaccess.h > +++ b/arch/arm64/include/asm/uaccess.h > @@ -22,8 +22,6 @@ > #include > #include > > -#ifndef __ASSEMBLY__ > - > /* > * User space memory access functions > */ > @@ -424,66 +422,4 @@ extern long strncpy_from_user(char *dest, const char > __user *src, long count); > extern __must_check long strlen_user(const char __user *str); > extern __must_check long strnlen_user(const char __user *str, long n); > > -#else/* __ASSEMBLY__ */ > - > -#include > - > -/* > - * User access enabling/disabling macros. > - */ > -#ifdef CONFIG_ARM64_SW_TTBR0_PAN > - .macro __uaccess_ttbr0_disable, tmp1 > - mrs \tmp1, ttbr1_el1// swapper_pg_dir > - add \tmp1, \tmp1, #SWAPPER_DIR_SIZE // reserved_ttbr0 at the end of > swapper_pg_dir > - msr ttbr0_el1, \tmp1// set reserved TTBR0_EL1 > - isb > - .endm > - > - .macro __uaccess_ttbr0_enable, tmp1 > - get_thread_info \tmp1 > - ldr \tmp1, [\tmp1, #TSK_TI_TTBR0] // load saved TTBR0_EL1 > - msr ttbr0_el1, \tmp1// set the non-PAN TTBR0_EL1 > - isb > - .endm > - > - .macro uaccess_ttbr0_disable, tmp1 > -alternative_if_not ARM64_HAS_PAN > - __uaccess_ttbr0_disable \tmp1 > -alternative_else_nop_endif > - .endm > - > - .macro uaccess_ttbr0_enable, tmp1, tmp2 > -alternative_if_not ARM64_HAS_PAN > - save_and_disable_irq \tmp2 // avoid preemption > - __uaccess_ttbr0_enable \tmp1 > - restore_irq \tmp2 > -alternative_else_nop_endif > - .endm > -#else > - .macro uaccess_ttbr0_disable, tmp1 > - .endm > - > - .macro uaccess_ttbr0_enable, tmp1, tmp2 > - .endm > -#endif > - > -/* > - * These macros are no-ops when UAO is present. > - */ > - .macro uaccess_disable_not_uao, tmp1 > - uaccess_ttbr0_disable \tmp1 > -alternative_if ARM64_ALT_PAN_NOT_UAO > - SET_PSTATE_PAN(1) > -alternative_else_nop_endif > - .endm > - > - .macro uaccess_enable_not_uao, tmp
Re: Linux 4.10-rc1
On 2016/12/26 17:18, Al Viro wrote:
> On Mon, Dec 26, 2016 at 05:05:37PM +0800, Kefeng Wang wrote:
>> It looks like we need revert the changes from assembly files.
> Better yet, split the damn thing in two and include the asm-only part.
>
>> diff --git a/arch/arm64/mm/cache.S b/arch/arm64/mm/cache.S
>> diff --git a/arch/arm64/xen/hypercall.S b/arch/arm64/xen/hypercall.S
> Missed those two... OK, how about this?
It happens some where else,
./include/asm-generic/rwsem.h:48: Error: junk at end of line, first
unrecognized character is `}'
./include/asm-generic/rwsem.h:49: Error: junk at end of line, first
unrecognized character is `}'
./include/asm-generic/rwsem.h:50: Error: unknown mnemonic `return' -- `return 0'
./include/asm-generic/rwsem.h:51: Error: junk at end of line, first
unrecognized character is `}'
./include/asm-generic/rwsem.h:56: Error: unknown mnemonic `static' -- `static
inline void __down_write(struct rw_semaphore*sem)'
./include/asm-generic/rwsem.h:57: Error: junk at end of line, first
unrecognized character is `{'
./include/asm-generic/rwsem.h:58: Error: unknown mnemonic `long' -- `long tmp'
./include/asm-generic/rwsem.h:60: Error: junk at end of line, first
unrecognized character is `('
./include/asm-generic/rwsem.h:61: Error: junk at end of line, first
unrecognized character is `('
./include/asm-generic/rwsem.h:62: Error: unknown mnemonic `if' -- `if
(unlikely(tmp!=((-0xL-1)+0x0001L)))'
./include/asm-generic/rwsem.h:63: Error: unknown mnemonic
`rwsem_down_write_failed' -- `rwsem_down_write_failed(sem)'
./include/asm-generic/rwsem.h:64: Error: junk at end of line, first
unrecognized character is `}'
./include/asm-generic/rwsem.h:66: Error: unknown mnemonic `static' -- `static
inline int __down_write_killable(struct rw_semaphore*sem)'
./include/asm-generic/rwsem.h:67: Error: junk at end of line, first
unrecognized character is `{'
./include/asm-generic/rwsem.h:68: Error: unknown mnemonic `long' -- `long tmp'
./include/asm-generic/rwsem.h:70: Error: junk at end of line, first
unrecognized character is `('
./include/asm-generic/rwsem.h:71: Error: junk at end of line, first
unrecognized character is `('
./include/asm-generic/rwsem.h:72: Error: unknown mnemonic `if' -- `if
(unlikely(tmp!=((-0xL-1)+0x0001L)))'
./include/asm-generic/rwsem.h:73: Error: unknown mnemonic `if' -- `if
(IS_ERR(rwsem_down_write_failed_killable(sem)))'
./include/asm-generic/rwsem.h:74: Error: unknown mnemonic `return' -- `return
-4'
./include/asm-generic/rwsem.h:75: Error: unknown mnemonic `return' -- `return 0'
./include/asm-generic/rwsem.h:76: Error: junk at end of line, first
unrecognized character is `}'
./include/asm-generic/rwsem.h:78: Error: unknown mnemonic `static' -- `static
inline int __down_write_trylock(struct rw_semaphore*sem)'
./include/asm-generic/rwsem.h:79: Error: junk at end of line, first
unrecognized character is `{'
./include/linux/highuid.h:34: Error: unknown mnemonic `extern' -- `extern int
overflowuid'
./include/linux/highuid.h:35: Error: unknown mnemonic `extern' -- `extern int
overflowgid'
./include/linux/highuid.h:37: Error: unknown mnemonic `extern' -- `extern void
__bad_uid(void)'
./include/linux/uidgid.h:21: Error: unknown mnemonic `uid_t' -- `uid_t val'
./include/linux/uidgid.h:22: Error: junk at end of line, first unrecognized
character is `}'
./include/linux/uidgid.h:25: Error: unknown mnemonic `typedef' -- `typedef
struct{'
./include/linux/uidgid.h:26: Error: unknown mnemonic `gid_t' -- `gid_t val'
./include/linux/uidgid.h:27: Error: junk at end of line, first unrecognized
character is `}'
./include/uapi/linux/sysctl.h:34: Error: unknown mnemonic `struct' -- `struct
__sysctl_args{'
./include/uapi/linux/sysctl.h:35: Error: unknown mnemonic `int' -- `int
__user*name'
./include/uapi/linux/sysctl.h:36: Error: unknown mnemonic `int' -- `int nlen'
./include/uapi/linux/sysctl.h:37: Error: unknown mnemonic `void' -- `void
__user*oldval'
Thanks
Hanjun
>
> arm64: don't pull uaccess.h into *.S
>
> Split asm-only parts of arm64 uaccess.h into a new header and use that
> from *.S.
>
> Signed-off-by: Al Viro
>
> diff --git a/arch/arm64/include/asm/asm-uaccess.h
> b/arch/arm64/include/asm/asm-uaccess.h
> new file mode 100644
> index ..df411f3e083c
> --- /dev/null
> +++ b/arch/arm64/include/asm/asm-uaccess.h
> @@ -0,0 +1,65 @@
> +#ifndef __ASM_ASM_UACCESS_H
> +#define __ASM_ASM_UACCESS_H
> +
> +#include
> +#include
> +#include
> +#include
> +
> +/*
> + * User access enabling/disabling macros.
> + */
> +#ifdef CONFIG_ARM64_SW_TTBR0_PAN
> + .macro __uaccess_ttbr0_disable, tmp1
> + mrs \tmp1, ttbr1_el1// swapper_pg_dir
> + add \tmp1, \tmp1, #SWAPPER_DIR_SIZE // reserved_ttbr0 at the end of
> swapper_pg_dir
> + msr ttbr0_el1, \tmp1// set reserved TTBR0_EL1
> + isb
> + .endm
> +
> + .macro __uaccess_ttbr0_enable, tmp1
> + get_thread_info \tmp1
> +
Re: Linux 4.10-rc1
On Mon, Dec 26, 2016 at 05:05:37PM +0800, Kefeng Wang wrote: > It looks like we need revert the changes from assembly files. Better yet, split the damn thing in two and include the asm-only part. > diff --git a/arch/arm64/mm/cache.S b/arch/arm64/mm/cache.S > diff --git a/arch/arm64/xen/hypercall.S b/arch/arm64/xen/hypercall.S Missed those two... OK, how about this? arm64: don't pull uaccess.h into *.S Split asm-only parts of arm64 uaccess.h into a new header and use that from *.S. Signed-off-by: Al Viro diff --git a/arch/arm64/include/asm/asm-uaccess.h b/arch/arm64/include/asm/asm-uaccess.h new file mode 100644 index ..df411f3e083c --- /dev/null +++ b/arch/arm64/include/asm/asm-uaccess.h @@ -0,0 +1,65 @@ +#ifndef __ASM_ASM_UACCESS_H +#define __ASM_ASM_UACCESS_H + +#include +#include +#include +#include + +/* + * User access enabling/disabling macros. + */ +#ifdef CONFIG_ARM64_SW_TTBR0_PAN + .macro __uaccess_ttbr0_disable, tmp1 + mrs \tmp1, ttbr1_el1// swapper_pg_dir + add \tmp1, \tmp1, #SWAPPER_DIR_SIZE // reserved_ttbr0 at the end of swapper_pg_dir + msr ttbr0_el1, \tmp1// set reserved TTBR0_EL1 + isb + .endm + + .macro __uaccess_ttbr0_enable, tmp1 + get_thread_info \tmp1 + ldr \tmp1, [\tmp1, #TSK_TI_TTBR0] // load saved TTBR0_EL1 + msr ttbr0_el1, \tmp1// set the non-PAN TTBR0_EL1 + isb + .endm + + .macro uaccess_ttbr0_disable, tmp1 +alternative_if_not ARM64_HAS_PAN + __uaccess_ttbr0_disable \tmp1 +alternative_else_nop_endif + .endm + + .macro uaccess_ttbr0_enable, tmp1, tmp2 +alternative_if_not ARM64_HAS_PAN + save_and_disable_irq \tmp2 // avoid preemption + __uaccess_ttbr0_enable \tmp1 + restore_irq \tmp2 +alternative_else_nop_endif + .endm +#else + .macro uaccess_ttbr0_disable, tmp1 + .endm + + .macro uaccess_ttbr0_enable, tmp1, tmp2 + .endm +#endif + +/* + * These macros are no-ops when UAO is present. + */ + .macro uaccess_disable_not_uao, tmp1 + uaccess_ttbr0_disable \tmp1 +alternative_if ARM64_ALT_PAN_NOT_UAO + SET_PSTATE_PAN(1) +alternative_else_nop_endif + .endm + + .macro uaccess_enable_not_uao, tmp1, tmp2 + uaccess_ttbr0_enable \tmp1, \tmp2 +alternative_if ARM64_ALT_PAN_NOT_UAO + SET_PSTATE_PAN(0) +alternative_else_nop_endif + .endm + +#endif diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h index d26750ca6e06..46da3ea638bb 100644 --- a/arch/arm64/include/asm/uaccess.h +++ b/arch/arm64/include/asm/uaccess.h @@ -22,8 +22,6 @@ #include #include -#ifndef __ASSEMBLY__ - /* * User space memory access functions */ @@ -424,66 +422,4 @@ extern long strncpy_from_user(char *dest, const char __user *src, long count); extern __must_check long strlen_user(const char __user *str); extern __must_check long strnlen_user(const char __user *str, long n); -#else /* __ASSEMBLY__ */ - -#include - -/* - * User access enabling/disabling macros. - */ -#ifdef CONFIG_ARM64_SW_TTBR0_PAN - .macro __uaccess_ttbr0_disable, tmp1 - mrs \tmp1, ttbr1_el1// swapper_pg_dir - add \tmp1, \tmp1, #SWAPPER_DIR_SIZE // reserved_ttbr0 at the end of swapper_pg_dir - msr ttbr0_el1, \tmp1// set reserved TTBR0_EL1 - isb - .endm - - .macro __uaccess_ttbr0_enable, tmp1 - get_thread_info \tmp1 - ldr \tmp1, [\tmp1, #TSK_TI_TTBR0] // load saved TTBR0_EL1 - msr ttbr0_el1, \tmp1// set the non-PAN TTBR0_EL1 - isb - .endm - - .macro uaccess_ttbr0_disable, tmp1 -alternative_if_not ARM64_HAS_PAN - __uaccess_ttbr0_disable \tmp1 -alternative_else_nop_endif - .endm - - .macro uaccess_ttbr0_enable, tmp1, tmp2 -alternative_if_not ARM64_HAS_PAN - save_and_disable_irq \tmp2 // avoid preemption - __uaccess_ttbr0_enable \tmp1 - restore_irq \tmp2 -alternative_else_nop_endif - .endm -#else - .macro uaccess_ttbr0_disable, tmp1 - .endm - - .macro uaccess_ttbr0_enable, tmp1, tmp2 - .endm -#endif - -/* - * These macros are no-ops when UAO is present. - */ - .macro uaccess_disable_not_uao, tmp1 - uaccess_ttbr0_disable \tmp1 -alternative_if ARM64_ALT_PAN_NOT_UAO - SET_PSTATE_PAN(1) -alternative_else_nop_endif - .endm - - .macro uaccess_enable_not_uao, tmp1, tmp2 - uaccess_ttbr0_enable \tmp1, \tmp2 -alternative_if ARM64_ALT_PAN_NOT_UAO - SET_PSTATE_PAN(0) -alternative_else_nop_endif - .endm - -#endif /* __ASSEMBLY__ */ - #endif /* __ASM_UACCESS_H */ diff --git a/arch/arm64/lib/clear_user.S b/arch/arm64/lib/clear_user.S index add4a1334085..e88fb99c1561 100644 --- a/arch/arm64/lib/clear_user.S +++ b/arch/arm64/lib/clear_user.S @@ -17,7
Re: Linux 4.10-rc1
On Mon, Dec 26, 2016 at 04:38:13PM +0800, Hanjun Guo wrote: > ./include/asm-generic/atomic-long.h:23: Error: unknown mnemonic `typedef' -- > `typedef atomic64_t atomic_long_t' *blink* OK, I see what has happened here - it's "arm64: Factor out PAN enabling/disabling into separate uaccess_* macros" that went in during this window, adding an include of asm/uaccess.h into several assembler files. AFAICS, the easiest way to deal with that is to separate for-asm parts of uaccess.h into a new header and use _that_ from *.S, as in (completely untested) diff below. Seeing that there's basically no overlap between the __ASSEMBLY__ and normal parts of arm64 uaccess.h, that would seem to be a fairly obvious solution... Objections? diff --git a/arch/arm64/include/asm/asm-uaccess.h b/arch/arm64/include/asm/asm-uaccess.h new file mode 100644 index ..df411f3e083c --- /dev/null +++ b/arch/arm64/include/asm/asm-uaccess.h @@ -0,0 +1,65 @@ +#ifndef __ASM_ASM_UACCESS_H +#define __ASM_ASM_UACCESS_H + +#include +#include +#include +#include + +/* + * User access enabling/disabling macros. + */ +#ifdef CONFIG_ARM64_SW_TTBR0_PAN + .macro __uaccess_ttbr0_disable, tmp1 + mrs \tmp1, ttbr1_el1// swapper_pg_dir + add \tmp1, \tmp1, #SWAPPER_DIR_SIZE // reserved_ttbr0 at the end of swapper_pg_dir + msr ttbr0_el1, \tmp1// set reserved TTBR0_EL1 + isb + .endm + + .macro __uaccess_ttbr0_enable, tmp1 + get_thread_info \tmp1 + ldr \tmp1, [\tmp1, #TSK_TI_TTBR0] // load saved TTBR0_EL1 + msr ttbr0_el1, \tmp1// set the non-PAN TTBR0_EL1 + isb + .endm + + .macro uaccess_ttbr0_disable, tmp1 +alternative_if_not ARM64_HAS_PAN + __uaccess_ttbr0_disable \tmp1 +alternative_else_nop_endif + .endm + + .macro uaccess_ttbr0_enable, tmp1, tmp2 +alternative_if_not ARM64_HAS_PAN + save_and_disable_irq \tmp2 // avoid preemption + __uaccess_ttbr0_enable \tmp1 + restore_irq \tmp2 +alternative_else_nop_endif + .endm +#else + .macro uaccess_ttbr0_disable, tmp1 + .endm + + .macro uaccess_ttbr0_enable, tmp1, tmp2 + .endm +#endif + +/* + * These macros are no-ops when UAO is present. + */ + .macro uaccess_disable_not_uao, tmp1 + uaccess_ttbr0_disable \tmp1 +alternative_if ARM64_ALT_PAN_NOT_UAO + SET_PSTATE_PAN(1) +alternative_else_nop_endif + .endm + + .macro uaccess_enable_not_uao, tmp1, tmp2 + uaccess_ttbr0_enable \tmp1, \tmp2 +alternative_if ARM64_ALT_PAN_NOT_UAO + SET_PSTATE_PAN(0) +alternative_else_nop_endif + .endm + +#endif diff --git a/arch/arm64/include/asm/uaccess.h b/arch/arm64/include/asm/uaccess.h index d26750ca6e06..46da3ea638bb 100644 --- a/arch/arm64/include/asm/uaccess.h +++ b/arch/arm64/include/asm/uaccess.h @@ -22,8 +22,6 @@ #include #include -#ifndef __ASSEMBLY__ - /* * User space memory access functions */ @@ -424,66 +422,4 @@ extern long strncpy_from_user(char *dest, const char __user *src, long count); extern __must_check long strlen_user(const char __user *str); extern __must_check long strnlen_user(const char __user *str, long n); -#else /* __ASSEMBLY__ */ - -#include - -/* - * User access enabling/disabling macros. - */ -#ifdef CONFIG_ARM64_SW_TTBR0_PAN - .macro __uaccess_ttbr0_disable, tmp1 - mrs \tmp1, ttbr1_el1// swapper_pg_dir - add \tmp1, \tmp1, #SWAPPER_DIR_SIZE // reserved_ttbr0 at the end of swapper_pg_dir - msr ttbr0_el1, \tmp1// set reserved TTBR0_EL1 - isb - .endm - - .macro __uaccess_ttbr0_enable, tmp1 - get_thread_info \tmp1 - ldr \tmp1, [\tmp1, #TSK_TI_TTBR0] // load saved TTBR0_EL1 - msr ttbr0_el1, \tmp1// set the non-PAN TTBR0_EL1 - isb - .endm - - .macro uaccess_ttbr0_disable, tmp1 -alternative_if_not ARM64_HAS_PAN - __uaccess_ttbr0_disable \tmp1 -alternative_else_nop_endif - .endm - - .macro uaccess_ttbr0_enable, tmp1, tmp2 -alternative_if_not ARM64_HAS_PAN - save_and_disable_irq \tmp2 // avoid preemption - __uaccess_ttbr0_enable \tmp1 - restore_irq \tmp2 -alternative_else_nop_endif - .endm -#else - .macro uaccess_ttbr0_disable, tmp1 - .endm - - .macro uaccess_ttbr0_enable, tmp1, tmp2 - .endm -#endif - -/* - * These macros are no-ops when UAO is present. - */ - .macro uaccess_disable_not_uao, tmp1 - uaccess_ttbr0_disable \tmp1 -alternative_if ARM64_ALT_PAN_NOT_UAO - SET_PSTATE_PAN(1) -alternative_else_nop_endif - .endm - - .macro uaccess_enable_not_uao, tmp1, tmp2 - uaccess_ttbr0_enable \tmp1, \tmp2 -alternative_if ARM64_ALT_PAN_NOT_UAO - SET_PSTATE_PAN(0) -alternative_else_nop_endif - .endm - -#endif /* __ASSEMBLY__ */ -
Re: Linux 4.10-rc1
On 2016/12/26 16:38, Hanjun Guo wrote:
> Hi Linus,
>
> On 2016/12/26 8:41, Linus Torvalds wrote:
>> It's Christmas Day, and it's two weeks since the merge window opened.
>> Thus, the merge window is now closed.
>>
>> I did a few final pulls today, but I also rejected a couple of pulls
>> that came in late in the window and looked dodgy. You know who you
>> are.
>>
>> On the whole, this wasn't all that big a release - nothing like 4.9.
>> Although it wasn't tiny either. I think 4.7 was smaller. 4.8 might
>> have been too. It's xmas day, and right now I can't be arsed to
>> actually do the statistics I'd normally do.
>>
>> Everything looks pretty normal, although we had an unusual amount of
>> tree-wide final cleanups in the last days of the merge window. But the
>> general statistics look fairly common: a bit over half is drivers,
>> maybe slightly less arch updates than normal, and a fair amount of
>> documentation updates due to the sphinx conversion. And then the usual
>> misc noise all over, although the perf tooling updates do stand out.
>>
>> The shortlog is much too big, as it always is during the merge window,
>> so as usual you just get the merge-log.
>
> Kejian and I got massive compile error when cross-compile the kernel for
> ARM64, such as
>
> ./include/asm-generic/atomic-long.h:23: Error: unknown mnemonic `typedef' --
> `typedef atomic64_t atomic_long_t'
> ./include/asm-generic/atomic-long.h:44: Error: unknown mnemonic `static' --
> `static inline long atomic_long_read(const
> atomic_long_t*l){atomic64_t*v=(atomic64_t*)l'
> ./include/asm-generic/atomic-long.h:44: Error: unknown mnemonic `return' --
> `return (long)READ_ONCE((v)->counter)'
> ./include/asm-generic/atomic-long.h:44: Error: junk at end of line, first
> unrecognized character is `}'
> ./include/asm-generic/atomic-long.h:45: Error: unknown mnemonic `static' --
> `static inline long atomic_long_read_acquire(const
> atomic_long_t*l){atomic64_t*v=(atomic64_t*)l'
> ./include/asm-generic/atomic-long.h:45: Error: unknown mnemonic `return' --
> `return (long)smp_load_acquire(&(v)->counter)'
> ./include/asm-generic/atomic-long.h:45: Error: junk at end of line, first
> unrecognized character is `}'
> ./include/asm-generic/atomic-long.h:56: Error: unknown mnemonic `static' --
> `static inline void atomic_long_set(atomic_long_t*l,long
> i){atomic64_t*v=(atomic64_t*)l'
> ./include/asm-generic/atomic-long.h:56: Error: unknown mnemonic `write_once'
> -- `write_once(((v)->counter), (i))'
> ./include/asm-generic/atomic-long.h:56: Error: junk at end of line, first
> unrecognized character is `}'
> ./include/asm-generic/atomic-long.h:57: Error: unknown mnemonic `static' --
> `static inline void atomic_long_set_release(atomic_long_t*l,long
> i){atomic64_t*v=(atomic64_t*)l'
> ./include/asm-generic/atomic-long.h:57: Error: unknown mnemonic
> `smp_store_release' -- `smp_store_release(&(v)->counter, (i))'
> ./include/asm-generic/atomic-long.h:57: Error: junk at end of line, first
> unrecognized character is `}'
> ./include/asm-generic/atomic-long.h:69: Error: unknown mnemonic `static' --
> `static inline long atomic_long_add_return(long
> i,atomic_long_t*l){atomic64_t*v=(atomic64_t*)l'
> ./include/asm-generic/atomic-long.h:69: Error: unknown mnemonic `return' --
> `return (long)atomic64_add_return(i,v)'
> ./include/asm-generic/atomic-long.h:69: Error: junk at end of line, first
> unrecognized character is `}'
> ./include/asm-generic/atomic-long.h:70: Error: unknown mnemonic `static' --
> `static inline long atomic_long_add_return_relaxed(long
> i,atomic_long_t*l){atomic64_t*v=(atomic64_t*)l'
> ./include/asm-generic/atomic-long.h:70: Error: unknown mnemonic `return' --
> `return (long)atomic64_add_return_relaxed(i,v)'
> ./include/asm-generic/atomic-long.h:70: Error: junk at end of line, first
> unrecognized character is `}'
> ./include/asm-generic/atomic-long.h:71: Error: unknown mnemonic `static' --
> `static inline long atomic_long_add_return_acquire(long
> i,atomic_long_t*l){atomic64_t*v=(atomic64_t*)l'
> ./include/asm-generic/atomic-long.h:71: Error: unknown mnemonic `return' --
> `return (long)atomic64_add_return_acquire(i,v)'
> ./include/asm-generic/atomic-long.h:71: Error: junk at end of line, first
> unrecognized character is `}'
> ./include/asm-generic/atomic-long.h:72: Error: unknown mnemonic `static' --
> `static inline long atomic_long_add_return_release(long
> i,atomic_long_t*l){atomic64_t*v=(atomic64_t*)l'
> ./include/asm-generic/atomic-long.h:72: Error: unknown mnemonic `return' --
> `return (long)atomic64_add_return_release(i,v)'
> ./include/asm-generic/atomic-long.h:72: Error: junk at end of line, first
> unrecognized character is `}'
> ./include/asm-generic/atomic-long.h:73: Error: unknown mnemonic `static' --
> `static inline long atomic_long_sub_return(long
> i,atomic_long_t*l){atomic64_t*v=(atomic64_t*)l'
> ./include/asm-generic/atomic-long.h:73: Error: unknown mnemonic `return' --
> `return (l
Re: Linux 4.10-rc1
Hi Linus,
On 2016/12/26 8:41, Linus Torvalds wrote:
> It's Christmas Day, and it's two weeks since the merge window opened.
> Thus, the merge window is now closed.
>
> I did a few final pulls today, but I also rejected a couple of pulls
> that came in late in the window and looked dodgy. You know who you
> are.
>
> On the whole, this wasn't all that big a release - nothing like 4.9.
> Although it wasn't tiny either. I think 4.7 was smaller. 4.8 might
> have been too. It's xmas day, and right now I can't be arsed to
> actually do the statistics I'd normally do.
>
> Everything looks pretty normal, although we had an unusual amount of
> tree-wide final cleanups in the last days of the merge window. But the
> general statistics look fairly common: a bit over half is drivers,
> maybe slightly less arch updates than normal, and a fair amount of
> documentation updates due to the sphinx conversion. And then the usual
> misc noise all over, although the perf tooling updates do stand out.
>
> The shortlog is much too big, as it always is during the merge window,
> so as usual you just get the merge-log.
Kejian and I got massive compile error when cross-compile the kernel for ARM64,
such as
./include/asm-generic/atomic-long.h:23: Error: unknown mnemonic `typedef' --
`typedef atomic64_t atomic_long_t'
./include/asm-generic/atomic-long.h:44: Error: unknown mnemonic `static' --
`static inline long atomic_long_read(const
atomic_long_t*l){atomic64_t*v=(atomic64_t*)l'
./include/asm-generic/atomic-long.h:44: Error: unknown mnemonic `return' --
`return (long)READ_ONCE((v)->counter)'
./include/asm-generic/atomic-long.h:44: Error: junk at end of line, first
unrecognized character is `}'
./include/asm-generic/atomic-long.h:45: Error: unknown mnemonic `static' --
`static inline long atomic_long_read_acquire(const
atomic_long_t*l){atomic64_t*v=(atomic64_t*)l'
./include/asm-generic/atomic-long.h:45: Error: unknown mnemonic `return' --
`return (long)smp_load_acquire(&(v)->counter)'
./include/asm-generic/atomic-long.h:45: Error: junk at end of line, first
unrecognized character is `}'
./include/asm-generic/atomic-long.h:56: Error: unknown mnemonic `static' --
`static inline void atomic_long_set(atomic_long_t*l,long
i){atomic64_t*v=(atomic64_t*)l'
./include/asm-generic/atomic-long.h:56: Error: unknown mnemonic `write_once' --
`write_once(((v)->counter), (i))'
./include/asm-generic/atomic-long.h:56: Error: junk at end of line, first
unrecognized character is `}'
./include/asm-generic/atomic-long.h:57: Error: unknown mnemonic `static' --
`static inline void atomic_long_set_release(atomic_long_t*l,long
i){atomic64_t*v=(atomic64_t*)l'
./include/asm-generic/atomic-long.h:57: Error: unknown mnemonic
`smp_store_release' -- `smp_store_release(&(v)->counter, (i))'
./include/asm-generic/atomic-long.h:57: Error: junk at end of line, first
unrecognized character is `}'
./include/asm-generic/atomic-long.h:69: Error: unknown mnemonic `static' --
`static inline long atomic_long_add_return(long
i,atomic_long_t*l){atomic64_t*v=(atomic64_t*)l'
./include/asm-generic/atomic-long.h:69: Error: unknown mnemonic `return' --
`return (long)atomic64_add_return(i,v)'
./include/asm-generic/atomic-long.h:69: Error: junk at end of line, first
unrecognized character is `}'
./include/asm-generic/atomic-long.h:70: Error: unknown mnemonic `static' --
`static inline long atomic_long_add_return_relaxed(long
i,atomic_long_t*l){atomic64_t*v=(atomic64_t*)l'
./include/asm-generic/atomic-long.h:70: Error: unknown mnemonic `return' --
`return (long)atomic64_add_return_relaxed(i,v)'
./include/asm-generic/atomic-long.h:70: Error: junk at end of line, first
unrecognized character is `}'
./include/asm-generic/atomic-long.h:71: Error: unknown mnemonic `static' --
`static inline long atomic_long_add_return_acquire(long
i,atomic_long_t*l){atomic64_t*v=(atomic64_t*)l'
./include/asm-generic/atomic-long.h:71: Error: unknown mnemonic `return' --
`return (long)atomic64_add_return_acquire(i,v)'
./include/asm-generic/atomic-long.h:71: Error: junk at end of line, first
unrecognized character is `}'
./include/asm-generic/atomic-long.h:72: Error: unknown mnemonic `static' --
`static inline long atomic_long_add_return_release(long
i,atomic_long_t*l){atomic64_t*v=(atomic64_t*)l'
./include/asm-generic/atomic-long.h:72: Error: unknown mnemonic `return' --
`return (long)atomic64_add_return_release(i,v)'
./include/asm-generic/atomic-long.h:72: Error: junk at end of line, first
unrecognized character is `}'
./include/asm-generic/atomic-long.h:73: Error: unknown mnemonic `static' --
`static inline long atomic_long_sub_return(long
i,atomic_long_t*l){atomic64_t*v=(atomic64_t*)l'
./include/asm-generic/atomic-long.h:73: Error: unknown mnemonic `return' --
`return (long)atomic64_sub_return(i,v)'
./include/asm-generic/atomic-long.h:73: Error: junk at end of line, first
unrecognized character is `}'
./include/asm-generic/atomic-long.h:74: Error: unknown mnemonic `st
Linux 4.10-rc1
It's Christmas Day, and it's two weeks since the merge window opened. Thus, the merge window is now closed. I did a few final pulls today, but I also rejected a couple of pulls that came in late in the window and looked dodgy. You know who you are. On the whole, this wasn't all that big a release - nothing like 4.9. Although it wasn't tiny either. I think 4.7 was smaller. 4.8 might have been too. It's xmas day, and right now I can't be arsed to actually do the statistics I'd normally do. Everything looks pretty normal, although we had an unusual amount of tree-wide final cleanups in the last days of the merge window. But the general statistics look fairly common: a bit over half is drivers, maybe slightly less arch updates than normal, and a fair amount of documentation updates due to the sphinx conversion. And then the usual misc noise all over, although the perf tooling updates do stand out. The shortlog is much too big, as it always is during the merge window, so as usual you just get the merge-log. Linus --- Al Viro (3): vfs updates more vfs updates final vfs updates Alex Williamson (1): VFIO updates Alexandre Belloni (1): RTC updates Andrew Morton (3): updates more updates final set of updates Arnd Bergmann (7): ARM SoC non-urgent fixes ARM SoC platform updates ARM SoC defconfig updates ARM SoC 64-bit updates ARM DT updates ARM 64-bit DT updates ARM SoC driver updates Bart Van Assche (1): scsi target cleanups Bjorn Andersson (2): remoteproc updates rpmsg updates Bjorn Helgaas (1): PCI updates Borislav Petkov (1): EDAC updates Brian Norris (1): MTD updates Bruce Fields (1): nfsd updates Catalin Marinas (1): arm64 updates Chris Mason (1): btrfs updates Chris Metcalf (1): arch/tile updates Christoph Hellwig (1): configfs update Corey Minyard (1): IPMI updates Dan Williams (1): libnvdimm updates Darren Hart (1): more x86 platform driver updates Darrent Hart (1): x86 platform driver updates Dave Airlie (2): drm updates drm fixes Dave Chinner (1): xfs updates David Kleikamp (1): jfs update David Miller (5): networking updates sparc updates networking fixes and cleanups networking fixes and cleanups networking fixes David Teigland (1): dlm fixes Dmitry Torokhov (1): input subsystem updates Doug Ledford (2): rdma updates rdma fixes Eric Biederman (1): namespace updates Geert Uytterhoeven (1): m68k updates Greg KH (5): USB/PHY updates tty/serial updates staging/IIO updates driver core updates char/misc driver updates Greg Ungerer (1): m68knommu updates Guenter Roeck (1): hwmon updates Hans-Christian Noren Egtvedt (1): AVR32 updates Helge Deller (1): parisc updates Herbert Xu (2): crypto updates crypto fixes Ilya Dryomov (1): ceph updates Ingo Molnar (24): RCU updates SMP bootup updates EFI updates locking updates mm/PAT cleanup perf updates scheduler updates hotplug API fix x86 RAS updates x86 apic updates x86 asm updates x86 boot updates x86 build updates x86 cleanups x86 CPU updates x86 FPU updates x86 header fixlet x86 idle updates x86 microcode update x86 platform updates irq fix perf fixes timer fix x86 fixes Jacek Anaszewski (2): LED updates LED maintainer email update Jaegeuk Kim (1): f2fs updates James Bottomley (2): SCSI updates late SCSI updates James Morris (2): security subsystem updates SElinux fix Jan Kara (1): quota, fsnotify and ext2 updates Jassi Brar (1): mailbox updates Jean Delvare (1): dmi fix Jens Axboe (4): block layer updates fs meta data unmap optimization block IO fixes block layer fixes Jesper Nilsson (1): CRIS updates Jessica Yu (1): modules updates Jiri Kosina (3): HID updates livepatch update trivial updates Joerg Roedel (1): IOMMU updates Jon Mason (1): NTB update Jonathan Corbet (3): documentation update more documentation updates documentation fix Juergen Gross (1): xen updates Kees Cook (2): pstore updates gcc plugins updates Konrad Rzeszutek Wilk (1): swiotlb updates Lee Jones (1): MFD updates Len Brown (1): turbostat updates Ley Foon Tan (1): arch/nios2 updates Linus Walleij (1): pinctrl updates Luinus Walleij (1): GPIO updates Luis de Bethencourt (1): befs updates Mark Brown (3): regmap fixlet regulator updates spi updates Martin Schwidefsky (2): s390 updates more s390 updates Mauro Carvalho Chehab (2): edac updates media updates Max Filippov (1): Xtensa updates Michael Ellerman (1): powerpc updates Michael Tsirkin (1): virtio updates Michal Marek (3): kbuild updates kconfig updates kb
Re: [GIT PULL] tpmdd updates for Linux 4.10
On Mon, 28 Nov 2016, Jarkko Sakkinen wrote: > Hi James, > > This pull request contains tpmdd updates for Linux 4.10. This release > contains two major changes: power gating support tpm_crb and precursory > cleanup work for the event log so that in a future release we will be > able to add event log for TPM 2.0. > Pulled, thanks. -- James Morris
[GIT PULL] tpmdd updates for Linux 4.10
Hi James, This pull request contains tpmdd updates for Linux 4.10. This release contains two major changes: power gating support tpm_crb and precursory cleanup work for the event log so that in a future release we will be able to add event log for TPM 2.0. /Jarkko The following changes since commit 0821e30cd2f246a93c5271f6c23d7134f809d70d: Merge branch 'stable-4.10' of git://git.infradead.org/users/pcmoore/selinux into next (2016-11-24 11:21:25 +1100) are available in the git repository at: git://git.infradead.org/users/jjs/linux-tpmdd.git tags/tpmdd-next-20161128 for you to fetch changes up to 9430066a15d6f55a3d008a6f99bb462480870207: tpm: adjust return value of tpm_read_log (2016-11-28 01:31:33 +0200) tpmdd updates for Linux 4.10 Baruch Siach (1): char: tpm: fix kerneldoc tpm2_unseal_trusted name typo Colin Ian King (1): tpm: return -ENODEV if np is not set Ed Swierk (1): tpm: Clean up reading of timeout and duration capabilities Jarkko Sakkinen (4): tpm: sanitize constant expressions tpm, tpm_vtpm_proxy: add kdoc comments for VTPM_PROXY_IOC_NEW_DEV tpm: replace dynamically allocated bios_dir with a static array tpm: drop tpm1_chip_register(/unregister) Jason Gunthorpe (7): tpm tis: Do not print timeout messages twice tpm xen: Remove bogus tpm_chip_unregister tpm: Get rid of TPM_CHIP_FLAG_REGISTERED tpm_tis: Allow tpm_tis to be bound using DT tpm: Fix handling of missing event log tpm: vtpm_proxy: conditionally call tpm_chip_unregister tpm: adjust return value of tpm_read_log Josh Zimmerman (1): tpm_tis: Check return values from get_burstcount. Nayna Jain (9): Documentation: tpm: add the IBM Virtual TPM device tree binding documentation Documentation: tpm: add the Physical TPM device tree binding documentation tpm: define a generic open() method for ascii & bios measurements tpm: replace symbolic permission with octal for securityfs files tpm: have event log use the tpm_chip tpm: fix the missing .owner in tpm_bios_measurements_ops tpm: redefine read_log() to handle ACPI/OF at runtime tpm: replace of_find_node_by_name() with dev of_node property tpm: cleanup of printk error messages Peter Huewe (1): char/tpm: Check return code of wait_for_tpm_stat Stefan Berger (2): tpm: Only call pm_runtime_get_sync if device has a parent tpm: Check the bios_dir entry for NULL before accessing it Winkler, Tomas (5): tpm/tpm_crb: implement tpm crb idle state tmp/tpm_crb: fix Intel PTT hw bug during idle state tpm/tpm_crb: open code the crb_init into acpi_add tmp/tpm_crb: implement runtime pm for tpm_crb tpm: place kdoc just above tpm_pcr_extend .../devicetree/bindings/security/tpm/ibmvtpm.txt | 41 .../devicetree/bindings/security/tpm/tpm-i2c.txt | 21 ++ .../bindings/security/tpm/tpm_tis_mmio.txt | 25 +++ drivers/char/tpm/Kconfig | 2 +- drivers/char/tpm/Makefile | 14 +- drivers/char/tpm/tpm-chip.c| 38 +--- drivers/char/tpm/tpm-interface.c | 110 +- drivers/char/tpm/tpm-sysfs.c | 7 +- drivers/char/tpm/tpm.h | 41 ++-- drivers/char/tpm/tpm2-cmd.c| 2 +- drivers/char/tpm/tpm_acpi.c| 46 ++--- drivers/char/tpm/tpm_crb.c | 173 +--- drivers/char/tpm/tpm_eventlog.c| 230 +++-- drivers/char/tpm/tpm_eventlog.h| 22 +- drivers/char/tpm/tpm_of.c | 48 ++--- drivers/char/tpm/tpm_tis.c | 11 + drivers/char/tpm/tpm_tis_core.c| 64 -- drivers/char/tpm/tpm_vtpm_proxy.c | 85 +--- drivers/char/tpm/xen-tpmfront.c| 1 - include/uapi/linux/vtpm_proxy.h| 23 ++- 20 files changed, 624 insertions(+), 380 deletions(-) create mode 100644 Documentation/devicetree/bindings/security/tpm/ibmvtpm.txt create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm-i2c.txt create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm_tis_mmio.txt
