RE: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON

2018-02-13 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Christophe JAILLET > Sent: Tuesday, February 6, 2018 11:48 AM > To: Kirsher, Jeffrey T > Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; linux- >

RE: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON

2018-02-13 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Christophe JAILLET > Sent: Tuesday, February 6, 2018 11:48 AM > To: Kirsher, Jeffrey T > Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; linux- > ker...@vger.kernel.org;

Re: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON

2018-02-06 Thread Richard Cochran
On Tue, Feb 06, 2018 at 08:47:59PM +0100, Christophe JAILLET wrote: > 'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask. > The modified code should behave the same, because HWTSTAMP_TX_ON is 1 > and no other possible values of 'tx_type' would match the test. > However, this is more

Re: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON

2018-02-06 Thread Richard Cochran
On Tue, Feb 06, 2018 at 08:47:59PM +0100, Christophe JAILLET wrote: > 'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask. > The modified code should behave the same, because HWTSTAMP_TX_ON is 1 > and no other possible values of 'tx_type' would match the test. > However, this is more