From: Joe Perches [mailto:j...@perches.com]
Sent: Thursday, August 16, 2012 9:16 PM
>Hi Cloud. Please convert this to
>
> netdev_printk(level, hw->adpt->netdev, "%pV", );
>
>I will submit a patch soon to make the __netdev_printk variant static.
Ok, thanks.
On Thu, 2012-08-16 at 01:53 +0800, cj...@qca.qualcomm.com wrote:
> From: Cloud Ren
>
> This driver support two new ethernet chipsets:
> 1969:1091 - AR8161 Gigabit Ethernet
> 1969:1090 - AR8162 Fast Ethernet
[]
> diff --git a/drivers/net/ethernet/atheros/alx/alx_main.c
>
On Thu, 2012-08-16 at 01:53 +0800, cj...@qca.qualcomm.com wrote:
From: Cloud Ren cj...@qca.qualcomm.com
This driver support two new ethernet chipsets:
1969:1091 - AR8161 Gigabit Ethernet
1969:1090 - AR8162 Fast Ethernet
[]
diff --git a/drivers/net/ethernet/atheros/alx/alx_main.c
From: Joe Perches [mailto:j...@perches.com]
Sent: Thursday, August 16, 2012 9:16 PM
Hi Cloud. Please convert this to
netdev_printk(level, hw-adpt-netdev, %pV, vaf);
I will submit a patch soon to make the __netdev_printk variant static.
Ok, thanks.
From: Stephen Hemminger [mailto:shemmin...@vyatta.com]
Sent: Wednesday, August 15, 2012 11:02 PM
>> + strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) -
>1);
>> ...
>> + strcpy(netdev->name, "eth%d");
>> + retval = register_netdev(netdev);
>> >>>
>>
On Wed, 15 Aug 2012 05:39:11 +
"Ren, Cloud" wrote:
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Wednesday, August 15, 2012 1:33 PM
>
> >From: "Ren, Cloud"
> >Date: Wed, 15 Aug 2012 03:29:26 +
> >
> +strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) -
On Wed, 15 Aug 2012 05:39:11 +
Ren, Cloud cj...@qca.qualcomm.com wrote:
From: David Miller [mailto:da...@davemloft.net]
Sent: Wednesday, August 15, 2012 1:33 PM
From: Ren, Cloud cj...@qca.qualcomm.com
Date: Wed, 15 Aug 2012 03:29:26 +
+strncpy(netdev-name,
From: Stephen Hemminger [mailto:shemmin...@vyatta.com]
Sent: Wednesday, August 15, 2012 11:02 PM
+ strncpy(netdev-name, pci_name(pdev), sizeof(netdev-name) -
1);
...
+ strcpy(netdev-name, eth%d);
+ retval = register_netdev(netdev);
The strcpy is unnecessary,
From: David Miller [mailto:da...@davemloft.net]
Sent: Wednesday, August 15, 2012 1:33 PM
>From: "Ren, Cloud"
>Date: Wed, 15 Aug 2012 03:29:26 +
>
+ strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1);
...
+ strcpy(netdev->name, "eth%d");
+ retval =
From: "Ren, Cloud"
Date: Wed, 15 Aug 2012 03:29:26 +
>>> + strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1);
>>> ...
>>> + strcpy(netdev->name, "eth%d");
>>> + retval = register_netdev(netdev);
>>
>>The strcpy is unnecessary, alloc_etherdev already sets that.
>
> The
>> +strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1);
>> ...
>> +strcpy(netdev->name, "eth%d");
>> +retval = register_netdev(netdev);
>
>The strcpy is unnecessary, alloc_etherdev already sets that.
The strcpy is useful. netdev->name is set as pci_name in front. So the
+strncpy(netdev-name, pci_name(pdev), sizeof(netdev-name) - 1);
...
+strcpy(netdev-name, eth%d);
+retval = register_netdev(netdev);
The strcpy is unnecessary, alloc_etherdev already sets that.
The strcpy is useful. netdev-name is set as pci_name in front. So the strcpy
restores
From: Ren, Cloud cj...@qca.qualcomm.com
Date: Wed, 15 Aug 2012 03:29:26 +
+ strncpy(netdev-name, pci_name(pdev), sizeof(netdev-name) - 1);
...
+ strcpy(netdev-name, eth%d);
+ retval = register_netdev(netdev);
The strcpy is unnecessary, alloc_etherdev already sets that.
The
From: David Miller [mailto:da...@davemloft.net]
Sent: Wednesday, August 15, 2012 1:33 PM
From: Ren, Cloud cj...@qca.qualcomm.com
Date: Wed, 15 Aug 2012 03:29:26 +
+ strncpy(netdev-name, pci_name(pdev), sizeof(netdev-name) - 1);
...
+ strcpy(netdev-name, eth%d);
+ retval =
> From: Stephen Hemminger [mailto:shemmin...@vyatta.com]
> Sent: Sunday, August 12, 2012 4:51
> To: Ren, Cloud
> > + strcpy(netdev->name, "eth%d");
> > + retval = register_netdev(netdev);
>
> The strcpy is unnecessary, alloc_etherdev already sets that.
Thanks, Hemminger, we will remove this
From: Stephen Hemminger [mailto:shemmin...@vyatta.com]
Sent: Sunday, August 12, 2012 4:51
To: Ren, Cloud
+ strcpy(netdev-name, eth%d);
+ retval = register_netdev(netdev);
The strcpy is unnecessary, alloc_etherdev already sets that.
Thanks, Hemminger, we will remove this line in the
On Thu, 9 Aug 2012 18:14:30 +0800
wrote:
> + strcpy(netdev->name, "eth%d");
> + retval = register_netdev(netdev);
The strcpy is unnecessary, alloc_etherdev already sets that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
On Thu, 9 Aug 2012 18:14:30 +0800
cj...@qca.qualcomm.com wrote:
+ strcpy(netdev-name, eth%d);
+ retval = register_netdev(netdev);
The strcpy is unnecessary, alloc_etherdev already sets that.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a
> The alterations to the description of atl1c ought to be broken out as a
> separate patch, though.
>
Yes, we will separate it. thanks !
-Xiong
On Thu, Aug 9, 2012 at 12:13 PM, Luis R. Rodriguez
wrote:
> So -- are we OK to *not* include SOBs of evolutions sent to developers
> of joojoo-1 when company x submits joojoo-2 so long as those patches
> were sent publicly or a record is kept somewhere ?
And lets be fair, some folks *may* want
On Thu, Aug 9, 2012 at 8:28 AM, Steven Rostedt wrote:
> On Thu, 2012-08-09 at 08:22 -0700, Joe Perches wrote:
>
>> Yes, I sent signed-off patches to their original RFC submission
>> (back last year?).
And that is why your SOB was kept.
>> To me, this single large patch is like a
>> snapshot of
On Thu, 2012-08-09 at 11:28 -0400, Steven Rostedt wrote:
> On Thu, 2012-08-09 at 08:22 -0700, Joe Perches wrote:
>
> > Yes, I sent signed-off patches to their original RFC submission
> > (back last year?). To me, this single large patch is like a
> > snapshot of a git tree and not all
On Thu, 2012-08-09 at 08:22 -0700, Joe Perches wrote:
> Yes, I sent signed-off patches to their original RFC submission
> (back last year?). To me, this single large patch is like a
> snapshot of a git tree and not all contributors to that git
> tree should be noted as signers of the entire
On Thu, 2012-08-09 at 10:54 -0400, Steven Rostedt wrote:
> On Thu, Aug 09, 2012 at 06:49:25AM +, Ren, Cloud wrote:
> > Luis has ever asked joe for adding as a Signed-off-by.
[]
> I'm curious, did Luis ask on list or off?
Off vger lists with some qca list or exploder added.
> The Signed-off
On Thu, Aug 09, 2012 at 06:49:25AM +, Ren, Cloud wrote:
>
> Please calm down. I will follow rule of sending email from now on. Sorry for
> causing
> your trouble. Luis has ever asked joe for adding as a Signed-off-by. At that
> time joe agreed
> with it. If joe prefers his name not be
>-Original Message-
>From: Joe Perches [mailto:j...@perches.com]
>Sent: Thursday, August 09, 2012 3:58 PM
>
>On Thu, 2012-08-09 at 06:49 +, Ren, Cloud wrote:
>> Luis has ever asked joe for adding as a Signed-off-by. At that time
>> joe agreed with it.
>
>What I replied to Luis and some
On Thu, 2012-08-09 at 06:49 +, Ren, Cloud wrote:
> Luis has ever asked joe for adding as a Signed-off-by. At that time joe agreed
> with it.
What I replied to Luis and some qca list was:
On Fri, 2012-01-20 at 19:49 -0800, Joe Perches wrote:
> On Fri, 2012-01-20 at 18:25 -0800, Luis R.
>Luis
>Subject: Re: [PATCH] net: add new QCA alx ethernet driver
>
>From: "Ren, Cloud"
>Date: Thu, 9 Aug 2012 04:44:08 +
>
>> I only want to do some additional explanations to david. It makes nothing
>> with
>original patch.
>
>Stop this TOP POST
From: "Ren, Cloud"
Date: Thu, 9 Aug 2012 04:44:08 +
> I only want to do some additional explanations to david. It makes nothing
> with original patch.
Stop this TOP POSTING, it's bad etiquette on a technical mailing list.
Look at how other people write their email responses on this
From: Joe Perches
Date: Wed, 08 Aug 2012 21:09:42 -0700
> On Thu, 2012-08-09 at 02:27 +, Ren, Cloud wrote:
>> Hi David,
> []
>> The alx driver only supports two new nics(l1f/l2f) now. It doesn't
>> supersede atl1c driver.
>> Atl1c driver still supports old nics.
> []
>> -Original
From: "Ren, Cloud"
Date: Thu, 9 Aug 2012 02:27:35 +
> The alx driver only supports two new nics(l1f/l2f) now. It doesn't supersede
> atl1c driver.
> Atl1c driver still supports old nics.
There is no worse act than quoting a huge patch, only to provide two
lines of text.
Doing so is an
From: Ren, Cloud cj...@qca.qualcomm.com
Date: Thu, 9 Aug 2012 02:27:35 +
The alx driver only supports two new nics(l1f/l2f) now. It doesn't supersede
atl1c driver.
Atl1c driver still supports old nics.
There is no worse act than quoting a huge patch, only to provide two
lines of text.
From: Joe Perches j...@perches.com
Date: Wed, 08 Aug 2012 21:09:42 -0700
On Thu, 2012-08-09 at 02:27 +, Ren, Cloud wrote:
Hi David,
[]
The alx driver only supports two new nics(l1f/l2f) now. It doesn't
supersede atl1c driver.
Atl1c driver still supports old nics.
[]
-Original
From: Ren, Cloud cj...@qca.qualcomm.com
Date: Thu, 9 Aug 2012 04:44:08 +
I only want to do some additional explanations to david. It makes nothing
with original patch.
Stop this TOP POSTING, it's bad etiquette on a technical mailing list.
Look at how other people write their email
: add new QCA alx ethernet driver
From: Ren, Cloud cj...@qca.qualcomm.com
Date: Thu, 9 Aug 2012 04:44:08 +
I only want to do some additional explanations to david. It makes nothing
with
original patch.
Stop this TOP POSTING, it's bad etiquette on a technical mailing list.
Look at how
On Thu, 2012-08-09 at 06:49 +, Ren, Cloud wrote:
Luis has ever asked joe for adding as a Signed-off-by. At that time joe agreed
with it.
What I replied to Luis and some qca list was:
On Fri, 2012-01-20 at 19:49 -0800, Joe Perches wrote:
On Fri, 2012-01-20 at 18:25 -0800, Luis R. Rodriguez
-Original Message-
From: Joe Perches [mailto:j...@perches.com]
Sent: Thursday, August 09, 2012 3:58 PM
On Thu, 2012-08-09 at 06:49 +, Ren, Cloud wrote:
Luis has ever asked joe for adding as a Signed-off-by. At that time
joe agreed with it.
What I replied to Luis and some qca list
On Thu, Aug 09, 2012 at 06:49:25AM +, Ren, Cloud wrote:
Please calm down. I will follow rule of sending email from now on. Sorry for
causing
your trouble. Luis has ever asked joe for adding as a Signed-off-by. At that
time joe agreed
with it. If joe prefers his name not be listed as a
On Thu, 2012-08-09 at 10:54 -0400, Steven Rostedt wrote:
On Thu, Aug 09, 2012 at 06:49:25AM +, Ren, Cloud wrote:
Luis has ever asked joe for adding as a Signed-off-by.
[]
I'm curious, did Luis ask on list or off?
Off vger lists with some qca list or exploder added.
The Signed-off tag
On Thu, 2012-08-09 at 08:22 -0700, Joe Perches wrote:
Yes, I sent signed-off patches to their original RFC submission
(back last year?). To me, this single large patch is like a
snapshot of a git tree and not all contributors to that git
tree should be noted as signers of the entire thing.
On Thu, 2012-08-09 at 11:28 -0400, Steven Rostedt wrote:
On Thu, 2012-08-09 at 08:22 -0700, Joe Perches wrote:
Yes, I sent signed-off patches to their original RFC submission
(back last year?). To me, this single large patch is like a
snapshot of a git tree and not all contributors to
On Thu, Aug 9, 2012 at 8:28 AM, Steven Rostedt rost...@goodmis.org wrote:
On Thu, 2012-08-09 at 08:22 -0700, Joe Perches wrote:
Yes, I sent signed-off patches to their original RFC submission
(back last year?).
And that is why your SOB was kept.
To me, this single large patch is like a
On Thu, Aug 9, 2012 at 12:13 PM, Luis R. Rodriguez
rodri...@qca.qualcomm.com wrote:
So -- are we OK to *not* include SOBs of evolutions sent to developers
of joojoo-1 when company x submits joojoo-2 so long as those patches
were sent publicly or a record is kept somewhere ?
And lets be fair,
The alterations to the description of atl1c ought to be broken out as a
separate patch, though.
Yes, we will separate it. thanks !
-Xiong
@vger.kernel.org;
qca-linux-team; nic-devel; Huang, Xiong; Hao-Ran Liu(Joseph Liu); Rodriguez,
Luis
Subject: RE: [PATCH] net: add new QCA alx ethernet driver
On Thu, 2012-08-09 at 02:27 +, Ren, Cloud wrote:
> Hi David,
[]
> The alx driver only supports two new nics(l1f/l2f) now. It doesn't sup
On Thu, 2012-08-09 at 02:27 +, Ren, Cloud wrote:
> Hi David,
[]
> The alx driver only supports two new nics(l1f/l2f) now. It doesn't supersede
> atl1c driver.
> Atl1c driver still supports old nics.
[]
> -Original Message-
> From: Ren, Cloud
> Sent: 2012年8月9日 18:15
[]
> This driver
On Thu, 2012-08-09 at 02:27 +, Ren, Cloud wrote:
Hi David,
[]
The alx driver only supports two new nics(l1f/l2f) now. It doesn't supersede
atl1c driver.
Atl1c driver still supports old nics.
[]
-Original Message-
From: Ren, Cloud
Sent: 2012年8月9日 18:15
[]
This driver support
@vger.kernel.org;
qca-linux-team; nic-devel; Huang, Xiong; Hao-Ran Liu(Joseph Liu); Rodriguez,
Luis
Subject: RE: [PATCH] net: add new QCA alx ethernet driver
On Thu, 2012-08-09 at 02:27 +, Ren, Cloud wrote:
Hi David,
[]
The alx driver only supports two new nics(l1f/l2f) now. It doesn't supersede
48 matches
Mail list logo
