RE: [PATCH] net: add new QCA alx ethernet driver
From: Joe Perches [mailto:j...@perches.com] Sent: Thursday, August 16, 2012 9:16 PM >Hi Cloud. Please convert this to > > netdev_printk(level, hw->adpt->netdev, "%pV", ); > >I will submit a patch soon to make the __netdev_printk variant static. Ok, thanks.
Re: [PATCH] net: add new QCA alx ethernet driver
On Thu, 2012-08-16 at 01:53 +0800, cj...@qca.qualcomm.com wrote:
> From: Cloud Ren
>
> This driver support two new ethernet chipsets:
> 1969:1091 - AR8161 Gigabit Ethernet
> 1969:1090 - AR8162 Fast Ethernet
[]
> diff --git a/drivers/net/ethernet/atheros/alx/alx_main.c
> b/drivers/net/ethernet/atheros/alx/alx_main.c
[]
> +/*
> + * alx_hw_printk
> + */
> +void alx_hw_printk(const char *level, const struct alx_hw *hw,
> +const char *fmt, ...)
> +{
> + struct va_format vaf;
> + va_list args;
> +
> + va_start(args, fmt);
> + vaf.fmt = fmt;
> + vaf.va =
> +
> + if (hw && hw->adpt && hw->adpt->netdev)
> + __netdev_printk(level, hw->adpt->netdev, );
Hi Cloud. Please convert this to
netdev_printk(level, hw->adpt->netdev, "%pV", );
I will submit a patch soon to make the __netdev_printk variant static.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
On Thu, 2012-08-16 at 01:53 +0800, cj...@qca.qualcomm.com wrote:
From: Cloud Ren cj...@qca.qualcomm.com
This driver support two new ethernet chipsets:
1969:1091 - AR8161 Gigabit Ethernet
1969:1090 - AR8162 Fast Ethernet
[]
diff --git a/drivers/net/ethernet/atheros/alx/alx_main.c
b/drivers/net/ethernet/atheros/alx/alx_main.c
[]
+/*
+ * alx_hw_printk
+ */
+void alx_hw_printk(const char *level, const struct alx_hw *hw,
+const char *fmt, ...)
+{
+ struct va_format vaf;
+ va_list args;
+
+ va_start(args, fmt);
+ vaf.fmt = fmt;
+ vaf.va = args;
+
+ if (hw hw-adpt hw-adpt-netdev)
+ __netdev_printk(level, hw-adpt-netdev, vaf);
Hi Cloud. Please convert this to
netdev_printk(level, hw-adpt-netdev, %pV, vaf);
I will submit a patch soon to make the __netdev_printk variant static.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] net: add new QCA alx ethernet driver
From: Joe Perches [mailto:j...@perches.com] Sent: Thursday, August 16, 2012 9:16 PM Hi Cloud. Please convert this to netdev_printk(level, hw-adpt-netdev, %pV, vaf); I will submit a patch soon to make the __netdev_printk variant static. Ok, thanks.
RE: [PATCH] net: add new QCA alx ethernet driver
From: Stephen Hemminger [mailto:shemmin...@vyatta.com] Sent: Wednesday, August 15, 2012 11:02 PM >> + strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - >1); >> ... >> + strcpy(netdev->name, "eth%d"); >> + retval = register_netdev(netdev); >> >>> >> >>>The strcpy is unnecessary, alloc_etherdev already sets that. >> >> >> >> The strcpy is useful. netdev->name is set as pci_name in front. So the >> >> strcpy >> >restores it. >> > >> >Are you doing this just to influence the initial driver log messages? >> >> Yes. >> >> > >> >Don't do that, it's gross. >> >> Ok, I will remove it. > >Before the driver is registered, use dev_info() type of logging. Ok, I will do. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
On Wed, 15 Aug 2012 05:39:11 + "Ren, Cloud" wrote: > From: David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, August 15, 2012 1:33 PM > > >From: "Ren, Cloud" > >Date: Wed, 15 Aug 2012 03:29:26 + > > > +strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1); > ... > +strcpy(netdev->name, "eth%d"); > +retval = register_netdev(netdev); > >>> > >>>The strcpy is unnecessary, alloc_etherdev already sets that. > >> > >> The strcpy is useful. netdev->name is set as pci_name in front. So the > >> strcpy > >restores it. > > > >Are you doing this just to influence the initial driver log messages? > > Yes. > > > > >Don't do that, it's gross. > > Ok, I will remove it. Before the driver is registered, use dev_info() type of logging. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
On Wed, 15 Aug 2012 05:39:11 + Ren, Cloud cj...@qca.qualcomm.com wrote: From: David Miller [mailto:da...@davemloft.net] Sent: Wednesday, August 15, 2012 1:33 PM From: Ren, Cloud cj...@qca.qualcomm.com Date: Wed, 15 Aug 2012 03:29:26 + +strncpy(netdev-name, pci_name(pdev), sizeof(netdev-name) - 1); ... +strcpy(netdev-name, eth%d); +retval = register_netdev(netdev); The strcpy is unnecessary, alloc_etherdev already sets that. The strcpy is useful. netdev-name is set as pci_name in front. So the strcpy restores it. Are you doing this just to influence the initial driver log messages? Yes. Don't do that, it's gross. Ok, I will remove it. Before the driver is registered, use dev_info() type of logging. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] net: add new QCA alx ethernet driver
From: Stephen Hemminger [mailto:shemmin...@vyatta.com] Sent: Wednesday, August 15, 2012 11:02 PM + strncpy(netdev-name, pci_name(pdev), sizeof(netdev-name) - 1); ... + strcpy(netdev-name, eth%d); + retval = register_netdev(netdev); The strcpy is unnecessary, alloc_etherdev already sets that. The strcpy is useful. netdev-name is set as pci_name in front. So the strcpy restores it. Are you doing this just to influence the initial driver log messages? Yes. Don't do that, it's gross. Ok, I will remove it. Before the driver is registered, use dev_info() type of logging. Ok, I will do. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] net: add new QCA alx ethernet driver
From: David Miller [mailto:da...@davemloft.net] Sent: Wednesday, August 15, 2012 1:33 PM >From: "Ren, Cloud" >Date: Wed, 15 Aug 2012 03:29:26 + > + strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1); ... + strcpy(netdev->name, "eth%d"); + retval = register_netdev(netdev); >>> >>>The strcpy is unnecessary, alloc_etherdev already sets that. >> >> The strcpy is useful. netdev->name is set as pci_name in front. So the strcpy >restores it. > >Are you doing this just to influence the initial driver log messages? Yes. > >Don't do that, it's gross. Ok, I will remove it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
From: "Ren, Cloud" Date: Wed, 15 Aug 2012 03:29:26 + >>> + strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1); >>> ... >>> + strcpy(netdev->name, "eth%d"); >>> + retval = register_netdev(netdev); >> >>The strcpy is unnecessary, alloc_etherdev already sets that. > > The strcpy is useful. netdev->name is set as pci_name in front. So the strcpy > restores it. Are you doing this just to influence the initial driver log messages? Don't do that, it's gross. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] net: add new QCA alx ethernet driver
>> +strncpy(netdev->name, pci_name(pdev), sizeof(netdev->name) - 1); >> ... >> +strcpy(netdev->name, "eth%d"); >> +retval = register_netdev(netdev); > >The strcpy is unnecessary, alloc_etherdev already sets that. The strcpy is useful. netdev->name is set as pci_name in front. So the strcpy restores it. Thanks cloud -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] net: add new QCA alx ethernet driver
+strncpy(netdev-name, pci_name(pdev), sizeof(netdev-name) - 1); ... +strcpy(netdev-name, eth%d); +retval = register_netdev(netdev); The strcpy is unnecessary, alloc_etherdev already sets that. The strcpy is useful. netdev-name is set as pci_name in front. So the strcpy restores it. Thanks cloud -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
From: Ren, Cloud cj...@qca.qualcomm.com Date: Wed, 15 Aug 2012 03:29:26 + + strncpy(netdev-name, pci_name(pdev), sizeof(netdev-name) - 1); ... + strcpy(netdev-name, eth%d); + retval = register_netdev(netdev); The strcpy is unnecessary, alloc_etherdev already sets that. The strcpy is useful. netdev-name is set as pci_name in front. So the strcpy restores it. Are you doing this just to influence the initial driver log messages? Don't do that, it's gross. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] net: add new QCA alx ethernet driver
From: David Miller [mailto:da...@davemloft.net] Sent: Wednesday, August 15, 2012 1:33 PM From: Ren, Cloud cj...@qca.qualcomm.com Date: Wed, 15 Aug 2012 03:29:26 + + strncpy(netdev-name, pci_name(pdev), sizeof(netdev-name) - 1); ... + strcpy(netdev-name, eth%d); + retval = register_netdev(netdev); The strcpy is unnecessary, alloc_etherdev already sets that. The strcpy is useful. netdev-name is set as pci_name in front. So the strcpy restores it. Are you doing this just to influence the initial driver log messages? Yes. Don't do that, it's gross. Ok, I will remove it. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] net: add new QCA alx ethernet driver
> From: Stephen Hemminger [mailto:shemmin...@vyatta.com] > Sent: Sunday, August 12, 2012 4:51 > To: Ren, Cloud > > + strcpy(netdev->name, "eth%d"); > > + retval = register_netdev(netdev); > > The strcpy is unnecessary, alloc_etherdev already sets that. Thanks, Hemminger, we will remove this line in the next post. -Xiong -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] net: add new QCA alx ethernet driver
From: Stephen Hemminger [mailto:shemmin...@vyatta.com] Sent: Sunday, August 12, 2012 4:51 To: Ren, Cloud + strcpy(netdev-name, eth%d); + retval = register_netdev(netdev); The strcpy is unnecessary, alloc_etherdev already sets that. Thanks, Hemminger, we will remove this line in the next post. -Xiong -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
On Thu, 9 Aug 2012 18:14:30 +0800 wrote: > + strcpy(netdev->name, "eth%d"); > + retval = register_netdev(netdev); The strcpy is unnecessary, alloc_etherdev already sets that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
On Thu, 9 Aug 2012 18:14:30 +0800 cj...@qca.qualcomm.com wrote: + strcpy(netdev-name, eth%d); + retval = register_netdev(netdev); The strcpy is unnecessary, alloc_etherdev already sets that. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] net: add new QCA alx ethernet driver
> The alterations to the description of atl1c ought to be broken out as a > separate patch, though. > Yes, we will separate it. thanks ! -Xiong
Re: [PATCH] net: add new QCA alx ethernet driver
On Thu, Aug 9, 2012 at 12:13 PM, Luis R. Rodriguez wrote: > So -- are we OK to *not* include SOBs of evolutions sent to developers > of joojoo-1 when company x submits joojoo-2 so long as those patches > were sent publicly or a record is kept somewhere ? And lets be fair, some folks *may* want their SOB passed along to the second joojoo-2, its hard to please everyone but so long as we can decide on a method -- then great, we don't have to come back to this again and then we can add this as documentation. I'm inclined to prefer to not have the small patch submitters SOB tag if their patch to joojoo-1 was public and in it they did have a SOB tag, given that in practice *a few* secondary patch submitters tend to get surprised when their SOB is added to a secondary patch submission if they only contributed a few lines. To be clear the SOB does not have anything to do with how many lines you contributed, its meaning is here: http://gerrit.googlecode.com/svn-history/r1526/documentation/2.1.2/user-signedoffby.html So even if those secondary patch submitters *think* it has to do with volume of code, perhaps its best in practice to not include them so long as we have a record of the original small patch submission publicly and with a SOB tag. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
On Thu, Aug 9, 2012 at 8:28 AM, Steven Rostedt wrote: > On Thu, 2012-08-09 at 08:22 -0700, Joe Perches wrote: > >> Yes, I sent signed-off patches to their original RFC submission >> (back last year?). And that is why your SOB was kept. >> To me, this single large patch is like a >> snapshot of a git tree and not all contributors to that git >> tree should be noted as signers of the entire thing. I am not sure we really ever addressed this technical difference and from what I have seen we always run into this question on new driver submissions. Entity x goes on and posts driver joojoo-1, and we some folks in the community may merge such patch onto their tree and edit the driver and send some of their own changes and improvements to the developers / mailing list. Typically if the patches sent had a SOB tag the right thing to due given the legal implications of the Developer's Certificate of Origin is to add those SOBs to the new driver submission if company x goes on and posts joojoo-2.. but... > Ouch, that looks like we are losing all history. Agreed! It'd be best instead to have such changes as part of a linear history somewhere so maybe what would be right prior to inclusion upstream is for such patches to be merged on an external github tree or wherever to be able to keep record of the submissions done during development. Then upon submission to the Linux kernel again as joojoo-2 instead of joojoo-1 company x would simply provide their own SOB, and the record of the previous SOBs would be kept on the forked git tree. Whether or not it is required to have the SOB tog of previous patch submitters is not clear but to me its not necessary if you have a record somewhere that they were submitted and merged in some other tree. The mailing list alone may serve as a good place holder for this information as well so a separate tree may not be required. So -- are we OK to *not* include SOBs of evolutions sent to developers of joojoo-1 when company x submits joojoo-2 so long as those patches were sent publicly or a record is kept somewhere ? > One large patch should not be submitted. If it was developed in steps, > then it is best to show those steps when they are incorporated into the > Linux repository. Sure, but at times some changes are asked after a submission of joojoo-1, and at times this may be ongoing until maybe even joojoo-10, before we are happy to merge it upstream. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
On Thu, 2012-08-09 at 11:28 -0400, Steven Rostedt wrote: > On Thu, 2012-08-09 at 08:22 -0700, Joe Perches wrote: > > > Yes, I sent signed-off patches to their original RFC submission > > (back last year?). To me, this single large patch is like a > > snapshot of a git tree and not all contributors to that git > > tree should be noted as signers of the entire thing. > > Ouch, that looks like we are losing all history. > > One large patch should not be submitted. If it was developed in steps, > then it is best to show those steps when they are incorporated into the > Linux repository. > > Sure, the patches may be reworked and folded together where appropriate, > but when I read "this single large patch is like a snapshot of a git > tree", that right there is a red flag. I don't think this has ever been a requirement for new drivers. The alterations to the description of atl1c ought to be broken out as a separate patch, though. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
On Thu, 2012-08-09 at 08:22 -0700, Joe Perches wrote: > Yes, I sent signed-off patches to their original RFC submission > (back last year?). To me, this single large patch is like a > snapshot of a git tree and not all contributors to that git > tree should be noted as signers of the entire thing. Ouch, that looks like we are losing all history. One large patch should not be submitted. If it was developed in steps, then it is best to show those steps when they are incorporated into the Linux repository. Sure, the patches may be reworked and folded together where appropriate, but when I read "this single large patch is like a snapshot of a git tree", that right there is a red flag. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
On Thu, 2012-08-09 at 10:54 -0400, Steven Rostedt wrote: > On Thu, Aug 09, 2012 at 06:49:25AM +, Ren, Cloud wrote: > > Luis has ever asked joe for adding as a Signed-off-by. [] > I'm curious, did Luis ask on list or off? Off vger lists with some qca list or exploder added. > The Signed-off tag has some legal bindings (all other tags are for > credit/info only). It is that person saying that the changes they made > to a patch are theirs and are giving the right to distribute it. I believe I posted all patches I signed-off to vger lists. > The sign-off is a simple line at the end of the explanation for the > patch, which certifies that you wrote it or otherwise have the right to > pass it on as an open-source patch. > > Joe, If you actually modified part of the code in the patch, you do have > the right to add a signed-off-by tag. If you just made suggestions or > reviewed, then a 'Suggested-by' or 'Reviewed-by' tag would be more > appropriate. Yes, I sent signed-off patches to their original RFC submission (back last year?). To me, this single large patch is like a snapshot of a git tree and not all contributors to that git tree should be noted as signers of the entire thing. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
On Thu, Aug 09, 2012 at 06:49:25AM +, Ren, Cloud wrote: > > Please calm down. I will follow rule of sending email from now on. Sorry for > causing > your trouble. Luis has ever asked joe for adding as a Signed-off-by. At that > time joe agreed > with it. If joe prefers his name not be listed as a Signed-off-by, I will > respect his decision. > alx driver is innocent. Please help review. Thanks I'm curious, did Luis ask on list or off? When I ask someone for a Signed-off-by tag, I always ask them to post it to the list, even when they have given it to me privately. I like others to see that someone explicitly gave me their permission, as I would never add a Signed-off tag for someone else. The Signed-off tag has some legal bindings (all other tags are for credit/info only). It is that person saying that the changes they made to a patch are theirs and are giving the right to distribute it. It is also used by those that take the changes and insert it into the repository. >From Documentation/SubmittingPatches: The sign-off is a simple line at the end of the explanation for the patch, which certifies that you wrote it or otherwise have the right to pass it on as an open-source patch. Joe, If you actually modified part of the code in the patch, you do have the right to add a signed-off-by tag. If you just made suggestions or reviewed, then a 'Suggested-by' or 'Reviewed-by' tag would be more appropriate. The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] net: add new QCA alx ethernet driver
>-Original Message-
>From: Joe Perches [mailto:j...@perches.com]
>Sent: Thursday, August 09, 2012 3:58 PM
>
>On Thu, 2012-08-09 at 06:49 +, Ren, Cloud wrote:
>> Luis has ever asked joe for adding as a Signed-off-by. At that time
>> joe agreed with it.
>
>What I replied to Luis and some qca list was:
>
>On Fri, 2012-01-20 at 19:49 -0800, Joe Perches wrote:
>> On Fri, 2012-01-20 at 18:25 -0800, Luis R. Rodriguez wrote:
>> > Hey Joe, do you mind if we add your SOB tag on the next RFC for
>> > submission of this driver? I see all your patches were merged by Ren.
>> > I want to make sure you get proper credit for your contributions.
>> Whatever's appropriate.
>
>At this time I don't think what I did amounts to a sign-off of the whole
>driver.
>
>I appreciate the thoughtfulness of trying to credit me as a person by improving
>the driver a little. I just wouldn't say I signed off on the whole thing.
>
>cheers, Joe
>
Thanks for your help with alx driver. I will respect your any decisions. I will
remove your
Signed-off-by. Thanks.
cloud
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z� �w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i
RE: [PATCH] net: add new QCA alx ethernet driver
On Thu, 2012-08-09 at 06:49 +, Ren, Cloud wrote: > Luis has ever asked joe for adding as a Signed-off-by. At that time joe agreed > with it. What I replied to Luis and some qca list was: On Fri, 2012-01-20 at 19:49 -0800, Joe Perches wrote: > On Fri, 2012-01-20 at 18:25 -0800, Luis R. Rodriguez wrote: > > Hey Joe, do you mind if we add your SOB tag on the next RFC for > > submission of this driver? I see all your patches were merged by Ren. > > I want to make sure you get proper credit for your contributions. > Whatever's appropriate. At this time I don't think what I did amounts to a sign-off of the whole driver. I appreciate the thoughtfulness of trying to credit me as a person by improving the driver a little. I just wouldn't say I signed off on the whole thing. cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] net: add new QCA alx ethernet driver
>-Original Message- >From: David Miller [mailto:da...@davemloft.net] >Sent: 2012年8月9日 14:18 >To: Ren, Cloud >Cc: j...@perches.com; net...@vger.kernel.org; linux-kernel@vger.kernel.org; >qca-linux-team; nic-devel; Huang, Xiong; hao-ran@canonical.com; Rodriguez, >Luis >Subject: Re: [PATCH] net: add new QCA alx ethernet driver > >From: "Ren, Cloud" >Date: Thu, 9 Aug 2012 04:44:08 + > >> I only want to do some additional explanations to david. It makes nothing >> with >original patch. > >Stop this TOP POSTING, it's bad etiquette on a technical mailing list. > >Look at how other people write their email responses on this mailing list. >They >first provide a quoted portion of what they are replying >to: > >> Quoted >> something like this. > >And then they provide their response UNDERNEATH. > >When you provide your response at the top of the email, it is unexpected, and >makes more work for people reading what you write. > >You guys are doing everything possibly wrong. > >You have unnecessarily quoted a HUGE patch just to provide some ancillary in >formation. > >You are TOP POSTING. > >You added a signoff of someone who did not give you explicit permission to do >so. > >And you seem to not comprehend nor care about the implications or effects of >your actions that are hurting other people and creating a huge brudon. > >I very much intend to simply ignore your work completely until you can get your >act in gear, write proper emails, and submit patches properly. > >It is the only deterrant I have for your incredibly rude and inconsiderate >behavior. Hi David, Please calm down. I will follow rule of sending email from now on. Sorry for causing your trouble. Luis has ever asked joe for adding as a Signed-off-by. At that time joe agreed with it. If joe prefers his name not be listed as a Signed-off-by, I will respect his decision. alx driver is innocent. Please help review. Thanks cloud
Re: [PATCH] net: add new QCA alx ethernet driver
From: "Ren, Cloud" Date: Thu, 9 Aug 2012 04:44:08 + > I only want to do some additional explanations to david. It makes nothing > with original patch. Stop this TOP POSTING, it's bad etiquette on a technical mailing list. Look at how other people write their email responses on this mailing list. They first provide a quoted portion of what they are replying to: > Quoted > something like this. And then they provide their response UNDERNEATH. When you provide your response at the top of the email, it is unexpected, and makes more work for people reading what you write. You guys are doing everything possibly wrong. You have unnecessarily quoted a HUGE patch just to provide some ancillary in formation. You are TOP POSTING. You added a signoff of someone who did not give you explicit permission to do so. And you seem to not comprehend nor care about the implications or effects of your actions that are hurting other people and creating a huge brudon. I very much intend to simply ignore your work completely until you can get your act in gear, write proper emails, and submit patches properly. It is the only deterrant I have for your incredibly rude and inconsiderate behavior. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
From: Joe Perches Date: Wed, 08 Aug 2012 21:09:42 -0700 > On Thu, 2012-08-09 at 02:27 +, Ren, Cloud wrote: >> Hi David, > [] >> The alx driver only supports two new nics(l1f/l2f) now. It doesn't >> supersede atl1c driver. >> Atl1c driver still supports old nics. > [] >> -Original Message- >> From: Ren, Cloud >> Sent: 2012年8月9日 18:15 > [] >> This driver support two new ethernet chipsets: > > [+400kb of entire original patch] > > Did you really have to quote 400kb of original patch to > make that prefixing statement to David? > > [] > >> Signed-off-by: Joe Perches > > I would prefer my name not be listed as a Signed-off-by. You should never EVER add a signoff, or any other kind of tag, of another person unless they give it to you explicitly. It is beyond rude to do this without that person's permission. You qualcomm guys are really mishandling this patch submission, and just like last time you are steadily pissing me off. You have a very low level of consideration for other people who feel the burdon of your work, and you often have no idea what the hell you are doing. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
From: "Ren, Cloud" Date: Thu, 9 Aug 2012 02:27:35 + > The alx driver only supports two new nics(l1f/l2f) now. It doesn't supersede > atl1c driver. > Atl1c driver still supports old nics. There is no worse act than quoting a huge patch, only to provide two lines of text. Doing so is an enormous waste of resources, bandwith, and people's time. Everyone single person on the CC: list and the various mailing lists had to consume this entire patch a second time, just to see these two small lines of text you wanted to add. Are you even aware of the ramifications of your actions at all? If this lack of consideration extends to your actual coding as well, I very much dread reviewing your work. Please be incredibly more considerate and thoughtful with your email etiquette, or I will just plain flat out ignore your patch submissions entirely. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
From: Ren, Cloud cj...@qca.qualcomm.com Date: Thu, 9 Aug 2012 02:27:35 + The alx driver only supports two new nics(l1f/l2f) now. It doesn't supersede atl1c driver. Atl1c driver still supports old nics. There is no worse act than quoting a huge patch, only to provide two lines of text. Doing so is an enormous waste of resources, bandwith, and people's time. Everyone single person on the CC: list and the various mailing lists had to consume this entire patch a second time, just to see these two small lines of text you wanted to add. Are you even aware of the ramifications of your actions at all? If this lack of consideration extends to your actual coding as well, I very much dread reviewing your work. Please be incredibly more considerate and thoughtful with your email etiquette, or I will just plain flat out ignore your patch submissions entirely. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
From: Joe Perches j...@perches.com Date: Wed, 08 Aug 2012 21:09:42 -0700 On Thu, 2012-08-09 at 02:27 +, Ren, Cloud wrote: Hi David, [] The alx driver only supports two new nics(l1f/l2f) now. It doesn't supersede atl1c driver. Atl1c driver still supports old nics. [] -Original Message- From: Ren, Cloud Sent: 2012年8月9日 18:15 [] This driver support two new ethernet chipsets: [+400kb of entire original patch] Did you really have to quote 400kb of original patch to make that prefixing statement to David? [] Signed-off-by: Joe Perches j...@perches.com I would prefer my name not be listed as a Signed-off-by. You should never EVER add a signoff, or any other kind of tag, of another person unless they give it to you explicitly. It is beyond rude to do this without that person's permission. You qualcomm guys are really mishandling this patch submission, and just like last time you are steadily pissing me off. You have a very low level of consideration for other people who feel the burdon of your work, and you often have no idea what the hell you are doing. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
From: Ren, Cloud cj...@qca.qualcomm.com Date: Thu, 9 Aug 2012 04:44:08 + I only want to do some additional explanations to david. It makes nothing with original patch. Stop this TOP POSTING, it's bad etiquette on a technical mailing list. Look at how other people write their email responses on this mailing list. They first provide a quoted portion of what they are replying to: Quoted something like this. And then they provide their response UNDERNEATH. When you provide your response at the top of the email, it is unexpected, and makes more work for people reading what you write. You guys are doing everything possibly wrong. You have unnecessarily quoted a HUGE patch just to provide some ancillary in formation. You are TOP POSTING. You added a signoff of someone who did not give you explicit permission to do so. And you seem to not comprehend nor care about the implications or effects of your actions that are hurting other people and creating a huge brudon. I very much intend to simply ignore your work completely until you can get your act in gear, write proper emails, and submit patches properly. It is the only deterrant I have for your incredibly rude and inconsiderate behavior. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] net: add new QCA alx ethernet driver
-Original Message- From: David Miller [mailto:da...@davemloft.net] Sent: 2012年8月9日 14:18 To: Ren, Cloud Cc: j...@perches.com; net...@vger.kernel.org; linux-kernel@vger.kernel.org; qca-linux-team; nic-devel; Huang, Xiong; hao-ran@canonical.com; Rodriguez, Luis Subject: Re: [PATCH] net: add new QCA alx ethernet driver From: Ren, Cloud cj...@qca.qualcomm.com Date: Thu, 9 Aug 2012 04:44:08 + I only want to do some additional explanations to david. It makes nothing with original patch. Stop this TOP POSTING, it's bad etiquette on a technical mailing list. Look at how other people write their email responses on this mailing list. They first provide a quoted portion of what they are replying to: Quoted something like this. And then they provide their response UNDERNEATH. When you provide your response at the top of the email, it is unexpected, and makes more work for people reading what you write. You guys are doing everything possibly wrong. You have unnecessarily quoted a HUGE patch just to provide some ancillary in formation. You are TOP POSTING. You added a signoff of someone who did not give you explicit permission to do so. And you seem to not comprehend nor care about the implications or effects of your actions that are hurting other people and creating a huge brudon. I very much intend to simply ignore your work completely until you can get your act in gear, write proper emails, and submit patches properly. It is the only deterrant I have for your incredibly rude and inconsiderate behavior. Hi David, Please calm down. I will follow rule of sending email from now on. Sorry for causing your trouble. Luis has ever asked joe for adding as a Signed-off-by. At that time joe agreed with it. If joe prefers his name not be listed as a Signed-off-by, I will respect his decision. alx driver is innocent. Please help review. Thanks cloud
RE: [PATCH] net: add new QCA alx ethernet driver
On Thu, 2012-08-09 at 06:49 +, Ren, Cloud wrote: Luis has ever asked joe for adding as a Signed-off-by. At that time joe agreed with it. What I replied to Luis and some qca list was: On Fri, 2012-01-20 at 19:49 -0800, Joe Perches wrote: On Fri, 2012-01-20 at 18:25 -0800, Luis R. Rodriguez wrote: Hey Joe, do you mind if we add your SOB tag on the next RFC for submission of this driver? I see all your patches were merged by Ren. I want to make sure you get proper credit for your contributions. Whatever's appropriate. At this time I don't think what I did amounts to a sign-off of the whole driver. I appreciate the thoughtfulness of trying to credit me as a person by improving the driver a little. I just wouldn't say I signed off on the whole thing. cheers, Joe -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] net: add new QCA alx ethernet driver
-Original Message-
From: Joe Perches [mailto:j...@perches.com]
Sent: Thursday, August 09, 2012 3:58 PM
On Thu, 2012-08-09 at 06:49 +, Ren, Cloud wrote:
Luis has ever asked joe for adding as a Signed-off-by. At that time
joe agreed with it.
What I replied to Luis and some qca list was:
On Fri, 2012-01-20 at 19:49 -0800, Joe Perches wrote:
On Fri, 2012-01-20 at 18:25 -0800, Luis R. Rodriguez wrote:
Hey Joe, do you mind if we add your SOB tag on the next RFC for
submission of this driver? I see all your patches were merged by Ren.
I want to make sure you get proper credit for your contributions.
Whatever's appropriate.
At this time I don't think what I did amounts to a sign-off of the whole
driver.
I appreciate the thoughtfulness of trying to credit me as a person by improving
the driver a little. I just wouldn't say I signed off on the whole thing.
cheers, Joe
Thanks for your help with alx driver. I will respect your any decisions. I will
remove your
Signed-off-by. Thanks.
cloud
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�j:+v���zZ+��+zf���h���~i���z� �w���?��)ߢf��^jǫy�m��@A�a���
0��h���i
Re: [PATCH] net: add new QCA alx ethernet driver
On Thu, Aug 09, 2012 at 06:49:25AM +, Ren, Cloud wrote: Please calm down. I will follow rule of sending email from now on. Sorry for causing your trouble. Luis has ever asked joe for adding as a Signed-off-by. At that time joe agreed with it. If joe prefers his name not be listed as a Signed-off-by, I will respect his decision. alx driver is innocent. Please help review. Thanks I'm curious, did Luis ask on list or off? When I ask someone for a Signed-off-by tag, I always ask them to post it to the list, even when they have given it to me privately. I like others to see that someone explicitly gave me their permission, as I would never add a Signed-off tag for someone else. The Signed-off tag has some legal bindings (all other tags are for credit/info only). It is that person saying that the changes they made to a patch are theirs and are giving the right to distribute it. It is also used by those that take the changes and insert it into the repository. From Documentation/SubmittingPatches: The sign-off is a simple line at the end of the explanation for the patch, which certifies that you wrote it or otherwise have the right to pass it on as an open-source patch. Joe, If you actually modified part of the code in the patch, you do have the right to add a signed-off-by tag. If you just made suggestions or reviewed, then a 'Suggested-by' or 'Reviewed-by' tag would be more appropriate. The Signed-off-by: tag indicates that the signer was involved in the development of the patch, or that he/she was in the patch's delivery path. -- Steve -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
On Thu, 2012-08-09 at 10:54 -0400, Steven Rostedt wrote: On Thu, Aug 09, 2012 at 06:49:25AM +, Ren, Cloud wrote: Luis has ever asked joe for adding as a Signed-off-by. [] I'm curious, did Luis ask on list or off? Off vger lists with some qca list or exploder added. The Signed-off tag has some legal bindings (all other tags are for credit/info only). It is that person saying that the changes they made to a patch are theirs and are giving the right to distribute it. I believe I posted all patches I signed-off to vger lists. The sign-off is a simple line at the end of the explanation for the patch, which certifies that you wrote it or otherwise have the right to pass it on as an open-source patch. Joe, If you actually modified part of the code in the patch, you do have the right to add a signed-off-by tag. If you just made suggestions or reviewed, then a 'Suggested-by' or 'Reviewed-by' tag would be more appropriate. Yes, I sent signed-off patches to their original RFC submission (back last year?). To me, this single large patch is like a snapshot of a git tree and not all contributors to that git tree should be noted as signers of the entire thing. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
On Thu, 2012-08-09 at 08:22 -0700, Joe Perches wrote: Yes, I sent signed-off patches to their original RFC submission (back last year?). To me, this single large patch is like a snapshot of a git tree and not all contributors to that git tree should be noted as signers of the entire thing. Ouch, that looks like we are losing all history. One large patch should not be submitted. If it was developed in steps, then it is best to show those steps when they are incorporated into the Linux repository. Sure, the patches may be reworked and folded together where appropriate, but when I read this single large patch is like a snapshot of a git tree, that right there is a red flag. -- Steve -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
On Thu, 2012-08-09 at 11:28 -0400, Steven Rostedt wrote: On Thu, 2012-08-09 at 08:22 -0700, Joe Perches wrote: Yes, I sent signed-off patches to their original RFC submission (back last year?). To me, this single large patch is like a snapshot of a git tree and not all contributors to that git tree should be noted as signers of the entire thing. Ouch, that looks like we are losing all history. One large patch should not be submitted. If it was developed in steps, then it is best to show those steps when they are incorporated into the Linux repository. Sure, the patches may be reworked and folded together where appropriate, but when I read this single large patch is like a snapshot of a git tree, that right there is a red flag. I don't think this has ever been a requirement for new drivers. The alterations to the description of atl1c ought to be broken out as a separate patch, though. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
On Thu, Aug 9, 2012 at 8:28 AM, Steven Rostedt rost...@goodmis.org wrote: On Thu, 2012-08-09 at 08:22 -0700, Joe Perches wrote: Yes, I sent signed-off patches to their original RFC submission (back last year?). And that is why your SOB was kept. To me, this single large patch is like a snapshot of a git tree and not all contributors to that git tree should be noted as signers of the entire thing. I am not sure we really ever addressed this technical difference and from what I have seen we always run into this question on new driver submissions. Entity x goes on and posts driver joojoo-1, and we some folks in the community may merge such patch onto their tree and edit the driver and send some of their own changes and improvements to the developers / mailing list. Typically if the patches sent had a SOB tag the right thing to due given the legal implications of the Developer's Certificate of Origin is to add those SOBs to the new driver submission if company x goes on and posts joojoo-2.. but... Ouch, that looks like we are losing all history. Agreed! It'd be best instead to have such changes as part of a linear history somewhere so maybe what would be right prior to inclusion upstream is for such patches to be merged on an external github tree or wherever to be able to keep record of the submissions done during development. Then upon submission to the Linux kernel again as joojoo-2 instead of joojoo-1 company x would simply provide their own SOB, and the record of the previous SOBs would be kept on the forked git tree. Whether or not it is required to have the SOB tog of previous patch submitters is not clear but to me its not necessary if you have a record somewhere that they were submitted and merged in some other tree. The mailing list alone may serve as a good place holder for this information as well so a separate tree may not be required. So -- are we OK to *not* include SOBs of evolutions sent to developers of joojoo-1 when company x submits joojoo-2 so long as those patches were sent publicly or a record is kept somewhere ? One large patch should not be submitted. If it was developed in steps, then it is best to show those steps when they are incorporated into the Linux repository. Sure, but at times some changes are asked after a submission of joojoo-1, and at times this may be ongoing until maybe even joojoo-10, before we are happy to merge it upstream. Luis -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] net: add new QCA alx ethernet driver
On Thu, Aug 9, 2012 at 12:13 PM, Luis R. Rodriguez rodri...@qca.qualcomm.com wrote: So -- are we OK to *not* include SOBs of evolutions sent to developers of joojoo-1 when company x submits joojoo-2 so long as those patches were sent publicly or a record is kept somewhere ? And lets be fair, some folks *may* want their SOB passed along to the second joojoo-2, its hard to please everyone but so long as we can decide on a method -- then great, we don't have to come back to this again and then we can add this as documentation. I'm inclined to prefer to not have the small patch submitters SOB tag if their patch to joojoo-1 was public and in it they did have a SOB tag, given that in practice *a few* secondary patch submitters tend to get surprised when their SOB is added to a secondary patch submission if they only contributed a few lines. To be clear the SOB does not have anything to do with how many lines you contributed, its meaning is here: http://gerrit.googlecode.com/svn-history/r1526/documentation/2.1.2/user-signedoffby.html So even if those secondary patch submitters *think* it has to do with volume of code, perhaps its best in practice to not include them so long as we have a record of the original small patch submission publicly and with a SOB tag. Luis -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] net: add new QCA alx ethernet driver
The alterations to the description of atl1c ought to be broken out as a separate patch, though. Yes, we will separate it. thanks ! -Xiong
RE: [PATCH] net: add new QCA alx ethernet driver
Hi Jeo
I only want to do some additional explanations to david. It makes nothing with
original patch.
Thanks
cloud
-Original Message-
From: Joe Perches [mailto:j...@perches.com]
Sent: 2012年8月9日 12:10
To: Ren, Cloud
Cc: da...@davemloft.net; net...@vger.kernel.org; linux-kernel@vger.kernel.org;
qca-linux-team; nic-devel; Huang, Xiong; Hao-Ran Liu(Joseph Liu); Rodriguez,
Luis
Subject: RE: [PATCH] net: add new QCA alx ethernet driver
On Thu, 2012-08-09 at 02:27 +, Ren, Cloud wrote:
> Hi David,
[]
> The alx driver only supports two new nics(l1f/l2f) now. It doesn't supersede
> atl1c driver.
> Atl1c driver still supports old nics.
[]
> -Original Message-
> From: Ren, Cloud
> Sent: 2012年8月9日 18:15
[]
> This driver support two new ethernet chipsets:
[+400kb of entire original patch]
Did you really have to quote 400kb of original patch to make that prefixing
statement to David?
[]
> Signed-off-by: Joe Perches
I would prefer my name not be listed as a Signed-off-by.
I don't have a card, I never tested it, etc. What I did do is a light review
and made a couple of trivial patch suggestions about how you might make logging
code a bit smaller.
Thanks and cheers, Joe
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z� �w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i
RE: [PATCH] net: add new QCA alx ethernet driver
On Thu, 2012-08-09 at 02:27 +, Ren, Cloud wrote: > Hi David, [] > The alx driver only supports two new nics(l1f/l2f) now. It doesn't supersede > atl1c driver. > Atl1c driver still supports old nics. [] > -Original Message- > From: Ren, Cloud > Sent: 2012年8月9日 18:15 [] > This driver support two new ethernet chipsets: [+400kb of entire original patch] Did you really have to quote 400kb of original patch to make that prefixing statement to David? [] > Signed-off-by: Joe Perches I would prefer my name not be listed as a Signed-off-by. I don't have a card, I never tested it, etc. What I did do is a light review and made a couple of trivial patch suggestions about how you might make logging code a bit smaller. Thanks and cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] net: add new QCA alx ethernet driver
On Thu, 2012-08-09 at 02:27 +, Ren, Cloud wrote: Hi David, [] The alx driver only supports two new nics(l1f/l2f) now. It doesn't supersede atl1c driver. Atl1c driver still supports old nics. [] -Original Message- From: Ren, Cloud Sent: 2012年8月9日 18:15 [] This driver support two new ethernet chipsets: [+400kb of entire original patch] Did you really have to quote 400kb of original patch to make that prefixing statement to David? [] Signed-off-by: Joe Perches j...@perches.com I would prefer my name not be listed as a Signed-off-by. I don't have a card, I never tested it, etc. What I did do is a light review and made a couple of trivial patch suggestions about how you might make logging code a bit smaller. Thanks and cheers, Joe -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] net: add new QCA alx ethernet driver
Hi Jeo
I only want to do some additional explanations to david. It makes nothing with
original patch.
Thanks
cloud
-Original Message-
From: Joe Perches [mailto:j...@perches.com]
Sent: 2012年8月9日 12:10
To: Ren, Cloud
Cc: da...@davemloft.net; net...@vger.kernel.org; linux-kernel@vger.kernel.org;
qca-linux-team; nic-devel; Huang, Xiong; Hao-Ran Liu(Joseph Liu); Rodriguez,
Luis
Subject: RE: [PATCH] net: add new QCA alx ethernet driver
On Thu, 2012-08-09 at 02:27 +, Ren, Cloud wrote:
Hi David,
[]
The alx driver only supports two new nics(l1f/l2f) now. It doesn't supersede
atl1c driver.
Atl1c driver still supports old nics.
[]
-Original Message-
From: Ren, Cloud
Sent: 2012年8月9日 18:15
[]
This driver support two new ethernet chipsets:
[+400kb of entire original patch]
Did you really have to quote 400kb of original patch to make that prefixing
statement to David?
[]
Signed-off-by: Joe Perches j...@perches.com
I would prefer my name not be listed as a Signed-off-by.
I don't have a card, I never tested it, etc. What I did do is a light review
and made a couple of trivial patch suggestions about how you might make logging
code a bit smaller.
Thanks and cheers, Joe
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�j:+v���zZ+��+zf���h���~i���z� �w���?��)ߢf��^jǫy�m��@A�a���
0��h���i
