RE: [PATCH 1/1] sched/topology: Make sched_init_numa() use a set for the deduplicating sort

2021-02-01 Thread Valentin Schneider
On 29/01/21 02:02, Song Bao Hua (Barry Song) wrote: >> -Original Message- >> From: Valentin Schneider [mailto:valentin.schnei...@arm.com] >> That is another thing that's worth considering. Morten was arguing that if >> the distance between two nodes is so tiny, it might not be worth >>

Re: [PATCH 1/1] sched/topology: Make sched_init_numa() use a set for the deduplicating sort

2021-02-01 Thread Valentin Schneider
On 01/02/21 10:53, Dietmar Eggemann wrote: > On 22/01/2021 13:39, Valentin Schneider wrote: > > [...] > >> @@ -1705,7 +1702,7 @@ void sched_init_numa(void) >> /* Compute default topology size */ >> for (i = 0; sched_domain_topology[i].mask; i++); >> >> -tl = kzalloc((i + level + 1) *

RE: [PATCH 1/1] sched/topology: Make sched_init_numa() use a set for the deduplicating sort

2021-02-01 Thread Song Bao Hua (Barry Song)
smus...@arm.com; mgor...@suse.de; Song Bao Hua (Barry Song) > > Subject: Re: [PATCH 1/1] sched/topology: Make sched_init_numa() use a set for > the deduplicating sort > > On 22/01/2021 13:39, Valentin Schneider wrote: > > [...] > > > @@ -1705,7 +1702,7 @@ void sched_

Re: [PATCH 1/1] sched/topology: Make sched_init_numa() use a set for the deduplicating sort

2021-02-01 Thread Vincent Guittot
On Mon, 1 Feb 2021 at 10:54, Dietmar Eggemann wrote: > > On 22/01/2021 13:39, Valentin Schneider wrote: > > [...] > > > @@ -1705,7 +1702,7 @@ void sched_init_numa(void) > > /* Compute default topology size */ > > for (i = 0; sched_domain_topology[i].mask; i++); > > > > - tl =

Re: [PATCH 1/1] sched/topology: Make sched_init_numa() use a set for the deduplicating sort

2021-02-01 Thread Dietmar Eggemann
On 22/01/2021 13:39, Valentin Schneider wrote: [...] > @@ -1705,7 +1702,7 @@ void sched_init_numa(void) > /* Compute default topology size */ > for (i = 0; sched_domain_topology[i].mask; i++); > > - tl = kzalloc((i + level + 1) * > + tl = kzalloc((i + nr_levels) * >

RE: [PATCH 1/1] sched/topology: Make sched_init_numa() use a set for the deduplicating sort

2021-01-28 Thread Song Bao Hua (Barry Song)
g; > dietmar.eggem...@arm.com; morten.rasmus...@arm.com; mgor...@suse.de > Subject: RE: [PATCH 1/1] sched/topology: Make sched_init_numa() use a set > for the deduplicating sort > > On 25/01/21 21:35, Song Bao Hua (Barry Song) wrote: > > I was using 5.11-rc1. One thing I'd like to

RE: [PATCH 1/1] sched/topology: Make sched_init_numa() use a set for the deduplicating sort

2021-01-28 Thread Valentin Schneider
On 25/01/21 21:35, Song Bao Hua (Barry Song) wrote: > I was using 5.11-rc1. One thing I'd like to mention is that: > > For the below topology: > +---+ +-+ > | node1 | 20 |node2| > | +--+ | > +---+---+ +-+ > | |12 > 12 |

RE: [PATCH 1/1] sched/topology: Make sched_init_numa() use a set for the deduplicating sort

2021-01-25 Thread Valentin Schneider
On 25/01/21 02:23, Song Bao Hua (Barry Song) wrote: > with the below topology: > qemu-system-aarch64 -M virt -nographic \ > -smp cpus=8 \ > -numa node,cpus=0-1,nodeid=0 \ > -numa node,cpus=2-3,nodeid=1 \ > -numa node,cpus=4-5,nodeid=2 \ > -numa node,cpus=6-7,nodeid=3 \ > -numa

RE: [PATCH 1/1] sched/topology: Make sched_init_numa() use a set for the deduplicating sort

2021-01-25 Thread Valentin Schneider
On 25/01/21 09:26, Valentin Schneider wrote: > On 25/01/21 02:23, Song Bao Hua (Barry Song) wrote: > >> with the below topology: >> qemu-system-aarch64 -M virt -nographic \ >> -smp cpus=8 \ >> -numa node,cpus=0-1,nodeid=0 \ >> -numa node,cpus=2-3,nodeid=1 \ >> -numa node,cpus=4-5,nodeid=2 \ >>

RE: [PATCH 1/1] sched/topology: Make sched_init_numa() use a set for the deduplicating sort

2021-01-25 Thread Song Bao Hua (Barry Song)
g; > dietmar.eggem...@arm.com; morten.rasmus...@arm.com; mgor...@suse.de > Subject: RE: [PATCH 1/1] sched/topology: Make sched_init_numa() use a set for > the deduplicating sort > > On 25/01/21 09:26, Valentin Schneider wrote: > > On 25/01/21 02:23, Song Bao Hua (Barry Song)

RE: [PATCH 1/1] sched/topology: Make sched_init_numa() use a set for the deduplicating sort

2021-01-24 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: Valentin Schneider [mailto:valentin.schnei...@arm.com] > Sent: Saturday, January 23, 2021 1:40 AM > To: linux-kernel@vger.kernel.org > Cc: mi...@kernel.org; pet...@infradead.org; vincent.guit...@linaro.org; > dietmar.eggem...@arm.com;