Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-10 Thread Jarkko Sakkinen
On Wed, 2018-03-07 at 11:35 -0500, Mimi Zohar wrote: > On Wed, 2018-03-07 at 08:54 -0700, Jonathan Corbet wrote: > > On Tue, 06 Mar 2018 13:36:36 -0500 > > Mimi Zohar wrote: > > > > > I've heard that some maintainers are moving away from cover letters, > > > since they are not include in the git

Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-10 Thread Jarkko Sakkinen
On Wed, 2018-03-07 at 08:54 -0700, Jonathan Corbet wrote: > On Tue, 06 Mar 2018 13:36:36 -0500 > Mimi Zohar wrote: > > > I've heard that some maintainers are moving away from cover letters, > > since they are not include in the git repo and are lost. > > If I get a patch series with a cover lett

Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-10 Thread Jarkko Sakkinen
On Tue, 2018-03-06 at 13:36 -0500, Mimi Zohar wrote: > I've heard that some maintainers are moving away from cover letters, > since they are not include in the git repo and are lost. I've seen > Andrew Morton cut and paste the cover letter in the first patch > description of the patch set. When I

Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-07 Thread Jonathan Corbet
On Wed, 07 Mar 2018 11:35:03 -0500 Mimi Zohar wrote: > Some maintainers are saying to put the Changelog after the "---" so > that it isn't included in the patch description. > > One of the reasons for including the Changelog in the patch > description, is to credit people with bug fixes, importa

Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-07 Thread Mimi Zohar
On Wed, 2018-03-07 at 08:54 -0700, Jonathan Corbet wrote: > On Tue, 06 Mar 2018 13:36:36 -0500 > Mimi Zohar wrote: > > > I've heard that some maintainers are moving away from cover letters, > > since they are not include in the git repo and are lost. > > If I get a patch series with a cover lett

RE: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-07 Thread Winkler, Tomas
> > On Tue, 06 Mar 2018 13:36:36 -0500 > Mimi Zohar wrote: > > > I've heard that some maintainers are moving away from cover letters, > > since they are not include in the git repo and are lost. > > If I get a patch series with a cover letter that should be preserved, I apply > the > series i

Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-07 Thread Jonathan Corbet
On Tue, 06 Mar 2018 13:36:36 -0500 Mimi Zohar wrote: > I've heard that some maintainers are moving away from cover letters, > since they are not include in the git repo and are lost. If I get a patch series with a cover letter that should be preserved, I apply the series in a branch then do a no

RE: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-07 Thread Winkler, Tomas
> > On Tue, 2018-03-06 at 14:59 -0700, Jason Gunthorpe wrote: > > On Tue, Mar 06, 2018 at 01:36:36PM -0500, Mimi Zohar wrote: > > > On Tue, 2018-03-06 at 08:32 -0800, James Bottomley wrote: > > > > On Tue, 2018-03-06 at 08:06 +, Winkler, Tomas wrote: > > > > > > > > > > > > > > > > > > On Mon

Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-07 Thread Mimi Zohar
On Tue, 2018-03-06 at 14:59 -0700, Jason Gunthorpe wrote: > On Tue, Mar 06, 2018 at 01:36:36PM -0500, Mimi Zohar wrote: > > On Tue, 2018-03-06 at 08:32 -0800, James Bottomley wrote: > > > On Tue, 2018-03-06 at 08:06 +, Winkler, Tomas wrote: > > > > > > > > > > > > > > > On Mon, Mar 05, 2018 a

Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-06 Thread Jason Gunthorpe
On Tue, Mar 06, 2018 at 01:36:36PM -0500, Mimi Zohar wrote: > On Tue, 2018-03-06 at 08:32 -0800, James Bottomley wrote: > > On Tue, 2018-03-06 at 08:06 +, Winkler, Tomas wrote: > > > > > > > > > > > > On Mon, Mar 05, 2018 at 01:09:09PM +, Winkler, Tomas wrote: > > > > > > > > > > Why you

Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-06 Thread Mimi Zohar
On Tue, 2018-03-06 at 08:32 -0800, James Bottomley wrote: > On Tue, 2018-03-06 at 08:06 +, Winkler, Tomas wrote: > > > > > > > > > On Mon, Mar 05, 2018 at 01:09:09PM +, Winkler, Tomas wrote: > > > > > > > > Why you need cover letter?  What are u missing in the patch > > > > description >

RE: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-06 Thread Winkler, Tomas
> > On Tue, 2018-03-06 at 08:06 +, Winkler, Tomas wrote: > > > > > > > > > On Mon, Mar 05, 2018 at 01:09:09PM +, Winkler, Tomas wrote: > > > > > > > > Why you need cover letter?  What are u missing in the patch > > > > description > > > > > > If you submit a *patch set* I *require* a cover

Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-06 Thread James Bottomley
On Tue, 2018-03-06 at 08:06 +, Winkler, Tomas wrote: > > > > > > On Mon, Mar 05, 2018 at 01:09:09PM +, Winkler, Tomas wrote: > > > > > > Why you need cover letter?  What are u missing in the patch > > > description > > > > If you submit a *patch set* I *require* a cover letter, yes. >

RE: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-06 Thread Winkler, Tomas
> > On Mon, Mar 05, 2018 at 06:04:56PM +, Winkler, Tomas wrote: > > > > > > On Mon, Mar 05, 2018 at 01:09:09PM +, Winkler, Tomas wrote: > > > > > enum tpm_duration { > > > > > TPM_DURATION_DEFAULT = 2000, > > > > > TPM_DURATION_LONG = 30, > > > > > }; > > > > > > > > > Ho

RE: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-06 Thread Winkler, Tomas
> > On Mon, Mar 05, 2018 at 01:09:09PM +, Winkler, Tomas wrote: > > Why you need cover letter? What are u missing in the patch description > > If you submit a *patch set* I *require* a cover letter, yes. It's good but it is not must, you are inventing your own rules. Thanks Tomas

Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-06 Thread Jarkko Sakkinen
On Mon, Mar 05, 2018 at 06:04:56PM +, Winkler, Tomas wrote: > > > > On Mon, Mar 05, 2018 at 01:09:09PM +, Winkler, Tomas wrote: > > > > enum tpm_duration { > > > > TPM_DURATION_DEFAULT = 2000, > > > > TPM_DURATION_LONG = 30, > > > > }; > > > > > > > How is this aligned

Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-05 Thread Jarkko Sakkinen
On Mon, Mar 05, 2018 at 01:09:09PM +, Winkler, Tomas wrote: > Why you need cover letter? What are u missing in the patch description If you submit a *patch set* I *require* a cover letter, yes. /Jarkko

RE: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-05 Thread Winkler, Tomas
> > On Mon, Mar 05, 2018 at 01:09:09PM +, Winkler, Tomas wrote: > > > enum tpm_duration { > > > TPM_DURATION_DEFAULT = 2000, > > > TPM_DURATION_LONG = 30, > > > }; > > > > > How is this aligned with the spec PTP spec? > > For TPM 2.0 that spec only partially defines durations for CCs

Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-05 Thread Jarkko Sakkinen
On Mon, Mar 05, 2018 at 01:09:09PM +, Winkler, Tomas wrote: > > enum tpm_duration { > > TPM_DURATION_DEFAULT = 2000, > > TPM_DURATION_LONG = 30, > > }; > > > How is this aligned with the spec PTP spec? For TPM 2.0 that spec only partially defines durations for CCs and thus our loo

RE: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-05 Thread Winkler, Tomas
nel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation > commands. > > On Sun, Mar 04, 2018 at 02:12:03PM +0200, Tomas Winkler wrote: > > TPM2_CC_Create(0x153) and TPM2_CC_CreatePrimary (0x131) involve > > generation of crypto

Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-05 Thread Jarkko Sakkinen
On Sun, Mar 04, 2018 at 02:12:03PM +0200, Tomas Winkler wrote: > TPM2_CC_Create(0x153) and TPM2_CC_CreatePrimary (0x131) involve generation > of crypto keys which can be a computationally intensive task. > The timeout is set to 3min. > > Signed-off-by: Tomas Winkler Where is the cover letter? Pl