RE: [PATCH 1/6] mfd: add lp8788 mfd driver

2012-08-09 Thread Kim, Milo
> > +static irqreturn_t lp8788_irq_handler(int irq, void *ptr) > > +{ > > + struct lp8788_irq_data *irqd = ptr; > > + unsigned long delay = msecs_to_jiffies(DEBOUNCE_MSEC); > > + > > + queue_delayed_work(irqd->thread, >work, delay); > > + > > + return IRQ_HANDLED; > > +} > > Why a delayed

RE: [PATCH 1/6] mfd: add lp8788 mfd driver

2012-08-09 Thread Kim, Milo
+static irqreturn_t lp8788_irq_handler(int irq, void *ptr) +{ + struct lp8788_irq_data *irqd = ptr; + unsigned long delay = msecs_to_jiffies(DEBOUNCE_MSEC); + + queue_delayed_work(irqd-thread, irqd-work, delay); + + return IRQ_HANDLED; +} Why a delayed work? That's

RE: [PATCH 1/6] mfd: add lp8788 mfd driver

2012-07-19 Thread Kim, Milo
> > +struct lp8788_irq_data { > > + struct lp8788 *lp; > > + struct irq_domain *irqdm; > > + struct mutex irq_lock; > > + struct delayed_work work; > > + struct workqueue_struct *thread; > > + int enabled[LP8788_INT_MAX]; > > + int irq; > > + int irq_base; > > +}; > > Can you use

RE: [PATCH 1/6] mfd: add lp8788 mfd driver

2012-07-19 Thread Kim, Milo
+struct lp8788_irq_data { + struct lp8788 *lp; + struct irq_domain *irqdm; + struct mutex irq_lock; + struct delayed_work work; + struct workqueue_struct *thread; + int enabled[LP8788_INT_MAX]; + int irq; + int irq_base; +}; Can you use regmap-irq? If not

Re: [PATCH 1/6] mfd: add lp8788 mfd driver

2012-07-18 Thread Mark Brown
On Wed, Jul 18, 2012 at 02:32:40PM +, Kim, Milo wrote: > +struct lp8788_irq_data { > + struct lp8788 *lp; > + struct irq_domain *irqdm; > + struct mutex irq_lock; > + struct delayed_work work; > + struct workqueue_struct *thread; > + int enabled[LP8788_INT_MAX]; > +

Re: [PATCH 1/6] mfd: add lp8788 mfd driver

2012-07-18 Thread Mark Brown
On Wed, Jul 18, 2012 at 02:32:40PM +, Kim, Milo wrote: +struct lp8788_irq_data { + struct lp8788 *lp; + struct irq_domain *irqdm; + struct mutex irq_lock; + struct delayed_work work; + struct workqueue_struct *thread; + int enabled[LP8788_INT_MAX]; + int