RE: [PATCH 5/6] clk: imx8mn: Add necessary frequency support for ARM PLL table
Hi, Stephen > Quoting Anson Huang (2019-08-17 15:22:01) > > Hi, Stephen > > > > > Quoting anson.hu...@nxp.com (2019-08-15 03:59:42) > > > > diff --git a/drivers/clk/imx/clk-imx8mn.c > > > > b/drivers/clk/imx/clk-imx8mn.c index ecd1062..3f1239a 100644 > > > > --- a/drivers/clk/imx/clk-imx8mn.c > > > > +++ b/drivers/clk/imx/clk-imx8mn.c > > > > @@ -82,6 +84,7 @@ static struct imx_pll14xx_clk imx8mn_dram_pll = > > > > { static struct imx_pll14xx_clk imx8mn_arm_pll = { > > > > .type = PLL_1416X, > > > > .rate_table = imx8mn_pll1416x_tbl, > > > > + .rate_count = ARRAY_SIZE(imx8mn_pll1416x_tbl), > > > > > > Why is rate_count added? That's not described in the commit text. > > > > rate_count is necessary for table search during set_rate, it was > > missed previously, I will add it into commit text in V2. > > > > Right, isn't that a more critical fix to make by itself instead of rolling > into this > change that adds a few more frequencies? Right, let me split this patch into two patches and resend the V2. Thanks, Anson.
RE: [PATCH 5/6] clk: imx8mn: Add necessary frequency support for ARM PLL table
Quoting Anson Huang (2019-08-17 15:22:01) > Hi, Stephen > > > Quoting anson.hu...@nxp.com (2019-08-15 03:59:42) > > > diff --git a/drivers/clk/imx/clk-imx8mn.c > > > b/drivers/clk/imx/clk-imx8mn.c index ecd1062..3f1239a 100644 > > > --- a/drivers/clk/imx/clk-imx8mn.c > > > +++ b/drivers/clk/imx/clk-imx8mn.c > > > @@ -82,6 +84,7 @@ static struct imx_pll14xx_clk imx8mn_dram_pll = { > > > static struct imx_pll14xx_clk imx8mn_arm_pll = { > > > .type = PLL_1416X, > > > .rate_table = imx8mn_pll1416x_tbl, > > > + .rate_count = ARRAY_SIZE(imx8mn_pll1416x_tbl), > > > > Why is rate_count added? That's not described in the commit text. > > rate_count is necessary for table search during set_rate, it was missed > previously, > I will add it into commit text in V2. > Right, isn't that a more critical fix to make by itself instead of rolling into this change that adds a few more frequencies?
RE: [PATCH 5/6] clk: imx8mn: Add necessary frequency support for ARM PLL table
Hi, Stephen > Quoting anson.hu...@nxp.com (2019-08-15 03:59:42) > > diff --git a/drivers/clk/imx/clk-imx8mn.c > > b/drivers/clk/imx/clk-imx8mn.c index ecd1062..3f1239a 100644 > > --- a/drivers/clk/imx/clk-imx8mn.c > > +++ b/drivers/clk/imx/clk-imx8mn.c > > @@ -82,6 +84,7 @@ static struct imx_pll14xx_clk imx8mn_dram_pll = { > > static struct imx_pll14xx_clk imx8mn_arm_pll = { > > .type = PLL_1416X, > > .rate_table = imx8mn_pll1416x_tbl, > > + .rate_count = ARRAY_SIZE(imx8mn_pll1416x_tbl), > > Why is rate_count added? That's not described in the commit text. rate_count is necessary for table search during set_rate, it was missed previously, I will add it into commit text in V2. Thanks, Anson.
Re: [PATCH 5/6] clk: imx8mn: Add necessary frequency support for ARM PLL table
Quoting anson.hu...@nxp.com (2019-08-15 03:59:42) > diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c > index ecd1062..3f1239a 100644 > --- a/drivers/clk/imx/clk-imx8mn.c > +++ b/drivers/clk/imx/clk-imx8mn.c > @@ -82,6 +84,7 @@ static struct imx_pll14xx_clk imx8mn_dram_pll = { > static struct imx_pll14xx_clk imx8mn_arm_pll = { > .type = PLL_1416X, > .rate_table = imx8mn_pll1416x_tbl, > + .rate_count = ARRAY_SIZE(imx8mn_pll1416x_tbl), Why is rate_count added? That's not described in the commit text.