RE: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-28 Thread Haiyang Zhang
inuxdriverproject.org > Subject: Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer > Driver > > On Fri, Feb 15, Haiyang Zhang wrote: > > > + if (fb_get_options("hyperv_fb", ) || !opt || !*opt) > > > + strcpy(info->fix.id, "hy

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-28 Thread Olaf Hering
On Fri, Feb 15, Haiyang Zhang wrote: > + if (fb_get_options("hyperv_fb", ) || !opt || !*opt) > + strcpy(info->fix.id, "hyperv"); Here is a mismatch between video= and /proc/fb output. Both should have the same string IMO. Olaf -- To unsubscribe from this list: send the line

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-28 Thread Olaf Hering
On Fri, Feb 15, Haiyang Zhang wrote: + if (fb_get_options(hyperv_fb, opt) || !opt || !*opt) + strcpy(info-fix.id, hyperv); Here is a mismatch between video=optname and /proc/fb output. Both should have the same string IMO. Olaf -- To unsubscribe from this list: send the line

RE: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-28 Thread Haiyang Zhang
Subject: Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver On Fri, Feb 15, Haiyang Zhang wrote: + if (fb_get_options(hyperv_fb, opt) || !opt || !*opt) + strcpy(info-fix.id, hyperv); Here is a mismatch between video=optname and /proc/fb output. Both should have

RE: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-21 Thread Haiyang Zhang
> From: Olaf Hering > Sent: Thursday, February 21, 2013 10:53 AM > To: Haiyang Zhang > Cc: florianschandi...@gmx.de; linux-fb...@vger.kernel.org; KY Srinivasan; > jasow...@redhat.com; linux-kernel@vger.kernel.org; > de...@linuxdriverproject.org > Subject: Re: [PATCH RF

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-21 Thread Olaf Hering
On Tue, Feb 19, Haiyang Zhang wrote: > > I havent read the vesafb code, but I think it can kind of give up the > > hardware, something ata_piix can not do. > > In my test, the vesafb doesn't automatically give up the emulated video > device, > unless I add the DMI based mechanism to let it exit

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-21 Thread Olaf Hering
On Tue, Feb 19, Haiyang Zhang wrote: I havent read the vesafb code, but I think it can kind of give up the hardware, something ata_piix can not do. In my test, the vesafb doesn't automatically give up the emulated video device, unless I add the DMI based mechanism to let it exit on

RE: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-21 Thread Haiyang Zhang
From: Olaf Hering Sent: Thursday, February 21, 2013 10:53 AM To: Haiyang Zhang Cc: florianschandi...@gmx.de; linux-fb...@vger.kernel.org; KY Srinivasan; jasow...@redhat.com; linux-kernel@vger.kernel.org; de...@linuxdriverproject.org Subject: Re: [PATCH RFC] video: Add Hyper-V Synthetic

RE: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-19 Thread Haiyang Zhang
rinivasan; > jasow...@redhat.com; linux-kernel@vger.kernel.org; > de...@linuxdriverproject.org > Subject: Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer > Driver > > On Tue, Feb 19, Haiyang Zhang wrote: > > > The emulated video device is a separate device from th

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-19 Thread Olaf Hering
On Tue, Feb 19, Haiyang Zhang wrote: > The emulated video device is a separate device from the synthetic video. > The synthetic driver can only take control of the synthetic video, but not > the emulated video. Please add this to the comment above. > Actually, we already have a similar

RE: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-19 Thread Haiyang Zhang
inuxdriverproject.org > Subject: Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer > Driver > > On Fri, Feb 15, Haiyang Zhang wrote: > > > @@ -508,6 +544,18 @@ static int __init vesafb_init(void) > > int ret; > > char *o

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-19 Thread Olaf Hering
On Fri, Feb 15, Haiyang Zhang wrote: > @@ -508,6 +544,18 @@ static int __init vesafb_init(void) > int ret; > char *option = NULL; > > +#if IS_ENABLED(CONFIG_HYPERV_FB) > + /* > + * On Hyper-V both the emulated and synthetic video devices are > + * available. To avoid

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-19 Thread Olaf Hering
On Fri, Feb 15, Haiyang Zhang wrote: @@ -508,6 +544,18 @@ static int __init vesafb_init(void) int ret; char *option = NULL; +#if IS_ENABLED(CONFIG_HYPERV_FB) + /* + * On Hyper-V both the emulated and synthetic video devices are + * available. To avoid

RE: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-19 Thread Haiyang Zhang
: Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver On Fri, Feb 15, Haiyang Zhang wrote: @@ -508,6 +544,18 @@ static int __init vesafb_init(void) int ret; char *option = NULL; +#if IS_ENABLED(CONFIG_HYPERV_FB) + /* +* On Hyper-V both

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-19 Thread Olaf Hering
On Tue, Feb 19, Haiyang Zhang wrote: The emulated video device is a separate device from the synthetic video. The synthetic driver can only take control of the synthetic video, but not the emulated video. Please add this to the comment above. Actually, we already have a similar mechanism in

RE: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-19 Thread Haiyang Zhang
; linux-kernel@vger.kernel.org; de...@linuxdriverproject.org Subject: Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver On Tue, Feb 19, Haiyang Zhang wrote: The emulated video device is a separate device from the synthetic video. The synthetic driver can only take

RE: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-18 Thread Haiyang Zhang
; > o...@aepfle.de; jasow...@redhat.com; linux-kernel@vger.kernel.org; > de...@linuxdriverproject.org > Subject: Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer > Driver > > On Fri, Feb 15, 2013 at 8:09 PM, Haiyang Zhang > wrote: > > +/* Allocate framebuf

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-18 Thread Geert Uytterhoeven
On Fri, Feb 15, 2013 at 8:09 PM, Haiyang Zhang wrote: > +/* Allocate framebuffer memory */ > +#define FOUR_MEGA (4*1024*1024) > +#define NALLOC 10 > +static void *hvfb_getmem(void) > +{ > + ulong *p; > + int i, j; > + ulong ret = 0; > + > + if (screen_fb_size == FOUR_MEGA)

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-18 Thread Geert Uytterhoeven
On Fri, Feb 15, 2013 at 8:09 PM, Haiyang Zhang haiya...@microsoft.com wrote: +/* Allocate framebuffer memory */ +#define FOUR_MEGA (4*1024*1024) +#define NALLOC 10 +static void *hvfb_getmem(void) +{ + ulong *p; + int i, j; + ulong ret = 0; + + if (screen_fb_size

RE: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-18 Thread Haiyang Zhang
...@redhat.com; linux-kernel@vger.kernel.org; de...@linuxdriverproject.org Subject: Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver On Fri, Feb 15, 2013 at 8:09 PM, Haiyang Zhang haiya...@microsoft.com wrote: +/* Allocate framebuffer memory */ Please instead reserve some

RE: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-17 Thread Haiyang Zhang
> From: Olaf Hering > Sent: Sunday, February 17, 2013 9:32 AM > To: Haiyang Zhang > Cc: florianschandi...@gmx.de; linux-fb...@vger.kernel.org; KY Srinivasan; > jasow...@redhat.com; linux-kernel@vger.kernel.org; > de...@linuxdriverproject.org > Subject: Re: [PATCH RF

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-17 Thread Olaf Hering
On Fri, Feb 15, Haiyang Zhang wrote: > +config HYPERV_FB This should probably be FB_HYPERB to follow the naming of all other drivers. Olaf -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-17 Thread Olaf Hering
On Fri, Feb 15, Haiyang Zhang wrote: +config HYPERV_FB This should probably be FB_HYPERB to follow the naming of all other drivers. Olaf -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

RE: [PATCH RFC] video: Add Hyper-V Synthetic Video Frame Buffer Driver

2013-02-17 Thread Haiyang Zhang
From: Olaf Hering Sent: Sunday, February 17, 2013 9:32 AM To: Haiyang Zhang Cc: florianschandi...@gmx.de; linux-fb...@vger.kernel.org; KY Srinivasan; jasow...@redhat.com; linux-kernel@vger.kernel.org; de...@linuxdriverproject.org Subject: Re: [PATCH RFC] video: Add Hyper-V Synthetic Video