RE: [PATCH net-next 1/1] net: stmmac: allow stmmac to probe for C45 PHY devices

2020-12-09 Thread Wong, Vee Khee



> -Original Message-
> From: Andrew Lunn 
> Sent: Thursday, December 10, 2020 12:09 AM
> To: Wong, Vee Khee 
> Cc: Giuseppe Cavallaro ; Alexandre Torgue
> ; Jose Abreu ; David
> S . Miller ; Jakub Kicinski ;
> Maxime Coquelin ; Voon, Weifeng
> ; net...@vger.kernel.org; linux-
> ker...@vger.kernel.org; Ong, Boon Leong ;
> linux-st...@st-md-mailman.stormreply.com; linux-arm-
> ker...@lists.infradead.org
> Subject: Re: [PATCH net-next 1/1] net: stmmac: allow stmmac to probe for
> C45 PHY devices
> 
> On Wed, Dec 09, 2020 at 07:19:33PM +0800, Wong Vee Khee wrote:
> > Assign stmmac's mdio_bus probe capabilities to MDIOBUS_C22_C45.
> > This extends the probing of C45 PHY devices on the MDIO bus.
> >
> > Signed-off-by: Wong Vee Khee 
> > ---
> >  drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> > index b2a707e2ef43..9f96bb7d27db 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> > @@ -364,6 +364,7 @@ int stmmac_mdio_register(struct net_device *ndev)
> > memcpy(new_bus->irq, mdio_bus_data->irqs,
> sizeof(new_bus->irq));
> >
> > new_bus->name = "stmmac";
> > +   new_bus->probe_capabilities = MDIOBUS_C22_C45;
> 
> It looks like this needs to be conditional on the version. xgmax2
> supports C45. And gmac4. But other versions don't.
> 
>Andrew

I will send a v2 with conditional checking for gmac4.
I do not have a xgmac2 hardware setup to test this.


Re: [PATCH net-next 1/1] net: stmmac: allow stmmac to probe for C45 PHY devices

2020-12-09 Thread Andrew Lunn
On Wed, Dec 09, 2020 at 07:19:33PM +0800, Wong Vee Khee wrote:
> Assign stmmac's mdio_bus probe capabilities to MDIOBUS_C22_C45.
> This extends the probing of C45 PHY devices on the MDIO bus.
> 
> Signed-off-by: Wong Vee Khee 
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c 
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> index b2a707e2ef43..9f96bb7d27db 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> @@ -364,6 +364,7 @@ int stmmac_mdio_register(struct net_device *ndev)
>   memcpy(new_bus->irq, mdio_bus_data->irqs, sizeof(new_bus->irq));
>  
>   new_bus->name = "stmmac";
> + new_bus->probe_capabilities = MDIOBUS_C22_C45;

It looks like this needs to be conditional on the version. xgmax2
supports C45. And gmac4. But other versions don't.

 Andrew