RE: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-28 Thread Punnaiah Choudary Kalluri
ikanth > Vemula <svem...@xilinx.com>; Anirudha Sarangi <anir...@xilinx.com>; > devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org; dmaeng...@vger.kernel.org > Subject: Re: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine >

RE: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-28 Thread Punnaiah Choudary Kalluri
org; linux- > ker...@vger.kernel.org; dmaeng...@vger.kernel.org > Subject: Re: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine > driver support > > On Tue, Jun 21, 2016 at 05:29:42PM +, Punnaiah Choudary Kalluri wrote: > > > > Ok agree with you for the scen

Re: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-27 Thread Vinod Koul
On Tue, Jun 21, 2016 at 05:29:42PM +, Punnaiah Choudary Kalluri wrote: > > Ok agree with you for the scenario that I have mentioned above. > > Other simple dma mode feature that I missed to explain is configuring the > Dma descriptors. It provides a register interface for configuring the

Re: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-27 Thread Vinod Koul
On Tue, Jun 21, 2016 at 05:29:42PM +, Punnaiah Choudary Kalluri wrote: > > Ok agree with you for the scenario that I have mentioned above. > > Other simple dma mode feature that I missed to explain is configuring the > Dma descriptors. It provides a register interface for configuring the

RE: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-21 Thread Punnaiah Choudary Kalluri
udha Sarangi <anir...@xilinx.com>; > Punnaiah Choudary Kalluri <punn...@xilinx.com>; > devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org; dmaeng...@vger.kernel.org > Subject: Re: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engi

RE: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-21 Thread Punnaiah Choudary Kalluri
..@lists.infradead.org; linux- > ker...@vger.kernel.org; dmaeng...@vger.kernel.org > Subject: Re: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine > driver support > > On Thu, Jun 16, 2016 at 07:19:38AM +, Appana Durga Kedareswara Rao > wrote: > > Hi Vinod, > > > >

RE: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-21 Thread Punnaiah Choudary Kalluri
> On Tue, Jun 21, 2016 at 04:19:38PM +, Punnaiah Choudary Kalluri wrote: > > > > > > > > mode Earlier In the driver this configuration is read from the > > > > > > > > device-tree But as per lars and your suggestion moved it as > runtime > > > config > > > > > parameters. > > > > > > > > > >

RE: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-21 Thread Punnaiah Choudary Kalluri
> On Tue, Jun 21, 2016 at 04:19:38PM +, Punnaiah Choudary Kalluri wrote: > > > > > > > > mode Earlier In the driver this configuration is read from the > > > > > > > > device-tree But as per lars and your suggestion moved it as > runtime > > > config > > > > > parameters. > > > > > > > > > >

Re: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-21 Thread Vinod Koul
On Tue, Jun 21, 2016 at 04:19:38PM +, Punnaiah Choudary Kalluri wrote: > > > > > > > mode Earlier In the driver this configuration is read from the > > > > > > > device-tree But as per lars and your suggestion moved it as > > > > > > > runtime > > config > > > > parameters. > > > > > > > > >

Re: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-21 Thread Vinod Koul
On Tue, Jun 21, 2016 at 04:19:38PM +, Punnaiah Choudary Kalluri wrote: > > > > > > > mode Earlier In the driver this configuration is read from the > > > > > > > device-tree But as per lars and your suggestion moved it as > > > > > > > runtime > > config > > > > parameters. > > > > > > > > >

Re: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-21 Thread Vinod Koul
On Thu, Jun 16, 2016 at 07:19:38AM +, Appana Durga Kedareswara Rao wrote: > Hi Vinod, > > Thanks for the review... > > > > > On Tue, Jun 14, 2016 at 08:18:09AM +, Appana Durga Kedareswara Rao > > wrote: > > > > > Yes it is HW capability. It can be either in simple mode or SG > > >

Re: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-21 Thread Vinod Koul
On Thu, Jun 16, 2016 at 07:19:38AM +, Appana Durga Kedareswara Rao wrote: > Hi Vinod, > > Thanks for the review... > > > > > On Tue, Jun 14, 2016 at 08:18:09AM +, Appana Durga Kedareswara Rao > > wrote: > > > > > Yes it is HW capability. It can be either in simple mode or SG > > >

RE: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-16 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review... > > On Tue, Jun 14, 2016 at 08:18:09AM +, Appana Durga Kedareswara Rao > wrote: > > > > Yes it is HW capability. It can be either in simple mode or SG > > > > mode Earlier In the driver this configuration is read from the > > > > device-tree But as

RE: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-16 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review... > > On Tue, Jun 14, 2016 at 08:18:09AM +, Appana Durga Kedareswara Rao > wrote: > > > > Yes it is HW capability. It can be either in simple mode or SG > > > > mode Earlier In the driver this configuration is read from the > > > > device-tree But as

Re: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-15 Thread Vinod Koul
On Tue, Jun 14, 2016 at 08:18:09AM +, Appana Durga Kedareswara Rao wrote: > > > Yes it is HW capability. It can be either in simple mode or SG mode > > > Earlier In the driver this configuration is read from the device-tree > > > But as per lars and your suggestion moved it as runtime config

Re: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-15 Thread Vinod Koul
On Tue, Jun 14, 2016 at 08:18:09AM +, Appana Durga Kedareswara Rao wrote: > > > Yes it is HW capability. It can be either in simple mode or SG mode > > > Earlier In the driver this configuration is read from the device-tree > > > But as per lars and your suggestion moved it as runtime config

RE: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-14 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review... > > On Wed, Jun 08, 2016 at 07:40:52AM +, Appana Durga Kedareswara Rao > wrote: > > > > +static void zynqmp_dma_desc_config_eod(struct zynqmp_dma_chan > > > > +*chan, void *desc) > > > > > > eod? 80 line? > > What's eod? End of descriptor... >

RE: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-14 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review... > > On Wed, Jun 08, 2016 at 07:40:52AM +, Appana Durga Kedareswara Rao > wrote: > > > > +static void zynqmp_dma_desc_config_eod(struct zynqmp_dma_chan > > > > +*chan, void *desc) > > > > > > eod? 80 line? > > What's eod? End of descriptor... >

Re: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-12 Thread Vinod Koul
On Wed, Jun 08, 2016 at 07:40:52AM +, Appana Durga Kedareswara Rao wrote: > > > +static void zynqmp_dma_desc_config_eod(struct zynqmp_dma_chan *chan, > > > +void *desc) > > > > eod? 80 line? What's eod? > > > +int zynqmp_dma_channel_set_config(struct dma_chan *dchan, > > > +

Re: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-12 Thread Vinod Koul
On Wed, Jun 08, 2016 at 07:40:52AM +, Appana Durga Kedareswara Rao wrote: > > > +static void zynqmp_dma_desc_config_eod(struct zynqmp_dma_chan *chan, > > > +void *desc) > > > > eod? 80 line? What's eod? > > > +int zynqmp_dma_channel_set_config(struct dma_chan *dchan, > > > +

RE: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-08 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review... > > On Wed, Jun 01, 2016 at 12:53:59PM +0530, Kedareswara rao Appana wrote: > > +config XILINX_ZYNQMP_DMA > > + tristate "Xilinx ZynqMP DMA Engine" > > + depends on (ARCH_ZYNQ || MICROBLAZE || ARM64) > > + select DMA_ENGINE > > + help > > +

RE: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-08 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review... > > On Wed, Jun 01, 2016 at 12:53:59PM +0530, Kedareswara rao Appana wrote: > > +config XILINX_ZYNQMP_DMA > > + tristate "Xilinx ZynqMP DMA Engine" > > + depends on (ARCH_ZYNQ || MICROBLAZE || ARM64) > > + select DMA_ENGINE > > + help > > +

Re: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-07 Thread Vinod Koul
On Wed, Jun 01, 2016 at 12:53:59PM +0530, Kedareswara rao Appana wrote: > +config XILINX_ZYNQMP_DMA > + tristate "Xilinx ZynqMP DMA Engine" > + depends on (ARCH_ZYNQ || MICROBLAZE || ARM64) > + select DMA_ENGINE > + help > + Enable support for Xilinx ZynqMP DMA controller.

Re: [PATCH v10 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

2016-06-07 Thread Vinod Koul
On Wed, Jun 01, 2016 at 12:53:59PM +0530, Kedareswara rao Appana wrote: > +config XILINX_ZYNQMP_DMA > + tristate "Xilinx ZynqMP DMA Engine" > + depends on (ARCH_ZYNQ || MICROBLAZE || ARM64) > + select DMA_ENGINE > + help > + Enable support for Xilinx ZynqMP DMA controller.