RE: [PATCH v10 2/7] PCI/AER: factor out error reporting from AER

2018-02-22 Thread David Laight 
From: Christoph Hellwig
> > -   pci_uevent_ers(dev, PCI_ERS_RESULT_DISCONNECT);
> > -   /* TODO: Should kernel panic here? */
> > -   pci_info(dev, "AER: Device recovery failed\n");
> > -}
> > +EXPORT_SYMBOL(pci_find_aer_service);
> 
> EXPORT_SYMBPOL_GPL please.

Is this a function that a 'normal' PCIe device driver would need to call?
If so it is a PITA requiring all drivers that want AER to be GPL.

David

RE: [PATCH v10 2/7] PCI/AER: factor out error reporting from AER

2018-02-22 Thread David Laight 
From: Christoph Hellwig
> > -   pci_uevent_ers(dev, PCI_ERS_RESULT_DISCONNECT);
> > -   /* TODO: Should kernel panic here? */
> > -   pci_info(dev, "AER: Device recovery failed\n");
> > -}
> > +EXPORT_SYMBOL(pci_find_aer_service);
> 
> EXPORT_SYMBPOL_GPL please.

Is this a function that a 'normal' PCIe device driver would need to call?
If so it is a PITA requiring all drivers that want AER to be GPL.

David

Re: [PATCH v10 2/7] PCI/AER: factor out error reporting from AER

2018-02-22 Thread Christoph Hellwig 
> - pci_uevent_ers(dev, PCI_ERS_RESULT_DISCONNECT);
> - /* TODO: Should kernel panic here? */
> - pci_info(dev, "AER: Device recovery failed\n");
> -}
> +EXPORT_SYMBOL(pci_find_aer_service);

EXPORT_SYMBPOL_GPL please.

Re: [PATCH v10 2/7] PCI/AER: factor out error reporting from AER

2018-02-22 Thread Christoph Hellwig 
> - pci_uevent_ers(dev, PCI_ERS_RESULT_DISCONNECT);
> - /* TODO: Should kernel panic here? */
> - pci_info(dev, "AER: Device recovery failed\n");
> -}
> +EXPORT_SYMBOL(pci_find_aer_service);

EXPORT_SYMBPOL_GPL please.