Re: [patch 05/24] Text Edit Lock - Architecture Independent Code

2007-12-21 Thread Mathieu Desnoyers
* zhangxiliang ([EMAIL PROTECTED]) wrote: > hello, >I have some questions for your patches. > Hi, > > Paravirt and alternatives are always done when SMP is > > inactive, so there is no > > need to use locks. > > > -#ifndef CONFIG_KPROBES > > -#ifdef CONFIG_HOTPLUG_CPU > > - /* It

Re: [patch 05/24] Text Edit Lock - Architecture Independent Code

2007-12-21 Thread Mathieu Desnoyers
* zhangxiliang ([EMAIL PROTECTED]) wrote: hello, I have some questions for your patches. Hi, Paravirt and alternatives are always done when SMP is inactive, so there is no need to use locks. -#ifndef CONFIG_KPROBES -#ifdef CONFIG_HOTPLUG_CPU - /* It must still be

RE: [patch 05/24] Text Edit Lock - Architecture Independent Code

2007-12-20 Thread zhangxiliang
break; } } if (dirty && ++kprobe_garbage_slots > INSNS_PER_PAGE) collect_garbage_slots(); + mutex_unlock(_mutex); } > -Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of

RE: [patch 05/24] Text Edit Lock - Architecture Independent Code

2007-12-20 Thread zhangxiliang
hello, I have some questions for your patches. > Paravirt and alternatives are always done when SMP is > inactive, so there is no > need to use locks. > -#ifndef CONFIG_KPROBES > -#ifdef CONFIG_HOTPLUG_CPU > - /* It must still be possible to apply SMP alternatives. */ > - if

RE: [patch 05/24] Text Edit Lock - Architecture Independent Code

2007-12-20 Thread zhangxiliang
hello, I have some questions for your patches. Paravirt and alternatives are always done when SMP is inactive, so there is no need to use locks. -#ifndef CONFIG_KPROBES -#ifdef CONFIG_HOTPLUG_CPU - /* It must still be possible to apply SMP alternatives. */ - if

RE: [patch 05/24] Text Edit Lock - Architecture Independent Code

2007-12-20 Thread zhangxiliang
Of zhangxiliang Sent: Friday, December 21, 2007 1:19 PM To: 'Mathieu Desnoyers'; [EMAIL PROTECTED]; 'Ingo Molnar'; linux-kernel@vger.kernel.org Cc: 'Andi Kleen' Subject: RE: [patch 05/24] Text Edit Lock - Architecture Independent Code hello, I have some questions for your patches. Paravirt