Re: linux-next: build failure after merge of the sound-asoc tree
Hi Daniel, On Tue, 15 Oct 2019 09:46:33 +0300 Daniel Baluta wrote: > > > I added the following fix for today (include/sound/sof/header.h > > probably should have something similar): > > Thanks for doing this! Is this patch in linux-next already? I couldn't find > it. Its part of the commit that merges the cound-asoc tree i.e. not a separate commit, but sould be applied to the sound-asoc tree itself. > For include/sound/sof/header.h Morimoto-san sent a patch to alsa-devel. Great, thanks. -- Cheers, Stephen Rothwell pgprQOMmhRbC1.pgp Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the sound-asoc tree
Hi Stephen,
On Fri, Oct 11, 2019 at 3:04 AM Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from include/sound/sof/dai-imx.h:11,
> from :
> include/sound/sof/header.h:125:2: error: unknown type name 'uint32_t'
> 125 | uint32_t size; /**< size of structure */
> | ^~~~
> include/sound/sof/header.h:136:2: error: unknown type name 'uint32_t'
> 136 | uint32_t size; /**< size of structure */
> | ^~~~
> include/sound/sof/header.h:137:2: error: unknown type name 'uint32_t'
> 137 | uint32_t cmd; /**< SOF_IPC_GLB_ + cmd */
> | ^~~~
> include/sound/sof/header.h:146:2: error: unknown type name 'int32_t'
> 146 | int32_t error; /**< negative error numbers */
> | ^~~
> include/sound/sof/header.h:160:2: error: unknown type name 'uint32_t'
> 160 | uint32_t count; /**< count of 0 means end of compound sequence */
> | ^~~~
> include/sound/sof/header.h:167:2: error: unknown type name 'uint32_t'
> 167 | uint32_t arch; /* Identifier of architecture */
> | ^~~~
> include/sound/sof/header.h:168:2: error: unknown type name 'uint32_t'
> 168 | uint32_t totalsize; /* Total size of oops message */
> | ^~~~
> include/sound/sof/header.h:175:2: error: unknown type name 'uint32_t'
> 175 | uint32_t configidhi; /* ConfigID hi 32bits */
> | ^~~~
> include/sound/sof/header.h:176:2: error: unknown type name 'uint32_t'
> 176 | uint32_t configidlo; /* ConfigID lo 32bits */
> | ^~~~
> include/sound/sof/header.h:177:2: error: unknown type name 'uint32_t'
> 177 | uint32_t numaregs; /* Special regs num */
> | ^~~~
> include/sound/sof/header.h:178:2: error: unknown type name 'uint32_t'
> 178 | uint32_t stackoffset; /* Offset to stack pointer from beginning of
> | ^~~~
> include/sound/sof/header.h:181:2: error: unknown type name 'uint32_t'
> 181 | uint32_t stackptr; /* Stack ptr */
> | ^~~~
> In file included from :
> include/sound/sof/dai-imx.h:18:2: error: unknown type name 'uint16_t'
>18 | uint16_t reserved1;
> | ^~~~
> include/sound/sof/dai-imx.h:19:2: error: unknown type name 'uint16_t'
>19 | uint16_t mclk_id;
> | ^~~~
> include/sound/sof/dai-imx.h:20:2: error: unknown type name 'uint32_t'
>20 | uint32_t mclk_direction;
> | ^~~~
> include/sound/sof/dai-imx.h:22:2: error: unknown type name 'uint32_t'
>22 | uint32_t mclk_rate; /* MCLK frequency in Hz */
> | ^~~~
> include/sound/sof/dai-imx.h:23:2: error: unknown type name 'uint32_t'
>23 | uint32_t fsync_rate; /* FSYNC frequency in Hz */
> | ^~~~
> include/sound/sof/dai-imx.h:24:2: error: unknown type name 'uint32_t'
>24 | uint32_t bclk_rate; /* BCLK frequency in Hz */
> | ^~~~
> include/sound/sof/dai-imx.h:27:2: error: unknown type name 'uint32_t'
>27 | uint32_t tdm_slots;
> | ^~~~
> include/sound/sof/dai-imx.h:28:2: error: unknown type name 'uint32_t'
>28 | uint32_t rx_slots;
> | ^~~~
> include/sound/sof/dai-imx.h:29:2: error: unknown type name 'uint32_t'
>29 | uint32_t tx_slots;
> | ^~~~
> include/sound/sof/dai-imx.h:30:2: error: unknown type name 'uint16_t'
>30 | uint16_t tdm_slot_width;
> | ^~~~
> include/sound/sof/dai-imx.h:31:2: error: unknown type name 'uint16_t'
>31 | uint16_t reserved2; /* alignment */
> | ^~~~
>
> Caused by commit
>
> b4be427683cf ("ASoC: SOF: imx: Describe ESAI parameters to be sent to DSP")
>
> I added the following fix for today (include/sound/sof/header.h
> probably should have something similar):
Thanks for doing this! Is this patch in linux-next already? I couldn't find it.
For include/sound/sof/header.h Morimoto-san sent a patch to alsa-devel.
>
> From: Stephen Rothwell
> Date: Fri, 11 Oct 2019 10:56:46 +1100
> Subject: [PATCH] ASOC: SOF: dai-imx.h needs linux/types.h
>
> Signed-off-by: Stephen Rothwell
> ---
> include/sound/sof/dai-imx.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/sound/sof/dai-imx.h b/include/sound/sof/dai-imx.h
> index e02fb0b0fae1..31ccb87a8273 100644
> --- a/include/sound/sof/dai-imx.h
> +++ b/include/sound/sof/dai-imx.h
> @@ -8,6 +8,7 @@
> #ifndef __INCLUDE_SOUND_SOF_DAI_IMX_H__
> #define __INCLUDE_SOUND_SOF_DAI_IMX_H__
>
> +#include
> #include
>
> /* ESAI Configuration Request - SOF_IPC_DAI_ESAI_CONFIG */
> --
> 2.23.0
>
> --
> Cheers,
> Stephen Rothwell
Re: linux-next: build failure after merge of the sound-asoc tree
Looks like the merge resolution is not quite right. I have used the sound-asoc tree from next-20190808 for today. I am still getting this failure ... Intel people, any thoughts? I provided a solution on alsa-devel yesterday, see 'ASoC: SOF: fix HDA direct MMIO access'
Re: linux-next: build failure after merge of the sound-asoc tree
On Tue, Aug 13, 2019 at 01:16:11PM +1000, Stephen Rothwell wrote:
> On Fri, 9 Aug 2019 13:08:11 +1000 Stephen Rothwell
> wrote:
> > sound/soc/sof/intel/hda-dsp.c: In function 'hda_resume':
> > sound/soc/sof/intel/hda-dsp.c:360:22: error: 'hlink' undeclared (first use
> > in this function)
> > list_for_each_entry(hlink, &bus->hlink_list, list)
> > ^
> > include/linux/list.h:577:7: note: in definition of macro
> > 'list_for_each_entry'
> > for (pos = list_first_entry(head, typeof(*pos), member); \
> >^~~
> > sound/soc/sof/intel/hda-dsp.c:360:22: note: each undeclared identifier is
> > reported only once for each function it appears in
> > list_for_each_entry(hlink, &bus->hlink_list, list)
> > ^
> > include/linux/list.h:577:7: note: in definition of macro
> > 'list_for_each_entry'
> > for (pos = list_first_entry(head, typeof(*pos), member); \
> >^~~
> > In file included from include/linux/list.h:9,
> > from include/linux/kobject.h:19,
> > from include/linux/device.h:16,
> > from include/sound/hdaudio.h:9,
> > from include/sound/hdaudio_ext.h:5,
> > from sound/soc/sof/intel/hda-dsp.c:18:
> > sound/soc/sof/intel/hda-dsp.c:360:30: error: 'bus' undeclared (first use in
> > this function)
> > list_for_each_entry(hlink, &bus->hlink_list, list)
> > ^~~
> > include/linux/kernel.h:972:26: note: in definition of macro 'container_of'
> > void *__mptr = (void *)(ptr); \
> > ^~~
> > include/linux/list.h:490:2: note: in expansion of macro 'list_entry'
> > list_entry((ptr)->next, type, member)
> > ^~
> > include/linux/list.h:577:13: note: in expansion of macro 'list_first_entry'
> > for (pos = list_first_entry(head, typeof(*pos), member); \
> > ^~~~
> > sound/soc/sof/intel/hda-dsp.c:360:2: note: in expansion of macro
> > 'list_for_each_entry'
> > list_for_each_entry(hlink, &bus->hlink_list, list)
> > ^~~
> > sound/soc/sof/intel/hda-dsp.c:364:2: error: #else without #if
> > #else
> > ^~~~
> > sound/soc/sof/intel/hda-dsp.c:390:2: error: #endif without #if
> > #endif
> > ^
> >
> > Caused by commit
> >
> > c2f16a94a804 ("Merge branch 'topic/hda-bus-ops-cleanup' of
> > https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound into asoc-5.4")
> >
> > Looks like the merge resolution is not quite right.
> >
> > I have used the sound-asoc tree from next-20190808 for today.
> I am still getting this failure ...
Intel people, any thoughts?
signature.asc
Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
Hi all,
On Fri, 9 Aug 2019 13:08:11 +1000 Stephen Rothwell
wrote:
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from include/linux/kobject.h:19,
> from include/linux/device.h:16,
> from include/sound/hdaudio.h:9,
> from include/sound/hdaudio_ext.h:5,
> from sound/soc/sof/intel/hda-dsp.c:18:
> sound/soc/sof/intel/hda-dsp.c: In function 'hda_resume':
> sound/soc/sof/intel/hda-dsp.c:360:22: error: 'hlink' undeclared (first use in
> this function)
> list_for_each_entry(hlink, &bus->hlink_list, list)
> ^
> include/linux/list.h:577:7: note: in definition of macro 'list_for_each_entry'
> for (pos = list_first_entry(head, typeof(*pos), member); \
>^~~
> sound/soc/sof/intel/hda-dsp.c:360:22: note: each undeclared identifier is
> reported only once for each function it appears in
> list_for_each_entry(hlink, &bus->hlink_list, list)
> ^
> include/linux/list.h:577:7: note: in definition of macro 'list_for_each_entry'
> for (pos = list_first_entry(head, typeof(*pos), member); \
>^~~
> In file included from include/linux/list.h:9,
> from include/linux/kobject.h:19,
> from include/linux/device.h:16,
> from include/sound/hdaudio.h:9,
> from include/sound/hdaudio_ext.h:5,
> from sound/soc/sof/intel/hda-dsp.c:18:
> sound/soc/sof/intel/hda-dsp.c:360:30: error: 'bus' undeclared (first use in
> this function)
> list_for_each_entry(hlink, &bus->hlink_list, list)
> ^~~
> include/linux/kernel.h:972:26: note: in definition of macro 'container_of'
> void *__mptr = (void *)(ptr); \
> ^~~
> include/linux/list.h:490:2: note: in expansion of macro 'list_entry'
> list_entry((ptr)->next, type, member)
> ^~
> include/linux/list.h:577:13: note: in expansion of macro 'list_first_entry'
> for (pos = list_first_entry(head, typeof(*pos), member); \
> ^~~~
> sound/soc/sof/intel/hda-dsp.c:360:2: note: in expansion of macro
> 'list_for_each_entry'
> list_for_each_entry(hlink, &bus->hlink_list, list)
> ^~~
> sound/soc/sof/intel/hda-dsp.c:364:2: error: #else without #if
> #else
> ^~~~
> sound/soc/sof/intel/hda-dsp.c:390:2: error: #endif without #if
> #endif
> ^
>
> Caused by commit
>
> c2f16a94a804 ("Merge branch 'topic/hda-bus-ops-cleanup' of
> https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound into asoc-5.4")
>
> Looks like the merge resolution is not quite right.
>
> I have used the sound-asoc tree from next-20190808 for today.
I am still getting this failure ...
--
Cheers,
Stephen Rothwell
pgpMgsfOck1_4.pgp
Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Wed, Apr 03, 2019 at 12:27:53PM +0800, Baolin Wang wrote: > On Wed, 3 Apr 2019 at 11:35, Mark Brown wrote: > > We can't leave this broken in -next for that long, can you please post > > the patch now if you've already got it? > OK, but I need some time to setup my environment to send this patch > and I'll try to fix this ASAP. Thanks. Don't worry about it, I can do things directly - it was just if you had the patch already it seemed better to use yours but if it's going to be painful to set up a dev environment there's no need to worry. signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Wed, 3 Apr 2019 at 11:35, Mark Brown wrote: > > On Wed, Apr 03, 2019 at 10:12:47AM +0800, Baolin Wang wrote: > > > snd-soc-sprd-platform-objs := sprd-pcm-dma.o sprd-pcm-compress.o > > > obj-$(CONFIG_SND_SOC_SPRD) += snd-soc-sprd-platform.o > > > I will send out one incremental patch to fix this issue after my > > business trip. Thanks. > > We can't leave this broken in -next for that long, can you please post > the patch now if you've already got it? OK, but I need some time to setup my environment to send this patch and I'll try to fix this ASAP. Thanks. -- Baolin Wang Best Regards
Re: linux-next: build failure after merge of the sound-asoc tree
On Wed, Apr 03, 2019 at 10:12:47AM +0800, Baolin Wang wrote: > snd-soc-sprd-platform-objs := sprd-pcm-dma.o sprd-pcm-compress.o > obj-$(CONFIG_SND_SOC_SPRD) += snd-soc-sprd-platform.o > I will send out one incremental patch to fix this issue after my > business trip. Thanks. We can't leave this broken in -next for that long, can you please post the patch now if you've already got it? signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
Hi,
On Wed, 3 Apr 2019 at 08:11, Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: "sprd_platform_compr_ops" [sound/soc/sprd/sprd-pcm-dma.ko] undefined!
>
> Caused by commit
>
> cce1396936ef ("ASoC: sprd: Add Spreadtrum audio compress offload support")
>
> I have used the sound-asoc tree from next-20190402 for today.
>
Thanks for pointing this out. I think I should fix the Makefile like this
snd-soc-sprd-platform-objs := sprd-pcm-dma.o sprd-pcm-compress.o
obj-$(CONFIG_SND_SOC_SPRD) += snd-soc-sprd-platform.o
I will send out one incremental patch to fix this issue after my
business trip. Thanks.
--
Baolin Wang
Best Regards
Re: linux-next: build failure after merge of the sound-asoc tree
On Mon, Apr 01, 2019 at 10:11:44PM +1100, Michael Ellerman wrote: > Anyway I think what you've done in next, make the code depend on > COMMON_CLOCK, is the best option. If anyone cares about that driver on > powerpc platforms that don't support COMMON_CLOCK they should speak up. It's probably fine for now for this one driver but it's going to cause issues going forwards since we're trying to make the framework's clock handling more standard. signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
Mark Brown writes: > On Wed, Mar 27, 2019 at 03:29:55PM +1100, Michael Ellerman wrote: >> Mark Brown writes: > >> > Hrm, seems PowerPC is still not using the common clock API - is there >> > any plan for that? There are some ASoC PowerPC uses so it's going to be >> > a bit of an issue as we expand our use of the clock API. > >> I don't know anything about the common clock API. What would it involve >> for powerpc to use it? > > It's what's in drivers/clk - you'd have to provide clock drivers for all > the clocks that are current supported by arch-specific code, make sure > that those drivers can be instantiated and then remove the custom > implementation of the clock API in arch/powerpc in favour of those. OK. I realise we do have some support for the common clock API, but only on certain sub-platforms (PPC_MPC512x, PPC_MPC52xx, PPC_E500MC). On other platforms we have nothing at all AFAICS. Seems Ben posted an RFC to support it in 2009, but nothing since: http://patchwork.ozlabs.org/patch/31551/ Anyway I think what you've done in next, make the code depend on COMMON_CLOCK, is the best option. If anyone cares about that driver on powerpc platforms that don't support COMMON_CLOCK they should speak up. cheers
Re: linux-next: build failure after merge of the sound-asoc tree
On Wed, Mar 27, 2019 at 03:29:55PM +1100, Michael Ellerman wrote: > Mark Brown writes: > > Hrm, seems PowerPC is still not using the common clock API - is there > > any plan for that? There are some ASoC PowerPC uses so it's going to be > > a bit of an issue as we expand our use of the clock API. > I don't know anything about the common clock API. What would it involve > for powerpc to use it? It's what's in drivers/clk - you'd have to provide clock drivers for all the clocks that are current supported by arch-specific code, make sure that those drivers can be instantiated and then remove the custom implementation of the clock API in arch/powerpc in favour of those. signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
Mark Brown writes: > On Tue, Mar 26, 2019 at 01:33:49PM +1100, Stephen Rothwell wrote: > >> After merging the sound-asoc tree, today's linux-next build (powerpc >> allyesconfig) failed like this: > >> sound/soc/codecs/tlv320aic32x4-clk.c: In function 'clk_aic32x4_pll_prepare': >> include/linux/kernel.h:979:32: error: dereferencing pointer to incomplete >> type 'struct clk_hw' >> BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ >> ^~ > > Hrm, seems PowerPC is still not using the common clock API - is there > any plan for that? There are some ASoC PowerPC uses so it's going to be > a bit of an issue as we expand our use of the clock API. I don't know anything about the common clock API. What would it involve for powerpc to use it? cheers
Re: linux-next: build failure after merge of the sound-asoc tree
On Tue, Mar 26, 2019 at 01:33:49PM +1100, Stephen Rothwell wrote: > After merging the sound-asoc tree, today's linux-next build (powerpc > allyesconfig) failed like this: > sound/soc/codecs/tlv320aic32x4-clk.c: In function 'clk_aic32x4_pll_prepare': > include/linux/kernel.h:979:32: error: dereferencing pointer to incomplete > type 'struct clk_hw' > BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ > ^~ Hrm, seems PowerPC is still not using the common clock API - is there any plan for that? There are some ASoC PowerPC uses so it's going to be a bit of an issue as we expand our use of the clock API. signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Fri, Feb 08, 2019 at 09:39:39AM +0100, Takashi Iwai wrote: > > Mark, could you apply it on your tree? > And I already took back the API change from for-next branch for > avoiding the bisection breakage. > > Or let me pull your tree into mine. > ... so Mark, please send a pull request to me for ASoC merges, so that > I can apply the API change. Done. This sort of thing is why I like having lots of topic branches :/ signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Fri, 08 Feb 2019 08:37:25 +0100,
Takashi Iwai wrote:
>
> On Fri, 08 Feb 2019 03:18:23 +0100,
> Stephen Rothwell wrote:
> >
> > Hi all,
> >
> > After merging the sound-asoc tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > sound/soc/xilinx/xlnx_formatter_pcm.c: In function 'xlnx_formatter_pcm_new':
> > sound/soc/xilinx/xlnx_formatter_pcm.c:539:9: error: void value not ignored
> > as it ought to be
> > return snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
> > ^~~
> > SNDRV_DMA_TYPE_DEV, component->dev,
> > ~~~
> > xlnx_pcm_hardware.buffer_bytes_max,
> > ~~~
> > xlnx_pcm_hardware.buffer_bytes_max);
> > ~~~
> > sound/soc/xilinx/xlnx_formatter_pcm.c:543:1: warning: control reaches end
> > of non-void function [-Wreturn-type]
> > }
> > ^
> >
> > Caused by commit
> >
> > 6f6c3c36f091 ("ASoC: xlnx: add pcm formatter platform driver")
> >
> > interacting with commit
> >
> > 9adb5165f1de ("ALSA: pcm: Define snd_pcm_lib_preallocate_*() as returning
> > void")
> >
> > from the sound tree.
> >
> > I have applied the following merge fix patch for today:
> >
> > From: Stephen Rothwell
> > Date: Fri, 8 Feb 2019 13:14:24 +1100
> > Subject: [PATCH] Asoc: xlnx: fix up for
> > snd_pcm_lib_preallocate_pages_for_all() API change
> >
> > Signed-off-by: Stephen Rothwell
> > ---
> > sound/soc/xilinx/xlnx_formatter_pcm.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/xilinx/xlnx_formatter_pcm.c
> > b/sound/soc/xilinx/xlnx_formatter_pcm.c
> > index 97177d35652e..dc8721f4f56b 100644
> > --- a/sound/soc/xilinx/xlnx_formatter_pcm.c
> > +++ b/sound/soc/xilinx/xlnx_formatter_pcm.c
> > @@ -536,10 +536,11 @@ static int xlnx_formatter_pcm_new(struct
> > snd_soc_pcm_runtime *rtd)
> > {
> > struct snd_soc_component *component = snd_soc_rtdcom_lookup(rtd,
> > DRV_NAME);
> > - return snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
> > + snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
> > SNDRV_DMA_TYPE_DEV, component->dev,
> > xlnx_pcm_hardware.buffer_bytes_max,
> > xlnx_pcm_hardware.buffer_bytes_max);
> > + return 0;
> > }
> >
> > static const struct snd_pcm_ops xlnx_formatter_pcm_ops = {
> > --
> > 2.20.1
>
> Thanks Stephen.
>
> Mark, could you apply it on your tree?
And I already took back the API change from for-next branch for
avoiding the bisection breakage.
> Or let me pull your tree into mine.
... so Mark, please send a pull request to me for ASoC merges, so that
I can apply the API change.
thanks,
Takashi
Re: linux-next: build failure after merge of the sound-asoc tree
On Fri, 08 Feb 2019 03:18:23 +0100,
Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/soc/xilinx/xlnx_formatter_pcm.c: In function 'xlnx_formatter_pcm_new':
> sound/soc/xilinx/xlnx_formatter_pcm.c:539:9: error: void value not ignored as
> it ought to be
> return snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
> ^~~
> SNDRV_DMA_TYPE_DEV, component->dev,
> ~~~
> xlnx_pcm_hardware.buffer_bytes_max,
> ~~~
> xlnx_pcm_hardware.buffer_bytes_max);
> ~~~
> sound/soc/xilinx/xlnx_formatter_pcm.c:543:1: warning: control reaches end of
> non-void function [-Wreturn-type]
> }
> ^
>
> Caused by commit
>
> 6f6c3c36f091 ("ASoC: xlnx: add pcm formatter platform driver")
>
> interacting with commit
>
> 9adb5165f1de ("ALSA: pcm: Define snd_pcm_lib_preallocate_*() as returning
> void")
>
> from the sound tree.
>
> I have applied the following merge fix patch for today:
>
> From: Stephen Rothwell
> Date: Fri, 8 Feb 2019 13:14:24 +1100
> Subject: [PATCH] Asoc: xlnx: fix up for
> snd_pcm_lib_preallocate_pages_for_all() API change
>
> Signed-off-by: Stephen Rothwell
> ---
> sound/soc/xilinx/xlnx_formatter_pcm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/xilinx/xlnx_formatter_pcm.c
> b/sound/soc/xilinx/xlnx_formatter_pcm.c
> index 97177d35652e..dc8721f4f56b 100644
> --- a/sound/soc/xilinx/xlnx_formatter_pcm.c
> +++ b/sound/soc/xilinx/xlnx_formatter_pcm.c
> @@ -536,10 +536,11 @@ static int xlnx_formatter_pcm_new(struct
> snd_soc_pcm_runtime *rtd)
> {
> struct snd_soc_component *component = snd_soc_rtdcom_lookup(rtd,
> DRV_NAME);
> - return snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
> + snd_pcm_lib_preallocate_pages_for_all(rtd->pcm,
> SNDRV_DMA_TYPE_DEV, component->dev,
> xlnx_pcm_hardware.buffer_bytes_max,
> xlnx_pcm_hardware.buffer_bytes_max);
> + return 0;
> }
>
> static const struct snd_pcm_ops xlnx_formatter_pcm_ops = {
> --
> 2.20.1
Thanks Stephen.
Mark, could you apply it on your tree?
Or let me pull your tree into mine.
Takashi
Re: linux-next: build failure after merge of the sound-asoc tree
On Wed, Apr 18, 2018 at 09:51:13AM +1000, Stephen Rothwell wrote:
> Caused by commit
> 81e9b0a07889 ("ASoC: topology: Give more data to clients via callbacks")
> I have used the sound-aoc tree from next-20180416 again today.
Ugh, reverted that and the following commit which depends on it.
signature.asc
Description: PGP signature
RE: linux-next: build failure after merge of the sound-asoc tree
Hi all,
I already sent the patch.
http://mailman.alsa-project.org/pipermail/alsa-devel/2018-April/134522.html
I apologize for the inconvenience.
Thanks!
Regards,
Shuming Fan
-Original Message-
From: Shuming [范書銘]
Sent: Tuesday, April 17, 2018 9:23 AM
To: 'Stephen Rothwell'; Mark Brown; Liam Girdwood
Cc: Linux-Next Mailing List; Linux Kernel Mailing List
Subject: RE: linux-next: build failure after merge of the sound-asoc tree
Hi all,
I think I miss the header file (#include ) I will fix it ASAP.
Sorry about that.
Thanks!
Regards,
Shuming Fan
-Original Message-
From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
Sent: Tuesday, April 17, 2018 9:03 AM
To: Mark Brown; Liam Girdwood
Cc: Linux-Next Mailing List; Linux Kernel Mailing List; Shuming [范書銘]
Subject: linux-next: build failure after merge of the sound-asoc tree
Hi all,
After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:
sound/soc/codecs/rt1305.c:1179:23: error: implicit declaration of function
'ACPI_PTR'; did you mean 'ERR_PTR'? [-Werror=implicit-function-declaration]
.acpi_match_table = ACPI_PTR(rt1305_acpi_match)
^~~~
ERR_PTR
sound/soc/codecs/rt1305.c:1179:23: warning: initialization makes pointer from
integer without a cast [-Wint-conversion]
sound/soc/codecs/rt1305.c:1179:23: note: (near initialization for
'rt1305_i2c_driver.driver.acpi_match_table')
sound/soc/codecs/rt1305.c:1179:23: error: initializer element is not constant
sound/soc/codecs/rt1305.c:1179:23: note: (near initialization for
'rt1305_i2c_driver.driver.acpi_match_table')
Caused by commit
29bc643ddd7e ("ASoC: rt1305: Add RT1305/RT1306 amplifier driver")
I have used the sound-asoc tree from next-20180416 for today.
--
Cheers,
Stephen Rothwell
--Please consider the environment before printing this e-mail.
RE: linux-next: build failure after merge of the sound-asoc tree
Hi all,
I think I miss the header file (#include )
I will fix it ASAP. Sorry about that.
Thanks!
Regards,
Shuming Fan
-Original Message-
From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
Sent: Tuesday, April 17, 2018 9:03 AM
To: Mark Brown; Liam Girdwood
Cc: Linux-Next Mailing List; Linux Kernel Mailing List; Shuming [范書銘]
Subject: linux-next: build failure after merge of the sound-asoc tree
Hi all,
After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:
sound/soc/codecs/rt1305.c:1179:23: error: implicit declaration of function
'ACPI_PTR'; did you mean 'ERR_PTR'? [-Werror=implicit-function-declaration]
.acpi_match_table = ACPI_PTR(rt1305_acpi_match)
^~~~
ERR_PTR
sound/soc/codecs/rt1305.c:1179:23: warning: initialization makes pointer from
integer without a cast [-Wint-conversion]
sound/soc/codecs/rt1305.c:1179:23: note: (near initialization for
'rt1305_i2c_driver.driver.acpi_match_table')
sound/soc/codecs/rt1305.c:1179:23: error: initializer element is not constant
sound/soc/codecs/rt1305.c:1179:23: note: (near initialization for
'rt1305_i2c_driver.driver.acpi_match_table')
Caused by commit
29bc643ddd7e ("ASoC: rt1305: Add RT1305/RT1306 amplifier driver")
I have used the sound-asoc tree from next-20180416 for today.
--
Cheers,
Stephen Rothwell
--Please consider the environment before printing this e-mail.
Re: linux-next: build failure after merge of the sound-asoc tree
On Tuesday 27 March 2018 04:57 PM, Mark Brown wrote: On Thu, Mar 22, 2018 at 11:24:43AM +0530, Mukunda,Vijendar wrote: On Thursday 22 March 2018 07:08 AM, Mark Brown wrote: You need to mention dependencies between patches when publishing and I don't seem to have a copy of that patch, according to the list archives Alex asked you to make some chnages to it. Changes suggested by Alex already implemented and posted . Current patch (https://patchwork.kernel.org/patch/10298281/ ) is dependent on below patch. https://patchwork.kernel.org/patch/10296597/ I'm working offline so these links aren't doing anything useful for me, sorry. submitted fresh patch set which includes dependent patch. Please ignore this mail thread. We will publish patch dependencies while sending patches. Please.
Re: linux-next: build failure after merge of the sound-asoc tree
On Thu, Mar 22, 2018 at 11:24:43AM +0530, Mukunda,Vijendar wrote: > On Thursday 22 March 2018 07:08 AM, Mark Brown wrote: > > You need to mention dependencies between patches when publishing and I > > don't seem to have a copy of that patch, according to the list archives > > Alex asked you to make some chnages to it. > Changes suggested by Alex already implemented and posted . > Current patch (https://patchwork.kernel.org/patch/10298281/ ) is > dependent on below patch. > https://patchwork.kernel.org/patch/10296597/ I'm working offline so these links aren't doing anything useful for me, sorry. > We will publish patch dependencies while sending patches. Please. signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Thursday 22 March 2018 07:08 AM, Mark Brown wrote: On Wed, Mar 21, 2018 at 11:15:16AM +0530, Mukunda,Vijendar wrote: There is a patch dependency . Below patch not merged yet. We submitted for upstream review. [PATCH V2] ASoC: dwc: I2S Controller instance param added You need to mention dependencies between patches when publishing and I don't seem to have a copy of that patch, according to the list archives Alex asked you to make some chnages to it. Changes suggested by Alex already implemented and posted . Current patch (https://patchwork.kernel.org/patch/10298281/ ) is dependent on below patch. https://patchwork.kernel.org/patch/10296597/ We will publish patch dependencies while sending patches.
Re: linux-next: build failure after merge of the sound-asoc tree
On Wed, Mar 21, 2018 at 11:15:16AM +0530, Mukunda,Vijendar wrote: > There is a patch dependency . > Below patch not merged yet. We submitted for upstream review. > [PATCH V2] ASoC: dwc: I2S Controller instance param added You need to mention dependencies between patches when publishing and I don't seem to have a copy of that patch, according to the list archives Alex asked you to make some chnages to it. signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Wednesday 21 March 2018 08:15 AM, Mark Brown wrote:
On Wed, Mar 21, 2018 at 01:30:40PM +1100, Stephen Rothwell wrote:
Caused by commit
363fe37948e2 ("ASoC: amd: dma driver changes for BT I2S controller instance")
I have used the sound-asoc tree from next-20180320 for today.
Dropped.
There is a patch dependency .
Below patch not merged yet. We submitted for upstream review.
[PATCH V2] ASoC: dwc: I2S Controller instance param added
Re: linux-next: build failure after merge of the sound-asoc tree
On Wed, Mar 21, 2018 at 01:30:40PM +1100, Stephen Rothwell wrote:
> Caused by commit
> 363fe37948e2 ("ASoC: amd: dma driver changes for BT I2S controller
> instance")
> I have used the sound-asoc tree from next-20180320 for today.
Dropped.
signature.asc
Description: PGP signature
RE: linux-next: build failure after merge of the sound-asoc tree
On 13 March 2018 06:09, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> sound/soc/codecs/da7219.o: In function `.da7219_remove':
> da7219.c:(.text+0xcbc): undefined reference to `.clkdev_drop'
>
> Caused by commit
>
> fc8f7ea2d6c0 ("ASoC: da7219: Add common clock usage for providing DAI clks")
>
> CONFIG_CLKDEV_LOOKUP is not set for this build.
>
> I have reverted that commit for today.
My bad. Apologies for this. :(
Mark, I'll send a follow up patch to fix this ASAP.
Re: linux-next: build failure after merge of the sound-asoc tree
On 3/2/2018 7:54 AM, Stephen Rothwell wrote:
Hi all,
After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:
sound/soc/intel/boards/cht_bsw_nau8824.c: In function 'cht_codec_init':
sound/soc/intel/boards/cht_bsw_nau8824.c:137:29: error: passing argument 1 of
'nau8824_enable_jack_detect' from incompatible pointer type
[-Werror=incompatible-pointer-types]
nau8824_enable_jack_detect(codec, jack);
^
In file included from sound/soc/intel/boards/cht_bsw_nau8824.c:31:0:
sound/soc/intel/boards/../../codecs/nau8824.h:474:5: note: expected 'struct
snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
int nau8824_enable_jack_detect(struct snd_soc_component *component,
^~
Caused by commit
5b00ce63e07f ("ASoC: Intel: add nau8824 sound card")
I have used the sound-asoc tree from next-20180301 for today.
The fix patch has submitted. Please check the link as follows:
http://mailman.alsa-project.org/pipermail/alsa-devel/2018-March/132811.html
[alsa-devel] [PATCH] ASoC: Intel: fix argument error in nau8824 machine
===
The privileged confidential information contained in this email is intended for
use only by the addressees as indicated by the original sender of this email.
If you are not the addressee indicated in this email or are not responsible for
delivery of the email to such a person, please kindly reply to the sender
indicating this fact and delete all copies of it from your computer and network
server immediately. Your cooperation is highly appreciated. It is advised that
any unauthorized use of confidential information of Nuvoton is strictly
prohibited; and any information in this email irrelevant to the official
business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.
Re: linux-next: build failure after merge of the sound-asoc tree
On 2/19/2018 5:02 AM, Stephen Rothwell wrote:
Hi all,
After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) failed like this:
sound/soc/amd/acp-da7219-max98357a.c: In function 'cz_da7219_init':
sound/soc/amd/acp-da7219-max98357a.c:79:22: error: passing argument 1 of
'da7219_aad_jack_det' from incompatible pointer type
[-Werror=incompatible-pointer-types]
da7219_aad_jack_det(codec, &cz_jack);
^
In file included from sound/soc/amd/acp-da7219-max98357a.c:38:0:
sound/soc/amd/../codecs/da7219-aad.h:209:6: note: expected 'struct
snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
void da7219_aad_jack_det(struct snd_soc_component *component, struct
snd_soc_jack *jack);
^~~
cc1: some warnings being treated as errors
sound/soc/intel/boards/kbl_da7219_max98357a.c: In function
'kabylake_da7219_codec_init':
sound/soc/intel/boards/kbl_da7219_max98357a.c:194:22: error: passing argument 1
of 'da7219_aad_jack_det' from incompatible pointer type
[-Werror=incompatible-pointer-types]
da7219_aad_jack_det(codec, &ctx->kabylake_headset);
^
In file included from sound/soc/intel/boards/kbl_da7219_max98357a.c:23:0:
sound/soc/intel/boards/../../codecs/da7219-aad.h:209:6: note: expected 'struct
snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
void da7219_aad_jack_det(struct snd_soc_component *component, struct
snd_soc_jack *jack);
^~~
sound/soc/intel/boards/kbl_da7219_max98357a.c: In function
'kabylake_card_late_probe':
sound/soc/intel/boards/kbl_da7219_max98357a.c:552:34: error: passing argument 1
of 'hdac_hdmi_jack_port_init' from incompatible pointer type
[-Werror=incompatible-pointer-types]
return hdac_hdmi_jack_port_init(codec, &card->dapm);
^
In file included from sound/soc/intel/boards/kbl_da7219_max98357a.c:21:0:
sound/soc/intel/boards/../../codecs/hdac_hdmi.h:8:5: note: expected 'struct
snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
int hdac_hdmi_jack_port_init(struct snd_soc_component *component,
^~~~
Caused by commits
608a300fc1f0 ("ASoC: AMD: Add machine driver for ST DA7219 MAX98357")
b3ea70ee64ea ("ASoC: Intel: Add Kabylake-y Dialog Maxim machine driver")
interacting with commit
451011221711 ("ASoC: hdac_hdmi/nau8825/rt286/rt298/rt5663/da7219: replace codec
to component")
I have used the sound-asoc tree from next-20180216 for today.
Thanks Kuninori for updating the patches with fixes for the above failure.
https://patchwork.kernel.org/patch/10227101/
https://patchwork.kernel.org/patch/10227099/
Re: linux-next: build failure after merge of the sound-asoc tree
Hi Stephen
Thank you for your report.
It seems added new drivers are not based on new framework.
I will post fixup patch for these.
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/soc/amd/acp-da7219-max98357a.c: In function 'cz_da7219_init':
> sound/soc/amd/acp-da7219-max98357a.c:79:22: error: passing argument 1 of
> 'da7219_aad_jack_det' from incompatible pointer type
> [-Werror=incompatible-pointer-types]
> da7219_aad_jack_det(codec, &cz_jack);
> ^
> In file included from sound/soc/amd/acp-da7219-max98357a.c:38:0:
> sound/soc/amd/../codecs/da7219-aad.h:209:6: note: expected 'struct
> snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
> void da7219_aad_jack_det(struct snd_soc_component *component, struct
> snd_soc_jack *jack);
> ^~~
> cc1: some warnings being treated as errors
> sound/soc/intel/boards/kbl_da7219_max98357a.c: In function
> 'kabylake_da7219_codec_init':
> sound/soc/intel/boards/kbl_da7219_max98357a.c:194:22: error: passing argument
> 1 of 'da7219_aad_jack_det' from incompatible pointer type
> [-Werror=incompatible-pointer-types]
> da7219_aad_jack_det(codec, &ctx->kabylake_headset);
> ^
> In file included from sound/soc/intel/boards/kbl_da7219_max98357a.c:23:0:
> sound/soc/intel/boards/../../codecs/da7219-aad.h:209:6: note: expected
> 'struct snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
> void da7219_aad_jack_det(struct snd_soc_component *component, struct
> snd_soc_jack *jack);
> ^~~
> sound/soc/intel/boards/kbl_da7219_max98357a.c: In function
> 'kabylake_card_late_probe':
> sound/soc/intel/boards/kbl_da7219_max98357a.c:552:34: error: passing argument
> 1 of 'hdac_hdmi_jack_port_init' from incompatible pointer type
> [-Werror=incompatible-pointer-types]
> return hdac_hdmi_jack_port_init(codec, &card->dapm);
> ^
> In file included from sound/soc/intel/boards/kbl_da7219_max98357a.c:21:0:
> sound/soc/intel/boards/../../codecs/hdac_hdmi.h:8:5: note: expected 'struct
> snd_soc_component *' but argument is of type 'struct snd_soc_codec *'
> int hdac_hdmi_jack_port_init(struct snd_soc_component *component,
> ^~~~
>
> Caused by commits
>
> 608a300fc1f0 ("ASoC: AMD: Add machine driver for ST DA7219 MAX98357")
> b3ea70ee64ea ("ASoC: Intel: Add Kabylake-y Dialog Maxim machine driver")
>
> interacting with commit
>
> 451011221711 ("ASoC: hdac_hdmi/nau8825/rt286/rt298/rt5663/da7219: replace
> codec to component")
>
> I have used the sound-asoc tree from next-20180216 for today.
>
> --
> Cheers,
> Stephen Rothwell
> [2 OpenPGP digital signature ]
> No public key for 015042F34957D06C created at 2018-02-19T08:32:45+0900 using
> RSA
Re: linux-next: build failure after merge of the sound-asoc tree
Hi Mark > > Thank you for reporting. > > It is my fault, this patch might cause other issue. > > I'm asking to Mark to remove it from his branch. > > Dropped. Thank you ! Best regards --- Kuninori Morimoto
Re: linux-next: build failure after merge of the sound-asoc tree
On Thu, Feb 15, 2018 at 02:49:44AM +, Kuninori Morimoto wrote: > > Hi Stephen > > Thank you for reporting. > It is my fault, this patch might cause other issue. > I'm asking to Mark to remove it from his branch. Dropped. signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
Hi Stephen
Thank you for reporting.
It is my fault, this patch might cause other issue.
I'm asking to Mark to remove it from his branch.
> After merging the sound-asoc tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> /home/sfr/next/next/sound/soc/soc-core.c: In function
> 'snd_soc_register_codec':
> /home/sfr/next/next/sound/soc/soc-core.c:3818:8: error: too many arguments to
> function 'snd_soc_register_dais'
> ret = snd_soc_register_dais(&codec->component, dai_drv, num_dai, false);
> ^
> /home/sfr/next/next/sound/soc/soc-core.c:3114:12: note: declared here
> static int snd_soc_register_dais(struct snd_soc_component *component,
> ^
>
> Caused by commit
>
> a8768c52c511 ("ASoC: soc-core: remove legacy_dai_naming from
> snd_soc_register_dais()")
>
> I have used the sound-asoc tree from next-20180214 for today.
>
> --
> Cheers,
> Stephen Rothwell
Re: linux-next: build failure after merge of the sound-asoc tree
On Wed, Sep 20, 2017 at 01:54:47PM +0200, robert.jarz...@free.fr wrote: > I will resend an incremental version of this patch alone Mark this evening if > that > suits you, with the bracket missing in wm9712.c:661 added. I fixed this already. signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
Hi Stephen and Mark,
This is my mess. And today my mailer is not my usual one, please don't blame me
for its probably awfull rendering.
Somehow, in my last serie, in wm9712_soc_probe(), a closing bracket has
disappeared.
This affects only wm9712.c, not the others, ie. the commit :
- 2ed1a8e "ASoC: wm9712: add ac97 new bus support"
I will resend an incremental version of this patch alone Mark this evening if
that
suits you, with the bracket missing in wm9712.c:661 added.
Cheers.
--
Robert
[1] The diff, scrambled probably by my mailer, will look like the attached
piece.
My mailer refuses to add a TAB so I cannot inline it with a scissor.
diff --git a/sound/soc/codecs/wm9712.c b/sound/soc/codecs/wm9712.c
index 1e228bf..9db5c77 100644
--- a/sound/soc/codecs/wm9712.c
+++ b/sound/soc/codecs/wm9712.c
@@ -658,6 +658,7 @@ static int wm9712_soc_probe(struct snd_soc_codec *codec)
if (IS_ERR(regmap)) {
ret = PTR_ERR(regmap);
goto err_free_ac97_codec;
+ }
#endif
}
Re: linux-next: build failure after merge of the sound-asoc tree
Sorry for the trouble.
Looks like these rt5514_spi_* functions should be guarded by #if
IS_ENABLED(CONFIG_SND_SOC_RT5514_SPI)
I'll resend the patch to address this.
Thanks,
Hsin-yu
On Fri, Aug 25, 2017 at 3:41 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> sound/soc/codecs/rt5514.c: In function 'rt5514_dsp_voice_wake_up_put':
> sound/soc/codecs/rt5514.c:343:11: error: implicit declaration of function
> 'rt5514_spi_burst_write' [-Werror=implicit-function-declaration]
> ret = rt5514_spi_burst_write(0x4ff8,
>^
>
> Caused by commit
>
> d18420b0a0b8 ("ASoC: rt5514: expose Hotword Model control")
>
> I have reverted that commit for today.
>
> --
> Cheers,
> Stephen Rothwell
Re: linux-next: build failure after merge of the sound-asoc tree
Hi all,
On Fri, 30 Jun 2017 11:51:35 +1000 Stephen Rothwell
wrote:
>
> On Thu, 29 Jun 2017 02:01:16 + Bard Liao wrote:
> >
> > > -Original Message-
> > > From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> > > Sent: Thursday, June 29, 2017 9:54 AM
> > > To: Mark Brown; Liam Girdwood
> > > Cc: Linux-Next Mailing List; Linux Kernel Mailing List; Bard Liao
> > > Subject: linux-next: build failure after merge of the sound-asoc tree
> > >
> > > Hi all,
> > >
> > > After merging the sound-asoc tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > sound/soc/codecs/rt5670.c: In function 'rt5670_set_codec_sysclk':
> > > sound/soc/codecs/rt5670.c:2448:57: error: 'codec' undeclared (first use
> > > in this
> > > function)
> > > struct rt5670_priv *rt5670 = snd_soc_codec_get_drvdata(codec);
> > > ^
> > > sound/soc/codecs/rt5670.c:2448:57: note: each undeclared identifier is
> > > reported only once for each function it appears in
> > > sound/soc/codecs/rt5670.c: At top level:
> > > sound/soc/codecs/rt5670.c:2775:16: error: initialization from incompatible
> > > pointer type [-Werror=incompatible-pointer-types]
> > > .set_sysclk = rt5670_set_codec_sysclk,
> > > ^
> > > sound/soc/codecs/rt5670.c:2775:16: note: (near initialization for
> > > 'soc_codec_dev_rt5670.set_sysclk')
> > > cc1: some warnings being treated as errors
> > >
> > > Caused by commit
> > >
> > > 6c28ce3c425e ("ASoC: rt5670: move set_sysclk to codec level")
> > >
> > > I have used the sound-asoc tree from next-20170628 for today.
> >
> > Sorry about that. I just sent a patch to fix it. Please check the attached.
> >
>
> I have applied your patch (attached) for today.
>
> Mark, Liam, please apply.
>
> Tested-by: Stephen Rothwell
Ping?
--
Cheers,
Stephen Rothwell
Re: linux-next: build failure after merge of the sound-asoc tree
Hi Bard,
On Thu, 29 Jun 2017 02:01:16 + Bard Liao wrote:
>
> > -Original Message-
> > From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> > Sent: Thursday, June 29, 2017 9:54 AM
> > To: Mark Brown; Liam Girdwood
> > Cc: Linux-Next Mailing List; Linux Kernel Mailing List; Bard Liao
> > Subject: linux-next: build failure after merge of the sound-asoc tree
> >
> > Hi all,
> >
> > After merging the sound-asoc tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > sound/soc/codecs/rt5670.c: In function 'rt5670_set_codec_sysclk':
> > sound/soc/codecs/rt5670.c:2448:57: error: 'codec' undeclared (first use in
> > this
> > function)
> > struct rt5670_priv *rt5670 = snd_soc_codec_get_drvdata(codec);
> > ^
> > sound/soc/codecs/rt5670.c:2448:57: note: each undeclared identifier is
> > reported only once for each function it appears in
> > sound/soc/codecs/rt5670.c: At top level:
> > sound/soc/codecs/rt5670.c:2775:16: error: initialization from incompatible
> > pointer type [-Werror=incompatible-pointer-types]
> > .set_sysclk = rt5670_set_codec_sysclk,
> > ^
> > sound/soc/codecs/rt5670.c:2775:16: note: (near initialization for
> > 'soc_codec_dev_rt5670.set_sysclk')
> > cc1: some warnings being treated as errors
> >
> > Caused by commit
> >
> > 6c28ce3c425e ("ASoC: rt5670: move set_sysclk to codec level")
> >
> > I have used the sound-asoc tree from next-20170628 for today.
>
> Sorry about that. I just sent a patch to fix it. Please check the attached.
I have applied your patch (attached) for today.
Mark, Liam, please apply.
Tested-by: Stephen Rothwell
--
Cheers,
Stephen Rothwell
>From edd2464c74be57ee7b5f5d08b539a0de0b3ecfc8 Mon Sep 17 00:00:00 2001
From: Bard Liao
Date: Thu, 29 Jun 2017 09:37:24 +0800
Subject: [PATCH] ASoC: rt5670: fix incompatible pointer type of set_sysclk
The first parameter is codec not dai.
Signed-off-by: Bard Liao
---
Sorry for missing it in the "move set_sysclk to codec level" patch
---
sound/soc/codecs/rt5670.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt5670.c b/sound/soc/codecs/rt5670.c
index 7fa63ad..64756dc 100644
--- a/sound/soc/codecs/rt5670.c
+++ b/sound/soc/codecs/rt5670.c
@@ -2442,7 +2442,7 @@ static int rt5670_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
return 0;
}
-static int rt5670_set_codec_sysclk(struct snd_soc_dai *dai, int clk_id,
+static int rt5670_set_codec_sysclk(struct snd_soc_codec *codec, int clk_id,
int source, unsigned int freq, int dir)
{
struct rt5670_priv *rt5670 = snd_soc_codec_get_drvdata(codec);
--
2.7.4
RE: linux-next: build failure after merge of the sound-asoc tree
> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: Thursday, June 29, 2017 9:54 AM
> To: Mark Brown; Liam Girdwood
> Cc: Linux-Next Mailing List; Linux Kernel Mailing List; Bard Liao
> Subject: linux-next: build failure after merge of the sound-asoc tree
>
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/soc/codecs/rt5670.c: In function 'rt5670_set_codec_sysclk':
> sound/soc/codecs/rt5670.c:2448:57: error: 'codec' undeclared (first use in
> this
> function)
> struct rt5670_priv *rt5670 = snd_soc_codec_get_drvdata(codec);
> ^
> sound/soc/codecs/rt5670.c:2448:57: note: each undeclared identifier is
> reported only once for each function it appears in
> sound/soc/codecs/rt5670.c: At top level:
> sound/soc/codecs/rt5670.c:2775:16: error: initialization from incompatible
> pointer type [-Werror=incompatible-pointer-types]
> .set_sysclk = rt5670_set_codec_sysclk,
> ^
> sound/soc/codecs/rt5670.c:2775:16: note: (near initialization for
> 'soc_codec_dev_rt5670.set_sysclk')
> cc1: some warnings being treated as errors
>
> Caused by commit
>
> 6c28ce3c425e ("ASoC: rt5670: move set_sysclk to codec level")
>
> I have used the sound-asoc tree from next-20170628 for today.
Sorry about that. I just sent a patch to fix it. Please check the attached.
>
> --
> Cheers,
> Stephen Rothwell
>
> --Please consider the environment before printing this e-mail.
0001-ASoC-rt5670-fix-incompatible-pointer-type-of-set_sys.patch
Description: 0001-ASoC-rt5670-fix-incompatible-pointer-type-of-set_sys.patch
Re: linux-next: build failure after merge of the sound-asoc tree
Hi Stephen
> After merging the sound-asoc tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> ERROR: "asoc_simple_card_clk_enable"
> [sound/soc/generic/snd-soc-simple-card.ko] undefined!
> ERROR: "asoc_simple_card_clk_disable"
> [sound/soc/generic/snd-soc-simple-card.ko] undefined!
>
> Caused by commit
>
> bb24a3ba3f52 ("ASoC: simple-scu-card: use asoc_simple_card_clk_xxx()")
>
> These symbols are not exported to modules.
>
> I have used the sound-asoc tree from next-20170613 for today.
Thanks.
I posted this fixup patch few hours ago
To: Mark Brown
Subject: [PATCH] ASoC: simple_card_utils: add EXPORT_SYMBOL_GPL() for
asoc_simple_card_clk_xxx()
CC: Linux-ALSA , Simon ,
Date: Wed, 14 Jun 2017 01:04:11 +
Best regards
---
Kuninori Morimoto
Re: linux-next: build failure after merge of the sound-asoc tree
On Tue, Dec 06, 2016 at 12:55:38PM +, Lee Jones wrote:
> On Tue, 06 Dec 2016, Mark Brown wrote:
> > On Tue, Dec 06, 2016 at 12:41:15AM +, Kuninori Morimoto wrote:
> > > 8ca9edc837932469b81b8b47ea43a074b6add970
> > > ("mfd: davinci_voicecodec: Tidyup header difinitions")
> > Reverted. Lee, there is actually a dependency here...
> No idea what you're talking about.
You were saying there were no dependencies for the ASoC bit of
Morimoto-san's cq9vc series.
> Are you going to allude to the patch you reverted?
The one Stephen identified.
> I assume you wish for me to pick it up?
Or if you could send me a pull request for the MFD bits.
signature.asc
Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Tue, 06 Dec 2016, Mark Brown wrote:
> On Tue, Dec 06, 2016 at 12:41:15AM +, Kuninori Morimoto wrote:
> > > In file included from sound/soc/codecs/cq93vc.c:32:0:
> > > include/linux/mfd/davinci_voicecodec.h:31:27: fatal error:
> > > mach/hardware.h: No such file or directory
> > >
>
> > As I indicated on cover letter, this patch is based on
>
> > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ::
> > for-mfd-next
>
> > Especially this commit
>
> > 8ca9edc837932469b81b8b47ea43a074b6add970
> > ("mfd: davinci_voicecodec: Tidyup header difinitions")
>
> Reverted. Lee, there is actually a dependency here...
No idea what you're talking about.
Are you going to allude to the patch you reverted?
I assume you wish for me to pick it up?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Re: linux-next: build failure after merge of the sound-asoc tree
On Tue, Dec 06, 2016 at 12:41:15AM +, Kuninori Morimoto wrote:
> > In file included from sound/soc/codecs/cq93vc.c:32:0:
> > include/linux/mfd/davinci_voicecodec.h:31:27: fatal error: mach/hardware.h:
> > No such file or directory
> >
> As I indicated on cover letter, this patch is based on
> git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ::
> for-mfd-next
> Especially this commit
> 8ca9edc837932469b81b8b47ea43a074b6add970
> ("mfd: davinci_voicecodec: Tidyup header difinitions")
Reverted. Lee, there is actually a dependency here...
signature.asc
Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
Hi Stephen, Mark
> In file included from sound/soc/codecs/cq93vc.c:32:0:
> include/linux/mfd/davinci_voicecodec.h:31:27: fatal error: mach/hardware.h:
> No such file or directory
>
> Probably caused by commit
>
> 4de429888c5b ("ASoC: cq93vc: remove MFD_DAVINCI_VOICECODEC dependency for
> CQ0093VC")
>
> I have used the sound-asoc tree from next-20161205 for today.
As I indicated on cover letter, this patch is based on
git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ::
for-mfd-next
Especially this commit
8ca9edc837932469b81b8b47ea43a074b6add970
("mfd: davinci_voicecodec: Tidyup header difinitions")
Re: linux-next: build failure after merge of the sound-asoc tree
Yes, it's because Mark applied a chain of patches but missed the first
patch in the chain that added the wm_coeff_base_reg() function
On Mon, 2016-11-14 at 11:28 +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/soc/codecs/wm_adsp.c: In function 'wm_coeff_write_acked_control':
> sound/soc/codecs/wm_adsp.c:791:8: error: implicit declaration of function
> 'wm_coeff_base_reg' [-Werror=implicit-function-declaration]
> ret = wm_coeff_base_reg(ctl, ®);
> ^
>
> Caused by commit
>
> f4f0c4c60c39 ("ASoC: wm_adsp: Signal firmware shutdown through event
> control")
>
> I have used the sound-asoc tree from next-2016 for today.
>
Re: linux-next: build failure after merge of the sound-asoc tree
On Tue, Nov 08, 2016 at 11:18:29AM +0800, Chen-Yu Tsai wrote:
> sound-asoc is missing patch
> ASoC: sun4i-codec: Add support for optional reset control to quirks
> http://www.spinics.net/lists/alsa-devel/msg56289.html
> which commit 8d9e4c9e993f ("ASoC: sun4i-codec: Add support for A31 playback
> through headphone output") depends on. This was part of the same series that
> I posted:
I don't have that...
> A new version of the remaining patches was posted yesterday:
> http://www.spinics.net/lists/alsa-devel/msg56443.html
Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.
signature.asc
Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
Hi,
On Tue, Nov 8, 2016 at 10:47 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> sound/soc/sunxi/sun4i-codec.c:1188:2: error: unknown field 'has_reset'
> specified in initializer
> .has_reset = true,
> ^
> sound/soc/sunxi/sun4i-codec.c:1188:15: warning: excess elements in struct
> initializer
> .has_reset = true,
>^
> sound/soc/sunxi/sun4i-codec.c:1188:15: note: (near initialization for
> 'sun6i_a31_codec_quirks')
>
> Caused by commit
>
> 8d9e4c9e993f ("ASoC: sun4i-codec: Add support for A31 playback through
> headphone output")
>
> I have used the sound-asoc tree from next-20161028 for today.
sound-asoc is missing patch
ASoC: sun4i-codec: Add support for optional reset control to quirks
http://www.spinics.net/lists/alsa-devel/msg56289.html
which commit 8d9e4c9e993f ("ASoC: sun4i-codec: Add support for A31 playback
through headphone output") depends on. This was part of the same series that
I posted:
http://www.spinics.net/lists/alsa-devel/msg56283.html
A new version of the remaining patches was posted yesterday:
http://www.spinics.net/lists/alsa-devel/msg56443.html
The build failure should be resolved once Mark merges the remaining patches,
though some reordering might be needed to maintain bisectability.
Regards
ChenYu
Re: linux-next: build failure after merge of the sound-asoc tree
Hi
> After merging the sound-asoc tree, today's linux-next build (arm
> multi_v7_defconfig build) failed like this:
>
> sound/soc/generic/simple-card.c: In function 'asoc_simple_card_dai_link_of':
> sound/soc/generic/simple-card.c:350:8: error: implicit declaration of
> function 'asoc_simple_card_parse_clk_cpu'
> [-Werror=implicit-function-declaration]
> ret = asoc_simple_card_parse_clk_cpu(cpu, dai_link, cpu_dai);
> ^
> sound/soc/generic/simple-card.c:354:8: error: implicit declaration of
> function 'asoc_simple_card_parse_clk_codec'
> [-Werror=implicit-function-declaration]
> ret = asoc_simple_card_parse_clk_codec(codec, dai_link, codec_dai);
> ^
> sound/soc/sh/rcar/rsrc-card.c: In function 'rsrc_card_parse_links':
> sound/soc/sh/rcar/rsrc-card.c:193:9: error: implicit declaration of function
> 'asoc_simple_card_parse_clk_cpu' [-Werror=implicit-function-declaration]
>ret = asoc_simple_card_parse_clk_cpu(np, dai_link, dai_props);
> ^
> sound/soc/sh/rcar/rsrc-card.c:232:9: error: implicit declaration of function
> 'asoc_simple_card_parse_clk_codec' [-Werror=implicit-function-declaration]
>ret = asoc_simple_card_parse_clk_codec(np, dai_link, dai_props);
> ^
>
> Caused by commits
>
> 28abd99b6e40 ("ASoC: simple-card: use asoc_simple_card_parse_clk()")
> c9a235da8a61 ("ASoC: rsrc-card: use asoc_simple_card_parse_clk()")
>
> I have used the sound-asoc tree from next-20160805 for today.
It seems topic/simple branch is missing [1/7], but has [2/7], [3/7] patches.
I'm asking it to Mark now.
Re: linux-next: build failure after merge of the sound-asoc tree
On Wed, May 11, 2016 at 11:07:02AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/soc/intel/boards/bxt_rt298.c:257:3: error: unknown field 'be_id'
> specified in initializer
>.be_id = 0,
>^
> sound/soc/intel/boards/bxt_rt298.c:274:3: error: unknown field 'be_id'
> specified in initializer
>.be_id = 1,
>^
> sound/soc/intel/boards/bxt_rt298.c:274:12: warning: initialization makes
> pointer from integer without a cast [-Wint-conversion]
>.be_id = 1,
> ^
> sound/soc/intel/boards/bxt_rt298.c:274:12: note: (near initialization for
> 'broxton_rt298_dais[7].stream_name')
> sound/soc/intel/boards/bxt_rt298.c:285:3: error: unknown field 'be_id'
> specified in initializer
>.be_id = 3,
>^
> sound/soc/intel/boards/bxt_rt298.c:285:12: warning: initialization makes
> pointer from integer without a cast [-Wint-conversion]
>.be_id = 3,
> ^
> sound/soc/intel/boards/bxt_rt298.c:285:12: note: (near initialization for
> 'broxton_rt298_dais[8].stream_name')
> sound/soc/intel/boards/bxt_rt298.c:296:3: error: unknown field 'be_id'
> specified in initializer
>.be_id = 4,
>^
> sound/soc/intel/boards/bxt_rt298.c:296:12: warning: initialization makes
> pointer from integer without a cast [-Wint-conversion]
>.be_id = 4,
> ^
> sound/soc/intel/boards/bxt_rt298.c:296:12: note: (near initialization for
> 'broxton_rt298_dais[9].stream_name')
> sound/soc/intel/boards/bxt_rt298.c:307:3: error: unknown field 'be_id'
> specified in initializer
>.be_id = 5,
>^
> sound/soc/intel/boards/bxt_rt298.c:307:12: warning: initialization makes
> pointer from integer without a cast [-Wint-conversion]
>.be_id = 5,
> ^
>
> Caused by commit
>
> 76016322ec56 ("ASoC: Intel: Add Broxton-P machine driver")
>
> interacting with commit
>
> 2f0ad49104cb ("ASoC: Change DAI link's be_id to a generic id")
My bad, patch was generated against topic/intel of Mark's tree and I should
have checked the -next branch as well
>
> I applied the following fix patch that should have happened in the
> merge commit
>
> 8554363b9f0f ("Merge remote-tracking branches 'asoc/topic/dai-link',
> 'asoc/topic/davinci', 'asoc/topic/dwc' and 'asoc/topic/es8328' into
> asoc-next")
>
> From: Stephen Rothwell
> Date: Wed, 11 May 2016 11:03:25 +1000
> Subject: [PATCH] ASoC: Intel: fix up for DAI link's be_id change
>
> Signed-off-by: Stephen Rothwell
Acked-by: Vinod Koul
I guess Mark you will merge this as well?
> ---
> sound/soc/intel/boards/bxt_rt298.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/intel/boards/bxt_rt298.c
> b/sound/soc/intel/boards/bxt_rt298.c
> index 1b845ff779f3..f4787515c0ed 100644
> --- a/sound/soc/intel/boards/bxt_rt298.c
> +++ b/sound/soc/intel/boards/bxt_rt298.c
> @@ -254,7 +254,7 @@ static struct snd_soc_dai_link broxton_rt298_dais[] = {
> {
> /* SSP5 - Codec */
> .name = "SSP5-Codec",
> - .be_id = 0,
> + .id = 0,
> .cpu_dai_name = "SSP5 Pin",
> .platform_name = ":00:0e.0",
> .no_pcm = 1,
> @@ -271,7 +271,7 @@ static struct snd_soc_dai_link broxton_rt298_dais[] = {
> },
> {
> .name = "dmic01",
> - .be_id = 1,
> + .id = 1,
> .cpu_dai_name = "DMIC01 Pin",
> .codec_name = "dmic-codec",
> .codec_dai_name = "dmic-hifi",
> @@ -282,7 +282,7 @@ static struct snd_soc_dai_link broxton_rt298_dais[] = {
> },
> {
> .name = "iDisp1",
> - .be_id = 3,
> + .id = 3,
> .cpu_dai_name = "iDisp1 Pin",
> .codec_name = "ehdaudio0D2",
> .codec_dai_name = "intel-hdmi-hifi1",
> @@ -293,7 +293,7 @@ static struct snd_soc_dai_link broxton_rt298_dais[] = {
> },
> {
> .name = "iDisp2",
> - .be_id = 4,
> + .id = 4,
> .cpu_dai_name = "iDisp2 Pin",
> .codec_name = "ehdaudio0D2",
> .codec_dai_name = "intel-hdmi-hifi2",
> @@ -304,7 +304,7 @@ static struct snd_soc_dai_link broxton_rt298_dais[] = {
> },
> {
> .name = "iDisp3",
> - .be_id = 5,
> + .id = 5,
> .cpu_dai_name = "iDisp3 Pin",
> .codec_name = "ehdaudio0D2",
> .codec_dai_name = "intel-hdmi-hifi3",
> --
> 2.7.0
>
> --
> Cheers,
> Stephen Rothwell
Thanks
--
~Vinod
RE: linux-next: build failure after merge of the sound-asoc tree
On May 06, 2016, 13:03, Mark Brown wrote: > > This patch was the 3rd in of a set of 3, and the header you added below was > > added as part of the 2nd patch of that set, hence why it is missing here. I > > assume the first 2 patches are still being reviewed by Mark. > > Yes. The ID patch should have been the first one here, put the simple > stuff first. In my mind it makes sense to only add this after support to use it is in place in the driver, hence the ordering.
Re: linux-next: build failure after merge of the sound-asoc tree
On Fri, May 06, 2016 at 09:48:51AM +, Opensource [Adam Thomson] wrote: > This patch was the 3rd in of a set of 3, and the header you added below was > added as part of the 2nd patch of that set, hence why it is missing here. I > assume the first 2 patches are still being reviewed by Mark. Yes. The ID patch should have been the first one here, put the simple stuff first. signature.asc Description: PGP signature
RE: linux-next: build failure after merge of the sound-asoc tree
On May 06, 2016, 01:58, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/soc/codecs/da7219.c:1964:23: error: implicit declaration of function
> 'ACPI_PTR' [-Werror=implicit-function-declaration]
>.acpi_match_table = ACPI_PTR(da7219_acpi_match),
>^
> sound/soc/codecs/da7219.c:1964:23: error: initializer element is not constant
> sound/soc/codecs/da7219.c:1964:23: note: (near initialization for
> 'da7219_i2c_driver.driver.acpi_match_table')
>
> Caused by commit
>
> 5181365f5312 ("ASoC: da7219: Add initial ACPI id for device")
>
> I added this patch for today:
This patch was the 3rd in of a set of 3, and the header you added below was
added as part of the 2nd patch of that set, hence why it is missing here. I
assume the first 2 patches are still being reviewed by Mark.
Re: linux-next: build failure after merge of the sound-asoc tree
On Fri, Apr 22, 2016 at 10:40:11AM +0200, Philipp Zabel wrote: > 8< > From: Philipp Zabel > Subject: [PATCH] fixup! ASoC: hdmi-codec: Add ELD control Please also use subject lines that match the style for the subsystem. signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Fri, Apr 22, 2016 at 10:40:11AM +0200, Philipp Zabel wrote: > 8< > From: Philipp Zabel > Subject: [PATCH] fixup! ASoC: hdmi-codec: Add ELD control Please don't bury patches in the middle of e-mails. signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
Am Freitag, den 22.04.2016, 12:03 +1000 schrieb Stephen Rothwell:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from include/linux/notifier.h:13:0,
> from include/linux/memory_hotplug.h:6,
> from include/linux/mmzone.h:744,
> from include/linux/gfp.h:5,
> from include/linux/kmod.h:22,
> from include/linux/module.h:13,
> from sound/soc/codecs/hdmi-codec.c:15:
> sound/soc/codecs/hdmi-codec.c: In function 'hdmi_eld_ctl_get':
> sound/soc/codecs/hdmi-codec.c:68:17: error: 'struct hdmi_codec_priv' has no
> member named 'eld_lock'
> mutex_lock(&hcp->eld_lock);
> ^
> include/linux/mutex.h:146:44: note: in definition of macro 'mutex_lock'
> #define mutex_lock(lock) mutex_lock_nested(lock, 0)
> ^
> sound/soc/codecs/hdmi-codec.c:70:19: error: 'struct hdmi_codec_priv' has no
> member named 'eld_lock'
> mutex_unlock(&hcp->eld_lock);
>^
>
> Caused by commit
>
> 81151cfb6bfe ("ASoC: hdmi-codec: Add ELD control")
>
> I have used the sound-asoc tree from next-20160421 for today.
Sorry, the mutex_lock slipped through when reordering the patches.
That should be part of the "Use HDMI notifications to add jack support"
patch instead.
regards
Philipp
8<
From: Philipp Zabel
Subject: [PATCH] fixup! ASoC: hdmi-codec: Add ELD control
---
sound/soc/codecs/hdmi-codec.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c
index c78333b..8e36e88 100644
--- a/sound/soc/codecs/hdmi-codec.c
+++ b/sound/soc/codecs/hdmi-codec.c
@@ -65,9 +65,7 @@ static int hdmi_eld_ctl_get(struct snd_kcontrol *kcontrol,
struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
struct hdmi_codec_priv *hcp = snd_soc_component_get_drvdata(component);
- mutex_lock(&hcp->eld_lock);
memcpy(ucontrol->value.bytes.data, hcp->eld, sizeof(hcp->eld));
- mutex_unlock(&hcp->eld_lock);
return 0;
}
--
2.8.0.rc3
Re: linux-next: build failure after merge of the sound-asoc tree
On Fri, Nov 20, 2015 at 12:06:13PM +, Mark Brown wrote:
> On Thu, Nov 19, 2015 at 08:32:09AM +0530, Vinod Koul wrote:
> > On Thu, Nov 19, 2015 at 11:35:28AM +1100, Stephen Rothwell wrote:
>
> > > Caused by commit
> > >
> > > a86d505783e4 ("ASoC: Intel: Skylake: Adding nau88l25+ssm4567 machine
> > > driver")
>
> > Okay both went it same time, I will send a patch for this
>
> Not seeing that patch...
Sorry for the delay. I have the patches, testing it now. couple of hours and
it should be on the list :)
Thanks
--
~Vinod
signature.asc
Description: Digital signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Thu, Nov 19, 2015 at 08:32:09AM +0530, Vinod Koul wrote:
> On Thu, Nov 19, 2015 at 11:35:28AM +1100, Stephen Rothwell wrote:
> > Caused by commit
> >
> > a86d505783e4 ("ASoC: Intel: Skylake: Adding nau88l25+ssm4567 machine
> > driver")
> Okay both went it same time, I will send a patch for this
Not seeing that patch...
signature.asc
Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Thu, Nov 19, 2015 at 08:32:09AM +0530, Vinod Koul wrote:
> On Thu, Nov 19, 2015 at 11:35:28AM +1100, Stephen Rothwell wrote:
> > a86d505783e4 ("ASoC: Intel: Skylake: Adding nau88l25+ssm4567 machine
> > driver")
> Okay both went it same time, I will send a patch for this
> Somehow Feng's bot missed this...
There was a mail about it - it came out too close to when Stephen
usually pulls for me to do anything about backing things out.
signature.asc
Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Thu, Nov 19, 2015 at 11:35:28AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/soc/fsl/fsl-asoc-card.c: In function 'fsl_asoc_card_late_probe':
> sound/soc/fsl/fsl-asoc-card.c:420:38: error: 'struct snd_soc_card' has no
> member named 'rtd'
> struct snd_soc_dai *codec_dai = card->rtd[0].codec_dai;
> ^
> sound/soc/fsl/fsl-asoc-card.c:427:37: error: 'struct snd_soc_card' has no
> member named 'rtd'
>struct snd_soc_codec *codec = card->rtd[0].codec;
> ^
>
> Caused by commit
>
> 5015920a1732 ("ASoC: Vendor drivers get a link's runtime by
> snd_soc_get_pcm_runtime()")
>
> sound/soc/intel/boards/skl_nau88l25_ssm4567.c: In function
> 'skl_get_codec_dai':
> sound/soc/intel/boards/skl_nau88l25_ssm4567.c:43:13: error: 'struct
> snd_soc_card' has no member named 'rtd'
>rtd = card->rtd + i;
> ^
>
> Caused by commit
>
> a86d505783e4 ("ASoC: Intel: Skylake: Adding nau88l25+ssm4567 machine
> driver")
Okay both went it same time, I will send a patch for this
Somehow Feng's bot missed this...
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the sound-asoc tree
On Mon, 31 Aug 2015, Stephen Rothwell wrote: > On Mon, 31 Aug 2015 17:48:42 +1000 Stephen Rothwell > wrote: > > > > On Mon, 31 Aug 2015 09:04:22 +0200 Ricard Wanderlof > > wrote: > > > > > > On Fri, 28 Aug 2015, Mark Brown wrote: > > > > > > > On Fri, Aug 28, 2015 at 09:40:41AM +0200, Ricard Wanderlof wrote: > > > > > On Fri, 28 Aug 2015, Stephen Rothwell wrote: > > > > > > > > > In fact the exact same construct is used by a handful of other codec > > > > > drivers which apparently don't fail. > > > > > > > > > I'm suspecting something slightly more convoluted like a missing > > > > #include . > > > > > > > > No, the issue is that you have used a different variable name when > > > > declaring the IDs and when referencing them in the module device table. > > > > > > Yeah, I realized that upon closer inspection. > > > > > > What bugs me is that my ARM gcc didn't seem to flag this, whereas the > > > x86 gcc did upon subsequent testing. And yes, CONFIG_OF is set during my > > > build. > > > > Do you have CONFIG_MODULE set in your build? (just guessing) > > Actually what matters is if you build the driver as a module or not. > See include/linux/module.h and the definitions of MODULE_DEVICE_TABLE(). Bingo. Haven't verified that, but it's true, the kernel build for our ARM system is largely monolithic as we have no need to reconfigure it once it has been built. Whereas in my x86 test build the driver was built as a module. Thanks Stegphen! /Ricard -- Ricard Wolf Wanderlöf ricardw(at)axis.com Axis Communications AB, Lund, Swedenwww.axis.com Phone +46 46 272 2016 Fax +46 46 13 61 30 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the sound-asoc tree
Hi Ricard, On Mon, 31 Aug 2015 17:48:42 +1000 Stephen Rothwell wrote: > > On Mon, 31 Aug 2015 09:04:22 +0200 Ricard Wanderlof > wrote: > > > > On Fri, 28 Aug 2015, Mark Brown wrote: > > > > > On Fri, Aug 28, 2015 at 09:40:41AM +0200, Ricard Wanderlof wrote: > > > > On Fri, 28 Aug 2015, Stephen Rothwell wrote: > > > > > > > In fact the exact same construct is used by a handful of other codec > > > > drivers which apparently don't fail. > > > > > > > I'm suspecting something slightly more convoluted like a missing > > > #include . > > > > > > No, the issue is that you have used a different variable name when > > > declaring the IDs and when referencing them in the module device table. > > > > Yeah, I realized that upon closer inspection. > > > > What bugs me is that my ARM gcc didn't seem to flag this, whereas the > > x86 gcc did upon subsequent testing. And yes, CONFIG_OF is set during my > > build. > > Do you have CONFIG_MODULE set in your build? (just guessing) Actually what matters is if you build the driver as a module or not. See include/linux/module.h and the definitions of MODULE_DEVICE_TABLE(). -- Cheers, Stephen Rothwells...@canb.auug.org.au -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the sound-asoc tree
Hi Ricard, On Mon, 31 Aug 2015 09:04:22 +0200 Ricard Wanderlof wrote: > > On Fri, 28 Aug 2015, Mark Brown wrote: > > > On Fri, Aug 28, 2015 at 09:40:41AM +0200, Ricard Wanderlof wrote: > > > On Fri, 28 Aug 2015, Stephen Rothwell wrote: > > > > > In fact the exact same construct is used by a handful of other codec > > > drivers which apparently don't fail. > > > > > I'm suspecting something slightly more convoluted like a missing > > #include . > > > > No, the issue is that you have used a different variable name when > > declaring the IDs and when referencing them in the module device table. > > Yeah, I realized that upon closer inspection. > > What bugs me is that my ARM gcc didn't seem to flag this, whereas the > x86 gcc did upon subsequent testing. And yes, CONFIG_OF is set during my > build. Do you have CONFIG_MODULE set in your build? (just guessing) -- Cheers, Stephen Rothwells...@canb.auug.org.au -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the sound-asoc tree
On Fri, 28 Aug 2015, Mark Brown wrote: > On Fri, Aug 28, 2015 at 09:40:41AM +0200, Ricard Wanderlof wrote: > > On Fri, 28 Aug 2015, Stephen Rothwell wrote: > > > In fact the exact same construct is used by a handful of other codec > > drivers which apparently don't fail. > > > I'm suspecting something slightly more convoluted like a missing > #include . > > No, the issue is that you have used a different variable name when > declaring the IDs and when referencing them in the module device table. Yeah, I realized that upon closer inspection. What bugs me is that my ARM gcc didn't seem to flag this, whereas the x86 gcc did upon subsequent testing. And yes, CONFIG_OF is set during my build. /Ricard -- Ricard Wolf Wanderlöf ricardw(at)axis.com Axis Communications AB, Lund, Swedenwww.axis.com Phone +46 46 272 2016 Fax +46 46 13 61 30 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the sound-asoc tree
On Fri, Aug 28, 2015 at 09:40:41AM +0200, Ricard Wanderlof wrote: > On Fri, 28 Aug 2015, Stephen Rothwell wrote: > In fact the exact same construct is used by a handful of other codec > drivers which apparently don't fail. > I'm suspecting something slightly more convoluted like a missing #include . No, the issue is that you have used a different variable name when declaring the IDs and when referencing them in the module device table. signature.asc Description: Digital signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Fri, 28 Aug 2015, Stephen Rothwell wrote:
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from sound/soc/codecs/ics43432.c:12:0:
> sound/soc/codecs/ics43432.c:60:25: error: 'ics43432_dt_ids' undeclared here
> (not in a function)
> MODULE_DEVICE_TABLE(of, ics43432_dt_ids);
> ^
> include/linux/module.h:223:21: note: in definition of macro
> 'MODULE_DEVICE_TABLE'
> extern const typeof(name) __mod_##type##__##name##_device_table \
> ^
> include/linux/module.h:223:27: error:
> '__mod_of__ics43432_dt_ids_device_table' aliased to undefined symbol
> 'ics43432_dt_ids'
> extern const typeof(name) __mod_##type##__##name##_device_table \
>^
> sound/soc/codecs/ics43432.c:60:1: note: in expansion of macro
> 'MODULE_DEVICE_TABLE'
> MODULE_DEVICE_TABLE(of, ics43432_dt_ids);
> ^
>
> Caused by commit
>
> 3b7ce99748f0 ("ASoC: ics43432: Add codec driver for InvenSense ICS-43432")
>
> Not really build tested with CONFIG_OF set, right? :-(
Well, actually, yes.
In fact the exact same construct is used by a handful of other codec
drivers which apparently don't fail.
I'm suspecting something slightly more convoluted like a missing #include .
> I have reverted that commit for today.
Ok. I'll get to work on this ASAP.
/Ricard
--
Ricard Wolf Wanderlöf ricardw(at)axis.com
Axis Communications AB, Lund, Swedenwww.axis.com
Phone +46 46 272 2016 Fax +46 46 13 61 30
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the sound-asoc tree
Hi all,
On Fri, 17 Jul 2015 14:25:01 +1000 Stephen Rothwell
wrote:
>
> After merging the sound-asoc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> sound/soc/sti/sti_uniperif.c: In function 'sti_uniperiph_dai_suspend':
> sound/soc/sti/sti_uniperif.c:81:2: error: implicit declaration of function
> 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
> ret = pinctrl_pm_select_sleep_state(uni->dev);
> ^
> sound/soc/sti/sti_uniperif.c: In function 'sti_uniperiph_dai_resume':
> sound/soc/sti/sti_uniperif.c:102:2: error: implicit declaration of function
> 'pinctrl_pm_select_default_state' [-Werror=implicit-function-declaration]
> ret = pinctrl_pm_select_default_state(uni->dev);
> ^
>
> Caused by commit
>
> f3bd847eb0a7 ("ASoC: sti: Add uniperipheral dai driver")
ping! I still needed this today.
>
> I have added this fix patch for today:
>
> From: Stephen Rothwell
> Date: Fri, 17 Jul 2015 14:21:37 +1000
> Subject: [PATCH] ASoC: sti: included needed header file
>
> Signed-off-by: Stephen Rothwell
> ---
> sound/soc/sti/sti_uniperif.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/sti/sti_uniperif.c b/sound/soc/sti/sti_uniperif.c
> index 749e6b294184..ab8d36af6dcb 100644
> --- a/sound/soc/sti/sti_uniperif.c
> +++ b/sound/soc/sti/sti_uniperif.c
> @@ -6,6 +6,7 @@
> */
>
> #include
> +#include
>
> #include "uniperif.h"
>
> --
> 2.1.4
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: linux-next: build failure after merge of the sound-asoc tree
Dear All,
I will send a patch to fix it immediately.
Thanks.
Bard Liao
Computer Peripherals Business Unit
Realtek Semiconductor Corp.
886-3-578-0211 ext. 3334
bardl...@realtek.com
> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: Thursday, April 30, 2015 10:06 AM
> To: Mark Brown; Liam Girdwood
> Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Bard Liao
> Subject: linux-next: build failure after merge of the sound-asoc tree
>
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> sound/soc/codecs/rt5645.c: In function 'rt5645_set_jack_detect':
> sound/soc/codecs/rt5645.c:2555:2: error: implicit declaration of function
> 'rt5645_irq_detection' [-Werror=implicit-function-declaration]
> rt5645_irq_detection(rt5645);
> ^
> sound/soc/codecs/rt5645.c: At top level:
> sound/soc/codecs/rt5645.c:2591:12: error: static declaration of
> 'rt5645_irq_detection' follows non-static declaration static int
> rt5645_irq_detection(struct rt5645_priv *rt5645)
> ^
> sound/soc/codecs/rt5645.c:2555:2: note: previous implicit declaration of
> 'rt5645_irq_detection' was here
> rt5645_irq_detection(rt5645);
> ^
> sound/soc/codecs/rt5645.c:2591:12: warning: 'rt5645_irq_detection'
> defined but not used [-Wunused-function] static int
> rt5645_irq_detection(struct rt5645_priv *rt5645)
> ^
>
> Caused by commit 6e747d5311fc ("ASoC: rt5645: Adds push button
> support for rt5650").
>
> I have used the sound-asoc tree from next-20150429 for today.
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au
>
> --Please consider the environment before printing this e-mail.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: linux-next: build failure after merge of the sound-asoc tree
> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: Thursday, March 12, 2015 10:12 AM
> To: Mark Brown; Liam Girdwood
> Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Bard Liao
> Subject: Re: linux-next: build failure after merge of the sound-asoc tree
>
> Hi all,
>
> On Tue, 10 Mar 2015 13:01:20 +1100 Stephen Rothwell
> wrote:
> >
> > After merging the sound-asoc tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > sound/soc/codecs/rt5670.c: In function 'is_sys_clk_from_pll':
> > sound/soc/codecs/rt5670.c:519:38: error: 'struct snd_soc_dapm_widget'
> has no member named 'codec'
> > struct snd_soc_codec *codec = source->codec;
> > ^
> >
Hi
Please apply Lars-Peter's "ASoC: rt5670: Replace w->codec
snd_soc_dapm_to_codec(w->dapm)" patch
http://mailman.alsa-project.org/pipermail/alsa-devel/2015-January/086618.html
Thanks.
> > Caused by commit 485372dc24ca ("ASoC: rt5670: Check sysclk source by
> > private data")?
>
> Still getting this.
>
> > sound/soc/codecs/rt5670.c: In function 'rt5670_set_dai_sysclk':
> > sound/soc/codecs/rt5670.c:2272:1: error: expected expression before
> > '<<' token <<<<<<< HEAD ^
> > sound/soc/codecs/rt5670.c:2284:1: error: expected expression before
> > '>>' token >>>>>>> v4.0-rc3 ^
> >
> > Oops :-(
>
> This has been fixed.
>
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au
>
> --Please consider the environment before printing this e-mail.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the sound-asoc tree
Hi all,
On Tue, 10 Mar 2015 13:01:20 +1100 Stephen Rothwell
wrote:
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/soc/codecs/rt5670.c: In function 'is_sys_clk_from_pll':
> sound/soc/codecs/rt5670.c:519:38: error: 'struct snd_soc_dapm_widget' has no
> member named 'codec'
> struct snd_soc_codec *codec = source->codec;
> ^
>
> Caused by commit 485372dc24ca ("ASoC: rt5670: Check sysclk source by
> private data")?
Still getting this.
> sound/soc/codecs/rt5670.c: In function 'rt5670_set_dai_sysclk':
> sound/soc/codecs/rt5670.c:2272:1: error: expected expression before '<<' token
> <<< HEAD
> ^
> sound/soc/codecs/rt5670.c:2284:1: error: expected expression before '>>' token
> >>> v4.0-rc3
> ^
>
> Oops :-(
This has been fixed.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgp2zewFsEYAW.pgp
Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Wed, Jan 28, 2015 at 09:50:40AM +, Charles Keepax wrote: > On Wed, Jan 28, 2015 at 09:09:35AM +, Charles Keepax wrote: > > Very sorry guys my fault, not sure how that slipped through. Mark > > do you want an incremental fix or shall I respin the two patches > > in question? > Ah... ok I think I just timed my patch very badly in relation to > Lar's changes and it was building here so I failed to notice the > error. I see you have fixed it in the merge are you happy to go > with that solution? It should be fixed for tomorrow I think - the zero day tester was quite slow for some reason. signature.asc Description: Digital signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Wed, Jan 28, 2015 at 01:00:47PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (x86_64
> allmodconfig)
> failed like this:
>
> sound/soc/codecs/arizona.c: In function 'arizona_out_ev':
> sound/soc/codecs/arizona.c:738:57: error: 'struct snd_soc_dapm_widget' has no
> member named 'codec'
> struct arizona_priv *priv = snd_soc_codec_get_drvdata(w->codec);
> ^
>
> Caused by commit 054e1b489227 ("ASoC: arizona: Add delay for output
> disable") interacting with commit 96da4e5b2e1d ("ASoC: Remove codec
> field from snd_soc_dapm_widget"). It needed to be fixed up in merge
> commit 7659e0ab1afa ("Merge remote-tracking branches
> 'asoc/topic/ad193x', 'asoc/topic/alc5632', 'asoc/topic/arizona' and
> 'asoc/topic/atmel' into asoc-next").
>
> I have used the sound-asoc tree from next-20150127 for today.
> --
Very sorry guys my fault, not sure how that slipped through. Mark
do you want an incremental fix or shall I respin the two patches
in question?
Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the sound-asoc tree
On Wed, Jan 28, 2015 at 09:09:35AM +, Charles Keepax wrote:
> On Wed, Jan 28, 2015 at 01:00:47PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the sound-asoc tree, today's linux-next build (x86_64
> > allmodconfig)
> > failed like this:
> >
> > sound/soc/codecs/arizona.c: In function 'arizona_out_ev':
> > sound/soc/codecs/arizona.c:738:57: error: 'struct snd_soc_dapm_widget' has
> > no member named 'codec'
> > struct arizona_priv *priv = snd_soc_codec_get_drvdata(w->codec);
> > ^
> >
> > Caused by commit 054e1b489227 ("ASoC: arizona: Add delay for output
> > disable") interacting with commit 96da4e5b2e1d ("ASoC: Remove codec
> > field from snd_soc_dapm_widget"). It needed to be fixed up in merge
> > commit 7659e0ab1afa ("Merge remote-tracking branches
> > 'asoc/topic/ad193x', 'asoc/topic/alc5632', 'asoc/topic/arizona' and
> > 'asoc/topic/atmel' into asoc-next").
> >
> > I have used the sound-asoc tree from next-20150127 for today.
> > --
>
> Very sorry guys my fault, not sure how that slipped through. Mark
> do you want an incremental fix or shall I respin the two patches
> in question?
Ah... ok I think I just timed my patch very badly in relation to
Lar's changes and it was building here so I failed to notice the
error. I see you have fixed it in the merge are you happy to go
with that solution?
Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the sound-asoc tree
On Mon, Aug 18, 2014 at 02:51:15PM +0800, Sean Cross wrote: > That gives it almost the exact same kernel config as the SGTL5000. > Is this the sort of thing you can apply on your end, or would you like > me to resubmit a v12 with just this file? I'm afraid I don't have a PPC > toolchain to test with. Please submit your fix using the normal submission process. signature.asc Description: Digital signature
Re: linux-next: build failure after merge of the sound-asoc tree
On 08/18/14 06:30, Stephen Rothwell wrote:
> Hi all,
>
> After merging the sound-asoc tree, today's linux-next build (powerpc
> allyesconfig)
> failed like this:
>
> sound/soc/fsl/imx-pcm-fiq.c:31:21: fatal error: asm/fiq.h: No such file or
> directory
> #include
> ^
>
> Caused by commit 7e7292dba215 ("ASoC: fsl: add imx-es8328 machine
> driver"). Presumably it will only build on arm?
>
> I reverted that commit for today.
The following patch should fix the problem:
diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index c0ace69..13199b5 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -237,8 +237,6 @@ config SND_SOC_IMX_ES8328
select SND_SOC_IMX_PCM_DMA
select SND_SOC_IMX_AUDMUX
select SND_SOC_FSL_SSI
-select SND_SOC_FSL_UTILS
-select SND_SOC_IMX_PCM_FIQ
help
Say Y if you want to add support for the ES8328 audio codec connected
via SSI/I2S over either SPI or I2C.
That gives it almost the exact same kernel config as the SGTL5000.
Is this the sort of thing you can apply on your end, or would you like
me to resubmit a v12 with just this file? I'm afraid I don't have a PPC
toolchain to test with.
Sean
signature.asc
Description: OpenPGP digital signature
Re: linux-next: build failure after merge of the sound-asoc tree
Hi Mark, On Wed, 19 Mar 2014 10:17:01 + Mark Brown wrote: > > Sorry, it's fixed already - your fetch must've raced with my fix last > night. No worries, that can happen since I fetch all the trees before I start merging. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpd3krEMCdUs.pgp Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Wed, Mar 19, 2014 at 12:10:00PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the sound-asoc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: Sorry, it's fixed already - your fetch must've raced with my fix last night. signature.asc Description: Digital signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Fri, Nov 29, 2013 at 11:54:07AM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the sound-asoc tree, today's linux-next build (x86_64 > allmodconfig) failed like this: Fixed, thanks. signature.asc Description: Digital signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Tue, Jul 16, 2013 at 01:18:28PM +1000, Stephen Rothwell wrote:
> Caused by commit df7e4082f47d ("ASoC: tegra: Enable COMPILE_TEST
> builds"). If you are going to do that, please test via (at least) an
> x86_64 allmodconf build. Including asm/mach-types.h is an architecture
> dependency.
I'm *very* surprised that the zero day tester didn't report this -
normally it's much faster at allmodconfigs than anything I have
available to me but it didn't report anything except the usual problem
with s390 not being converted over to genirq.
signature.asc
Description: Digital signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Mon, Jan 14, 2013 at 12:04:00PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the sound-asoc tree, today's linux-next build > (x86_64allmodconfig) failed like this: Applied, thanks. > As an aside, should ak4642_of_match be marked "const"? Probably. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the sound-asoc tree
On Tue, Oct 30, 2012 at 07:46:31AM +1100, Stephen Rothwell wrote: > Then you need to have a different branch being tested by Fenguang and > friends to what you have in linux-next. The stuff that you put into > linux-next has to be at least build tested, so you should delay pushing > it up to your linux-next included branch until after that is done. Which is what I was doing, as I said I had thought I'd pushed up something different to what was actually there. > This case was particularly irritating because you were the developer of > the patch that was broken which indicates that you are not even testing > your own development work before pushing it out for others to work on top > of. I don't treat my own patches any differently to any other patches I push out; in this case the issue was a mistaken fix for a merge issue cherry picking the code out of a working branch into the public branch. With a huge chunk of new device enablement like this it's just not possible to do anything except build testing on the branches in -next, there'll be at least some cross tree issues getting in the way of actually running anything. At that point all the issues with time spent doing build tests apply; as I keep saying I will tend to do some if I have time but it can fall by the wayside and they're not the tests anyone else does. signature.asc Description: Digital signature
Re: linux-next: build failure after merge of the sound-asoc tree
Hi Mark, On Mon, 29 Oct 2012 18:15:34 + Mark Brown wrote: > > Honestly when I'm travelling with the automated build testing Fenguang > and friends are doing it's actually faster to just push things up rather > than doing testing of branches like this locally, their build farm > usually kicks in very close to the time it takes me to do a single fresh > build. Then you need to have a different branch being tested by Fenguang and friends to what you have in linux-next. The stuff that you put into linux-next has to be at least build tested, so you should delay pushing it up to your linux-next included branch until after that is done. This case was particularly irritating because you were the developer of the patch that was broken which indicates that you are not even testing your own development work before pushing it out for others to work on top of. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgphyxonN2Naa.pgp Description: PGP signature
Re: linux-next: build failure after merge of the sound-asoc tree
On Mon, Oct 29, 2012 at 11:48:48AM +1100, Stephen Rothwell wrote:
> Caused by commit 2882fcb3cfe6 ("ASoC: adsp: Add ADSP base support").
> Please build test this stuff - there is a typo in the Makefile. :-(
Actually already fixed, just forgot to push up.
Honestly when I'm travelling with the automated build testing Fenguang
and friends are doing it's actually faster to just push things up rather
than doing testing of branches like this locally, their build farm
usually kicks in very close to the time it takes me to do a single fresh
build.
signature.asc
Description: Digital signature
