Re: [2/5] 2.6.21-rc4: known regressions (v2)

2007-03-26 Thread Tejun Heo
Adrian Bunk wrote:
 Subject: NCQ problem with ahci and Hitachi drive  (ACPI related)
 References : http://lkml.org/lkml/2007/3/4/178
  http://lkml.org/lkml/2007/3/9/475
 Submitter  : Mathieu BĂ©rard [EMAIL PROTECTED]
 Handled-By : Tejun Heo [EMAIL PROTECTED]
 Status : problem is being debugged

Patch is available and whether to put it into mainline or not is being
discussed.  libata EH does the right thing after several errors so
things should work properly after several errors.

http://thread.gmane.org/gmane.linux.kernel/496524

 Subject: libata: PATA UDMA/100 configured as UDMA/33
 References : http://lkml.org/lkml/2007/2/20/294
  
 http://www.mail-archive.com/linux-ide@vger.kernel.org/msg04115.html
  http://bugzilla.kernel.org/show_bug.cgi?id=8133
  http://bugzilla.kernel.org/show_bug.cgi?id=8164
  http://lkml.org/lkml/2007/3/21/330
 Submitter  : Fabio Comolli [EMAIL PROTECTED]
  Plamen Petrov [EMAIL PROTECTED]
  Laurent Riffard [EMAIL PROTECTED]
  Lukas Hejtmanek [EMAIL PROTECTED]
 Handled-By : Tejun Heo [EMAIL PROTECTED]
  Alan Cox [EMAIL PROTECTED]
 Status : Alan: Some cases should be fixed now but probably not all
(eg the Nvidia one)

Further patch submitted.

http://thread.gmane.org/gmane.linux.ide/17444

This should fix all regression cases.  sata_nv has been always broken so
isn't a regression.  It needs acpi tricks and I don't think it fits
2.6.21 cycle.

Thanks.

-- 
tejun
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [2/5] 2.6.21-rc4: known regressions (v2)

2007-03-24 Thread Ray Lee
Thomas Gleixner wrote:
 Patch reproduced below, with an acked-by (and, uhm, a couple of spelling
 fixes in the description -- don't hate me, 'kay?).
 
 I know that my English sucks.

Your English is fantastic, and far better than my German ever will be, so
no worries :-).

~r.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [2/5] 2.6.21-rc4: known regressions (v2)

2007-03-23 Thread Thomas Gleixner
On Fri, 2007-03-23 at 19:48 +0100, Adrian Bunk wrote:
 Subject: x86_64: ACPI regression with noapic  (APICTIMER_STOPS_ON_C3?)
 References : http://lkml.org/lkml/2007/3/8/468
  http://lkml.org/lkml/2007/3/22/156
 Submitter  : Ray Lee [EMAIL PROTECTED]
 Handled-By : Thomas Gleixner [EMAIL PROTECTED]
 Status : problem is being debugged

Ray,

can you please test the patch below ?

Thanks,

tglx

--
Subject: [PATCH] x86_64: avoid sending LOCAL_TIMER_VECTOR IPI to itself

Ray Lee reported, that on an UP kernel with noapic commandline option
set, the box locks hard during boot.

Adding some debug printks revieled, that the last action on the box
before stalling was Send IPI - a debug printk which was put into
smp_send_timer_broadcast_ipi().

It seems that send_IPI_mask(mask, LOCAL_TIMER_VECTOR) fails when
noapic is set on the commandline on an UP kernel.

Aside of that it does not make much sense to trigger an interrupt
instead of calling the function directly on the CPU which gets the
PIT/HPET interrupt in case of broadcasting.

Reported-by: Ray Lee [EMAIL PROTECTED]
Signed-off-by: Thomas Gleixner [EMAIL PROTECTED]

diff --git a/arch/x86_64/kernel/apic.c b/arch/x86_64/kernel/apic.c
index 723417d..83328e1 100644
--- a/arch/x86_64/kernel/apic.c
+++ b/arch/x86_64/kernel/apic.c
@@ -930,9 +930,17 @@ EXPORT_SYMBOL(switch_APIC_timer_to_ipi);
 
 void smp_send_timer_broadcast_ipi(void)
 {
+   int cpu = smp_processor_id();
cpumask_t mask;
 
cpus_and(mask, cpu_online_map, timer_interrupt_broadcast_ipi_mask);
+
+   if (cpu_isset(cpu, mask)) {
+   cpu_clear(cpu, mask);
+   add_pda(apic_timer_irqs, 1);
+   smp_local_timer_interrupt();
+   }
+
if (!cpus_empty(mask)) {
send_IPI_mask(mask, LOCAL_TIMER_VECTOR);
}


-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [2/5] 2.6.21-rc4: known regressions (v2)

2007-03-23 Thread Ray Lee
Thomas Gleixner wrote:
 On Fri, 2007-03-23 at 19:48 +0100, Adrian Bunk wrote:
 Subject: x86_64: ACPI regression with noapic  (APICTIMER_STOPS_ON_C3?)
 References : http://lkml.org/lkml/2007/3/8/468
  http://lkml.org/lkml/2007/3/22/156
 Submitter  : Ray Lee [EMAIL PROTECTED]
 Handled-By : Thomas Gleixner [EMAIL PROTECTED]
 Status : problem is being debugged
 
 Ray,
 
 can you please test the patch below ?
 
 Thanks,
 
   tglx

(I wondered about the IPI on a UP system, seemed a bit weird :-).)

Works great, booting both with NOAPIC and without. *Much* thanks for
debugging this while you're also handling a bunch of other issues at
the same time.

Patch reproduced below, with an acked-by (and, uhm, a couple of spelling
fixes in the description -- don't hate me, 'kay?). Please apply before
2.6.21 final.

--
Subject: [PATCH] x86_64: avoid sending LOCAL_TIMER_VECTOR IPI to itself

Ray Lee reported, that on an UP kernel with noapic command line option
set, the box locks hard during boot.

Adding some debug printks revealed, that the last action on the box
before stalling was Send IPI - a debug printk which was put into
smp_send_timer_broadcast_ipi().

It seems that send_IPI_mask(mask, LOCAL_TIMER_VECTOR) fails when
noapic is set on the command line on an UP kernel.

Aside of that it does not make much sense to trigger an interrupt
instead of calling the function directly on the CPU which gets the
PIT/HPET interrupt in case of broadcasting.

Reported-by: Ray Lee [EMAIL PROTECTED]
Signed-off-by: Thomas Gleixner [EMAIL PROTECTED]
Acked-by:  Ray Lee [EMAIL PROTECTED]

diff --git a/arch/x86_64/kernel/apic.c b/arch/x86_64/kernel/apic.c
index 723417d..83328e1 100644
--- a/arch/x86_64/kernel/apic.c
+++ b/arch/x86_64/kernel/apic.c
@@ -930,9 +930,17 @@ EXPORT_SYMBOL(switch_APIC_timer_to_ipi);

 void smp_send_timer_broadcast_ipi(void)
 {
+   int cpu = smp_processor_id();
cpumask_t mask;

cpus_and(mask, cpu_online_map, timer_interrupt_broadcast_ipi_mask);
+
+   if (cpu_isset(cpu, mask)) {
+   cpu_clear(cpu, mask);
+   add_pda(apic_timer_irqs, 1);
+   smp_local_timer_interrupt();
+   }
+
if (!cpus_empty(mask)) {
send_IPI_mask(mask, LOCAL_TIMER_VECTOR);
}


-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [2/5] 2.6.21-rc4: known regressions (v2)

2007-03-23 Thread Thomas Gleixner
Ray,

On Fri, 2007-03-23 at 17:14 -0700, Ray Lee wrote:
 (I wondered about the IPI on a UP system, seemed a bit weird :-).)
 
 Works great, booting both with NOAPIC and without. *Much* thanks for
 debugging this while you're also handling a bunch of other issues at
 the same time.

Thank you for debugging and excellent problem descriptions !

 Patch reproduced below, with an acked-by (and, uhm, a couple of spelling
 fixes in the description -- don't hate me, 'kay?).

I know that my English sucks.

Thanks,

tglx


-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/