Re: [2.6 patch] include/linux/bio.h: "extern inline" -> "static inline"

2005-07-27 Thread Adrian Bunk
On Wed, Jul 27, 2005 at 10:59:35AM -0400, Kimball Murray wrote: > Jens Axboe wrote: > > >On Tue, Jul 26 2005, Adrian Bunk wrote: > > > > > >>"extern inline" doesn't make much sense. > >> > >> > > > >Yep, thanks. > > > > > > > IIRC, there was a time when the extern inline construct was used

Re: [2.6 patch] include/linux/bio.h: "extern inline" -> "static inline"

2005-07-27 Thread Kimball Murray
Jens Axboe wrote: On Tue, Jul 26 2005, Adrian Bunk wrote: "extern inline" doesn't make much sense. Yep, thanks. IIRC, there was a time when the extern inline construct was used to catch cases where the compiler did not inline the function (you'd get a link error). Seems like

Re: [2.6 patch] include/linux/bio.h: "extern inline" -> "static inline"

2005-07-27 Thread Jens Axboe
On Tue, Jul 26 2005, Adrian Bunk wrote: > "extern inline" doesn't make much sense. Yep, thanks. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [2.6 patch] include/linux/bio.h: "extern inline" -> "static inline"

2005-07-27 Thread Adrian Bunk
On Tue, Jul 26, 2005 at 09:49:02PM -0400, Horst von Brand wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > "extern inline" doesn't make much sense. > > The gcc info here (4.0.1-4 on Fedora rawhide) says it means that the > function should be inlined, and no local copy should be generated >

Re: [2.6 patch] include/linux/bio.h: "extern inline" -> "static inline"

2005-07-27 Thread Horst von Brand
Adrian Bunk <[EMAIL PROTECTED]> wrote: > "extern inline" doesn't make much sense. The gcc info here (4.0.1-4 on Fedora rawhide) says it means that the function should be inlined, and no local copy should be generated ever. This way the build will bomb out when something isn't inlined. It also

Re: [2.6 patch] include/linux/bio.h: extern inline - static inline

2005-07-27 Thread Horst von Brand
Adrian Bunk [EMAIL PROTECTED] wrote: extern inline doesn't make much sense. The gcc info here (4.0.1-4 on Fedora rawhide) says it means that the function should be inlined, and no local copy should be generated ever. This way the build will bomb out when something isn't inlined. It also says

Re: [2.6 patch] include/linux/bio.h: extern inline - static inline

2005-07-27 Thread Adrian Bunk
On Tue, Jul 26, 2005 at 09:49:02PM -0400, Horst von Brand wrote: Adrian Bunk [EMAIL PROTECTED] wrote: extern inline doesn't make much sense. The gcc info here (4.0.1-4 on Fedora rawhide) says it means that the function should be inlined, and no local copy should be generated ever. This way

Re: [2.6 patch] include/linux/bio.h: extern inline - static inline

2005-07-27 Thread Jens Axboe
On Tue, Jul 26 2005, Adrian Bunk wrote: extern inline doesn't make much sense. Yep, thanks. -- Jens Axboe - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [2.6 patch] include/linux/bio.h: extern inline - static inline

2005-07-27 Thread Kimball Murray
Jens Axboe wrote: On Tue, Jul 26 2005, Adrian Bunk wrote: extern inline doesn't make much sense. Yep, thanks. IIRC, there was a time when the extern inline construct was used to catch cases where the compiler did not inline the function (you'd get a link error). Seems like it

Re: [2.6 patch] include/linux/bio.h: extern inline - static inline

2005-07-27 Thread Adrian Bunk
On Wed, Jul 27, 2005 at 10:59:35AM -0400, Kimball Murray wrote: Jens Axboe wrote: On Tue, Jul 26 2005, Adrian Bunk wrote: extern inline doesn't make much sense. Yep, thanks. IIRC, there was a time when the extern inline construct was used to catch cases where the