Re: [Orinoco-devel] Re: [8/14] Orinoco driver updates - PCMCIA initialization cleanups
On Fri, Feb 25, 2005 at 04:03:10PM +1100, David Gibson wrote: > On Thu, Feb 24, 2005 at 02:29:05AM -0500, Jeff Garzik wrote: > > Dominik Brodowski wrote: > > >>@@ -184,6 +186,7 @@ > > >> dev_list = link; > > >> > > >> client_reg.dev_info = _info; > > >>+ client_reg.Attributes = INFO_IO_CLIENT | INFO_CARD_SHARE; > > > > > > > > >That's not needed any longer for 2.6. > > > > So who wants to send the incremental update patch? :) > > Guess I will. See below. > > Any particular reason the field and associated constants haven't been > exunged from the tree, since they're no longer used? To keep external drivers compiling -- it'll be removed soon, though. Dominik - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Orinoco-devel] Re: [8/14] Orinoco driver updates - PCMCIA initialization cleanups
On Thu, Feb 24, 2005 at 02:29:05AM -0500, Jeff Garzik wrote: > Dominik Brodowski wrote: > >>@@ -184,6 +186,7 @@ > >>dev_list = link; > >> > >>client_reg.dev_info = _info; > >>+ client_reg.Attributes = INFO_IO_CLIENT | INFO_CARD_SHARE; > > > > > >That's not needed any longer for 2.6. > > So who wants to send the incremental update patch? :) Guess I will. See below. Any particular reason the field and associated constants haven't been exunged from the tree, since they're no longer used? The client_reg.Attributes field is no longer used. Don't bother setting it. Signed-off-by: David Gibson <[EMAIL PROTECTED]> Index: working-2.6/drivers/net/wireless/orinoco_cs.c === --- working-2.6.orig/drivers/net/wireless/orinoco_cs.c 2005-02-25 15:47:53.098405968 +1100 +++ working-2.6/drivers/net/wireless/orinoco_cs.c 2005-02-25 15:52:56.0 +1100 @@ -186,7 +186,6 @@ dev_list = link; client_reg.dev_info = _info; - client_reg.Attributes = INFO_IO_CLIENT | INFO_CARD_SHARE; client_reg.EventMask = CS_EVENT_CARD_INSERTION | CS_EVENT_CARD_REMOVAL | CS_EVENT_RESET_PHYSICAL | CS_EVENT_CARD_RESET | -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist. NOT _the_ _other_ _way_ | _around_! http://www.ozlabs.org/people/dgibson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Orinoco-devel] Re: [8/14] Orinoco driver updates - PCMCIA initialization cleanups
On Thu, Feb 24, 2005 at 02:29:05AM -0500, Jeff Garzik wrote: Dominik Brodowski wrote: @@ -184,6 +186,7 @@ dev_list = link; client_reg.dev_info = dev_info; + client_reg.Attributes = INFO_IO_CLIENT | INFO_CARD_SHARE; That's not needed any longer for 2.6. So who wants to send the incremental update patch? :) Guess I will. See below. Any particular reason the field and associated constants haven't been exunged from the tree, since they're no longer used? The client_reg.Attributes field is no longer used. Don't bother setting it. Signed-off-by: David Gibson [EMAIL PROTECTED] Index: working-2.6/drivers/net/wireless/orinoco_cs.c === --- working-2.6.orig/drivers/net/wireless/orinoco_cs.c 2005-02-25 15:47:53.098405968 +1100 +++ working-2.6/drivers/net/wireless/orinoco_cs.c 2005-02-25 15:52:56.0 +1100 @@ -186,7 +186,6 @@ dev_list = link; client_reg.dev_info = dev_info; - client_reg.Attributes = INFO_IO_CLIENT | INFO_CARD_SHARE; client_reg.EventMask = CS_EVENT_CARD_INSERTION | CS_EVENT_CARD_REMOVAL | CS_EVENT_RESET_PHYSICAL | CS_EVENT_CARD_RESET | -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist. NOT _the_ _other_ _way_ | _around_! http://www.ozlabs.org/people/dgibson - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Orinoco-devel] Re: [8/14] Orinoco driver updates - PCMCIA initialization cleanups
On Fri, Feb 25, 2005 at 04:03:10PM +1100, David Gibson wrote: On Thu, Feb 24, 2005 at 02:29:05AM -0500, Jeff Garzik wrote: Dominik Brodowski wrote: @@ -184,6 +186,7 @@ dev_list = link; client_reg.dev_info = dev_info; + client_reg.Attributes = INFO_IO_CLIENT | INFO_CARD_SHARE; That's not needed any longer for 2.6. So who wants to send the incremental update patch? :) Guess I will. See below. Any particular reason the field and associated constants haven't been exunged from the tree, since they're no longer used? To keep external drivers compiling -- it'll be removed soon, though. Dominik - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [8/14] Orinoco driver updates - PCMCIA initialization cleanups
Dominik Brodowski wrote: @@ -184,6 +186,7 @@ dev_list = link; client_reg.dev_info = _info; + client_reg.Attributes = INFO_IO_CLIENT | INFO_CARD_SHARE; That's not needed any longer for 2.6. So who wants to send the incremental update patch? :) Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [8/14] Orinoco driver updates - PCMCIA initialization cleanups
> @@ -184,6 +186,7 @@ > dev_list = link; > > client_reg.dev_info = _info; > + client_reg.Attributes = INFO_IO_CLIENT | INFO_CARD_SHARE; That's not needed any longer for 2.6. Dominik - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [8/14] Orinoco driver updates - PCMCIA initialization cleanups
@@ -184,6 +186,7 @@ dev_list = link; client_reg.dev_info = dev_info; + client_reg.Attributes = INFO_IO_CLIENT | INFO_CARD_SHARE; That's not needed any longer for 2.6. Dominik - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [8/14] Orinoco driver updates - PCMCIA initialization cleanups
Dominik Brodowski wrote: @@ -184,6 +186,7 @@ dev_list = link; client_reg.dev_info = dev_info; + client_reg.Attributes = INFO_IO_CLIENT | INFO_CARD_SHARE; That's not needed any longer for 2.6. So who wants to send the incremental update patch? :) Jeff - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
