Re: [BUG] act_ife: sleeping functions called in atomic context

On 16-06-17 01:31 PM, Cong Wang wrote: My patch is against -net. (I see you already figured out your patch is missing in -net-next.) Ok, should have re-read this email before working on the patch;-> Or are you suggesting to rebase it for -net-next? I think it fixes some real bug so -net is

Re: [BUG] act_ife: sleeping functions called in atomic context

On 16-06-17 01:31 PM, Cong Wang wrote: My patch is against -net. (I see you already figured out your patch is missing in -net-next.) Ok, should have re-read this email before working on the patch;-> Or are you suggesting to rebase it for -net-next? I think it fixes some real bug so -net is

Re: [BUG] act_ife: sleeping functions called in atomic context

On Fri, Jun 17, 2016 at 4:07 AM, Jamal Hadi Salim wrote: > On 16-06-17 01:38 AM, Cong Wang wrote: >> >> On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang >> wrote: >>> >>> >>> I think we can just remove that tcf_lock, I am testing a patch now. >> >> >>

Re: [BUG] act_ife: sleeping functions called in atomic context

On Fri, Jun 17, 2016 at 4:07 AM, Jamal Hadi Salim wrote: > On 16-06-17 01:38 AM, Cong Wang wrote: >> >> On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang >> wrote: >>> >>> >>> I think we can just remove that tcf_lock, I am testing a patch now. >> >> >> Please try the attached patch, I will do more

Re: [BUG] act_ife: sleeping functions called in atomic context

On Fri, Jun 17, 2016 at 4:05 AM, Alexey Khoroshilov wrote: > On 17.06.2016 08:38, Cong Wang wrote: >> On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang wrote: >>> >>> I think we can just remove that tcf_lock, I am testing a patch now. >> >> Please try

Re: [BUG] act_ife: sleeping functions called in atomic context

On Fri, Jun 17, 2016 at 4:05 AM, Alexey Khoroshilov wrote: > On 17.06.2016 08:38, Cong Wang wrote: >> On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang wrote: >>> >>> I think we can just remove that tcf_lock, I am testing a patch now. >> >> Please try the attached patch, I will do more tests tomorrow.

Re: [BUG] act_ife: sleeping functions called in atomic context

On 17.06.2016 08:38, Cong Wang wrote: > On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang wrote: >> >> I think we can just remove that tcf_lock, I am testing a patch now. > > Please try the attached patch, I will do more tests tomorrow. > > Thanks! > Looks good with two

Re: [BUG] act_ife: sleeping functions called in atomic context

On 16-06-17 01:38 AM, Cong Wang wrote: On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang wrote: I think we can just remove that tcf_lock, I am testing a patch now. Please try the attached patch, I will do more tests tomorrow. Thanks! Cong, What tree are you using? I

Re: [BUG] act_ife: sleeping functions called in atomic context

On 17.06.2016 08:38, Cong Wang wrote: > On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang wrote: >> >> I think we can just remove that tcf_lock, I am testing a patch now. > > Please try the attached patch, I will do more tests tomorrow. > > Thanks! > Looks good with two notes: 1. add_metainfo()

Re: [BUG] act_ife: sleeping functions called in atomic context

On 16-06-17 01:38 AM, Cong Wang wrote: On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang wrote: I think we can just remove that tcf_lock, I am testing a patch now. Please try the attached patch, I will do more tests tomorrow. Thanks! Cong, What tree are you using? I dont see the time

Re: [BUG] act_ife: sleeping functions called in atomic context

On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang wrote: > > I think we can just remove that tcf_lock, I am testing a patch now. Please try the attached patch, I will do more tests tomorrow. Thanks! diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c index 658046d..859fb02

Re: [BUG] act_ife: sleeping functions called in atomic context

On Thu, Jun 16, 2016 at 7:14 PM, Cong Wang wrote: > > I think we can just remove that tcf_lock, I am testing a patch now. Please try the attached patch, I will do more tests tomorrow. Thanks! diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c index 658046d..859fb02 100644 ---

Re: [BUG] act_ife: sleeping functions called in atomic context

On Thu, Jun 16, 2016 at 5:38 PM, Jamal Hadi Salim wrote: > On 16-06-16 05:43 PM, Cong Wang wrote: >> >> On Thu, Jun 16, 2016 at 1:50 PM, Alexey Khoroshilov >> wrote: >>> >>> tcf_ife_init() contains a big chunk of code executed with >>> ife->tcf_lock

Re: [BUG] act_ife: sleeping functions called in atomic context

On Thu, Jun 16, 2016 at 5:38 PM, Jamal Hadi Salim wrote: > On 16-06-16 05:43 PM, Cong Wang wrote: >> >> On Thu, Jun 16, 2016 at 1:50 PM, Alexey Khoroshilov >> wrote: >>> >>> tcf_ife_init() contains a big chunk of code executed with >>> ife->tcf_lock spinlock held. But that code contains several

Re: [BUG] act_ife: sleeping functions called in atomic context

On 16-06-16 05:43 PM, Cong Wang wrote: On Thu, Jun 16, 2016 at 1:50 PM, Alexey Khoroshilov wrote: tcf_ife_init() contains a big chunk of code executed with ife->tcf_lock spinlock held. But that code contains several calls to sleeping functions: populate_metalist() and

Re: [BUG] act_ife: sleeping functions called in atomic context

On 16-06-16 05:43 PM, Cong Wang wrote: On Thu, Jun 16, 2016 at 1:50 PM, Alexey Khoroshilov wrote: tcf_ife_init() contains a big chunk of code executed with ife->tcf_lock spinlock held. But that code contains several calls to sleeping functions: populate_metalist() and use_all_metadata()

Re: [BUG] act_ife: sleeping functions called in atomic context

On Thu, Jun 16, 2016 at 1:50 PM, Alexey Khoroshilov wrote: > tcf_ife_init() contains a big chunk of code executed with > ife->tcf_lock spinlock held. But that code contains several calls > to sleeping functions: > populate_metalist() and use_all_metadata() > ->

Re: [BUG] act_ife: sleeping functions called in atomic context

On Thu, Jun 16, 2016 at 1:50 PM, Alexey Khoroshilov wrote: > tcf_ife_init() contains a big chunk of code executed with > ife->tcf_lock spinlock held. But that code contains several calls > to sleeping functions: > populate_metalist() and use_all_metadata() > -> add_metainfo() > ->