Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-13 Thread Paul E. McKenney
On Wed, Jun 13, 2018 at 11:42:51AM +1000, NeilBrown wrote: > On Tue, Jun 12 2018, Paul E. McKenney wrote: > > > On Tue, Jun 12, 2018 at 06:11:50PM -0700, Linus Torvalds wrote: > >> On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney > >> wrote: > >> > > >> > We did review this one, and Neil did

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-13 Thread Paul E. McKenney
On Wed, Jun 13, 2018 at 11:42:51AM +1000, NeilBrown wrote: > On Tue, Jun 12 2018, Paul E. McKenney wrote: > > > On Tue, Jun 12, 2018 at 06:11:50PM -0700, Linus Torvalds wrote: > >> On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney > >> wrote: > >> > > >> > We did review this one, and Neil did

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread NeilBrown
On Tue, Jun 12 2018, Paul E. McKenney wrote: > On Tue, Jun 12, 2018 at 06:11:50PM -0700, Linus Torvalds wrote: >> On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney >> wrote: >> > >> > We did review this one, and Neil did make requested changes to the comment >> > header and documentation. >> >>

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread NeilBrown
On Tue, Jun 12 2018, Paul E. McKenney wrote: > On Tue, Jun 12, 2018 at 06:11:50PM -0700, Linus Torvalds wrote: >> On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney >> wrote: >> > >> > We did review this one, and Neil did make requested changes to the comment >> > header and documentation. >> >>

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Paul E. McKenney
On Tue, Jun 12, 2018 at 06:11:50PM -0700, Linus Torvalds wrote: > On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney > wrote: > > > > We did review this one, and Neil did make requested changes to the comment > > header and documentation. > > Oh, I checked the commit for "acked-by" from you and

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Paul E. McKenney
On Tue, Jun 12, 2018 at 06:11:50PM -0700, Linus Torvalds wrote: > On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney > wrote: > > > > We did review this one, and Neil did make requested changes to the comment > > header and documentation. > > Oh, I checked the commit for "acked-by" from you and

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney wrote: > > We did review this one, and Neil did make requested changes to the comment > header and documentation. Oh, I checked the commit for "acked-by" from you and didn't see any, so I was assuming this was just Neil and Trond on their own..

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney wrote: > > We did review this one, and Neil did make requested changes to the comment > header and documentation. Oh, I checked the commit for "acked-by" from you and didn't see any, so I was assuming this was just Neil and Trond on their own..

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Paul E. McKenney
On Tue, Jun 12, 2018 at 11:08:31AM -0700, Linus Torvalds wrote: > Final note (for now) on this: I've merged the nfs code, but I really > am obviously not happy with these crazy random ad-hoc > cursor-not-cursor list games. We did review this one, and Neil did make requested changes to the comment

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Paul E. McKenney
On Tue, Jun 12, 2018 at 11:08:31AM -0700, Linus Torvalds wrote: > Final note (for now) on this: I've merged the nfs code, but I really > am obviously not happy with these crazy random ad-hoc > cursor-not-cursor list games. We did review this one, and Neil did make requested changes to the comment

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread NeilBrown
On Tue, Jun 12 2018, Linus Torvalds wrote: > Final note (for now) on this: I've merged the nfs code, but I really > am obviously not happy with these crazy random ad-hoc > cursor-not-cursor list games. > > Linus Hi Linus, thanks for merging the code despite your reservations.

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread NeilBrown
On Tue, Jun 12 2018, Linus Torvalds wrote: > Final note (for now) on this: I've merged the nfs code, but I really > am obviously not happy with these crazy random ad-hoc > cursor-not-cursor list games. > > Linus Hi Linus, thanks for merging the code despite your reservations.

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Linus Torvalds
Final note (for now) on this: I've merged the nfs code, but I really am obviously not happy with these crazy random ad-hoc cursor-not-cursor list games. Linus

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Linus Torvalds
Final note (for now) on this: I've merged the nfs code, but I really am obviously not happy with these crazy random ad-hoc cursor-not-cursor list games. Linus

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 10:42 AM Linus Torvalds wrote: > > So could we please have a cursor entry for RCU walking, and actually > have a agreed-upon way to do this? Maybe even using the low bit in the > "next" field to mark a cursor entry generically - the same way we > already do for the HEAD

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 10:42 AM Linus Torvalds wrote: > > So could we please have a cursor entry for RCU walking, and actually > have a agreed-upon way to do this? Maybe even using the low bit in the > "next" field to mark a cursor entry generically - the same way we > already do for the HEAD

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 6:39 AM Trond Myklebust wrote: > > NeilBrown (4): > rculist: add list_for_each_entry_from_rcu() Oh christ, people. Not another one of these. We need to start having a real rule in place where people DO NOT PLAY GAMES WITH RCU LISTS. Adding Paul McKenney to the

Re: [GIT PULL] Please pull NFS client changes for 4.18

2018-06-12 Thread Linus Torvalds
On Tue, Jun 12, 2018 at 6:39 AM Trond Myklebust wrote: > > NeilBrown (4): > rculist: add list_for_each_entry_from_rcu() Oh christ, people. Not another one of these. We need to start having a real rule in place where people DO NOT PLAY GAMES WITH RCU LISTS. Adding Paul McKenney to the