Re: [Linux-nvdimm] [PATCH 03/21] nd_acpi: initial core implementation and nfit skeleton
On Tue, Apr 28, 2015 at 5:53 AM, Christoph Hellwig wrote: > On Fri, Apr 17, 2015 at 09:35:30PM -0400, Dan Williams wrote: >> new file mode 100644 >> index ..5fa74f124b3e >> --- /dev/null >> +++ b/drivers/block/nd/Kconfig >> @@ -0,0 +1,44 @@ >> +config ND_ARCH_HAS_IOREMAP_CACHE >> + depends on (X86 || IA64 || ARM || ARM64 || SH || XTENSA) >> + def_bool y > > As mentioned before please either define this symbol in each > arch Kconfig, or just ensure every architecture proides a stub. > > But more importantly it doesn't seem like you're actually using > ioremap_cache anywhere. Allowing a cached ioremap would be a very > worthwile addition to the pmem drivers once we have the proper > memcpy functions making it safe, and is one of the high priority > todo items for the pmem driver. > >> + >> +menuconfig NFIT_DEVICES >> + bool "NVDIMM (NFIT) Support" > > Please just call all the symbolc and file names nvdimm instead of nfit > or nd to make eryones life simpler for the generic code. Just use the > EFI/ACPI terminology in those parts that actually parse those tables. Done in v2. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Linux-nvdimm] [PATCH 03/21] nd_acpi: initial core implementation and nfit skeleton
On Fri, Apr 17, 2015 at 09:35:30PM -0400, Dan Williams wrote: > new file mode 100644 > index ..5fa74f124b3e > --- /dev/null > +++ b/drivers/block/nd/Kconfig > @@ -0,0 +1,44 @@ > +config ND_ARCH_HAS_IOREMAP_CACHE > + depends on (X86 || IA64 || ARM || ARM64 || SH || XTENSA) > + def_bool y As mentioned before please either define this symbol in each arch Kconfig, or just ensure every architecture proides a stub. But more importantly it doesn't seem like you're actually using ioremap_cache anywhere. Allowing a cached ioremap would be a very worthwile addition to the pmem drivers once we have the proper memcpy functions making it safe, and is one of the high priority todo items for the pmem driver. > + > +menuconfig NFIT_DEVICES > + bool "NVDIMM (NFIT) Support" Please just call all the symbolc and file names nvdimm instead of nfit or nd to make eryones life simpler for the generic code. Just use the EFI/ACPI terminology in those parts that actually parse those tables. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Linux-nvdimm] [PATCH 03/21] nd_acpi: initial core implementation and nfit skeleton
On Fri, Apr 17, 2015 at 09:35:30PM -0400, Dan Williams wrote: new file mode 100644 index ..5fa74f124b3e --- /dev/null +++ b/drivers/block/nd/Kconfig @@ -0,0 +1,44 @@ +config ND_ARCH_HAS_IOREMAP_CACHE + depends on (X86 || IA64 || ARM || ARM64 || SH || XTENSA) + def_bool y As mentioned before please either define this symbol in each arch Kconfig, or just ensure every architecture proides a stub. But more importantly it doesn't seem like you're actually using ioremap_cache anywhere. Allowing a cached ioremap would be a very worthwile addition to the pmem drivers once we have the proper memcpy functions making it safe, and is one of the high priority todo items for the pmem driver. + +menuconfig NFIT_DEVICES + bool NVDIMM (NFIT) Support Please just call all the symbolc and file names nvdimm instead of nfit or nd to make eryones life simpler for the generic code. Just use the EFI/ACPI terminology in those parts that actually parse those tables. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Linux-nvdimm] [PATCH 03/21] nd_acpi: initial core implementation and nfit skeleton
On Tue, Apr 28, 2015 at 5:53 AM, Christoph Hellwig h...@infradead.org wrote: On Fri, Apr 17, 2015 at 09:35:30PM -0400, Dan Williams wrote: new file mode 100644 index ..5fa74f124b3e --- /dev/null +++ b/drivers/block/nd/Kconfig @@ -0,0 +1,44 @@ +config ND_ARCH_HAS_IOREMAP_CACHE + depends on (X86 || IA64 || ARM || ARM64 || SH || XTENSA) + def_bool y As mentioned before please either define this symbol in each arch Kconfig, or just ensure every architecture proides a stub. But more importantly it doesn't seem like you're actually using ioremap_cache anywhere. Allowing a cached ioremap would be a very worthwile addition to the pmem drivers once we have the proper memcpy functions making it safe, and is one of the high priority todo items for the pmem driver. + +menuconfig NFIT_DEVICES + bool NVDIMM (NFIT) Support Please just call all the symbolc and file names nvdimm instead of nfit or nd to make eryones life simpler for the generic code. Just use the EFI/ACPI terminology in those parts that actually parse those tables. Done in v2. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
