Re: [Linux-nvdimm] [PATCH 05/21] nfit-test: manufactured NFITs for interface development

2015-04-28 Thread Dan Williams
On Tue, Apr 28, 2015 at 5:54 AM, Christoph Hellwig wrote: > Eww, the --wrap stuff is too ugly too live. Since when are unit tests pretty? > Just implement the > implemenetation of persistent nvdimms into qemu where it belongs. Ugh, no, I'm not keen to introduce yet another roadblock to running

Re: [Linux-nvdimm] [PATCH 05/21] nfit-test: manufactured NFITs for interface development

2015-04-28 Thread Christoph Hellwig
Eww, the --wrap stuff is too ugly too live. Just implement the implemenetation of persistent nvdimms into qemu where it belongs. Note that having a not actually persistent implementation that register with the subsystems which doesn't need these hacks still sounds ok to me, altough I suspect

Re: [Linux-nvdimm] [PATCH 05/21] nfit-test: manufactured NFITs for interface development

2015-04-28 Thread Christoph Hellwig
Eww, the --wrap stuff is too ugly too live. Just implement the implemenetation of persistent nvdimms into qemu where it belongs. Note that having a not actually persistent implementation that register with the subsystems which doesn't need these hacks still sounds ok to me, altough I suspect

Re: [Linux-nvdimm] [PATCH 05/21] nfit-test: manufactured NFITs for interface development

2015-04-28 Thread Dan Williams
On Tue, Apr 28, 2015 at 5:54 AM, Christoph Hellwig h...@infradead.org wrote: Eww, the --wrap stuff is too ugly too live. Since when are unit tests pretty? Just implement the implemenetation of persistent nvdimms into qemu where it belongs. Ugh, no, I'm not keen to introduce yet another

Re: [Linux-nvdimm] [PATCH 05/21] nfit-test: manufactured NFITs for interface development

2015-04-24 Thread Dan Williams
On Fri, Apr 24, 2015 at 2:59 PM, Linda Knippers wrote: > On 4/24/2015 5:50 PM, Dan Williams wrote: >> On Fri, Apr 24, 2015 at 2:47 PM, Linda Knippers >> wrote: >>> On 4/17/2015 9:35 PM, Dan Williams wrote: >>> : diff --git a/drivers/block/nd/Kconfig b/drivers/block/nd/Kconfig index

Re: [Linux-nvdimm] [PATCH 05/21] nfit-test: manufactured NFITs for interface development

2015-04-24 Thread Linda Knippers
On 4/24/2015 5:50 PM, Dan Williams wrote: > On Fri, Apr 24, 2015 at 2:47 PM, Linda Knippers wrote: >> On 4/17/2015 9:35 PM, Dan Williams wrote: >> : >>> diff --git a/drivers/block/nd/Kconfig b/drivers/block/nd/Kconfig >>> index 5fa74f124b3e..0106b3807202 100644 >>> --- a/drivers/block/nd/Kconfig

Re: [Linux-nvdimm] [PATCH 05/21] nfit-test: manufactured NFITs for interface development

2015-04-24 Thread Dan Williams
On Fri, Apr 24, 2015 at 2:47 PM, Linda Knippers wrote: > On 4/17/2015 9:35 PM, Dan Williams wrote: > : >> diff --git a/drivers/block/nd/Kconfig b/drivers/block/nd/Kconfig >> index 5fa74f124b3e..0106b3807202 100644 >> --- a/drivers/block/nd/Kconfig >> +++ b/drivers/block/nd/Kconfig >> @@ -41,4

Re: [Linux-nvdimm] [PATCH 05/21] nfit-test: manufactured NFITs for interface development

2015-04-24 Thread Linda Knippers
On 4/17/2015 9:35 PM, Dan Williams wrote: : > diff --git a/drivers/block/nd/Kconfig b/drivers/block/nd/Kconfig > index 5fa74f124b3e..0106b3807202 100644 > --- a/drivers/block/nd/Kconfig > +++ b/drivers/block/nd/Kconfig > @@ -41,4 +41,24 @@ config NFIT_ACPI > register the platform-global

Re: [Linux-nvdimm] [PATCH 05/21] nfit-test: manufactured NFITs for interface development

2015-04-24 Thread Dan Williams
On Fri, Apr 24, 2015 at 2:59 PM, Linda Knippers linda.knipp...@hp.com wrote: On 4/24/2015 5:50 PM, Dan Williams wrote: On Fri, Apr 24, 2015 at 2:47 PM, Linda Knippers linda.knipp...@hp.com wrote: On 4/17/2015 9:35 PM, Dan Williams wrote: : diff --git a/drivers/block/nd/Kconfig

Re: [Linux-nvdimm] [PATCH 05/21] nfit-test: manufactured NFITs for interface development

2015-04-24 Thread Linda Knippers
On 4/17/2015 9:35 PM, Dan Williams wrote: : diff --git a/drivers/block/nd/Kconfig b/drivers/block/nd/Kconfig index 5fa74f124b3e..0106b3807202 100644 --- a/drivers/block/nd/Kconfig +++ b/drivers/block/nd/Kconfig @@ -41,4 +41,24 @@ config NFIT_ACPI register the platform-global NFIT

Re: [Linux-nvdimm] [PATCH 05/21] nfit-test: manufactured NFITs for interface development

2015-04-24 Thread Dan Williams
On Fri, Apr 24, 2015 at 2:47 PM, Linda Knippers linda.knipp...@hp.com wrote: On 4/17/2015 9:35 PM, Dan Williams wrote: : diff --git a/drivers/block/nd/Kconfig b/drivers/block/nd/Kconfig index 5fa74f124b3e..0106b3807202 100644 --- a/drivers/block/nd/Kconfig +++ b/drivers/block/nd/Kconfig @@

Re: [Linux-nvdimm] [PATCH 05/21] nfit-test: manufactured NFITs for interface development

2015-04-24 Thread Linda Knippers
On 4/24/2015 5:50 PM, Dan Williams wrote: On Fri, Apr 24, 2015 at 2:47 PM, Linda Knippers linda.knipp...@hp.com wrote: On 4/17/2015 9:35 PM, Dan Williams wrote: : diff --git a/drivers/block/nd/Kconfig b/drivers/block/nd/Kconfig index 5fa74f124b3e..0106b3807202 100644 ---