Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-16 Thread Changwei Ge
It looks good to me. Reviewed-by: Changwei Ge On 2017/12/14 13:16, Gang He wrote: > As you know, ocfs2 has support trim the underlying disk via > fstrim command. But there is a problem, ocfs2 is a shared disk > cluster file system, if the user configures a scheduled fstrim

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-16 Thread Changwei Ge
It looks good to me. Reviewed-by: Changwei Ge On 2017/12/14 13:16, Gang He wrote: > As you know, ocfs2 has support trim the underlying disk via > fstrim command. But there is a problem, ocfs2 is a shared disk > cluster file system, if the user configures a scheduled fstrim > job on each file

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-11 Thread Changwei Ge
On 2018/1/11 15:57, Gang He wrote: > > > >> On 2018/1/11 15:19, Gang He wrote: >>> >>> >>> >> On 2018/1/11 12:31, Gang He wrote: > Hi Changwei, > > >> On 2018/1/11 11:33, Gang He wrote: >>> Hi Changwei, >>> >>> >> On 2018/1/11

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-11 Thread Changwei Ge
On 2018/1/11 15:57, Gang He wrote: > > > >> On 2018/1/11 15:19, Gang He wrote: >>> >>> >>> >> On 2018/1/11 12:31, Gang He wrote: > Hi Changwei, > > >> On 2018/1/11 11:33, Gang He wrote: >>> Hi Changwei, >>> >>> >> On 2018/1/11

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
>>> > On 2018/1/11 15:19, Gang He wrote: >> >> >> > >>> On 2018/1/11 12:31, Gang He wrote: Hi Changwei, >>> > On 2018/1/11 11:33, Gang He wrote: >> Hi Changwei, >> >> > >>> On 2018/1/11 10:07, Gang He wrote: Hi Changwei,

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
>>> > On 2018/1/11 15:19, Gang He wrote: >> >> >> > >>> On 2018/1/11 12:31, Gang He wrote: Hi Changwei, >>> > On 2018/1/11 11:33, Gang He wrote: >> Hi Changwei, >> >> > >>> On 2018/1/11 10:07, Gang He wrote: Hi Changwei,

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Changwei Ge
On 2018/1/11 15:19, Gang He wrote: > > > >> On 2018/1/11 12:31, Gang He wrote: >>> Hi Changwei, >>> >>> >> On 2018/1/11 11:33, Gang He wrote: > Hi Changwei, > > >> On 2018/1/11 10:07, Gang He wrote: >>> Hi Changwei, >>> >>> >>

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Changwei Ge
On 2018/1/11 15:19, Gang He wrote: > > > >> On 2018/1/11 12:31, Gang He wrote: >>> Hi Changwei, >>> >>> >> On 2018/1/11 11:33, Gang He wrote: > Hi Changwei, > > >> On 2018/1/11 10:07, Gang He wrote: >>> Hi Changwei, >>> >>> >>

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
>>> > On 2018/1/11 12:31, Gang He wrote: >> Hi Changwei, >> >> > >>> On 2018/1/11 11:33, Gang He wrote: Hi Changwei, >>> > On 2018/1/11 10:07, Gang He wrote: >> Hi Changwei, >> >> > >>> On 2018/1/10 18:14, Gang He wrote: Hi

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
>>> > On 2018/1/11 12:31, Gang He wrote: >> Hi Changwei, >> >> > >>> On 2018/1/11 11:33, Gang He wrote: Hi Changwei, >>> > On 2018/1/11 10:07, Gang He wrote: >> Hi Changwei, >> >> > >>> On 2018/1/10 18:14, Gang He wrote: Hi

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Changwei Ge
On 2018/1/11 12:31, Gang He wrote: > Hi Changwei, > > >> On 2018/1/11 11:33, Gang He wrote: >>> Hi Changwei, >>> >>> >> On 2018/1/11 10:07, Gang He wrote: > Hi Changwei, > > >> On 2018/1/10 18:14, Gang He wrote: >>> Hi Changwei, >>> >>>

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Changwei Ge
On 2018/1/11 12:31, Gang He wrote: > Hi Changwei, > > >> On 2018/1/11 11:33, Gang He wrote: >>> Hi Changwei, >>> >>> >> On 2018/1/11 10:07, Gang He wrote: > Hi Changwei, > > >> On 2018/1/10 18:14, Gang He wrote: >>> Hi Changwei, >>> >>>

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
Hi Changwei, >>> > On 2018/1/11 11:33, Gang He wrote: >> Hi Changwei, >> >> > >>> On 2018/1/11 10:07, Gang He wrote: Hi Changwei, >>> > On 2018/1/10 18:14, Gang He wrote: >> Hi Changwei, >> >> > >>> On 2018/1/10 17:05, Gang He wrote:

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
Hi Changwei, >>> > On 2018/1/11 11:33, Gang He wrote: >> Hi Changwei, >> >> > >>> On 2018/1/11 10:07, Gang He wrote: Hi Changwei, >>> > On 2018/1/10 18:14, Gang He wrote: >> Hi Changwei, >> >> > >>> On 2018/1/10 17:05, Gang He wrote:

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Changwei Ge
On 2018/1/11 11:33, Gang He wrote: > Hi Changwei, > > >> On 2018/1/11 10:07, Gang He wrote: >>> Hi Changwei, >>> >>> >> On 2018/1/10 18:14, Gang He wrote: > Hi Changwei, > > >> On 2018/1/10 17:05, Gang He wrote: >>> Hi Changwei, >>> >>>

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Changwei Ge
On 2018/1/11 11:33, Gang He wrote: > Hi Changwei, > > >> On 2018/1/11 10:07, Gang He wrote: >>> Hi Changwei, >>> >>> >> On 2018/1/10 18:14, Gang He wrote: > Hi Changwei, > > >> On 2018/1/10 17:05, Gang He wrote: >>> Hi Changwei, >>> >>>

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
Hi Changwei, >>> > On 2018/1/11 10:07, Gang He wrote: >> Hi Changwei, >> >> > >>> On 2018/1/10 18:14, Gang He wrote: Hi Changwei, >>> > On 2018/1/10 17:05, Gang He wrote: >> Hi Changwei, >> >> > >>> Hi Gang, >>> >>> On 2017/12/14

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
Hi Changwei, >>> > On 2018/1/11 10:07, Gang He wrote: >> Hi Changwei, >> >> > >>> On 2018/1/10 18:14, Gang He wrote: Hi Changwei, >>> > On 2018/1/10 17:05, Gang He wrote: >> Hi Changwei, >> >> > >>> Hi Gang, >>> >>> On 2017/12/14

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Changwei Ge
On 2018/1/11 10:07, Gang He wrote: > Hi Changwei, > > >> On 2018/1/10 18:14, Gang He wrote: >>> Hi Changwei, >>> >>> >> On 2018/1/10 17:05, Gang He wrote: > Hi Changwei, > > >> Hi Gang, >> >> On 2017/12/14 13:16, Gang He wrote: >>> As you know,

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Changwei Ge
On 2018/1/11 10:07, Gang He wrote: > Hi Changwei, > > >> On 2018/1/10 18:14, Gang He wrote: >>> Hi Changwei, >>> >>> >> On 2018/1/10 17:05, Gang He wrote: > Hi Changwei, > > >> Hi Gang, >> >> On 2017/12/14 13:16, Gang He wrote: >>> As you know,

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
Hi Changwei, >>> > On 2018/1/10 18:14, Gang He wrote: >> Hi Changwei, >> >> > >>> On 2018/1/10 17:05, Gang He wrote: Hi Changwei, >>> > Hi Gang, > > On 2017/12/14 13:16, Gang He wrote: >> As you know, ocfs2 has support trim the underlying disk via >>

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
Hi Changwei, >>> > On 2018/1/10 18:14, Gang He wrote: >> Hi Changwei, >> >> > >>> On 2018/1/10 17:05, Gang He wrote: Hi Changwei, >>> > Hi Gang, > > On 2017/12/14 13:16, Gang He wrote: >> As you know, ocfs2 has support trim the underlying disk via >>

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Changwei Ge
On 2018/1/10 18:14, Gang He wrote: > Hi Changwei, > > >> On 2018/1/10 17:05, Gang He wrote: >>> Hi Changwei, >>> >>> >> Hi Gang, On 2017/12/14 13:16, Gang He wrote: > As you know, ocfs2 has support trim the underlying disk via > fstrim command. But there is a

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Changwei Ge
On 2018/1/10 18:14, Gang He wrote: > Hi Changwei, > > >> On 2018/1/10 17:05, Gang He wrote: >>> Hi Changwei, >>> >>> >> Hi Gang, On 2017/12/14 13:16, Gang He wrote: > As you know, ocfs2 has support trim the underlying disk via > fstrim command. But there is a

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Changwei Ge
Hi Gang, On 2018/1/10 18:14, Gang He wrote: > Hi Changwei, > > >> On 2018/1/10 17:05, Gang He wrote: >>> Hi Changwei, >>> >>> >> Hi Gang, On 2017/12/14 13:16, Gang He wrote: > As you know, ocfs2 has support trim the underlying disk via > fstrim command. But there

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Changwei Ge
Hi Gang, On 2018/1/10 18:14, Gang He wrote: > Hi Changwei, > > >> On 2018/1/10 17:05, Gang He wrote: >>> Hi Changwei, >>> >>> >> Hi Gang, On 2017/12/14 13:16, Gang He wrote: > As you know, ocfs2 has support trim the underlying disk via > fstrim command. But there

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
Hi Changwei, >>> > On 2018/1/10 17:05, Gang He wrote: >> Hi Changwei, >> >> > >>> Hi Gang, >>> >>> On 2017/12/14 13:16, Gang He wrote: As you know, ocfs2 has support trim the underlying disk via fstrim command. But there is a problem, ocfs2 is a shared disk cluster file

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
Hi Changwei, >>> > On 2018/1/10 17:05, Gang He wrote: >> Hi Changwei, >> >> > >>> Hi Gang, >>> >>> On 2017/12/14 13:16, Gang He wrote: As you know, ocfs2 has support trim the underlying disk via fstrim command. But there is a problem, ocfs2 is a shared disk cluster file

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Changwei Ge
On 2018/1/4 10:09, Gang He wrote: > Hi Alex, > > >> Hi Gang, >> >> On 2017/12/14 13:14, Gang He wrote: >>> As you know, ocfs2 has support trim the underlying disk via >>> fstrim command. But there is a problem, ocfs2 is a shared disk >>> cluster file system, if the user configures a

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Changwei Ge
On 2018/1/4 10:09, Gang He wrote: > Hi Alex, > > >> Hi Gang, >> >> On 2017/12/14 13:14, Gang He wrote: >>> As you know, ocfs2 has support trim the underlying disk via >>> fstrim command. But there is a problem, ocfs2 is a shared disk >>> cluster file system, if the user configures a

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Changwei Ge
On 2018/1/10 17:05, Gang He wrote: > Hi Changwei, > > >> Hi Gang, >> >> On 2017/12/14 13:16, Gang He wrote: >>> As you know, ocfs2 has support trim the underlying disk via >>> fstrim command. But there is a problem, ocfs2 is a shared disk >>> cluster file system, if the user configures a

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Changwei Ge
On 2018/1/10 17:05, Gang He wrote: > Hi Changwei, > > >> Hi Gang, >> >> On 2017/12/14 13:16, Gang He wrote: >>> As you know, ocfs2 has support trim the underlying disk via >>> fstrim command. But there is a problem, ocfs2 is a shared disk >>> cluster file system, if the user configures a

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
Hi Changwei, >>> > Hi Gang, > > On 2017/12/14 13:16, Gang He wrote: >> As you know, ocfs2 has support trim the underlying disk via >> fstrim command. But there is a problem, ocfs2 is a shared disk >> cluster file system, if the user configures a scheduled fstrim >> job on each file system

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-10 Thread Gang He
Hi Changwei, >>> > Hi Gang, > > On 2017/12/14 13:16, Gang He wrote: >> As you know, ocfs2 has support trim the underlying disk via >> fstrim command. But there is a problem, ocfs2 is a shared disk >> cluster file system, if the user configures a scheduled fstrim >> job on each file system

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-09 Thread Changwei Ge
Hi Gang, On 2017/12/14 13:16, Gang He wrote: > As you know, ocfs2 has support trim the underlying disk via > fstrim command. But there is a problem, ocfs2 is a shared disk > cluster file system, if the user configures a scheduled fstrim > job on each file system node, this will trigger multiple

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-09 Thread Changwei Ge
Hi Gang, On 2017/12/14 13:16, Gang He wrote: > As you know, ocfs2 has support trim the underlying disk via > fstrim command. But there is a problem, ocfs2 is a shared disk > cluster file system, if the user configures a scheduled fstrim > job on each file system node, this will trigger multiple

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-03 Thread Gang He
Hi Alex, >>> > Hi Gang, > > On 2017/12/14 13:14, Gang He wrote: >> As you know, ocfs2 has support trim the underlying disk via >> fstrim command. But there is a problem, ocfs2 is a shared disk >> cluster file system, if the user configures a scheduled fstrim >> job on each file system node,

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-03 Thread Gang He
Hi Alex, >>> > Hi Gang, > > On 2017/12/14 13:14, Gang He wrote: >> As you know, ocfs2 has support trim the underlying disk via >> fstrim command. But there is a problem, ocfs2 is a shared disk >> cluster file system, if the user configures a scheduled fstrim >> job on each file system node,

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-03 Thread alex chen
Hi Gang, On 2017/12/14 13:14, Gang He wrote: > As you know, ocfs2 has support trim the underlying disk via > fstrim command. But there is a problem, ocfs2 is a shared disk > cluster file system, if the user configures a scheduled fstrim > job on each file system node, this will trigger multiple

Re: [Ocfs2-devel] [PATCH v2 2/2] ocfs2: add trimfs lock to avoid duplicated trims in cluster

2018-01-03 Thread alex chen
Hi Gang, On 2017/12/14 13:14, Gang He wrote: > As you know, ocfs2 has support trim the underlying disk via > fstrim command. But there is a problem, ocfs2 is a shared disk > cluster file system, if the user configures a scheduled fstrim > job on each file system node, this will trigger multiple