Re: [Outreachy kernel] [PATCH 1/5] staging: octeon: remove typedef declaration for cvmx_wqe_t

2019-10-11 Thread Dan Carpenter
On Fri, Oct 11, 2019 at 11:59:52AM +0300, Wambui Karuga wrote: > On Fri, Oct 11, 2019 at 08:18:25AM +0200, Julia Lawall wrote: > > > > > > On Fri, 11 Oct 2019, Wambui Karuga wrote: > > > > > Remove typedef declaration from struct cvmx_wqe_t in > > > > You can remove the _t from the name as well

Re: [Outreachy kernel] [PATCH 1/5] staging: octeon: remove typedef declaration for cvmx_wqe_t

2019-10-11 Thread Wambui Karuga
On Fri, Oct 11, 2019 at 08:18:25AM +0200, Julia Lawall wrote: > > > On Fri, 11 Oct 2019, Wambui Karuga wrote: > > > Remove typedef declaration from struct cvmx_wqe_t in > > You can remove the _t from the name as well. Should I remove the _t from all the enums/structs? > > > drivers/staging/oct

Re: [Outreachy kernel] [PATCH 1/5] staging: octeon: remove typedef declaration for cvmx_wqe_t

2019-10-10 Thread Julia Lawall
On Fri, 11 Oct 2019, Wambui Karuga wrote: > Remove typedef declaration from struct cvmx_wqe_t in You can remove the _t from the name as well. > drivers/staging/octeon/octeon-stubs.h. It's not really necessary to give the name of the file in the log message, as it can easily be seen below. j