Re: [Outreachy kernel] [PATCH v7 1/3] staging: rtl8723bs: Remove camelcase in several files
On Sat, Apr 10, 2021 at 11:45:18AM +0200, Fabio M. De Francesco wrote: > On Saturday, April 10, 2021 11:32:00 AM CEST Greg KH wrote: > > On Sat, Apr 10, 2021 at 11:22:29AM +0200, Fabio M. De Francesco wrote: > > > Remove camelcase in bFwCurrentInPSMode, a variable used by code > > > of several subdirectories/files of the driver. Issue detected by > > > checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from > > > the beginning of the name. > > > > > > Signed-off-by: Fabio M. De Francesco > > > --- > > > > Why is there a "v7" in this subject line, but not all the other lines? > > > > It's v7 because only this file (and not the others in the series had six > previous versions that you dropped. Please remind that it was already sent > alone (not in a series) several times. The changelog is in the body. > > Should I drop that "v7" and the changelog, and the send the patch series > anew? It's a v2 series now, right? :) > Please, I'm waiting your instructions on what to do. Don't "wait" for anyone, least of all me. Do what you think is needed, after waiting a bit of time, there's no rush here... thanks, greg k-h
Re: [Outreachy kernel] [PATCH v7 1/3] staging: rtl8723bs: Remove camelcase in several files
On Saturday, April 10, 2021 11:32:00 AM CEST Greg KH wrote: > On Sat, Apr 10, 2021 at 11:22:29AM +0200, Fabio M. De Francesco wrote: > > Remove camelcase in bFwCurrentInPSMode, a variable used by code > > of several subdirectories/files of the driver. Issue detected by > > checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from > > the beginning of the name. > > > > Signed-off-by: Fabio M. De Francesco > > --- > > Why is there a "v7" in this subject line, but not all the other lines? > It's v7 because only this file (and not the others in the series had six previous versions that you dropped. Please remind that it was already sent alone (not in a series) several times. The changelog is in the body. Should I drop that "v7" and the changelog, and the send the patch series anew? Please, I'm waiting your instructions on what to do. Thanks, Fabio > > It should be in all of them, including the 0/X email, git format-patch > will create it automatically if you tell it to. > > thanks, > > greg k-h
Re: [Outreachy kernel] [PATCH v7 1/3] staging: rtl8723bs: Remove camelcase in several files
On Sat, Apr 10, 2021 at 11:22:29AM +0200, Fabio M. De Francesco wrote: > Remove camelcase in bFwCurrentInPSMode, a variable used by code > of several subdirectories/files of the driver. Issue detected by > checkpatch.pl. Delete the unnecessary "b" (that stands for "byte") from > the beginning of the name. > > Signed-off-by: Fabio M. De Francesco > --- > Why is there a "v7" in this subject line, but not all the other lines? It should be in all of them, including the 0/X email, git format-patch will create it automatically if you tell it to. thanks, greg k-h
