Re: [PATCH, RFC] Ext4: Mount partition as read only if during orphan cleanup truncate fails to obtain journal handle.

2012-12-07 Thread Ashish Sangwan
On Thu, Dec 6, 2012 at 10:39 PM, Theodore Ts'o wrote: > On Thu, Dec 06, 2012 at 04:59:43PM +0530, Ashish Sangwan wrote: >> >> Did you get any time to look into this patch? >> This problem is with ext4 only as ext4_truncate does not clean the >> orphan list unlike that of ext3_truncate. >>

Re: [PATCH, RFC] Ext4: Mount partition as read only if during orphan cleanup truncate fails to obtain journal handle.

2012-12-07 Thread Ashish Sangwan
On Thu, Dec 6, 2012 at 10:39 PM, Theodore Ts'o ty...@mit.edu wrote: On Thu, Dec 06, 2012 at 04:59:43PM +0530, Ashish Sangwan wrote: Did you get any time to look into this patch? This problem is with ext4 only as ext4_truncate does not clean the orphan list unlike that of ext3_truncate.

Re: [PATCH, RFC] Ext4: Mount partition as read only if during orphan cleanup truncate fails to obtain journal handle.

2012-12-06 Thread Theodore Ts'o
On Thu, Dec 06, 2012 at 04:59:43PM +0530, Ashish Sangwan wrote: > > Did you get any time to look into this patch? > This problem is with ext4 only as ext4_truncate does not clean the > orphan list unlike that of ext3_truncate. > Instead, in case of failure to obtain handle, orphan list cleanup is

Re: [PATCH, RFC] Ext4: Mount partition as read only if during orphan cleanup truncate fails to obtain journal handle.

2012-12-06 Thread Ashish Sangwan
Hi Ted, Did you get any time to look into this patch? This problem is with ext4 only as ext4_truncate does not clean the orphan list unlike that of ext3_truncate. Instead, in case of failure to obtain handle, orphan list cleanup is done in ext4_setattr. But during mount, ext4_truncate is not

Re: [PATCH, RFC] Ext4: Mount partition as read only if during orphan cleanup truncate fails to obtain journal handle.

2012-12-06 Thread Ashish Sangwan
Hi Ted, Did you get any time to look into this patch? This problem is with ext4 only as ext4_truncate does not clean the orphan list unlike that of ext3_truncate. Instead, in case of failure to obtain handle, orphan list cleanup is done in ext4_setattr. But during mount, ext4_truncate is not

Re: [PATCH, RFC] Ext4: Mount partition as read only if during orphan cleanup truncate fails to obtain journal handle.

2012-12-06 Thread Theodore Ts'o
On Thu, Dec 06, 2012 at 04:59:43PM +0530, Ashish Sangwan wrote: Did you get any time to look into this patch? This problem is with ext4 only as ext4_truncate does not clean the orphan list unlike that of ext3_truncate. Instead, in case of failure to obtain handle, orphan list cleanup is

Re: [PATCH, RFC] Ext4: Mount partition as read only if during orphan cleanup truncate fails to obtain journal handle.

2012-10-26 Thread Namjae Jeon
Add Cc in mail loop. Thanks. 2012/10/24, Ashish Sangwan : > During orphan cleanup while doing truncate, if we fail to obtain journal > handle, the inode for which truncate was called would not be removed from > both the on-disk and in-memory orphan lists as the call to ext4_orphan_del > would

Re: [PATCH, RFC] Ext4: Mount partition as read only if during orphan cleanup truncate fails to obtain journal handle.

2012-10-26 Thread Namjae Jeon
Add Cc in mail loop. Thanks. 2012/10/24, Ashish Sangwan ashishsangw...@gmail.com: During orphan cleanup while doing truncate, if we fail to obtain journal handle, the inode for which truncate was called would not be removed from both the on-disk and in-memory orphan lists as the call to